All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Marc Dionne <marc.c.dionne@gmail.com>
Cc: dhowells@redhat.com, linux-afs@lists.infradead.org,
	Tom Rix <trix@redhat.com>,
	linux-fsdevel@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] afs: check function return
Date: Mon, 12 Jul 2021 16:21:26 +0100	[thread overview]
Message-ID: <3360495.1626103286@warthog.procyon.org.uk> (raw)
In-Reply-To: <CAB9dFdvHsLsw7CMnB+4cgciWDSqVjuij4mH3TaXnHQB8sz5rHw@mail.gmail.com>

Marc Dionne <marc.c.dionne@gmail.com> wrote:

> > @@ -777,7 +777,7 @@ int afs_writepages(struct address_space *mapping,
> >                 mapping->writeback_index = next / PAGE_SIZE;
> 
> Isn't there the same issue with the use of next here.

Good point.

> >                         mapping->writeback_index = next;
> 
> Unrelated to this patch, but since next is a byte offset, should this
> also divide by PAGE_SIZE as above.

Also a good point.  I'll whip up a separate patch for that.

David


  parent reply	other threads:[~2021-07-12 15:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 12:57 [PATCH 0/3] afs: Miscellaneous fixes David Howells
2021-07-12 12:57 ` [PATCH 1/3] afs: Fix tracepoint string placement with built-in AFS David Howells
2021-07-12 12:57 ` [PATCH 2/3] afs: check function return David Howells
2021-07-12 14:20   ` Marc Dionne
2021-07-12 15:21   ` David Howells [this message]
2021-07-12 12:57 ` [PATCH 3/3] afs: Remove redundant assignment to ret David Howells
2021-07-12 14:04   ` Marc Dionne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3360495.1626103286@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.c.dionne@gmail.com \
    --cc=trix@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.