From: Geliang Tang <geliangtang@163.com>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>
Cc: Geliang Tang <geliangtang@163.com>,
Pablo Neira Ayuso <pablo@netfilter.org>,
Patrick McHardy <kaber@trash.net>,
Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@kernel.dk>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com>,
Josh Triplett <josh@joshtriplett.org>,
live-patching@vger.kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, netdev@vger.kernel.org,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] livepatch: use list_is_first()
Date: Thu, 10 Dec 2015 22:17:16 +0800 [thread overview]
Message-ID: <394e9e5ece944969fe1ff4f37c9a73bf5543265e.1449755818.git.geliangtang@163.com> (raw)
In-Reply-To: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com>
In-Reply-To: <305feb971ae11e192f35f25d66bb7b2e28e06c39.1449755818.git.geliangtang@163.com>
For better readability, use list_is_first() instead of open-coded.
Signed-off-by: Geliang Tang <geliangtang@163.com>
---
kernel/livepatch/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index bc2c85c..be64106 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -479,7 +479,7 @@ static int __klp_enable_patch(struct klp_patch *patch)
return -EINVAL;
/* enforce stacking: only the first disabled patch can be enabled */
- if (patch->list.prev != &klp_patches &&
+ if (!list_is_first(&patch->list, &klp_patches) &&
list_prev_entry(patch, list)->state == KLP_DISABLED)
return -EBUSY;
--
2.5.0
next prev parent reply other threads:[~2015-12-10 14:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-10 14:17 [PATCH 1/4] list: introduce list_is_first() Geliang Tang
2015-12-10 14:17 ` Geliang Tang [this message]
2015-12-10 14:17 ` [PATCH 3/4] netfilter: ipset: use list_is_first() Geliang Tang
2015-12-10 14:20 ` [PATCH 4/4] elevator: use list_is_{first,last} Geliang Tang
2015-12-10 15:10 ` [PATCH 1/4] list: introduce list_is_first() Jens Axboe
2015-12-10 15:23 ` Josh Poimboeuf
2015-12-10 15:35 ` Jens Axboe
2015-12-10 16:47 ` Jiri Kosina
2015-12-10 15:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=394e9e5ece944969fe1ff4f37c9a73bf5543265e.1449755818.git.geliangtang@163.com \
--to=geliangtang@163.com \
--cc=axboe@kernel.dk \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=jikos@kernel.org \
--cc=josh@joshtriplett.org \
--cc=jpoimboe@redhat.com \
--cc=kaber@trash.net \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.