All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liuwenyi <qingshenlwy@gmail.com>
To: chris.mason@oracle.com, viro@zeniv.linux.org.uk,
	joel.becker@oracle.com, cjb@laptop.org, jmorris@namei.org,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	onlyflyer@gmail.
Subject: [PATCHv2 02/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 19:52:58 +0800	[thread overview]
Message-ID: <4B2F619A.8000407@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.


---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: James Morris <jmorris@namei.org>
Cc: linux-btrfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 2e9e699..0f14f95 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle
*trans,
char *value = NULL;
mode_t mode;

- if (acl) {
- ret = posix_acl_valid(acl);
- if (ret < 0)
- return ret;
- ret = 0;
- }
+ ret = posix_acl_valid(acl);
+ if (ret < 0)
+ return ret;

switch (type) {
case ACL_TYPE_ACCESS:

-- 
Best Regards,
Liuwenyi

WARNING: multiple messages have this Message-ID (diff)
From: Liuwenyi <qingshenlwy@gmail.com>
To: chris.mason@oracle.com, viro@zeniv.linux.org.uk,
	joel.becker@oracle.com, cjb@laptop.org, jmorris@namei.org,
	linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	onlyflyer@gmail.com, strongzgy@gmail.com
Subject: [PATCHv2 02/12]posix_acl: Add the check items
Date: Mon, 21 Dec 2009 19:52:58 +0800	[thread overview]
Message-ID: <4B2F619A.8000407@gmail.com> (raw)

move the ACL validation check in to fs/posix_acl.c.
Including nullpointer check and PTR_ERR check.


---
Signed-off-by: Liuwenyi <qingshenlwy@gmail.com>
Cc: Chris Mason <chris.mason@oracle.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Joel Becker <joel.becker@oracle.com>
Cc: Chris Ball <cjb@laptop.org>
Cc: James Morris <jmorris@namei.org>
Cc: linux-btrfs@vger.kernel.org
Cc: linux-kernel@vger.kernel.org

---
diff --git a/fs/btrfs/acl.c b/fs/btrfs/acl.c
index 2e9e699..0f14f95 100644
--- a/fs/btrfs/acl.c
+++ b/fs/btrfs/acl.c
@@ -102,12 +102,9 @@ static int btrfs_set_acl(struct btrfs_trans_handle
*trans,
char *value = NULL;
mode_t mode;

- if (acl) {
- ret = posix_acl_valid(acl);
- if (ret < 0)
- return ret;
- ret = 0;
- }
+ ret = posix_acl_valid(acl);
+ if (ret < 0)
+ return ret;

switch (type) {
case ACL_TYPE_ACCESS:

-- 
Best Regards,
Liuwenyi


             reply	other threads:[~2009-12-21 11:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-21 11:52 Liuwenyi [this message]
2009-12-21 11:52 ` [PATCHv2 02/12]posix_acl: Add the check items Liuwenyi
2009-12-22 12:08 ` Al Viro
2009-12-22 14:31   ` liu weni
2009-12-22 14:31     ` liu weni
2009-12-22 14:48     ` Al Viro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B2F619A.8000407@gmail.com \
    --to=qingshenlwy@gmail.com \
    --cc=chris.mason@oracle.com \
    --cc=cjb@laptop.org \
    --cc=jmorris@namei.org \
    --cc=joel.becker@oracle.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=onlyflyer@gmail. \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.