All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yegor Yefremov <yegor_sub1@visionsystems.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Input: TPS6507X - define MFD dependencies for touch	and regulator unit
Date: Mon, 11 Jul 2011 14:29:39 +0200	[thread overview]
Message-ID: <4E1AECB3.3080607@visionsystems.de> (raw)
In-Reply-To: <20110711122004.GA9478@sirena.org.uk>

Am 11.07.2011 14:20, schrieb Mark Brown:
> On Mon, Jul 11, 2011 at 12:50:19PM +0200, Yegor Yefremov wrote:
>> both touchscreen and regulator units are only working if
>> mfd device is activated. So if mfd support is enabled,
>> select TPS6507X mfd support automatically.
>>
>> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
> This should be split into separate patches and sent to *all* the
> relevant maintainers.
>
>>  config TOUCHSCREEN_TPS6507X
>>  	tristate "TPS6507x based touchscreens"
>> -	depends on I2C
>> +	depends on I2C && MFD_SUPPORT
>> +	select TPS6507X
> This isn't a good fix, the driver should depend on the MFD core not
> select it.

Thanks for reviewing. Should I change the patch like this:

touchscreen unit is only working if mfd device is activated.
So if mfd support is enabled, select TPS6507X mfd support
automatically.

Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
---
 drivers/input/touchscreen/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/input/touchscreen/Kconfig
===================================================================
--- a/drivers/input/touchscreen/Kconfig
+++ b/drivers/input/touchscreen/Kconfig
@@ -716,7 +716,7 @@

 config TOUCHSCREEN_TPS6507X
        tristate "TPS6507x based touchscreens"
-       depends on I2C
+       depends on I2C && TPS6507X
        help
          Say Y here if you have a TPS6507x based touchscreen
          controller.


  reply	other threads:[~2011-07-11 12:29 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 10:50 [PATCH] Input: TPS6507X - define MFD dependencies for touch and regulator unit Yegor Yefremov
2011-07-11 12:20 ` Mark Brown
2011-07-11 12:29   ` Yegor Yefremov [this message]
2011-07-11 14:08     ` Mark Brown
2011-07-11 16:41   ` Dmitry Torokhov
2011-07-11 22:33     ` Mark Brown
2011-07-12  8:23       ` Yegor Yefremov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E1AECB3.3080607@visionsystems.de \
    --to=yegor_sub1@visionsystems.de \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.