From: Randy Dunlap <rdunlap@infradead.org>
To: dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
David Airlie <airlied@linux.ie>
Subject: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
Date: Thu, 5 Mar 2020 19:17:49 -0800 [thread overview]
Message-ID: <4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
symbols do not depend on DRM_RCAR_DU, the menu presentation is
broken for these and following non-R-Car Kconfig symbols.
Is it safe/appropriate to make all of these symbols depend on
DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Cc: Dave Airlie <airlied@linux.ie>
---
drivers/gpu/drm/rcar-du/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
+++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
@@ -24,6 +24,7 @@ config DRM_RCAR_CMM
config DRM_RCAR_DW_HDMI
tristate "R-Car DU Gen3 HDMI Encoder Support"
depends on DRM && OF
+ depends on DRM_RCAR_DU
select DRM_DW_HDMI
help
Enable support for R-Car Gen3 internal HDMI encoder.
@@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
config DRM_RCAR_LVDS
tristate "R-Car DU LVDS Encoder Support"
depends on DRM && DRM_BRIDGE && OF
+ depends on DRM_RCAR_DU
select DRM_PANEL
select OF_FLATTREE
select OF_OVERLAY
@@ -47,4 +49,5 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
+ depends on DRM_RCAR_DU
default y if ARM64
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org>
To: dri-devel <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Cc: Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
David Airlie <airlied@linux.ie>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Koji Matsuoka <koji.matsuoka.xm@renesas.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>
Subject: [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU
Date: Thu, 5 Mar 2020 19:17:49 -0800 [thread overview]
Message-ID: <4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org> (raw)
From: Randy Dunlap <rdunlap@infradead.org>
DRM_RCAR_CMM depends on DRM_RCAR_DU. Since the following Kconfig
symbols do not depend on DRM_RCAR_DU, the menu presentation is
broken for these and following non-R-Car Kconfig symbols.
Is it safe/appropriate to make all of these symbols depend on
DRM_RCAR_DU? It make the kconfig menu presentation much cleaner.
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-renesas-soc@vger.kernel.org
Cc: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
Cc: Dave Airlie <airlied@linux.ie>
---
drivers/gpu/drm/rcar-du/Kconfig | 3 +++
1 file changed, 3 insertions(+)
--- linux-next-20200305.orig/drivers/gpu/drm/rcar-du/Kconfig
+++ linux-next-20200305/drivers/gpu/drm/rcar-du/Kconfig
@@ -24,6 +24,7 @@ config DRM_RCAR_CMM
config DRM_RCAR_DW_HDMI
tristate "R-Car DU Gen3 HDMI Encoder Support"
depends on DRM && OF
+ depends on DRM_RCAR_DU
select DRM_DW_HDMI
help
Enable support for R-Car Gen3 internal HDMI encoder.
@@ -31,6 +32,7 @@ config DRM_RCAR_DW_HDMI
config DRM_RCAR_LVDS
tristate "R-Car DU LVDS Encoder Support"
depends on DRM && DRM_BRIDGE && OF
+ depends on DRM_RCAR_DU
select DRM_PANEL
select OF_FLATTREE
select OF_OVERLAY
@@ -47,4 +49,5 @@ config DRM_RCAR_VSP
config DRM_RCAR_WRITEBACK
bool
+ depends on DRM_RCAR_DU
default y if ARM64
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next reply other threads:[~2020-03-06 3:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 3:17 Randy Dunlap [this message]
2020-03-06 3:17 ` [RFC PATCH] drm: rcar-du: make all sub-symbols depend on DRM_RCAR_DU Randy Dunlap
2020-03-06 8:00 ` Geert Uytterhoeven
2020-03-06 8:00 ` Geert Uytterhoeven
2020-03-06 14:28 ` Laurent Pinchart
2020-03-06 14:28 ` Laurent Pinchart
2020-03-06 15:09 ` Randy Dunlap
2020-03-06 15:09 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b50cc9f-1434-b78a-d56a-fadfd030f002@infradead.org \
--to=rdunlap@infradead.org \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=koji.matsuoka.xm@renesas.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.