From: Kinglong Mee <kinglongmee@gmail.com>
To: Christoph Hellwig <hch@lst.de>, "J. Bruce Fields" <bfields@fieldses.org>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
xfs@oss.sgi.com
Subject: [PATCH] NFSD: Fix infinite loop in nfsd4_cb_layout_fail()
Date: Fri, 20 Mar 2015 15:56:40 +0800 [thread overview]
Message-ID: <550BD2B8.6070900@gmail.com> (raw)
In-Reply-To: <20150320065010.GC626@lst.de>
Fix commit 31ef83dc05 (nfsd: add trace events)'s typo
causing a infinite loop when callback layout fail.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4layouts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
index 3c1bfa1..0a616b5 100644
--- a/fs/nfsd/nfs4layouts.c
+++ b/fs/nfsd/nfs4layouts.c
@@ -587,7 +587,7 @@ nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls)
rpc_ntop((struct sockaddr *)&clp->cl_addr, addr_str, sizeof(addr_str));
- nfsd4_cb_layout_fail(ls);
+ trace_layout_recall_fail(&ls->ls_stid.sc_stateid);
printk(KERN_WARNING
"nfsd: client %s failed to respond to layout recall. "
--
2.3.3
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Kinglong Mee <kinglongmee@gmail.com>
To: Christoph Hellwig <hch@lst.de>, "J. Bruce Fields" <bfields@fieldses.org>
Cc: Dave Chinner <david@fromorbit.com>,
Eric Sandeen <sandeen@sandeen.net>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
xfs@oss.sgi.com
Subject: [PATCH] NFSD: Fix infinite loop in nfsd4_cb_layout_fail()
Date: Fri, 20 Mar 2015 15:56:40 +0800 [thread overview]
Message-ID: <550BD2B8.6070900@gmail.com> (raw)
In-Reply-To: <20150320065010.GC626@lst.de>
Fix commit 31ef83dc05 (nfsd: add trace events)'s typo
causing a infinite loop when callback layout fail.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com>
---
fs/nfsd/nfs4layouts.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4layouts.c b/fs/nfsd/nfs4layouts.c
index 3c1bfa1..0a616b5 100644
--- a/fs/nfsd/nfs4layouts.c
+++ b/fs/nfsd/nfs4layouts.c
@@ -587,7 +587,7 @@ nfsd4_cb_layout_fail(struct nfs4_layout_stateid *ls)
rpc_ntop((struct sockaddr *)&clp->cl_addr, addr_str, sizeof(addr_str));
- nfsd4_cb_layout_fail(ls);
+ trace_layout_recall_fail(&ls->ls_stid.sc_stateid);
printk(KERN_WARNING
"nfsd: client %s failed to respond to layout recall. "
--
2.3.3
next prev parent reply other threads:[~2015-03-20 7:56 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-03 22:10 panic on 4.20 server exporting xfs filesystem J. Bruce Fields
2015-03-03 22:10 ` J. Bruce Fields
2015-03-03 22:44 ` Dave Chinner
2015-03-03 22:44 ` Dave Chinner
2015-03-04 2:08 ` J. Bruce Fields
2015-03-04 2:08 ` J. Bruce Fields
2015-03-04 4:41 ` Dave Chinner
2015-03-04 4:41 ` Dave Chinner
2015-03-05 13:19 ` Christoph Hellwig
2015-03-05 13:19 ` Christoph Hellwig
2015-03-05 15:21 ` J. Bruce Fields
2015-03-05 15:21 ` J. Bruce Fields
2015-03-08 13:08 ` Tom Haynes
2015-03-08 13:08 ` Tom Haynes
2015-03-04 15:54 ` J. Bruce Fields
2015-03-04 15:54 ` J. Bruce Fields
2015-03-04 22:09 ` Dave Chinner
2015-03-04 22:09 ` Dave Chinner
2015-03-04 22:27 ` J. Bruce Fields
2015-03-04 22:27 ` J. Bruce Fields
2015-03-04 22:45 ` Dave Chinner
2015-03-04 22:45 ` Dave Chinner
2015-03-04 22:49 ` Eric Sandeen
2015-03-04 22:49 ` Eric Sandeen
2015-03-04 22:56 ` Dave Chinner
2015-03-04 22:56 ` Dave Chinner
2015-03-05 4:08 ` J. Bruce Fields
2015-03-05 4:08 ` J. Bruce Fields
2015-03-05 13:17 ` Christoph Hellwig
2015-03-05 13:17 ` Christoph Hellwig
2015-03-05 15:01 ` J. Bruce Fields
2015-03-05 15:01 ` J. Bruce Fields
2015-03-05 17:02 ` J. Bruce Fields
2015-03-05 17:02 ` J. Bruce Fields
2015-03-05 20:47 ` J. Bruce Fields
2015-03-05 20:47 ` J. Bruce Fields
2015-03-05 20:59 ` Dave Chinner
2015-03-05 20:59 ` Dave Chinner
2015-03-06 20:47 ` J. Bruce Fields
2015-03-06 20:47 ` J. Bruce Fields
2015-03-19 17:27 ` Christoph Hellwig
2015-03-19 17:27 ` Christoph Hellwig
2015-03-19 18:47 ` J. Bruce Fields
2015-03-19 18:47 ` J. Bruce Fields
2015-03-20 6:49 ` Christoph Hellwig
2015-03-20 6:49 ` Christoph Hellwig
2015-03-08 15:30 ` Christoph Hellwig
2015-03-08 15:30 ` Christoph Hellwig
2015-03-09 19:45 ` J. Bruce Fields
2015-03-09 19:45 ` J. Bruce Fields
2015-03-20 4:06 ` Kinglong Mee
2015-03-20 4:06 ` Kinglong Mee
2015-03-20 6:50 ` Christoph Hellwig
2015-03-20 6:50 ` Christoph Hellwig
2015-03-20 7:56 ` Kinglong Mee [this message]
2015-03-20 7:56 ` [PATCH] NFSD: Fix infinite loop in nfsd4_cb_layout_fail() Kinglong Mee
2015-03-15 12:58 ` panic on 4.20 server exporting xfs filesystem Christoph Hellwig
2015-03-15 12:58 ` Christoph Hellwig
2015-03-16 14:27 ` J. Bruce Fields
2015-03-16 14:27 ` J. Bruce Fields
2015-03-17 10:30 ` Christoph Hellwig
2015-03-17 10:30 ` Christoph Hellwig
2015-03-18 10:50 ` Christoph Hellwig
2015-03-18 10:50 ` Christoph Hellwig
2015-03-27 10:41 ` Christoph Hellwig
2015-03-27 14:50 ` Jeff Layton
2015-03-30 16:44 ` Christoph Hellwig
2015-03-27 15:13 ` J. Bruce Fields
2015-04-26 16:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550BD2B8.6070900@gmail.com \
--to=kinglongmee@gmail.com \
--cc=bfields@fieldses.org \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.