All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phu Luu <Phu.Luu@silabs.com>
To: "johan@kernel.org" <johan@kernel.org>,
	"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "Brant Merryman" <Brant.Merryman@silabs.com>,
	"Richard Hendricks" <Richard.Hendricks@silabs.com>,
	"hungnd3@fsoft.com.vn" <hungnd3@fsoft.com.vn>,
	"Phú Lưu An" <luuanphu@gmail.com>
Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle
Date: Fri, 26 Jun 2020 04:22:58 +0000	[thread overview]
Message-ID: <57401AF3-9961-461F-95E1-F8AFC2105F5E@silabs.com> (raw)

From: Brant Merryman <brant.merryman@silabs.com>

Assign the .throttle and .unthrottle functions to be generic function
in the driver structure to prevent data loss that can otherwise occur
if the host does not enable USB throttling.

Signed-off-by: Phu Luu <phu.luu@silabs.com>
Signed-off-by: Brant Merryman <brant.merryman@silabs.com>
---
06/09/2020: Patch v3 1/2 Modified based on feedback from Johan Hovold <johan@kernel.org>
12/18/2019: Patch v2 Broken into two patches and modified based on feedback from Johan Hovold <johan@kernel.org>
12/09/2019: Initial submission of patch "Proper RTS control when buffers fill"

 drivers/usb/serial/cp210x.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/serial/cp210x.c b/drivers/usb/serial/cp210x.c
index f5143eedbc48..bcceb4ad8be0 100644
--- a/drivers/usb/serial/cp210x.c
+++ b/drivers/usb/serial/cp210x.c
@@ -272,6 +272,8 @@ static struct usb_serial_driver cp210x_device = {
 	.break_ctl		= cp210x_break_ctl,
 	.set_termios		= cp210x_set_termios,
 	.tx_empty		= cp210x_tx_empty,
+	.throttle		= usb_serial_generic_throttle,
+	.unthrottle		= usb_serial_generic_unthrottle,
 	.tiocmget		= cp210x_tiocmget,
 	.tiocmset		= cp210x_tiocmset,
 	.attach			= cp210x_attach,
-- 
2.17.0



             reply	other threads:[~2020-06-26  4:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26  4:22 Phu Luu [this message]
2020-06-26  7:36 ` [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle Johan Hovold
  -- strict thread matches above, loose matches on Subject: below --
2020-06-24  7:01 Phu Luu
2020-06-24  7:43 ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57401AF3-9961-461F-95E1-F8AFC2105F5E@silabs.com \
    --to=phu.luu@silabs.com \
    --cc=Brant.Merryman@silabs.com \
    --cc=Richard.Hendricks@silabs.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hungnd3@fsoft.com.vn \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=luuanphu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.