All of lore.kernel.org
 help / color / mirror / Atom feed
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: jic23@kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
	a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
	gwendal@chromium.org, alexandre.belloni@bootlin.com,
	david@lechnology.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
	patrick.havelange@essensium.com, fabrice.gasnier@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com,
	William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [PATCH v13 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write
Date: Tue, 13 Jul 2021 18:53:05 +0900	[thread overview]
Message-ID: <5a9678944e953d23e0ee2a53d3c61e700cb1cd89.1626165765.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1626165764.git.vilhelm.gray@gmail.com>

The 104-QUAD-8 only has two count modes where a ceiling value makes
sense: Range Limit and Modulo-N. Outside of these two modes, setting a
ceiling value is an invalid operation -- so let's report it as such by
returning -EINVAL.

Fixes: fc069262261c ("counter: 104-quad-8: Add lock guards - generic interface")
Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/counter/104-quad-8.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 09a9a77cce06..81f9642777fb 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -715,12 +715,13 @@ static ssize_t quad8_count_ceiling_write(struct counter_device *counter,
 	case 1:
 	case 3:
 		quad8_preset_register_set(priv, count->id, ceiling);
-		break;
+		mutex_unlock(&priv->lock);
+		return len;
 	}
 
 	mutex_unlock(&priv->lock);
 
-	return len;
+	return -EINVAL;
 }
 
 static ssize_t quad8_count_preset_enable_read(struct counter_device *counter,
-- 
2.32.0


WARNING: multiple messages have this Message-ID (diff)
From: William Breathitt Gray <vilhelm.gray@gmail.com>
To: jic23@kernel.org
Cc: linux-stm32@st-md-mailman.stormreply.com, kernel@pengutronix.de,
	a.fatoum@pengutronix.de, kamel.bouhara@bootlin.com,
	gwendal@chromium.org, alexandre.belloni@bootlin.com,
	david@lechnology.com, linux-iio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, syednwaris@gmail.com,
	patrick.havelange@essensium.com, fabrice.gasnier@st.com,
	mcoquelin.stm32@gmail.com, alexandre.torgue@st.com,
	o.rempel@pengutronix.de, jarkko.nikula@linux.intel.com,
	William Breathitt Gray <vilhelm.gray@gmail.com>
Subject: [PATCH v13 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write
Date: Tue, 13 Jul 2021 18:53:05 +0900	[thread overview]
Message-ID: <5a9678944e953d23e0ee2a53d3c61e700cb1cd89.1626165765.git.vilhelm.gray@gmail.com> (raw)
In-Reply-To: <cover.1626165764.git.vilhelm.gray@gmail.com>

The 104-QUAD-8 only has two count modes where a ceiling value makes
sense: Range Limit and Modulo-N. Outside of these two modes, setting a
ceiling value is an invalid operation -- so let's report it as such by
returning -EINVAL.

Fixes: fc069262261c ("counter: 104-quad-8: Add lock guards - generic interface")
Acked-by: Syed Nayyar Waris <syednwaris@gmail.com>
Signed-off-by: William Breathitt Gray <vilhelm.gray@gmail.com>
---
 drivers/counter/104-quad-8.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c
index 09a9a77cce06..81f9642777fb 100644
--- a/drivers/counter/104-quad-8.c
+++ b/drivers/counter/104-quad-8.c
@@ -715,12 +715,13 @@ static ssize_t quad8_count_ceiling_write(struct counter_device *counter,
 	case 1:
 	case 3:
 		quad8_preset_register_set(priv, count->id, ceiling);
-		break;
+		mutex_unlock(&priv->lock);
+		return len;
 	}
 
 	mutex_unlock(&priv->lock);
 
-	return len;
+	return -EINVAL;
 }
 
 static ssize_t quad8_count_preset_enable_read(struct counter_device *counter,
-- 
2.32.0


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-07-13  9:53 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-13  9:53 [PATCH v13 00/17] Introduce the Counter character device interface William Breathitt Gray
2021-07-13  9:53 ` William Breathitt Gray
2021-07-13  9:53 ` William Breathitt Gray [this message]
2021-07-13  9:53   ` [PATCH v13 01/17] counter: 104-quad-8: Return error when invalid mode during ceiling_write William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 02/17] counter: Return error code on invalid modes William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 03/17] counter: Standardize to ERANGE for limit exceeded errors William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 04/17] counter: Rename counter_signal_value to counter_signal_level William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 05/17] counter: Rename counter_count_function to counter_function William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 06/17] counter: Internalize sysfs interface code William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 07/17] counter: Update counter.h comments to reflect sysfs internalization William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 08/17] docs: counter: Update " William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 09/17] counter: Move counter enums to uapi header William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 10/17] counter: Add character device interface William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 11/17] docs: counter: Document " William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 12/17] tools/counter: Create Counter tools William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 13/17] counter: Implement signalZ_action_component_id sysfs attribute William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 14/17] counter: Implement *_component_id sysfs attributes William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 15/17] counter: Implement events_queue_size sysfs attribute William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 16/17] counter: 104-quad-8: Replace mutex with spinlock William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-13  9:53 ` [PATCH v13 17/17] counter: 104-quad-8: Add IRQ support for the ACCES 104-QUAD-8 William Breathitt Gray
2021-07-13  9:53   ` William Breathitt Gray
2021-07-28  8:51 ` [PATCH v13 00/17] Introduce the Counter character device interface William Breathitt Gray
2021-07-28  8:51   ` William Breathitt Gray
2021-07-29  9:48   ` William Breathitt Gray
2021-07-29  9:48     ` William Breathitt Gray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5a9678944e953d23e0ee2a53d3c61e700cb1cd89.1626165765.git.vilhelm.gray@gmail.com \
    --to=vilhelm.gray@gmail.com \
    --cc=a.fatoum@pengutronix.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alexandre.torgue@st.com \
    --cc=david@lechnology.com \
    --cc=fabrice.gasnier@st.com \
    --cc=gwendal@chromium.org \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=jic23@kernel.org \
    --cc=kamel.bouhara@bootlin.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=o.rempel@pengutronix.de \
    --cc=patrick.havelange@essensium.com \
    --cc=syednwaris@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.