All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Subject: [RFC PATCH 5/7] test-lib: use pkgsrc provided unzip for NetBSD
Date: Sun, 25 Nov 2018 03:06:48 -0800	[thread overview]
Message-ID: <5fe64afa3d7cf9a46a527c47885e8e60dae2445c.1543143503.git.carenas@gmail.com> (raw)
In-Reply-To: <cover.1543143503.git.carenas@gmail.com>

d98b2c5fce ("test-lib: on FreeBSD, look for unzip(1) in /usr/local/bin/",
2016-07-21) added an exception to the test suite for FreeBSD because the
tests assume functionality not provided by its base unzip tool.

NetBSD shares that limitation and provides a package that could be used
instead so all tests from t5003 succeed

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
 t/test-lib.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 6c6c0af7a1..2acb35f277 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -1244,6 +1244,7 @@ test_lazy_prereq SANITY '
 '
 
 test FreeBSD != $uname_s || GIT_UNZIP=${GIT_UNZIP:-/usr/local/bin/unzip}
+test $uname_s = NetBSD && GIT_UNZIP=${GIT_UNZIP:-/usr/pkg/bin/unzip}
 GIT_UNZIP=${GIT_UNZIP:-unzip}
 test_lazy_prereq UNZIP '
 	"$GIT_UNZIP" -v
-- 
2.20.0.rc1


  parent reply	other threads:[~2018-11-25 11:07 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-25 11:06 [RFC PATCH 0/7] test: NetBSD support Carlo Marcelo Arenas Belón
2018-11-25 11:06 ` [RFC PATCH 1/7] Documentation: update INSTALL for NetBSD Carlo Marcelo Arenas Belón
2018-11-26  6:27   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 2/7] t0301: remove trailing / for dir creation Carlo Marcelo Arenas Belón
2018-11-26  6:40   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 3/7] config.mak.uname: NetBSD uses BSD semantics with fread for directories Carlo Marcelo Arenas Belón
2018-11-26  6:41   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 4/7] config.mak.uname: NetBSD uses old iconv interface Carlo Marcelo Arenas Belón
2018-11-26  6:45   ` Junio C Hamano
2018-11-25 11:06 ` Carlo Marcelo Arenas Belón [this message]
2018-11-26  6:50   ` [RFC PATCH 5/7] test-lib: use pkgsrc provided unzip for NetBSD Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 6/7] t5004: use GNU tar to avoid known issues with BSD tar Carlo Marcelo Arenas Belón
2018-11-26  6:52   ` Junio C Hamano
2018-11-25 11:06 ` [RFC PATCH 7/7] config.mak.uname: use pkgsrc perl for NetBSD Carlo Marcelo Arenas Belón
2018-11-26  6:53   ` Junio C Hamano
2018-11-26 15:42 ` [RFC PATCH 0/7] test: NetBSD support Ævar Arnfjörð Bjarmason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5fe64afa3d7cf9a46a527c47885e8e60dae2445c.1543143503.git.carenas@gmail.com \
    --to=carenas@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.