From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern <dsa@cumulusnetworks.com>, Doug Ledford <dledford@redhat.com>, Erez Shitrit <erezsh@mellanox.com>, Feras Daoud <ferasda@mellanox.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Leon Romanovsky <leon@kernel.org>, Mark Bloch <markb@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>, Sagi Grimberg <sagi@grimberg.me>, Sean Hefty <sean.hefty@intel.com>, Yuval Shaia <yuval.shaia@oracle.com>, Zhu Yanjun <yanjun.zhu@oracle.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 7/9] IB/iser: Add spaces for better code readability Date: Fri, 7 Apr 2017 23:07:23 +0200 [thread overview] Message-ID: <7e406ba5-f7c8-16a7-9c3e-464e48120088@users.sourceforge.net> (raw) In-Reply-To: <ce4249f2-c7e7-0282-2cff-3f9c3991efa3@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 7 Apr 2017 21:37:48 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: space required after that ',' (ctx:VxV) Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/infiniband/ulp/iser/iser_initiator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 6c48bdc8a64d..fbab1303a740 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -422,7 +422,7 @@ int iser_send_command(struct iscsi_conn *conn, return 0; send_command_error: - iser_err("conn %p failed task->itt %d err %d\n",conn, task->itt, err); + iser_err("conn %p failed task->itt %d err %d\n", conn, task->itt, err); return err; } @@ -448,7 +448,7 @@ int iser_send_data_out(struct iscsi_conn *conn, buf_offset = ntohl(hdr->offset); iser_dbg("%s itt %d dseg_len %d offset %d\n", - __func__,(int)itt,(int)data_seg_len,(int)buf_offset); + __func__, (int)itt, (int)data_seg_len, (int)buf_offset); tx_desc = kmem_cache_zalloc(ig.desc_cache, GFP_ATOMIC); if (tx_desc == NULL) { @@ -553,7 +553,7 @@ int iser_send_control(struct iscsi_conn *conn, return 0; send_control_error: - iser_err("conn %p failed err %d\n",conn, err); + iser_err("conn %p failed err %d\n", conn, err); return err; } -- 2.12.2
WARNING: multiple messages have this Message-ID (diff)
From: SF Markus Elfring <elfring@users.sourceforge.net> To: linux-rdma@vger.kernel.org, target-devel@vger.kernel.org, David Ahern <dsa@cumulusnetworks.com>, Doug Ledford <dledford@redhat.com>, Erez Shitrit <erezsh@mellanox.com>, Feras Daoud <ferasda@mellanox.com>, Hal Rosenstock <hal.rosenstock@gmail.com>, Leon Romanovsky <leon@kernel.org>, Mark Bloch <markb@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, Paolo Abeni <pabeni@redhat.com>, Roi Dayan <roid@mellanox.com>, Sagi Grimberg <sagi@grimberg.me>, Sean Hefty <sean.hefty@intel.com>, Yuval Shaia <yuval.shaia@oracle.com>, Zhu Yanjun <yanjun.zhu@oracle.com> Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org Subject: [PATCH 7/9] IB/iser: Add spaces for better code readability Date: Fri, 07 Apr 2017 21:07:23 +0000 [thread overview] Message-ID: <7e406ba5-f7c8-16a7-9c3e-464e48120088@users.sourceforge.net> (raw) In-Reply-To: <ce4249f2-c7e7-0282-2cff-3f9c3991efa3@users.sourceforge.net> From: Markus Elfring <elfring@users.sourceforge.net> Date: Fri, 7 Apr 2017 21:37:48 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: space required after that ',' (ctx:VxV) Thus fix the affected source code places. Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- drivers/infiniband/ulp/iser/iser_initiator.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/ulp/iser/iser_initiator.c b/drivers/infiniband/ulp/iser/iser_initiator.c index 6c48bdc8a64d..fbab1303a740 100644 --- a/drivers/infiniband/ulp/iser/iser_initiator.c +++ b/drivers/infiniband/ulp/iser/iser_initiator.c @@ -422,7 +422,7 @@ int iser_send_command(struct iscsi_conn *conn, return 0; send_command_error: - iser_err("conn %p failed task->itt %d err %d\n",conn, task->itt, err); + iser_err("conn %p failed task->itt %d err %d\n", conn, task->itt, err); return err; } @@ -448,7 +448,7 @@ int iser_send_data_out(struct iscsi_conn *conn, buf_offset = ntohl(hdr->offset); iser_dbg("%s itt %d dseg_len %d offset %d\n", - __func__,(int)itt,(int)data_seg_len,(int)buf_offset); + __func__, (int)itt, (int)data_seg_len, (int)buf_offset); tx_desc = kmem_cache_zalloc(ig.desc_cache, GFP_ATOMIC); if (tx_desc = NULL) { @@ -553,7 +553,7 @@ int iser_send_control(struct iscsi_conn *conn, return 0; send_control_error: - iser_err("conn %p failed err %d\n",conn, err); + iser_err("conn %p failed err %d\n", conn, err); return err; } -- 2.12.2
next prev parent reply other threads:[~2017-04-07 21:07 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-07 20:54 [PATCH 0/9] InfiniBand-ULP: Fine-tuning for several function implementations SF Markus Elfring 2017-04-07 20:54 ` SF Markus Elfring 2017-04-07 20:54 ` SF Markus Elfring 2017-04-07 20:57 ` [PATCH 1/9] IB/IPoIB: Use kcalloc() in two functions SF Markus Elfring 2017-04-07 20:57 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg [not found] ` <ce4249f2-c7e7-0282-2cff-3f9c3991efa3-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2017-04-07 21:00 ` [PATCH 2/9] IB/IPoIB: Delete an error message for a failed memory allocation SF Markus Elfring 2017-04-07 21:00 ` SF Markus Elfring 2017-04-07 21:00 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:03 ` [PATCH 4/9] IB/IPoIB: Delete unwanted spaces behind usages of the sizeof operator SF Markus Elfring 2017-04-07 21:03 ` SF Markus Elfring 2017-04-07 21:03 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:06 ` [PATCH 6/9] IB/iser: Use kmalloc_array() in iser_alloc_rx_descriptors() SF Markus Elfring 2017-04-07 21:06 ` SF Markus Elfring 2017-04-07 21:06 ` SF Markus Elfring [not found] ` <75e5726b-d75f-1b79-1242-08f6440e1691-Rn4VEauK+AKRv+LV9MX5uipxlwaOVQ5f@public.gmane.org> 2017-04-09 9:01 ` Sagi Grimberg 2017-04-09 9:01 ` Sagi Grimberg 2017-04-09 9:01 ` Sagi Grimberg 2017-04-07 21:08 ` [PATCH 8/9] IB/isert: Use kcalloc() in isert_alloc_rx_descriptors() SF Markus Elfring 2017-04-07 21:08 ` SF Markus Elfring 2017-04-07 21:08 ` SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg 2017-04-07 21:01 ` [PATCH 3/9] IB/IPoIB: Enclose six expressions for the sizeof operator by parentheses SF Markus Elfring 2017-04-07 21:01 ` SF Markus Elfring 2017-04-09 12:26 ` Sagi Grimberg 2017-04-09 12:26 ` Sagi Grimberg 2017-04-07 21:05 ` [PATCH 5/9] IB/IPoIB: Combine substrings for three messages SF Markus Elfring 2017-04-07 21:05 ` SF Markus Elfring 2017-04-18 11:33 ` Yuval Shaia 2017-04-18 11:33 ` Yuval Shaia 2017-04-07 21:07 ` SF Markus Elfring [this message] 2017-04-07 21:07 ` [PATCH 7/9] IB/iser: Add spaces for better code readability SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg 2017-04-07 21:09 ` [PATCH 9/9] IB/isert: Improve size determinations in three functions SF Markus Elfring 2017-04-07 21:09 ` SF Markus Elfring 2017-04-09 9:02 ` Sagi Grimberg 2017-04-09 9:02 ` Sagi Grimberg
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7e406ba5-f7c8-16a7-9c3e-464e48120088@users.sourceforge.net \ --to=elfring@users.sourceforge.net \ --cc=dledford@redhat.com \ --cc=dsa@cumulusnetworks.com \ --cc=erezsh@mellanox.com \ --cc=ferasda@mellanox.com \ --cc=hal.rosenstock@gmail.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=leon@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rdma@vger.kernel.org \ --cc=markb@mellanox.com \ --cc=ogerlitz@mellanox.com \ --cc=pabeni@redhat.com \ --cc=roid@mellanox.com \ --cc=sagi@grimberg.me \ --cc=sean.hefty@intel.com \ --cc=target-devel@vger.kernel.org \ --cc=yanjun.zhu@oracle.com \ --cc=yuval.shaia@oracle.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.