From: Viresh Kumar <viresh.kumar@st.com> To: <linus.walleij@linaro.org> Cc: <vinod.koul@intel.com>, <dan.j.williams@intel.com>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux@arm.linux.org.uk>, <armando.visconti@st.com>, <shiraz.hashim@st.com>, <vipin.kumar@st.com>, <rajeev-dlh.kumar@st.com>, <deepak.sikri@st.com>, <vipulkumar.samar@st.com>, <amit.virdi@st.com>, <viresh.kumar@st.com>, <pratyush.anand@st.com>, <bhupesh.sharma@st.com>, <viresh.linux@gmail.com> Subject: [PATCH V2 13/20] dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width (not MIN(width)) Date: Mon, 1 Aug 2011 15:07:23 +0530 [thread overview] Message-ID: <816b8264dc71310bd6fca94ed454ebb6e2b2ba5e.1312190881.git.viresh.kumar@st.com> (raw) In-Reply-To: <cover.1312190881.git.viresh.kumar@st.com> max_bytes_per_lli = bd.srcbus.buswidth * PL080_CONTROL_TRANSFER_SIZE_MASK; This is confirmed by ARM support guys. Below is summary of mail exchange with them: [Viresh] What is the total data to be transferred in case source and destination bus widths are different. Suppose, source bus width is 2 bytes and destination is 4 bytes. Now in order to transfer 80 bytes, what should be value of TransferSize field in control reg: 40? or 20?. [David from ARM] The value that is programmed into the TransferSize field should be the number of <SourceWidth> transfers needed to achieve the required data transfer. So, to transfer 80 bytes, with a Source Width of 2, the TransferSize field = should be programmed with: Total transfer size ------------------- = 40 <source width> [Viresh] Will this change if source is 4 bytes and dest is 2? [David] Yes - the calculation then becomes: Total transfer size ------------------- =20 <source width> Also, max_bytes_per_lli must be calculated after fixing src and dest widths not before that. So move this code to the correct place. This patch also removes max_bytes_per_lli from earlier print message, as till that point max_bytes_per_lli is unknown. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/dma/amba-pl08x.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index e00a9b5..c29e55c 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -601,23 +601,17 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, bd.srcbus.buswidth = bd.srcbus.maxwidth; bd.dstbus.buswidth = bd.dstbus.maxwidth; - /* - * Bytes transferred == tsize * MIN(buswidths), not max(buswidths) - */ - max_bytes_per_lli = min(bd.srcbus.buswidth, bd.dstbus.buswidth) * - PL080_CONTROL_TRANSFER_SIZE_MASK; - /* We need to count this down to zero */ bd.remainder = txd->len; pl08x_choose_master_bus(&bd, &mbus, &sbus, cctl); - dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu llimax=%zu\n", + dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu\n", bd.srcbus.addr, cctl & PL080_CONTROL_SRC_INCR ? "+" : "", bd.srcbus.buswidth, bd.dstbus.addr, cctl & PL080_CONTROL_DST_INCR ? "+" : "", bd.dstbus.buswidth, - bd.remainder, max_bytes_per_lli); + bd.remainder); dev_vdbg(&pl08x->adev->dev, "mbus=%s sbus=%s\n", mbus == &bd.srcbus ? "src" : "dst", sbus == &bd.srcbus ? "src" : "dst"); @@ -657,6 +651,10 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, sbus->buswidth = 1; } + /* Bytes transferred = tsize * src width, not MIN(buswidths) */ + max_bytes_per_lli = bd.srcbus.buswidth * + PL080_CONTROL_TRANSFER_SIZE_MASK; + /* * Make largest possible LLIs until less than one bus * width left -- 1.7.2.2
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@st.com (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V2 13/20] dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width (not MIN(width)) Date: Mon, 1 Aug 2011 15:07:23 +0530 [thread overview] Message-ID: <816b8264dc71310bd6fca94ed454ebb6e2b2ba5e.1312190881.git.viresh.kumar@st.com> (raw) In-Reply-To: <cover.1312190881.git.viresh.kumar@st.com> max_bytes_per_lli = bd.srcbus.buswidth * PL080_CONTROL_TRANSFER_SIZE_MASK; This is confirmed by ARM support guys. Below is summary of mail exchange with them: [Viresh] What is the total data to be transferred in case source and destination bus widths are different. Suppose, source bus width is 2 bytes and destination is 4 bytes. Now in order to transfer 80 bytes, what should be value of TransferSize field in control reg: 40? or 20?. [David from ARM] The value that is programmed into the TransferSize field should be the number of <SourceWidth> transfers needed to achieve the required data transfer. So, to transfer 80 bytes, with a Source Width of 2, the TransferSize field = should be programmed with: Total transfer size ------------------- = 40 <source width> [Viresh] Will this change if source is 4 bytes and dest is 2? [David] Yes - the calculation then becomes: Total transfer size ------------------- =20 <source width> Also, max_bytes_per_lli must be calculated after fixing src and dest widths not before that. So move this code to the correct place. This patch also removes max_bytes_per_lli from earlier print message, as till that point max_bytes_per_lli is unknown. Signed-off-by: Viresh Kumar <viresh.kumar@st.com> Acked-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/dma/amba-pl08x.c | 14 ++++++-------- 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c index e00a9b5..c29e55c 100644 --- a/drivers/dma/amba-pl08x.c +++ b/drivers/dma/amba-pl08x.c @@ -601,23 +601,17 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, bd.srcbus.buswidth = bd.srcbus.maxwidth; bd.dstbus.buswidth = bd.dstbus.maxwidth; - /* - * Bytes transferred == tsize * MIN(buswidths), not max(buswidths) - */ - max_bytes_per_lli = min(bd.srcbus.buswidth, bd.dstbus.buswidth) * - PL080_CONTROL_TRANSFER_SIZE_MASK; - /* We need to count this down to zero */ bd.remainder = txd->len; pl08x_choose_master_bus(&bd, &mbus, &sbus, cctl); - dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu llimax=%zu\n", + dev_vdbg(&pl08x->adev->dev, "src=0x%08x%s/%u dst=0x%08x%s/%u len=%zu\n", bd.srcbus.addr, cctl & PL080_CONTROL_SRC_INCR ? "+" : "", bd.srcbus.buswidth, bd.dstbus.addr, cctl & PL080_CONTROL_DST_INCR ? "+" : "", bd.dstbus.buswidth, - bd.remainder, max_bytes_per_lli); + bd.remainder); dev_vdbg(&pl08x->adev->dev, "mbus=%s sbus=%s\n", mbus == &bd.srcbus ? "src" : "dst", sbus == &bd.srcbus ? "src" : "dst"); @@ -657,6 +651,10 @@ static int pl08x_fill_llis_for_desc(struct pl08x_driver_data *pl08x, sbus->buswidth = 1; } + /* Bytes transferred = tsize * src width, not MIN(buswidths) */ + max_bytes_per_lli = bd.srcbus.buswidth * + PL080_CONTROL_TRANSFER_SIZE_MASK; + /* * Make largest possible LLIs until less than one bus * width left -- 1.7.2.2
next prev parent reply other threads:[~2011-08-01 9:41 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-01 9:37 [PATCH V2 00/20] dmaengine/amba-pl08x updates Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 01/20] ARM: asm/pl080.h: Protect against multiple inclusion of header file Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 02/20] dmaengine/amba-pl08x: Resolve formatting issues Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 03/20] dmaengine/amba-pl08x: Rearrange inclusion of header files in ascending order Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:52 ` Sergei Shtylyov 2011-08-01 9:52 ` Sergei Shtylyov 2011-08-01 10:34 ` viresh kumar 2011-08-01 10:34 ` viresh kumar 2011-08-01 9:37 ` [PATCH V2 04/20] dmaengine/amba-pl08x: pass (*ptr) to sizeof() instead of (struct xyz) Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 05/20] dmaengine/amba-pl08x: Complete doc comment for struct pl08x_txd Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 06/20] dmaengine/amba-pl08x: Remove redundant comment and rewrite original Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 07/20] dmaengine/amba-pl08x: Changing few prints to dev_dbg from dev_info Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-04 8:28 ` Koul, Vinod 2011-08-04 8:28 ` Koul, Vinod 2011-08-04 9:25 ` viresh kumar 2011-08-04 9:25 ` viresh kumar 2011-08-04 8:53 ` Koul, Vinod 2011-08-04 8:53 ` Koul, Vinod 2011-08-01 9:37 ` [PATCH V2 08/20] dmaengine/amba-pl08x: support runtime PM Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 10:26 ` Russell King - ARM Linux 2011-08-01 10:26 ` Russell King - ARM Linux 2011-08-01 11:55 ` viresh kumar 2011-08-01 11:55 ` viresh kumar 2011-08-03 12:39 ` Russell King - ARM Linux 2011-08-03 12:39 ` Russell King - ARM Linux 2011-08-04 5:19 ` viresh kumar 2011-08-04 5:19 ` viresh kumar 2011-08-04 5:36 ` Koul, Vinod 2011-08-04 5:36 ` Koul, Vinod 2011-08-04 6:31 ` viresh kumar 2011-08-04 6:31 ` viresh kumar 2011-08-04 7:28 ` Koul, Vinod 2011-08-04 7:28 ` Koul, Vinod 2011-08-04 8:42 ` viresh kumar 2011-08-04 8:42 ` viresh kumar 2011-08-01 9:37 ` [PATCH V2 09/20] dmaengine/amba-pl08x: Simplify pl08x_ensure_on() Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 10/20] dmaengine/amba-pl08x: No need to check "ch->signal < 0" Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 11/20] dmaengine/amba-pl08x: Schedule tasklet in case of error interrupt Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 12/20] dmaengine/amba-pl08x: Get rid of pl08x_pre_boundary() Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar [this message] 2011-08-01 9:37 ` [PATCH V2 13/20] dmaengine/amba-pl08x: max_bytes_per_lli is TRANSFER_SIZE * src_width (not MIN(width)) Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 14/20] dmaengine/amba-pl08x: Add prep_single_byte_llis() routine Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 15/20] dmaengine/amba-pl08x: Align lli_len to max(src.width, dst.width) Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 16/20] dmaengine/amba-pl08x: Choose peripheral bus as master bus Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 17/20] dmaengine/amba-pl08x: Pass flow controller information with slave channel data Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 18/20] dmaengine/amba-pl08x: Add support for sg len greater than one for slave transfers Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-04 10:27 ` viresh kumar 2011-08-04 10:27 ` viresh kumar 2011-08-01 9:37 ` [PATCH V2 19/20] dmaengine/amba-pl08x: Check txd->llis_va before freeing dma_pool Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 9:37 ` [PATCH V2 20/20] dmaengine/amba-pl08x: Call pl08x_free_txd() instead of calling kfree() directly Viresh Kumar 2011-08-01 9:37 ` Viresh Kumar 2011-08-01 11:56 ` [PATCH V3 08/20] dmaengine/amba-pl08x: support runtime PM Viresh Kumar 2011-08-01 11:56 ` Viresh Kumar 2011-08-04 8:52 ` Koul, Vinod 2011-08-04 8:52 ` Koul, Vinod 2011-08-04 9:41 ` viresh kumar 2011-08-04 9:41 ` viresh kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=816b8264dc71310bd6fca94ed454ebb6e2b2ba5e.1312190881.git.viresh.kumar@st.com \ --to=viresh.kumar@st.com \ --cc=amit.virdi@st.com \ --cc=armando.visconti@st.com \ --cc=bhupesh.sharma@st.com \ --cc=dan.j.williams@intel.com \ --cc=deepak.sikri@st.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=pratyush.anand@st.com \ --cc=rajeev-dlh.kumar@st.com \ --cc=shiraz.hashim@st.com \ --cc=vinod.koul@intel.com \ --cc=vipin.kumar@st.com \ --cc=vipulkumar.samar@st.com \ --cc=viresh.linux@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.