From: Arnd Bergmann <arnd@arndb.de> To: Mark Brown <broonie@kernel.org> Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen <lars@metafoo.de>, Alexander Shiyan <shc_work@mail.ru>, linux-arm-kernel@lists.infradead.org, Liam Girdwood <lgirdwood@gmail.com> Subject: Re: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Date: Tue, 29 Apr 2014 21:16:35 +0200 [thread overview] Message-ID: <8655908.M1OtjG8JKI@wuerfel> (raw) In-Reply-To: <20140429165630.GD16981@sirena.org.uk> On Tuesday 29 April 2014 09:56:30 Mark Brown wrote: > On Tue, Apr 29, 2014 at 04:30:43PM +0200, Lars-Peter Clausen wrote: > > > Yes. The patch should also add a select for SND_SOC_IMX_PCM_FIQ as that is > > used in the same way in the fsl_ssi driver. If anybody is afraid that > > selecting both SND_SOC_IMX_PCM_FIQ and SND_SOC_IMX_PCM_DMA by default adds > > too much overhead you could add boolean sub-options that allow to > > enable/disable support individually. > > Yes, the overhead should be negligable since the FIQ code is tiny. > Arnd, please CC maintainers on patches - you've sent this to my > Linaro address again and not added Liam. I've tried yet another approach now, this should also work and has simpler dependencies. I'll follow up with the suggested patch and let you pick one or the other. Sorry for using the wrong Cc list, I too the addresses out of the patch that introduced the problem and didn't think about it. Arnd 8<----------- >From e07c95b1519c2103a9b42fd12e993440dafba9d6 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann <arnd@arndb.de> Date: Mon, 28 Apr 2014 16:28:01 +0200 Subject: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Since commit 204dec93eaa "ASoC: fsl: Allow to select individual common options", it is possible to enable SND_SOC_FSL_SSI and SND_SOC_FSL_SPDIF manually, either as loadable modules or built-in. This unfortunately leads to a link error if one or both of them are built-in, while the imx-pcm-dma framework is a loadable module: sound/built-in.o: In function `fsl_ssi_probe': :(.text+0x51fb8): undefined reference to `imx_pcm_dma_init' sound/built-in.o: In function `fsl_spdif_probe': :(.text+0x52e20): undefined reference to `imx_pcm_dma_init' This changes Kconfig to prevent this case by ensuring the imx-pcm-dma code is built-in if the i.MX SoC support is enabled and at least one of the two drivers is built-in. Signed-off-by: Arnd Bergmann <arnd@arndb.de> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index fb26345..5e0a58c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -34,6 +34,7 @@ config SND_SOC_FSL_UTILS config SND_SOC_IMX_PCM_DMA tristate + default y if SND_IMX_SOC!=n && (SND_SOC_FSL_SSI=y || SND_SOC_FSL_SPDIF=y) select SND_SOC_GENERIC_DMAENGINE_PCM config SND_SOC_IMX_AUDMUX
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann) To: linux-arm-kernel@lists.infradead.org Subject: [alsa-devel] [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Date: Tue, 29 Apr 2014 21:16:35 +0200 [thread overview] Message-ID: <8655908.M1OtjG8JKI@wuerfel> (raw) In-Reply-To: <20140429165630.GD16981@sirena.org.uk> On Tuesday 29 April 2014 09:56:30 Mark Brown wrote: > On Tue, Apr 29, 2014 at 04:30:43PM +0200, Lars-Peter Clausen wrote: > > > Yes. The patch should also add a select for SND_SOC_IMX_PCM_FIQ as that is > > used in the same way in the fsl_ssi driver. If anybody is afraid that > > selecting both SND_SOC_IMX_PCM_FIQ and SND_SOC_IMX_PCM_DMA by default adds > > too much overhead you could add boolean sub-options that allow to > > enable/disable support individually. > > Yes, the overhead should be negligable since the FIQ code is tiny. > Arnd, please CC maintainers on patches - you've sent this to my > Linaro address again and not added Liam. I've tried yet another approach now, this should also work and has simpler dependencies. I'll follow up with the suggested patch and let you pick one or the other. Sorry for using the wrong Cc list, I too the addresses out of the patch that introduced the problem and didn't think about it. Arnd 8<----------- >From e07c95b1519c2103a9b42fd12e993440dafba9d6 Mon Sep 17 00:00:00 2001 From: Arnd Bergmann <arnd@arndb.de> Date: Mon, 28 Apr 2014 16:28:01 +0200 Subject: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Since commit 204dec93eaa "ASoC: fsl: Allow to select individual common options", it is possible to enable SND_SOC_FSL_SSI and SND_SOC_FSL_SPDIF manually, either as loadable modules or built-in. This unfortunately leads to a link error if one or both of them are built-in, while the imx-pcm-dma framework is a loadable module: sound/built-in.o: In function `fsl_ssi_probe': :(.text+0x51fb8): undefined reference to `imx_pcm_dma_init' sound/built-in.o: In function `fsl_spdif_probe': :(.text+0x52e20): undefined reference to `imx_pcm_dma_init' This changes Kconfig to prevent this case by ensuring the imx-pcm-dma code is built-in if the i.MX SoC support is enabled and at least one of the two drivers is built-in. Signed-off-by: Arnd Bergmann <arnd@arndb.de> diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig index fb26345..5e0a58c 100644 --- a/sound/soc/fsl/Kconfig +++ b/sound/soc/fsl/Kconfig @@ -34,6 +34,7 @@ config SND_SOC_FSL_UTILS config SND_SOC_IMX_PCM_DMA tristate + default y if SND_IMX_SOC!=n && (SND_SOC_FSL_SSI=y || SND_SOC_FSL_SPDIF=y) select SND_SOC_GENERIC_DMAENGINE_PCM config SND_SOC_IMX_AUDMUX
next prev parent reply other threads:[~2014-04-29 19:16 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2014-04-28 14:46 [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Arnd Bergmann 2014-04-28 14:46 ` Arnd Bergmann 2014-04-28 18:46 ` Alexander Shiyan 2014-04-28 19:52 ` Arnd Bergmann 2014-04-28 19:52 ` Arnd Bergmann 2014-04-28 20:35 ` Alexander Shiyan 2014-04-28 21:12 ` Arnd Bergmann 2014-04-28 21:12 ` Arnd Bergmann 2014-04-29 3:07 ` Alexander Shiyan 2014-04-29 10:37 ` Arnd Bergmann 2014-04-29 10:37 ` Arnd Bergmann 2014-04-29 10:57 ` Lars-Peter Clausen 2014-04-29 10:57 ` [alsa-devel] " Lars-Peter Clausen 2014-04-29 13:30 ` Arnd Bergmann 2014-04-29 13:30 ` [alsa-devel] " Arnd Bergmann 2014-04-29 14:30 ` Lars-Peter Clausen 2014-04-29 14:30 ` Lars-Peter Clausen 2014-04-29 16:56 ` Mark Brown 2014-04-29 16:56 ` [alsa-devel] " Mark Brown 2014-04-29 19:16 ` Arnd Bergmann [this message] 2014-04-29 19:16 ` Arnd Bergmann 2014-04-29 19:36 ` Arnd Bergmann 2014-04-29 19:36 ` [alsa-devel] " Arnd Bergmann 2014-05-01 20:54 ` Mark Brown 2014-05-01 20:54 ` [alsa-devel] " Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8655908.M1OtjG8JKI@wuerfel \ --to=arnd@arndb.de \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lars@metafoo.de \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=shc_work@mail.ru \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.