All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Mark Brown <broonie@kernel.org>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: [alsa-devel] [PATCH v3 resend 3/8] ASoC: soc-core: care .ignore_suspend for Component suspend
Date: 10 Jan 2020 11:36:02 +0900	[thread overview]
Message-ID: <877e20t4vh.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87blrct4xg.wl-kuninori.morimoto.gx@renesas.com>

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Card dai_link has .ignore_suspend, and ALSA SoC cares it when suspend.
For example, like this

	for_each_card_rtds(card, rtd) {
		if (rtd->dai_link->ignore_suspend)
			continue;
		...
	}

But in snd_soc_suspend(), it doesn't care about
it when suspending Component. This patch cares it.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 sound/soc/soc-core.c | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/sound/soc/soc-core.c b/sound/soc/soc-core.c
index 9a6d905..8a1b4ff 100644
--- a/sound/soc/soc-core.c
+++ b/sound/soc/soc-core.c
@@ -562,15 +562,25 @@ int snd_soc_suspend(struct device *dev)
 	snd_soc_dapm_sync(&card->dapm);
 
 	/* suspend all COMPONENTs */
-	for_each_card_components(card, component) {
-		struct snd_soc_dapm_context *dapm =
+	for_each_card_rtds(card, rtd) {
+
+		if (rtd->dai_link->ignore_suspend)
+			continue;
+
+		for_each_rtd_components(rtd, i, component) {
+			struct snd_soc_dapm_context *dapm =
 				snd_soc_component_get_dapm(component);
 
-		/*
-		 * If there are paths active then the COMPONENT will be held
-		 * with bias _ON and should not be suspended.
-		 */
-		if (!snd_soc_component_is_suspended(component)) {
+			/*
+			 * ignore if component was already suspended
+			 */
+			if (snd_soc_component_is_suspended(component))
+				continue;
+
+			/*
+			 * If there are paths active then the COMPONENT will be
+			 * held with bias _ON and should not be suspended.
+			 */
 			switch (snd_soc_dapm_get_bias_level(dapm)) {
 			case SND_SOC_BIAS_STANDBY:
 				/*
-- 
2.7.4

_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  parent reply	other threads:[~2020-01-10  2:38 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-10  2:34 [alsa-devel] [PATCH v3 resend 0/8] ASoC: soc-core cleanup step8 Kuninori Morimoto
2020-01-10  2:35 ` [alsa-devel] [PATCH v3 resend 1/8] ASoC: soc-core: remove snd_soc_rtdcom_list Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: remove snd_soc_rtdcom_list" to the asoc tree Mark Brown
2020-01-10  2:35 ` [alsa-devel] [PATCH v3 resend 2/8] ASoC: soc-core: rename snd_soc_rtdcom_add() to snd_soc_rtd_add_component() Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: rename snd_soc_rtdcom_add() to snd_soc_rtd_add_component()" to the asoc tree Mark Brown
2020-01-10  2:36 ` Kuninori Morimoto [this message]
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: care .ignore_suspend for Component suspend" " Mark Brown
2020-01-10  2:36 ` [alsa-devel] [PATCH v3 resend 4/8] ASoC: soc-core: remove duplicate pinctrl operation when suspend Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: remove duplicate pinctrl operation when suspend" to the asoc tree Mark Brown
2020-01-10  2:36 ` [alsa-devel] [PATCH v3 resend 5/8] ASoC: soc-core: do pinctrl_pm_select_xxx() as component Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: do pinctrl_pm_select_xxx() as component" to the asoc tree Mark Brown
2020-01-10  2:36 ` [alsa-devel] [PATCH v3 resend 6/8] ASoC: soc-core: add snd_soc_close_delayed_work() Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-core: add snd_soc_close_delayed_work()" to the asoc tree Mark Brown
2020-01-10  2:36 ` [alsa-devel] [PATCH v3 resend 7/8] ASoC: soc-dapm: add snd_soc_dapm_stream_stop() Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-dapm: add snd_soc_dapm_stream_stop()" to the asoc tree Mark Brown
2020-01-10  2:36 ` [alsa-devel] [PATCH v3 resend 8/8] ASoC: soc-pcm/soc-compress: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP Kuninori Morimoto
2020-01-10 13:37   ` [alsa-devel] Applied "ASoC: soc-pcm/soc-compress: use snd_soc_dapm_stream_stop() for SND_SOC_DAPM_STREAM_STOP" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877e20t4vh.wl-kuninori.morimoto.gx@renesas.com \
    --to=kuninori.morimoto.gx@renesas.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.