Re: [PATCH v7 1/4] spinlock: A new lockref structure for lockless update of refcount

[Sedat Dilek <sedat.dilek@gmail.com>]

On Wed, Sep 4, 2013 at 1:15 AM, Dave Jones <davej@redhat.com> wrote:
> On Wed, Sep 04, 2013 at 01:05:38AM +0200, Sedat Dilek wrote:
>  > On Wed, Sep 4, 2013 at 12:55 AM, Dave Jones <davej@redhat.com> wrote:
>  > > On Wed, Sep 04, 2013 at 12:37:25AM +0200, Sedat Dilek wrote:
>  > >
>  > >  > > You're spending more time on the task stats than on the actual lookup.
>  > >  > > Maybe you should turn off CONFIG_TASKSTATS..But why that whole
>  > >  > > irq_return thing? Odd.
>  > >  > >
>  > >  >
>  > >  > [ init/Kconfig ]
>  > >  > ...
>  > >  > config TASKSTATS
>  > >  >         bool "Export task/process statistics through netlink"
>  > >  >         depends on NET <--- Difficult to disable it?!
>  > >
>  > > More likely you're getting bitten by the fact that CONFIG_KVM has
>  > > a 'select TASKSTATS'
>  > >
>  >
>  > With CONFIG_KVM=n ...
>  >
>  > $ egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
>  > CONFIG_TASKSTATS=y
>  > CONFIG_NET=y
>
> Weird.
>
> sed -i '/TASKSTATS/d' .config
> sed -i '/KVM/d' .config
> make oldconfig
> ...
> egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
> # CONFIG_TASKSTATS is not set
> CONFIG_NET=y
>
>
> The NET dependancy shouldn't matter at all.
> I don't see any other 'select TASKSTATS' in the tree.
>

Ah, cool.

With CONFIG_KVM=n and CONFIG_TASKSTATS=n plus...

$ yes "" | make oldconfig && make silentoldconfig </dev/null

...I get now:

$ egrep 'CONFIG_NET=|CONFIG_KVM=|CONFIG_TASKSTATS' .config
# CONFIG_TASKSTATS is not set
CONFIG_NET=y

Thanks, Dave!

- Sedat -