All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Baluta <daniel.baluta@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"S.j. Wang" <shengjiu.wang@nxp.com>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: simple-audio-card,mclk-fs
Date: Fri, 22 Feb 2019 17:16:46 +0200	[thread overview]
Message-ID: <CAEnQRZDpJu27_pB=-ZYQjsNPC8eA4-Ur-36niT2hCosMWtC7jw@mail.gmail.com> (raw)

Hello Morimoto-san,

Do you have any plans on adding support for multiple mclk-fs values
in simple-card?

Usually one constant mclk-fs value is not enough because usually codecs
have different value depending on rate.

For example, for wm8524 [1] one can use
mclk-fs = 256 for rates between 8kHz and 96kHz
but it needs to change mclk-fs = 128 for 176.4hHz
and 192kHz.

I am thinking of something like this:

--- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
@@ -44,6 +44,8 @@
                compatible = "simple-audio-card";
                simple-audio-card,name = "wm8524-audio";
                simple-audio-card,format = "i2s";
+               simple-audio-card,lrclk-fs = <8000>, <32000>, <44100>
<48000>, <96000>, <176400>, <192000>;
+               simple-audio-card,mclk-fs = <256>, <256>, <256>,
<256>, <256>, <128>, <128>;

Let me know if this would be a good direction and I will send a patch.

thanks,
Daniel.
[1] https://www.cirrus.com/products/wm8524/

             reply	other threads:[~2019-02-22 15:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-22 15:16 Daniel Baluta [this message]
2019-02-25  1:48 ` simple-audio-card,mclk-fs Kuninori Morimoto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEnQRZDpJu27_pB=-ZYQjsNPC8eA4-Ur-36niT2hCosMWtC7jw@mail.gmail.com' \
    --to=daniel.baluta@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=daniel.baluta@nxp.com \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-imx@nxp.com \
    --cc=shengjiu.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.