From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: Ilya Dryomov <idryomov@gmail.com>,
Dave Wysochanski <dwysocha@redhat.com>,
Shyam Prasad N <nspmangalore@gmail.com>,
linux-nfs@vger.kernel.org, linux-cifs@vger.kernel.org,
Dominique Martinet <asmadeus@codewreck.org>,
linux-mm@kvack.org, Rohith Surabattula <rohiths.msft@gmail.com>,
v9fs-developer@lists.sourceforge.net, ceph-devel@vger.kernel.org,
linux-cachefs@redhat.com, linux-afs@lists.infradead.org,
Matthew Wilcox <willy@infradead.org>,
Steve French <sfrench@samba.org>,
linux-fsdevel@vger.kernel.org, Jeff Layton <jlayton@kernel.org>,
linux-erofs@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache
Date: Wed, 23 Nov 2022 14:52:58 -0800 [thread overview]
Message-ID: <CAHk-=wjq7gRdVUrwpQvEN1+um+hTkW8dZZATtfFS-fp9nNssRw@mail.gmail.com> (raw)
In-Reply-To: <166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk>
On Wed, Nov 23, 2022 at 2:48 PM David Howells <dhowells@redhat.com> wrote:
>
> I've also got rid of the bit clearances
> from the network filesystem evict_inode functions as they doesn't seem to
> be necessary.
Well, the patches look superficially cleaner to me, at least. That
"doesn't seem to be necessary" makes me a bit worried, and I'd have
liked to see a more clear-cut "clearing it isn't necessary because X",
but I _assume_ it's not necessary simply because the 'struct
address_space" is released and never re-used.
But making the lifetime of that bit explicit might just be a good idea.
Linus
WARNING: multiple messages have this Message-ID (diff)
From: Linus Torvalds <torvalds@linux-foundation.org>
To: David Howells <dhowells@redhat.com>
Cc: Shyam Prasad N <nspmangalore@gmail.com>,
linux-cifs@vger.kernel.org, linux-nfs@vger.kernel.org,
Rohith Surabattula <rohiths.msft@gmail.com>,
Jeff Layton <jlayton@kernel.org>,
Dave Wysochanski <dwysocha@redhat.com>,
ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-afs@lists.infradead.org, Steve French <sfrench@samba.org>,
linux-mm@kvack.org, linux-cachefs@redhat.com,
linux-fsdevel@vger.kernel.org,
v9fs-developer@lists.sourceforge.net,
Ilya Dryomov <idryomov@gmail.com>,
linux-erofs@lists.ozlabs.org,
Dominique Martinet <asmadeus@codewreck.org>
Subject: Re: [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache
Date: Wed, 23 Nov 2022 14:52:58 -0800 [thread overview]
Message-ID: <CAHk-=wjq7gRdVUrwpQvEN1+um+hTkW8dZZATtfFS-fp9nNssRw@mail.gmail.com> (raw)
In-Reply-To: <166924370539.1772793.13730698360771821317.stgit@warthog.procyon.org.uk>
On Wed, Nov 23, 2022 at 2:48 PM David Howells <dhowells@redhat.com> wrote:
>
> I've also got rid of the bit clearances
> from the network filesystem evict_inode functions as they doesn't seem to
> be necessary.
Well, the patches look superficially cleaner to me, at least. That
"doesn't seem to be necessary" makes me a bit worried, and I'd have
liked to see a more clear-cut "clearing it isn't necessary because X",
but I _assume_ it's not necessary simply because the 'struct
address_space" is released and never re-used.
But making the lifetime of that bit explicit might just be a good idea.
Linus
next prev parent reply other threads:[~2022-11-23 22:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 22:48 [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache David Howells
2022-11-23 22:48 ` David Howells
2022-11-23 22:48 ` [RFC PATCH v4 1/3] mm: Merge folio_has_private()/filemap_release_folio() call pairs David Howells
2022-11-23 22:48 ` David Howells
2022-11-23 22:48 ` [RFC PATCH v4 2/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache David Howells
2022-11-23 22:48 ` David Howells
2022-11-23 22:48 ` [RFC PATCH v4 3/3] mm: Make filemap_release_folio() better inform shrink_folio_list() David Howells
2022-11-23 22:48 ` David Howells
2022-11-23 22:52 ` Linus Torvalds [this message]
2022-11-23 22:52 ` [PATCH v4 0/3] mm, netfs, fscache: Stop read optimisation when folio removed from pagecache Linus Torvalds
2022-11-23 23:12 ` David Howells
2022-11-23 23:12 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wjq7gRdVUrwpQvEN1+um+hTkW8dZZATtfFS-fp9nNssRw@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=asmadeus@codewreck.org \
--cc=ceph-devel@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=dwysocha@redhat.com \
--cc=idryomov@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-cachefs@redhat.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-erofs@lists.ozlabs.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nspmangalore@gmail.com \
--cc=rohiths.msft@gmail.com \
--cc=sfrench@samba.org \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.