From: Arnd Bergmann <arnd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
llvm@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Hu Haowen <src.res@email.cn>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-doc-tw-discuss@lists.sourceforge.net,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11
Date: Mon, 28 Feb 2022 12:37:37 +0100 [thread overview]
Message-ID: <CAK8P3a0CTmtUq+Uba2S3D7wjSstew2M+LfzZoOcKdKK9cfXO9A@mail.gmail.com> (raw)
In-Reply-To: <YhyxML05rjJ/57Vk@FVFF77S0Q05N>
On Mon, Feb 28, 2022 at 12:25 PM Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
> >
> > Nathan Chancellor reported an additional -Wdeclaration-after-statement
> > warning that appears in a system header on arm, this still needs a
> > workaround.
>
> FWIW, I had a go at moving to c99 a few weeks ago (to be able to use
> for-loop-declarations in some concurrency primitives), and when I tried, I also
> saw declaration-after-statement warnings when building modpost.c, which is easy
> enough to fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=treewide/gnu99&id=505775bd6fd0bc1883f3271f826963066bbdc194
I think the KBUILD_USERCFLAGS portion and the modpost.c fix for it
make sense regardless of the -std=gnu11 change, but your change
to KBUILD_CFLAGS is not actually needed because the warning is
already enabled there -- gnu89 allows intermingled declarations since
gcc-3.4, so the warning flag was added during early 2.6.x kernels.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marco Elver <elver@google.com>,
Michal Marek <michal.lkml@markovi.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
linux-staging@lists.linux.dev,
Masahiro Yamada <masahiroy@kernel.org>,
llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
greybus-dev@lists.linaro.org, Alex Shi <alexs@kernel.org>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Hu Haowen <src.res@email.cn>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-doc-tw-discuss@lists.sourceforge.net,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11
Date: Mon, 28 Feb 2022 12:37:37 +0100 [thread overview]
Message-ID: <CAK8P3a0CTmtUq+Uba2S3D7wjSstew2M+LfzZoOcKdKK9cfXO9A@mail.gmail.com> (raw)
In-Reply-To: <YhyxML05rjJ/57Vk@FVFF77S0Q05N>
On Mon, Feb 28, 2022 at 12:25 PM Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
> >
> > Nathan Chancellor reported an additional -Wdeclaration-after-statement
> > warning that appears in a system header on arm, this still needs a
> > workaround.
>
> FWIW, I had a go at moving to c99 a few weeks ago (to be able to use
> for-loop-declarations in some concurrency primitives), and when I tried, I also
> saw declaration-after-statement warnings when building modpost.c, which is easy
> enough to fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=treewide/gnu99&id=505775bd6fd0bc1883f3271f826963066bbdc194
I think the KBUILD_USERCFLAGS portion and the modpost.c fix for it
make sense regardless of the -std=gnu11 change, but your change
to KBUILD_CFLAGS is not actually needed because the warning is
already enabled there -- gnu89 allows intermingled declarations since
gcc-3.4, so the warning flag was added during early 2.6.x kernels.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
llvm@lists.linux.dev, Jonathan Corbet <corbet@lwn.net>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Alex Shi <alexs@kernel.org>, Hu Haowen <src.res@email.cn>,
Michal Marek <michal.lkml@markovi.net>,
Nick Desaulniers <ndesaulniers@google.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-doc-tw-discuss@lists.sourceforge.net,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH] [v2] Kbuild: move to -std=gnu11
Date: Mon, 28 Feb 2022 12:37:37 +0100 [thread overview]
Message-ID: <CAK8P3a0CTmtUq+Uba2S3D7wjSstew2M+LfzZoOcKdKK9cfXO9A@mail.gmail.com> (raw)
In-Reply-To: <YhyxML05rjJ/57Vk@FVFF77S0Q05N>
On Mon, Feb 28, 2022 at 12:25 PM Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
> >
> > Nathan Chancellor reported an additional -Wdeclaration-after-statement
> > warning that appears in a system header on arm, this still needs a
> > workaround.
>
> FWIW, I had a go at moving to c99 a few weeks ago (to be able to use
> for-loop-declarations in some concurrency primitives), and when I tried, I also
> saw declaration-after-statement warnings when building modpost.c, which is easy
> enough to fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=treewide/gnu99&id=505775bd6fd0bc1883f3271f826963066bbdc194
I think the KBUILD_USERCFLAGS portion and the modpost.c fix for it
make sense regardless of the -std=gnu11 change, but your change
to KBUILD_CFLAGS is not actually needed because the warning is
already enabled there -- gnu89 allows intermingled declarations since
gcc-3.4, so the warning flag was added during early 2.6.x kernels.
Arnd
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@kernel.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
Marco Elver <elver@google.com>,
Michal Marek <michal.lkml@markovi.net>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Jonathan Corbet <corbet@lwn.net>,
linux-staging@lists.linux.dev,
Masahiro Yamada <masahiroy@kernel.org>,
llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
greybus-dev@lists.linaro.org, Alex Shi <alexs@kernel.org>,
Federico Vaga <federico.vaga@vaga.pv.it>,
Hu Haowen <src.res@email.cn>,
Intel Graphics <intel-gfx@lists.freedesktop.org>,
linux-btrfs <linux-btrfs@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-doc-tw-discuss@lists.sourceforge.net,
Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Subject: Re: [Intel-gfx] [PATCH] [v2] Kbuild: move to -std=gnu11
Date: Mon, 28 Feb 2022 12:37:37 +0100 [thread overview]
Message-ID: <CAK8P3a0CTmtUq+Uba2S3D7wjSstew2M+LfzZoOcKdKK9cfXO9A@mail.gmail.com> (raw)
In-Reply-To: <YhyxML05rjJ/57Vk@FVFF77S0Q05N>
On Mon, Feb 28, 2022 at 12:25 PM Mark Rutland <mark.rutland@arm.com> wrote:
> On Mon, Feb 28, 2022 at 11:27:43AM +0100, Arnd Bergmann wrote:
> >
> > Nathan Chancellor reported an additional -Wdeclaration-after-statement
> > warning that appears in a system header on arm, this still needs a
> > workaround.
>
> FWIW, I had a go at moving to c99 a few weeks ago (to be able to use
> for-loop-declarations in some concurrency primitives), and when I tried, I also
> saw declaration-after-statement warnings when building modpost.c, which is easy
> enough to fix:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/commit/?h=treewide/gnu99&id=505775bd6fd0bc1883f3271f826963066bbdc194
I think the KBUILD_USERCFLAGS portion and the modpost.c fix for it
make sense regardless of the -std=gnu11 change, but your change
to KBUILD_CFLAGS is not actually needed because the warning is
already enabled there -- gnu89 allows intermingled declarations since
gcc-3.4, so the warning flag was added during early 2.6.x kernels.
Arnd
next prev parent reply other threads:[~2022-02-28 11:37 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 10:27 [PATCH] [v2] Kbuild: move to -std=gnu11 Arnd Bergmann
2022-02-28 10:27 ` [Intel-gfx] " Arnd Bergmann
2022-02-28 10:27 ` Arnd Bergmann
2022-02-28 10:27 ` Arnd Bergmann
2022-02-28 10:50 ` Greg KH
2022-02-28 10:50 ` Greg KH
2022-02-28 10:50 ` [Intel-gfx] " Greg KH
2022-02-28 10:50 ` Greg KH
2022-02-28 11:25 ` Mark Rutland
2022-02-28 11:25 ` [Intel-gfx] " Mark Rutland
2022-02-28 11:25 ` Mark Rutland
2022-02-28 11:25 ` Mark Rutland
2022-02-28 11:37 ` Arnd Bergmann [this message]
2022-02-28 11:37 ` [Intel-gfx] " Arnd Bergmann
2022-02-28 11:37 ` Arnd Bergmann
2022-02-28 11:37 ` Arnd Bergmann
2022-02-28 18:40 ` [Intel-gfx] " Linus Torvalds
2022-02-28 18:40 ` Linus Torvalds
2022-02-28 18:40 ` Linus Torvalds
2022-02-28 18:40 ` Linus Torvalds
2022-02-28 17:07 ` Masahiro Yamada
2022-02-28 17:07 ` [Intel-gfx] " Masahiro Yamada
2022-02-28 17:07 ` Masahiro Yamada
2022-02-28 17:07 ` Masahiro Yamada
2022-02-28 11:47 ` Marco Elver
2022-02-28 11:47 ` [Intel-gfx] " Marco Elver
2022-02-28 11:47 ` Marco Elver
2022-02-28 11:47 ` Marco Elver
2022-02-28 11:57 ` Arnd Bergmann
2022-02-28 11:57 ` [Intel-gfx] " Arnd Bergmann
2022-02-28 11:57 ` Arnd Bergmann
2022-02-28 11:57 ` Arnd Bergmann
2022-02-28 16:56 ` Nathan Chancellor
2022-02-28 16:56 ` [Intel-gfx] " Nathan Chancellor
2022-02-28 16:56 ` Nathan Chancellor
2022-02-28 16:56 ` Nathan Chancellor
2022-02-28 12:36 ` Jani Nikula
2022-02-28 12:36 ` Jani Nikula
2022-02-28 12:36 ` [Intel-gfx] " Jani Nikula
2022-02-28 12:36 ` Jani Nikula
2022-02-28 13:01 ` Arnd Bergmann
2022-02-28 13:01 ` [Intel-gfx] " Arnd Bergmann
2022-02-28 13:01 ` Arnd Bergmann
2022-02-28 13:01 ` Arnd Bergmann
2022-02-28 13:19 ` David Sterba
2022-02-28 13:19 ` David Sterba
2022-02-28 13:19 ` [Intel-gfx] " David Sterba
2022-02-28 13:19 ` David Sterba
2022-02-28 12:48 ` Alex Shi
2022-02-28 12:48 ` Alex Shi
2022-02-28 12:48 ` [Intel-gfx] " Alex Shi
2022-02-28 12:48 ` Alex Shi
2022-02-28 12:56 ` David Sterba
2022-02-28 12:56 ` David Sterba
2022-02-28 12:56 ` [Intel-gfx] " David Sterba
2022-02-28 12:56 ` David Sterba
2022-02-28 17:02 ` Masahiro Yamada
2022-02-28 17:02 ` [Intel-gfx] " Masahiro Yamada
2022-02-28 17:02 ` Masahiro Yamada
2022-02-28 17:02 ` Masahiro Yamada
2022-02-28 18:24 ` Arnd Bergmann
2022-02-28 18:24 ` [Intel-gfx] " Arnd Bergmann
2022-02-28 18:24 ` Arnd Bergmann
2022-02-28 18:24 ` Arnd Bergmann
2022-02-28 21:03 ` Nick Desaulniers
2022-02-28 21:03 ` Nick Desaulniers
2022-02-28 21:03 ` [Intel-gfx] " Nick Desaulniers
2022-02-28 21:03 ` Nick Desaulniers
2022-02-28 21:41 ` Fangrui Song
2022-02-28 21:41 ` [Intel-gfx] " Fangrui Song
2022-02-28 21:41 ` Fangrui Song
2022-02-28 21:41 ` Fangrui Song
2022-03-01 14:45 ` Arnd Bergmann
2022-03-01 14:45 ` [Intel-gfx] " Arnd Bergmann
2022-03-01 14:45 ` Arnd Bergmann
2022-03-01 14:45 ` Arnd Bergmann
2022-02-28 21:41 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for " Patchwork
2022-02-28 22:13 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-03-01 7:30 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2022-03-01 10:24 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Kbuild: move to -std=gnu11 (rev2) Patchwork
2022-03-01 10:43 ` [PATCH] [v2] Kbuild: move to -std=gnu11 Miguel Ojeda
2022-03-01 10:43 ` [Intel-gfx] " Miguel Ojeda
2022-03-01 10:43 ` Miguel Ojeda
2022-03-01 10:43 ` Miguel Ojeda
2022-03-01 14:44 ` Arnd Bergmann
2022-03-01 14:44 ` [Intel-gfx] " Arnd Bergmann
2022-03-01 14:44 ` Arnd Bergmann
2022-03-01 14:44 ` Arnd Bergmann
2022-03-01 10:59 ` [Intel-gfx] ✓ Fi.CI.BAT: success for Kbuild: move to -std=gnu11 (rev2) Patchwork
2022-03-01 17:22 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-05-16 13:10 ` [PATCH] [v2] Kbuild: move to -std=gnu11 Guenter Roeck
2022-05-16 13:10 ` Guenter Roeck
2022-05-16 13:10 ` [Intel-gfx] " Guenter Roeck
2022-05-16 13:10 ` Guenter Roeck
2022-05-16 13:31 ` [greybus-dev] " Greg KH
2022-05-16 13:31 ` Greg KH
2022-05-16 13:31 ` [Intel-gfx] " Greg KH
2022-05-16 13:31 ` Greg KH
2022-05-16 14:19 ` Guenter Roeck
2022-05-16 14:19 ` Guenter Roeck
2022-05-16 14:19 ` [Intel-gfx] " Guenter Roeck
2022-05-16 14:19 ` Guenter Roeck
2022-05-18 7:46 ` Arnd Bergmann
2022-05-18 7:46 ` Arnd Bergmann
2022-05-18 7:46 ` Arnd Bergmann
2022-05-18 14:07 ` Guenter Roeck
2022-05-18 14:07 ` Guenter Roeck
2022-05-18 14:07 ` [Intel-gfx] " Guenter Roeck
2022-05-18 14:07 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0CTmtUq+Uba2S3D7wjSstew2M+LfzZoOcKdKK9cfXO9A@mail.gmail.com \
--to=arnd@kernel.org \
--cc=alexs@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=elver@google.com \
--cc=federico.vaga@vaga.pv.it \
--cc=greybus-dev@lists.linaro.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=llvm@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=ndesaulniers@google.com \
--cc=src.res@email.cn \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.