All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: rjw@sisk.pl, Steve.Bannister@arm.com, linux-pm@vger.kernel.org,
	Sudeep KarkadaNagesha <sudeep.karkadanagesha@arm.com>,
	Liviu.Dudau@arm.com, linux-kernel@vger.kernel.org,
	cpufreq@vger.kernel.org, robin.randhawa@arm.com,
	linux-arm-kernel@lists.infradead.org,
	mark.hambleton@broadcom.com, linaro-kernel@lists.linaro.org,
	charles.garcia-tobin@arm.com
Subject: Re: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Fri, 8 Mar 2013 01:04:51 +0800	[thread overview]
Message-ID: <CAKohpomp_DFi3GAJeTUiQowyEvfXcmTeuf9+O0qcXsXtbFkTDg@mail.gmail.com> (raw)
In-Reply-To: <20130307114950.GF17833@n2100.arm.linux.org.uk>

On 7 March 2013 19:49, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> So how is this different from any other clock which may also return zero
> from its clk_get_rate() ?
>
> If that's the condition you want to check for, call clk_get_rate() after
> a successful clk_get*() and check for the condition.  Don't go treating
> the cookie somehow specially.  You're *assuming* a behaviour that is
> inappropriate for the side of the interface you're working with.

Okay. I will replace the earlier fixup with following:

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index fdf54a9..87b7e48 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -9,8 +9,7 @@ config ARM_BIG_LITTLE_CPUFREQ
 config ARM_DT_BL_CPUFREQ
        tristate "Generic ARM big LITTLE CPUfreq driver probed via DT"
        select ARM_BIG_LITTLE_CPUFREQ
-       depends on OF
-       default n
+       depends on OF && HAVE_CLK
        help
          This enables the Generic CPUfreq driver for ARM big.LITTLE platform.
          This gets frequency tables from DT.
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
index 2486b9a..a41fd89 100644
--- a/drivers/cpufreq/arm_big_little.c
+++ b/drivers/cpufreq/arm_big_little.c
@@ -147,7 +147,7 @@ static void put_cluster_clk_and_freq_table(u32 cluster)

 static int get_cluster_clk_and_freq_table(u32 cluster)
 {
-       char name[9] = "cluster";
+       char name[9] = "cpu-cluster";
        int count;

        if (atomic_inc_return(&cluster_usage[cluster]) != 1)


For more clarity i will resend this patch now will all updates.

WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue
Date: Fri, 8 Mar 2013 01:04:51 +0800	[thread overview]
Message-ID: <CAKohpomp_DFi3GAJeTUiQowyEvfXcmTeuf9+O0qcXsXtbFkTDg@mail.gmail.com> (raw)
In-Reply-To: <20130307114950.GF17833@n2100.arm.linux.org.uk>

On 7 March 2013 19:49, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote:
> So how is this different from any other clock which may also return zero
> from its clk_get_rate() ?
>
> If that's the condition you want to check for, call clk_get_rate() after
> a successful clk_get*() and check for the condition.  Don't go treating
> the cookie somehow specially.  You're *assuming* a behaviour that is
> inappropriate for the side of the interface you're working with.

Okay. I will replace the earlier fixup with following:

diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
index fdf54a9..87b7e48 100644
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -9,8 +9,7 @@ config ARM_BIG_LITTLE_CPUFREQ
 config ARM_DT_BL_CPUFREQ
        tristate "Generic ARM big LITTLE CPUfreq driver probed via DT"
        select ARM_BIG_LITTLE_CPUFREQ
-       depends on OF
-       default n
+       depends on OF && HAVE_CLK
        help
          This enables the Generic CPUfreq driver for ARM big.LITTLE platform.
          This gets frequency tables from DT.
diff --git a/drivers/cpufreq/arm_big_little.c b/drivers/cpufreq/arm_big_little.c
index 2486b9a..a41fd89 100644
--- a/drivers/cpufreq/arm_big_little.c
+++ b/drivers/cpufreq/arm_big_little.c
@@ -147,7 +147,7 @@ static void put_cluster_clk_and_freq_table(u32 cluster)

 static int get_cluster_clk_and_freq_table(u32 cluster)
 {
-       char name[9] = "cluster";
+       char name[9] = "cpu-cluster";
        int count;

        if (atomic_inc_return(&cluster_usage[cluster]) != 1)


For more clarity i will resend this patch now will all updates.

  reply	other threads:[~2013-03-07 17:04 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-05  4:52 [PATCH] cpufreq: ARM big LITTLE: Add generic cpufreq driver and its DT glue Viresh Kumar
2013-03-05  4:52 ` Viresh Kumar
2013-03-05 10:52 ` Russell King - ARM Linux
2013-03-05 10:52   ` Russell King - ARM Linux
2013-03-05 16:38   ` Viresh Kumar
2013-03-05 16:38     ` Viresh Kumar
2013-03-06 17:25     ` Russell King - ARM Linux
2013-03-06 17:25       ` Russell King - ARM Linux
2013-03-06 23:09       ` Viresh Kumar
2013-03-06 23:09         ` Viresh Kumar
2013-03-07  0:32   ` Viresh Kumar
2013-03-07  0:32     ` Viresh Kumar
2013-03-07  0:49     ` Harvey Harrison
2013-03-07  0:49       ` Harvey Harrison
2013-03-07  1:46       ` Viresh Kumar
2013-03-07  1:46         ` Viresh Kumar
2013-03-07  0:51     ` Russell King - ARM Linux
2013-03-07  0:51       ` Russell King - ARM Linux
2013-03-07  2:03       ` Viresh Kumar
2013-03-07  2:03         ` Viresh Kumar
2013-03-07 11:49         ` Russell King - ARM Linux
2013-03-07 11:49           ` Russell King - ARM Linux
2013-03-07 17:04           ` Viresh Kumar [this message]
2013-03-07 17:04             ` Viresh Kumar
2013-03-07  1:46 ` Olof Johansson
2013-03-07  1:46   ` Olof Johansson
2013-03-07  1:50   ` Olof Johansson
2013-03-07  1:50     ` Olof Johansson
2013-03-07  2:29     ` Viresh Kumar
2013-03-07  2:29       ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKohpomp_DFi3GAJeTUiQowyEvfXcmTeuf9+O0qcXsXtbFkTDg@mail.gmail.com \
    --to=viresh.kumar@linaro.org \
    --cc=Liviu.Dudau@arm.com \
    --cc=Steve.Bannister@arm.com \
    --cc=charles.garcia-tobin@arm.com \
    --cc=cpufreq@vger.kernel.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=mark.hambleton@broadcom.com \
    --cc=rjw@sisk.pl \
    --cc=robin.randhawa@arm.com \
    --cc=sudeep.karkadanagesha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.