From: Viresh Kumar <viresh.kumar@linaro.org> To: "Rafael J. Wysocki" <rjw@sisk.pl>, Arnd Bergmann <arnd@arndb.de> Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org Subject: Re: [PATCH, RFC 02/22] cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY Date: Sat, 4 May 2013 12:09:40 +0530 [thread overview] Message-ID: <CAKohponuYRm+D-FU5_7Ny1PPmwUhFLm9DkAR9iHURur+GFq_kA@mail.gmail.com> (raw) In-Reply-To: <1367507786-505303-3-git-send-email-arnd@arndb.de> [-- Attachment #1: Type: text/plain, Size: 2446 bytes --] On 2 May 2013 20:46, Arnd Bergmann <arnd@arndb.de> wrote: > The big.LITTLE cpufreq driver uses the CPU topology API, which > needs to be reflected in Kconfig to prevent broken configurations. > > warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which > has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY) > > Cc: Rafael J. Wysocki <rjw@sisk.pl> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: cpufreq@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) With all the discussions we had, please see if you can replace your patch with this one (Attached too for applying, copy/paste in gmail will break it): From: Viresh Kumar <viresh.kumar@linaro.org> Date: Sat, 4 May 2013 12:03:54 +0530 Subject: [PATCH] cpufreq: ARM big LITTLE: Fix Kconfig entries This fixes usage of "depends on" and "select" options in Kconfig for ARM big LITTLE cpufreq driver. Otherwise we get these warnings: warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY) Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/Kconfig.arm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 634e992..a924408 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -3,17 +3,17 @@ # config ARM_BIG_LITTLE_CPUFREQ - tristate - depends on ARM_CPU_TOPOLOGY - select PM_OPP + tristate "Generic ARM big LITTLE CPUfreq driver" + depends on ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK + help + This enables the Generic CPUfreq driver for ARM big.LITTLE platforms. config ARM_DT_BL_CPUFREQ - tristate "Generic ARM big LITTLE CPUfreq driver probed via DT" - select ARM_BIG_LITTLE_CPUFREQ - depends on OF && HAVE_CLK + tristate "Generic probing via DT for ARM big LITTLE CPUfreq driver" + depends on ARM_BIG_LITTLE_CPUFREQ && OF help - This enables the Generic CPUfreq driver for ARM big.LITTLE platform. - This gets frequency tables from DT. + This enables probing via DT for Generic CPUfreq driver for ARM + big.LITTLE platform. This gets frequency tables from DT. config ARM_EXYNOS_CPUFREQ bool "SAMSUNG EXYNOS SoCs" [-- Attachment #2: 0001-cpufreq-ARM-big-LITTLE-Fix-Kconfig-entries.patch --] [-- Type: application/octet-stream, Size: 1866 bytes --] From b31d40aef18da91c5f933db6d68f8b32b20033a2 Mon Sep 17 00:00:00 2001 Message-Id: <b31d40aef18da91c5f933db6d68f8b32b20033a2.1367649473.git.viresh.kumar@linaro.org> From: Viresh Kumar <viresh.kumar@linaro.org> Date: Sat, 4 May 2013 12:03:54 +0530 Subject: [PATCH] cpufreq: ARM big LITTLE: Fix Kconfig entries This fixes usage of "depends on" and "select" options in Kconfig for ARM big LITTLE cpufreq driver. Otherwise we get these warnings: warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY) Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/Kconfig.arm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 634e992..a924408 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -3,17 +3,17 @@ # config ARM_BIG_LITTLE_CPUFREQ - tristate - depends on ARM_CPU_TOPOLOGY - select PM_OPP + tristate "Generic ARM big LITTLE CPUfreq driver" + depends on ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK + help + This enables the Generic CPUfreq driver for ARM big.LITTLE platforms. config ARM_DT_BL_CPUFREQ - tristate "Generic ARM big LITTLE CPUfreq driver probed via DT" - select ARM_BIG_LITTLE_CPUFREQ - depends on OF && HAVE_CLK + tristate "Generic probing via DT for ARM big LITTLE CPUfreq driver" + depends on ARM_BIG_LITTLE_CPUFREQ && OF help - This enables the Generic CPUfreq driver for ARM big.LITTLE platform. - This gets frequency tables from DT. + This enables probing via DT for Generic CPUfreq driver for ARM + big.LITTLE platform. This gets frequency tables from DT. config ARM_EXYNOS_CPUFREQ bool "SAMSUNG EXYNOS SoCs" -- 1.7.12.rc2.18.g61b472e
WARNING: multiple messages have this Message-ID (diff)
From: viresh.kumar@linaro.org (Viresh Kumar) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH, RFC 02/22] cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY Date: Sat, 4 May 2013 12:09:40 +0530 [thread overview] Message-ID: <CAKohponuYRm+D-FU5_7Ny1PPmwUhFLm9DkAR9iHURur+GFq_kA@mail.gmail.com> (raw) In-Reply-To: <1367507786-505303-3-git-send-email-arnd@arndb.de> On 2 May 2013 20:46, Arnd Bergmann <arnd@arndb.de> wrote: > The big.LITTLE cpufreq driver uses the CPU topology API, which > needs to be reflected in Kconfig to prevent broken configurations. > > warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which > has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY) > > Cc: Rafael J. Wysocki <rjw@sisk.pl> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Cc: cpufreq at vger.kernel.org > Cc: linux-pm at vger.kernel.org > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/cpufreq/Kconfig.arm | 1 + > 1 file changed, 1 insertion(+) With all the discussions we had, please see if you can replace your patch with this one (Attached too for applying, copy/paste in gmail will break it): From: Viresh Kumar <viresh.kumar@linaro.org> Date: Sat, 4 May 2013 12:03:54 +0530 Subject: [PATCH] cpufreq: ARM big LITTLE: Fix Kconfig entries This fixes usage of "depends on" and "select" options in Kconfig for ARM big LITTLE cpufreq driver. Otherwise we get these warnings: warning: (ARM_DT_BL_CPUFREQ) selects ARM_BIG_LITTLE_CPUFREQ which has unmet direct dependencies (ARCH_HAS_CPUFREQ && CPU_FREQ && ARM && ARM_CPU_TOPOLOGY) Signed-off-by: Arnd Bergmann <arnd@arndb.de> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org> --- drivers/cpufreq/Kconfig.arm | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 634e992..a924408 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -3,17 +3,17 @@ # config ARM_BIG_LITTLE_CPUFREQ - tristate - depends on ARM_CPU_TOPOLOGY - select PM_OPP + tristate "Generic ARM big LITTLE CPUfreq driver" + depends on ARM_CPU_TOPOLOGY && PM_OPP && HAVE_CLK + help + This enables the Generic CPUfreq driver for ARM big.LITTLE platforms. config ARM_DT_BL_CPUFREQ - tristate "Generic ARM big LITTLE CPUfreq driver probed via DT" - select ARM_BIG_LITTLE_CPUFREQ - depends on OF && HAVE_CLK + tristate "Generic probing via DT for ARM big LITTLE CPUfreq driver" + depends on ARM_BIG_LITTLE_CPUFREQ && OF help - This enables the Generic CPUfreq driver for ARM big.LITTLE platform. - This gets frequency tables from DT. + This enables probing via DT for Generic CPUfreq driver for ARM + big.LITTLE platform. This gets frequency tables from DT. config ARM_EXYNOS_CPUFREQ bool "SAMSUNG EXYNOS SoCs" -------------- next part -------------- A non-text attachment was scrubbed... Name: 0001-cpufreq-ARM-big-LITTLE-Fix-Kconfig-entries.patch Type: application/octet-stream Size: 1866 bytes Desc: not available URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20130504/984b8769/attachment.obj>
next prev parent reply other threads:[~2013-05-04 6:39 UTC|newest] Thread overview: 151+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-05-02 15:16 [PATCH, RFC 00/22] ARM randconfig bugs Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 01/22] can: move CONFIG_HAVE_CAN_FLEXCAN out of CAN_DEV Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 9:53 ` Marc Kleine-Budde 2013-05-03 9:53 ` Marc Kleine-Budde 2013-05-03 15:24 ` Arnd Bergmann 2013-05-03 15:24 ` Arnd Bergmann 2013-05-07 9:18 ` Marc Kleine-Budde 2013-05-07 9:18 ` Marc Kleine-Budde 2013-05-02 15:16 ` [PATCH, RFC 02/22] cpufreq: ARM_DT_BL_CPUFREQ needs ARM_CPU_TOPOLOGY Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 4:51 ` Viresh Kumar 2013-05-03 4:51 ` Viresh Kumar 2013-05-03 12:15 ` Rafael J. Wysocki 2013-05-03 12:15 ` Rafael J. Wysocki 2013-05-03 13:01 ` Viresh Kumar 2013-05-03 13:01 ` Viresh Kumar 2013-05-03 19:27 ` Rafael J. Wysocki 2013-05-03 19:27 ` Rafael J. Wysocki 2013-05-04 6:39 ` Viresh Kumar [this message] 2013-05-04 6:39 ` Viresh Kumar 2013-05-08 0:26 ` Rafael J. Wysocki 2013-05-08 0:26 ` Rafael J. Wysocki 2013-05-02 15:16 ` [PATCH, RFC 03/22] cpuidle: calxeda: select ARM_CPU_SUSPEND Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 21:31 ` Daniel Lezcano 2013-05-02 21:31 ` Daniel Lezcano 2013-05-07 21:42 ` Rob Herring 2013-05-07 21:42 ` Rob Herring 2013-05-02 15:16 ` [PATCH, RFC 04/22] staging/drm: imx: add missing dependencies Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 2:16 ` Shawn Guo 2013-05-03 2:16 ` Shawn Guo 2013-05-03 15:21 ` Arnd Bergmann 2013-05-03 15:21 ` Arnd Bergmann 2013-05-04 12:35 ` Shawn Guo 2013-05-04 12:35 ` Shawn Guo 2013-05-02 15:16 ` [PATCH, RFC 05/22] drm: always provide debugfs function prototypes Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 06/22] gpu/drm: host1x: add dependency on Tegra Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 13:45 ` Thierry Reding 2013-05-03 13:45 ` Thierry Reding 2013-05-03 14:02 ` Arnd Bergmann 2013-05-03 14:02 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 07/22] drm/tilcd: select BACKLIGHT_LCD_SUPPORT Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 08/22] OMAPDSS: DPI needs DSI Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:42 ` Tomi Valkeinen 2013-05-02 15:42 ` Tomi Valkeinen 2013-05-02 16:26 ` Arnd Bergmann 2013-05-02 16:26 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 09/22] crypto: lz4: don't build on ARM Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 10/22] mfd: ab8500: debugfs code depends on gpadc Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:36 ` Lee Jones 2013-05-02 15:36 ` Lee Jones 2013-05-02 16:24 ` Arnd Bergmann 2013-05-02 16:24 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 11/22] iwlegacy: il_pm_ops is only provided for PM_SLEEP Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-05 20:29 ` Borislav Petkov 2013-05-05 20:29 ` Borislav Petkov 2013-05-02 15:16 ` [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:46 ` Eduardo Valentin 2013-05-02 15:46 ` Eduardo Valentin 2013-05-02 16:29 ` [PATCH v2] " Arnd Bergmann 2013-05-02 16:29 ` Arnd Bergmann 2013-05-02 16:54 ` Eduardo Valentin 2013-05-02 16:54 ` Eduardo Valentin 2013-05-08 12:12 ` Arnd Bergmann 2013-05-08 12:12 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 13/22] staging/logger: use kuid_t internally Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 14/22] oprofile: always enable IRQ_WORK Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 11:53 ` Robert Richter 2013-05-03 11:53 ` Robert Richter 2013-05-03 13:30 ` Steven Rostedt 2013-05-03 13:30 ` Steven Rostedt 2013-05-03 15:14 ` Steven Rostedt 2013-05-03 15:14 ` Steven Rostedt 2013-05-03 21:26 ` Arnd Bergmann 2013-05-03 21:26 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 15/22] USB: EHCI: remove bogus #error Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 17:34 ` Alan Stern 2013-05-02 17:34 ` Alan Stern 2013-05-02 17:55 ` Arnd Bergmann 2013-05-02 17:55 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 16/22] USB: UHCI: clarify Kconfig dependencies Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 17:30 ` Alan Stern 2013-05-02 17:30 ` Alan Stern 2013-05-02 17:52 ` Arnd Bergmann 2013-05-02 17:52 ` Arnd Bergmann 2013-05-02 18:27 ` Alan Stern 2013-05-02 18:27 ` Alan Stern 2013-05-02 19:12 ` Arnd Bergmann 2013-05-02 19:12 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 17/22] USB: OHCI: " Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 18/22] Xen: SWIOTLB is only used on x86 Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:38 ` Stefano Stabellini 2013-05-02 15:38 ` Stefano Stabellini 2013-05-02 18:13 ` Konrad Rzeszutek Wilk 2013-05-02 18:13 ` Konrad Rzeszutek Wilk 2013-05-02 18:16 ` Arnd Bergmann 2013-05-02 18:16 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 19/22] staging/solo6x10: depend on CONFIG_FONTS Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-23 20:15 ` Geert Uytterhoeven 2013-05-23 20:15 ` Geert Uytterhoeven 2013-05-23 21:47 ` Arnd Bergmann 2013-05-23 21:47 ` Arnd Bergmann 2013-05-02 15:16 ` [PATCH, RFC 20/22] media: coda: select GENERIC_ALLOCATOR Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 17:20 ` Alexander Shiyan 2013-05-02 17:20 ` Alexander Shiyan 2013-05-02 19:53 ` Arnd Bergmann 2013-05-02 19:53 ` Arnd Bergmann 2013-05-03 2:33 ` Shawn Guo 2013-05-03 2:33 ` Shawn Guo 2013-05-02 15:16 ` [PATCH, RFC 21/22] davinci: vpfe_capture needs i2c Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-03 11:00 ` Prabhakar Lad 2013-05-03 11:00 ` Prabhakar Lad 2013-05-02 15:16 ` [PATCH, RFC 22/22] radio-si4713: depend on SND_SOC Arnd Bergmann 2013-05-02 15:16 ` Arnd Bergmann 2013-05-02 15:24 ` edubezval 2013-05-02 15:24 ` edubezval at gmail.com 2013-05-02 16:25 ` Arnd Bergmann 2013-05-02 16:25 ` Arnd Bergmann 2013-05-02 17:37 ` Mauro Carvalho Chehab 2013-05-02 17:37 ` Mauro Carvalho Chehab 2013-05-02 17:57 ` Arnd Bergmann 2013-05-02 17:57 ` Arnd Bergmann 2013-05-02 18:53 ` [PATCH, RFC 00/22] ARM randconfig bugs Rafael J. Wysocki 2013-05-02 18:53 ` Rafael J. Wysocki 2013-05-02 18:53 ` Rafael J. Wysocki 2013-05-02 23:52 ` Re : [PATCH, RFC 09/22] crypto: lz4: don't build on ARM Chanho Min 2013-05-02 23:52 ` Chanho Min 2013-05-03 15:29 ` Re : " Arnd Bergmann 2013-05-03 15:29 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CAKohponuYRm+D-FU5_7Ny1PPmwUhFLm9DkAR9iHURur+GFq_kA@mail.gmail.com \ --to=viresh.kumar@linaro.org \ --cc=arnd@arndb.de \ --cc=cpufreq@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=rjw@sisk.pl \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.