From: Rob Herring <robh@kernel.org> To: Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Linux-ALSA <alsa-devel@alsa-project.org>, linux-tegra <linux-tegra@vger.kernel.org>, Jonathan Hunter <jonathanh@nvidia.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Liam Girdwood <lgirdwood@gmail.com>, Lubomir Rintel <lkundrak@v3.sk>, Masahiro Yamada <yamada.masahiro@socionext.com>, Sameer Pujar <spujar@nvidia.com>, Thierry Reding <thierry.reding@gmail.com> Subject: Re: [PATCH 1/3] ASoC: dt-bindings: Move port/ports properties out of audio-graph-port.yaml Date: Tue, 23 Mar 2021 13:15:08 -0600 [thread overview] Message-ID: <CAL_JsqLFj3tUUeEeKoZx=P3AHE4Tu1TzuA-tqK4+qD=4J6c=8Q@mail.gmail.com> (raw) In-Reply-To: <20210323163634.877511-2-robh@kernel.org> On Tue, Mar 23, 2021 at 10:36 AM Rob Herring <robh@kernel.org> wrote: > > Users of the audio-graph-port schema need to define how many ports > and what each port is, so they need to define 'ports' and/or 'port' > anyways. Let's drop 'ports' and 'port' from the schema and adjust users > to reference audio-graph-port.yaml from a port property. > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Cc: Lubomir Rintel <lkundrak@v3.sk> > Cc: Sameer Pujar <spujar@nvidia.com> > Cc: alsa-devel@alsa-project.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > index 31f3e51974bb..e568d6c7dddd 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > @@ -17,9 +17,6 @@ maintainers: > - Jon Hunter <jonathanh@nvidia.com> > - Sameer Pujar <spujar@nvidia.com> > > -allOf: > - - $ref: audio-graph-port.yaml# > - > properties: > $nodename: > pattern: "^ahub@[0-9a-f]*$" > @@ -60,12 +57,18 @@ properties: > ranges: true > > ports: > + $ref: /schemas/graph.yaml#/properties/ports > description: | > Contains list of ACIF (Audio CIF) port nodes for AHUB (Audio Hub). > These are connected to ACIF interfaces of AHUB clients. Thus the > number of port nodes depend on the number of clients that AHUB may > have depending on the SoC revision. > > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > required: > - compatible > - reg > @@ -77,7 +80,7 @@ required: > - "#size-cells" > - ranges > > -unevaluatedProperties: false > +additionalProperties: false Adding this results in schema errors in the example, so a prerequisite patch is needed. Rob
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org> To: Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, Linux-ALSA <alsa-devel@alsa-project.org>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, Liam Girdwood <lgirdwood@gmail.com>, Masahiro Yamada <yamada.masahiro@socionext.com>, Sameer Pujar <spujar@nvidia.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jonathan Hunter <jonathanh@nvidia.com>, Lubomir Rintel <lkundrak@v3.sk>, Thierry Reding <thierry.reding@gmail.com>, linux-tegra <linux-tegra@vger.kernel.org> Subject: Re: [PATCH 1/3] ASoC: dt-bindings: Move port/ports properties out of audio-graph-port.yaml Date: Tue, 23 Mar 2021 13:15:08 -0600 [thread overview] Message-ID: <CAL_JsqLFj3tUUeEeKoZx=P3AHE4Tu1TzuA-tqK4+qD=4J6c=8Q@mail.gmail.com> (raw) In-Reply-To: <20210323163634.877511-2-robh@kernel.org> On Tue, Mar 23, 2021 at 10:36 AM Rob Herring <robh@kernel.org> wrote: > > Users of the audio-graph-port schema need to define how many ports > and what each port is, so they need to define 'ports' and/or 'port' > anyways. Let's drop 'ports' and 'port' from the schema and adjust users > to reference audio-graph-port.yaml from a port property. > > Cc: Liam Girdwood <lgirdwood@gmail.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: Jonathan Hunter <jonathanh@nvidia.com> > Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> > Cc: Lubomir Rintel <lkundrak@v3.sk> > Cc: Sameer Pujar <spujar@nvidia.com> > Cc: alsa-devel@alsa-project.org > Cc: linux-tegra@vger.kernel.org > Signed-off-by: Rob Herring <robh@kernel.org> > --- > diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > index 31f3e51974bb..e568d6c7dddd 100644 > --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-ahub.yaml > @@ -17,9 +17,6 @@ maintainers: > - Jon Hunter <jonathanh@nvidia.com> > - Sameer Pujar <spujar@nvidia.com> > > -allOf: > - - $ref: audio-graph-port.yaml# > - > properties: > $nodename: > pattern: "^ahub@[0-9a-f]*$" > @@ -60,12 +57,18 @@ properties: > ranges: true > > ports: > + $ref: /schemas/graph.yaml#/properties/ports > description: | > Contains list of ACIF (Audio CIF) port nodes for AHUB (Audio Hub). > These are connected to ACIF interfaces of AHUB clients. Thus the > number of port nodes depend on the number of clients that AHUB may > have depending on the SoC revision. > > + patternProperties: > + '^port@[0-9]': > + $ref: audio-graph-port.yaml# > + unevaluatedProperties: false > + > required: > - compatible > - reg > @@ -77,7 +80,7 @@ required: > - "#size-cells" > - ranges > > -unevaluatedProperties: false > +additionalProperties: false Adding this results in schema errors in the example, so a prerequisite patch is needed. Rob
next prev parent reply other threads:[~2021-03-23 19:16 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-03-23 16:36 [PATCH 0/3] ASoC: dt-bindings: Rework audio-graph-port schema Rob Herring 2021-03-23 16:36 ` Rob Herring 2021-03-23 16:36 ` [PATCH 1/3] ASoC: dt-bindings: Move port/ports properties out of audio-graph-port.yaml Rob Herring 2021-03-23 16:36 ` Rob Herring 2021-03-23 19:15 ` Rob Herring [this message] 2021-03-23 19:15 ` Rob Herring 2021-03-31 12:41 ` Mark Brown 2021-03-31 12:41 ` Mark Brown 2021-03-23 16:36 ` [PATCH 2/3] ASoC: dt-bindings: Use OF graph schema Rob Herring 2021-03-23 16:36 ` Rob Herring 2021-03-23 16:36 ` [PATCH 3/3] ASoC: dt-bindings: socionext: Use audio-graph-port schema Rob Herring 2021-03-23 16:36 ` Rob Herring 2021-04-01 10:16 ` [PATCH 0/3] ASoC: dt-bindings: Rework " Mark Brown 2021-04-01 10:16 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAL_JsqLFj3tUUeEeKoZx=P3AHE4Tu1TzuA-tqK4+qD=4J6c=8Q@mail.gmail.com' \ --to=robh@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jonathanh@nvidia.com \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-tegra@vger.kernel.org \ --cc=lkundrak@v3.sk \ --cc=spujar@nvidia.com \ --cc=thierry.reding@gmail.com \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.