From: Nathan Chancellor <nathan@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
Yafang Shao <laoar.shao@gmail.com>,
llvm@lists.linux.dev, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [tip:sched/core 14/47] kernel/sched/fair.c:893:22: error: variable 'p' set but not used
Date: Wed, 13 Oct 2021 21:23:56 -0700 [thread overview]
Message-ID: <YWew3ItdPC5QrL/w@archlinux-ax161> (raw)
In-Reply-To: <YWWPLnaZGybHsTkv@hirez.programming.kicks-ass.net>
On Tue, Oct 12, 2021 at 03:35:42PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 12, 2021 at 01:26:54PM +0200, Peter Zijlstra wrote:
>
> > Again, I have absolutely no intention of fixing this. IMO this is the
> > compiler being a total pain in the arse.
> >
> > Please stop reporting this.
>
> How's this then?
>
> diff --git a/kernel/sched/Makefile b/kernel/sched/Makefile
> index 978fcfca5871..b0d9121c5dce 100644
> --- a/kernel/sched/Makefile
> +++ b/kernel/sched/Makefile
> @@ -3,6 +3,10 @@ ifdef CONFIG_FUNCTION_TRACER
> CFLAGS_REMOVE_clock.o = $(CC_FLAGS_FTRACE)
> endif
>
> +# The compilers are complaining about unused variables inside an if(0) scope
> +# block. This is daft, shut them up.
> +ccflags-y += -Wno-unused-but-set-variable
Please consider making this
ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
because -Wunused-but-set-variable was only added to clang in the 13
release but we support back to 10, meaning this will cause errors for
those older compilers.
With that:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Additionally, perhaps this could be restricted to just fair.c?
> +
> # These files are disabled because they produce non-interesting flaky coverage
> # that is not a function of syscall inputs. E.g. involuntary context switches.
> KCOV_INSTRUMENT := n
>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: kbuild-all@lists.01.org
Subject: Re: [tip:sched/core 14/47] kernel/sched/fair.c:893:22: error: variable 'p' set but not used
Date: Wed, 13 Oct 2021 21:23:56 -0700 [thread overview]
Message-ID: <YWew3ItdPC5QrL/w@archlinux-ax161> (raw)
In-Reply-To: <YWWPLnaZGybHsTkv@hirez.programming.kicks-ass.net>
[-- Attachment #1: Type: text/plain, Size: 1369 bytes --]
On Tue, Oct 12, 2021 at 03:35:42PM +0200, Peter Zijlstra wrote:
> On Tue, Oct 12, 2021 at 01:26:54PM +0200, Peter Zijlstra wrote:
>
> > Again, I have absolutely no intention of fixing this. IMO this is the
> > compiler being a total pain in the arse.
> >
> > Please stop reporting this.
>
> How's this then?
>
> diff --git a/kernel/sched/Makefile b/kernel/sched/Makefile
> index 978fcfca5871..b0d9121c5dce 100644
> --- a/kernel/sched/Makefile
> +++ b/kernel/sched/Makefile
> @@ -3,6 +3,10 @@ ifdef CONFIG_FUNCTION_TRACER
> CFLAGS_REMOVE_clock.o = $(CC_FLAGS_FTRACE)
> endif
>
> +# The compilers are complaining about unused variables inside an if(0) scope
> +# block. This is daft, shut them up.
> +ccflags-y += -Wno-unused-but-set-variable
Please consider making this
ccflags-y += $(call cc-disable-warning, unused-but-set-variable)
because -Wunused-but-set-variable was only added to clang in the 13
release but we support back to 10, meaning this will cause errors for
those older compilers.
With that:
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
Additionally, perhaps this could be restricted to just fair.c?
> +
> # These files are disabled because they produce non-interesting flaky coverage
> # that is not a function of syscall inputs. E.g. involuntary context switches.
> KCOV_INSTRUMENT := n
>
next prev parent reply other threads:[~2021-10-14 4:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-12 3:57 [tip:sched/core 14/47] kernel/sched/fair.c:893:22: error: variable 'p' set but not used kernel test robot
2021-10-12 3:57 ` kernel test robot
2021-10-12 11:26 ` Peter Zijlstra
2021-10-12 11:26 ` Peter Zijlstra
2021-10-12 13:35 ` Peter Zijlstra
2021-10-12 13:35 ` Peter Zijlstra
2021-10-13 6:18 ` Yafang Shao
2021-10-13 6:18 ` Yafang Shao
2021-10-14 4:23 ` Nathan Chancellor [this message]
2021-10-14 4:23 ` Nathan Chancellor
2021-10-14 15:08 ` Peter Zijlstra
2021-10-14 15:08 ` Peter Zijlstra
2021-10-15 9:45 ` [tip: sched/core] sched: Disable -Wunused-but-set-variable tip-bot2 for Peter Zijlstra
2021-10-12 14:31 ` [kbuild-all] Re: [tip:sched/core 14/47] kernel/sched/fair.c:893:22: error: variable 'p' set but not used Chen, Rong A
2021-10-12 14:31 ` Chen, Rong A
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YWew3ItdPC5QrL/w@archlinux-ax161 \
--to=nathan@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=laoar.shao@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.