From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Baruch Siach <baruch@tkos.co.il> Cc: Thierry Reding <thierry.reding@gmail.com>, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>, Andy Gross <agross@kernel.org>, Baruch Siach <baruch.siach@siklu.com>, Balaji Prakash J <bjagadee@codeaurora.org>, Rob Herring <robh+dt@kernel.org>, Robert Marko <robert.marko@sartura.hr>, Kathiravan T <kathirav@codeaurora.org>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] dt-bindings: pwm: add IPQ6018 binding Date: Thu, 24 Feb 2022 13:48:51 -0600 [thread overview] Message-ID: <YhfhIyRKwl1bJObC@builder.lan> (raw) In-Reply-To: <dee024e7add1b2c919b23472c90391239a0a2572.1644226245.git.baruch@tkos.co.il> On Mon 07 Feb 03:30 CST 2022, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > This series does not convert the TCSR binding documentation to YAML. As > a result, this commit adds a new dt_binding_check warning: > > /example-0/syscon@1937000: failed to match any schema with compatible: ['qcom,tcsr-ipq 6018', 'syscon', 'simple-mfd'] > > If that is a blocker to IPQ6018 PWM support, so be it. Patches will wait > for someone else to push them further. > > v10: > > No change > > v9: > > Add 'ranges' property to example (Rob) > > Drop label in example (Rob) > > v8: > > Add size cell to 'reg' (Rob) > > v7: > > Use 'reg' instead of 'offset' (Rob) > > Drop 'clock-names' and 'assigned-clock*' (Bjorn) > > Use single cell address/size in example node (Bjorn) > > Move '#pwm-cells' lower in example node (Bjorn) > > List 'reg' as required > > v6: > > Device node is child of TCSR; remove phandle (Rob Herring) > > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König) > > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn > Andersson, Kathiravan T) > > v4: Update the binding example node as well (Rob Herring's bot) > > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) > > v2: Make #pwm-cells const (Rob Herring) > --- > .../devicetree/bindings/pwm/ipq-pwm.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > new file mode 100644 > index 000000000000..857086ad539e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ6018 PWM controller > + > +maintainers: > + - Baruch Siach <baruch@tkos.co.il> > + > +properties: > + "#pwm-cells": > + const: 2 > + > + compatible: > + const: qcom,ipq6018-pwm > + > + reg: > + description: Offset of PWM register in the TCSR block. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - "#pwm-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-ipq6018.h> > + > + syscon@1937000 { > + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd"; > + reg = <0x01937000 0x21000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x1937000 0x21000>; > + > + pwm: pwm@a010 { > + compatible = "qcom,ipq6018-pwm"; > + reg = <0xa010 0x20>; > + clocks = <&gcc GCC_ADSS_PWM_CLK>; > + assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>; > + assigned-clock-rates = <100000000>; > + #pwm-cells = <2>; > + }; > + }; > -- > 2.34.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org> To: Baruch Siach <baruch@tkos.co.il> Cc: Thierry Reding <thierry.reding@gmail.com>, Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>, Andy Gross <agross@kernel.org>, Baruch Siach <baruch.siach@siklu.com>, Balaji Prakash J <bjagadee@codeaurora.org>, Rob Herring <robh+dt@kernel.org>, Robert Marko <robert.marko@sartura.hr>, Kathiravan T <kathirav@codeaurora.org>, linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/3] dt-bindings: pwm: add IPQ6018 binding Date: Thu, 24 Feb 2022 13:48:51 -0600 [thread overview] Message-ID: <YhfhIyRKwl1bJObC@builder.lan> (raw) In-Reply-To: <dee024e7add1b2c919b23472c90391239a0a2572.1644226245.git.baruch@tkos.co.il> On Mon 07 Feb 03:30 CST 2022, Baruch Siach wrote: > From: Baruch Siach <baruch.siach@siklu.com> > > DT binding for the PWM block in Qualcomm IPQ6018 SoC. > > Signed-off-by: Baruch Siach <baruch.siach@siklu.com> Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > This series does not convert the TCSR binding documentation to YAML. As > a result, this commit adds a new dt_binding_check warning: > > /example-0/syscon@1937000: failed to match any schema with compatible: ['qcom,tcsr-ipq 6018', 'syscon', 'simple-mfd'] > > If that is a blocker to IPQ6018 PWM support, so be it. Patches will wait > for someone else to push them further. > > v10: > > No change > > v9: > > Add 'ranges' property to example (Rob) > > Drop label in example (Rob) > > v8: > > Add size cell to 'reg' (Rob) > > v7: > > Use 'reg' instead of 'offset' (Rob) > > Drop 'clock-names' and 'assigned-clock*' (Bjorn) > > Use single cell address/size in example node (Bjorn) > > Move '#pwm-cells' lower in example node (Bjorn) > > List 'reg' as required > > v6: > > Device node is child of TCSR; remove phandle (Rob Herring) > > Add assigned-clocks/assigned-clock-rates (Uwe Kleine-König) > > v5: Use qcom,pwm-regs for phandle instead of direct regs (Bjorn > Andersson, Kathiravan T) > > v4: Update the binding example node as well (Rob Herring's bot) > > v3: s/qcom,pwm-ipq6018/qcom,ipq6018-pwm/ (Rob Herring) > > v2: Make #pwm-cells const (Rob Herring) > --- > .../devicetree/bindings/pwm/ipq-pwm.yaml | 53 +++++++++++++++++++ > 1 file changed, 53 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > > diff --git a/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > new file mode 100644 > index 000000000000..857086ad539e > --- /dev/null > +++ b/Documentation/devicetree/bindings/pwm/ipq-pwm.yaml > @@ -0,0 +1,53 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pwm/ipq-pwm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm IPQ6018 PWM controller > + > +maintainers: > + - Baruch Siach <baruch@tkos.co.il> > + > +properties: > + "#pwm-cells": > + const: 2 > + > + compatible: > + const: qcom,ipq6018-pwm > + > + reg: > + description: Offset of PWM register in the TCSR block. > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - "#pwm-cells" > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/qcom,gcc-ipq6018.h> > + > + syscon@1937000 { > + compatible = "qcom,tcsr-ipq6018", "syscon", "simple-mfd"; > + reg = <0x01937000 0x21000>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0 0x1937000 0x21000>; > + > + pwm: pwm@a010 { > + compatible = "qcom,ipq6018-pwm"; > + reg = <0xa010 0x20>; > + clocks = <&gcc GCC_ADSS_PWM_CLK>; > + assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>; > + assigned-clock-rates = <100000000>; > + #pwm-cells = <2>; > + }; > + }; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-02-24 19:48 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-07 9:30 [PATCH 1/3] pwm: driver for qualcomm ipq6018 pwm block Baruch Siach 2022-02-07 9:30 ` Baruch Siach 2022-02-07 9:30 ` [PATCH 2/3] dt-bindings: pwm: add IPQ6018 binding Baruch Siach 2022-02-07 9:30 ` Baruch Siach 2022-02-24 19:48 ` Bjorn Andersson [this message] 2022-02-24 19:48 ` Bjorn Andersson 2022-02-07 9:30 ` [PATCH 3/3] arm64: dts: ipq6018: add pwm node Baruch Siach 2022-02-07 9:30 ` Baruch Siach 2022-02-07 20:22 ` [PATCH 1/3] pwm: driver for qualcomm ipq6018 pwm block kernel test robot 2022-02-07 20:22 ` kernel test robot 2022-02-08 6:51 ` Baruch Siach 2022-02-08 6:51 ` Baruch Siach 2022-02-08 18:47 ` Nathan Chancellor 2022-02-08 18:47 ` Nathan Chancellor 2023-09-15 6:25 ` Devi Priya 2023-09-15 6:25 ` Devi Priya 2023-09-15 6:36 ` Baruch Siach 2023-09-15 6:36 ` Baruch Siach 2023-09-20 4:58 ` Devi Priya 2023-09-20 4:58 ` Devi Priya 2023-09-22 6:00 ` Devi Priya 2023-09-22 6:00 ` Devi Priya 2023-09-22 8:35 ` Baruch Siach 2023-09-22 8:35 ` Baruch Siach 2023-09-22 10:56 ` Devi Priya 2023-09-22 10:56 ` Devi Priya -- strict thread matches above, loose matches on Subject: below -- 2021-05-19 7:48 Baruch Siach 2021-05-19 7:48 ` [PATCH 2/3] dt-bindings: pwm: add IPQ6018 binding Baruch Siach 2021-05-19 7:48 ` Baruch Siach 2021-05-21 1:34 ` Rob Herring 2021-05-21 1:34 ` Rob Herring
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YhfhIyRKwl1bJObC@builder.lan \ --to=bjorn.andersson@linaro.org \ --cc=agross@kernel.org \ --cc=baruch.siach@siklu.com \ --cc=baruch@tkos.co.il \ --cc=bjagadee@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=kathirav@codeaurora.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-pwm@vger.kernel.org \ --cc=robert.marko@sartura.hr \ --cc=robh+dt@kernel.org \ --cc=thierry.reding@gmail.com \ --cc=u.kleine-koenig@pengutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.