All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nathan Chancellor <nathan@kernel.org>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled
Date: Tue, 8 Mar 2022 13:39:16 -0700	[thread overview]
Message-ID: <Yie+9J0hyA6k2KvD@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220308191820.18270-1-linkmauve@linkmauve.fr>

On Tue, Mar 08, 2022 at 08:18:20PM +0100, Emmanuel Gil Peyrot wrote:
> It was missing a semicolon.
> 
> Fixes build error introduced in
> 25875aa71dfefd1959f07e626c4d285b88b27ac2.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>

Our CI just went red from this as well:

https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090927
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953124502
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090534
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953086304
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953050829

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Linus, would it be possible for you apply this directly?

> ---
>  arch/arm/kernel/spectre.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/spectre.c b/arch/arm/kernel/spectre.c
> index e7fea962d632..0dcefc36fb7a 100644
> --- a/arch/arm/kernel/spectre.c
> +++ b/arch/arm/kernel/spectre.c
> @@ -10,7 +10,7 @@ static bool _unprivileged_ebpf_enabled(void)
>  #ifdef CONFIG_BPF_SYSCALL
>  	return !sysctl_unprivileged_bpf_disabled;
>  #else
> -	return false
> +	return false;
>  #endif
>  }
>  
> -- 
> 2.35.1
> 
> 

WARNING: multiple messages have this Message-ID (diff)
From: Nathan Chancellor <nathan@kernel.org>
To: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Russell King <rmk+kernel@armlinux.org.uk>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled
Date: Tue, 8 Mar 2022 13:39:16 -0700	[thread overview]
Message-ID: <Yie+9J0hyA6k2KvD@dev-arch.thelio-3990X> (raw)
In-Reply-To: <20220308191820.18270-1-linkmauve@linkmauve.fr>

On Tue, Mar 08, 2022 at 08:18:20PM +0100, Emmanuel Gil Peyrot wrote:
> It was missing a semicolon.
> 
> Fixes build error introduced in
> 25875aa71dfefd1959f07e626c4d285b88b27ac2.
> 
> Signed-off-by: Emmanuel Gil Peyrot <linkmauve@linkmauve.fr>

Our CI just went red from this as well:

https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090927
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953124502
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953090534
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953086304
https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/1953050829

Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Linus, would it be possible for you apply this directly?

> ---
>  arch/arm/kernel/spectre.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/kernel/spectre.c b/arch/arm/kernel/spectre.c
> index e7fea962d632..0dcefc36fb7a 100644
> --- a/arch/arm/kernel/spectre.c
> +++ b/arch/arm/kernel/spectre.c
> @@ -10,7 +10,7 @@ static bool _unprivileged_ebpf_enabled(void)
>  #ifdef CONFIG_BPF_SYSCALL
>  	return !sysctl_unprivileged_bpf_disabled;
>  #else
> -	return false
> +	return false;
>  #endif
>  }
>  
> -- 
> 2.35.1
> 
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-03-08 20:39 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-08 19:18 [PATCH] ARM: fix compilation error when BPF_SYSCALL is disabled Emmanuel Gil Peyrot
2022-03-08 19:18 ` Emmanuel Gil Peyrot
2022-03-08 20:39 ` Nathan Chancellor [this message]
2022-03-08 20:39   ` Nathan Chancellor
2022-03-08 20:53   ` Linus Torvalds
2022-03-08 20:53     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yie+9J0hyA6k2KvD@dev-arch.thelio-3990X \
    --to=nathan@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=linkmauve@linkmauve.fr \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.