All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sean Anderson <sean.anderson@seco.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Robert Hancock <robert.hancock@calian.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock
Date: Wed, 19 Jan 2022 13:23:44 -0500	[thread overview]
Message-ID: <a1932eba-564c-fe32-f220-53aa75250105@seco.com> (raw)
In-Reply-To: <87ee53fv01.fsf@tarshish>

Hi Baruch,

On 1/19/22 1:14 PM, Baruch Siach wrote:
> Hi Sean,
>
> On Tue, Jan 18 2022, Sean Anderson wrote:
>> This is a rework of patches 3-5 of [1]. It attempts to correctly program
>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since
>> we no longer need a special property duplicating this configuration,
>> snps,ref-clock-period-ns is deprecated.
>>
>> Please test this! Patches 3/4 in this series have the effect of
>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure
>> the "ref" clock. I have build tested, but not much else.
>
> Tested here on IPQ6010 based system. USB still works. But the with "ref"
> clock at 24MHz, period is calculated as 0x29. Previous
> snps,ref-clock-period-ns value used to be 0x32.
>
> Is that expected?

Yes. From the documentation for GFLADJ_REFCLK_240MHZ_DECR:

> Examples:
> If the ref_clk is 24 MHz then
> - GUCTL.REF_CLK_PERIOD = 41
> - GFLADJ.GFLADJ_REFCLK_240MHZ_DECR = 240/24 = 10

And 41 == 0x29.

--Sean

WARNING: multiple messages have this Message-ID (diff)
From: Sean Anderson <sean.anderson@seco.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, Felipe Balbi <balbi@kernel.org>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	Balaji Prakash J <bjagadee@codeaurora.org>,
	linux-kernel@vger.kernel.org,
	Robert Hancock <robert.hancock@calian.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock
Date: Wed, 19 Jan 2022 13:23:44 -0500	[thread overview]
Message-ID: <a1932eba-564c-fe32-f220-53aa75250105@seco.com> (raw)
In-Reply-To: <87ee53fv01.fsf@tarshish>

Hi Baruch,

On 1/19/22 1:14 PM, Baruch Siach wrote:
> Hi Sean,
>
> On Tue, Jan 18 2022, Sean Anderson wrote:
>> This is a rework of patches 3-5 of [1]. It attempts to correctly program
>> REFCLKPER and REFCLK_FLADJ based on the reference clock frequency. Since
>> we no longer need a special property duplicating this configuration,
>> snps,ref-clock-period-ns is deprecated.
>>
>> Please test this! Patches 3/4 in this series have the effect of
>> programming REFCLKPER and REFCLK_FLADJ on boards which already configure
>> the "ref" clock. I have build tested, but not much else.
>
> Tested here on IPQ6010 based system. USB still works. But the with "ref"
> clock at 24MHz, period is calculated as 0x29. Previous
> snps,ref-clock-period-ns value used to be 0x32.
>
> Is that expected?

Yes. From the documentation for GFLADJ_REFCLK_240MHZ_DECR:

> Examples:
> If the ref_clk is 24 MHz then
> - GUCTL.REF_CLK_PERIOD = 41
> - GFLADJ.GFLADJ_REFCLK_240MHZ_DECR = 240/24 = 10

And 41 == 0x29.

--Sean

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-19 18:24 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-19  0:24 [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Sean Anderson
2022-01-19  0:24 ` Sean Anderson
2022-01-19  0:24 ` [PATCH v2 1/7] dt-bindings: usb: dwc3: Deprecate snps,ref-clock-period-ns Sean Anderson
2022-01-19  0:24 ` [PATCH v2 2/7] usb: dwc3: Get clocks individually Sean Anderson
2022-01-20 16:52   ` Robert Hancock
2022-01-19  0:24 ` [PATCH v2 3/7] usb: dwc3: Calculate REFCLKPER based on reference clock Sean Anderson
2022-01-20 16:53   ` Robert Hancock
2022-01-19  0:24 ` [PATCH v2 4/7] usb: dwc3: Program GFLADJ Sean Anderson
2022-01-20 16:55   ` Robert Hancock
2022-01-24 22:46   ` Thinh Nguyen
2022-01-24 23:06     ` Sean Anderson
2022-01-25  2:11       ` Thinh Nguyen
2022-01-25  6:17         ` Felipe Balbi
2022-01-25 20:02           ` Thinh Nguyen
2022-01-25 16:22         ` Sean Anderson
2022-01-25 19:36           ` Thinh Nguyen
2022-01-26 10:56             ` Felipe Balbi
2022-01-26 10:53           ` Felipe Balbi
2022-01-27 16:45             ` Sean Anderson
2022-01-19  0:24 ` [PATCH v2 5/7] usb: dwc3: Add snps,ref-clock-frequency-hz property for ACPI Sean Anderson
2022-01-24 22:44   ` Thinh Nguyen
2022-01-24 23:07     ` Sean Anderson
2022-01-24 23:14       ` Sean Anderson
2022-01-25  2:21         ` Thinh Nguyen
2022-01-19  0:24 ` [PATCH v2 6/7] arm64: dts: zynqmp: Move USB clocks to dwc3 node Sean Anderson
2022-01-19  0:24   ` Sean Anderson
2022-01-20 16:56   ` Robert Hancock
2022-01-20 16:56     ` Robert Hancock
2022-01-19  0:24 ` [PATCH v2 7/7] arm64: dts: ipq6018: Use reference clock to set dwc3 period Sean Anderson
2022-01-19 18:14 ` [PATCH v2 0/7] usb: dwc3: Calculate REFCLKPER et. al. from reference clock Baruch Siach
2022-01-19 18:14   ` Baruch Siach
2022-01-19 18:23   ` Sean Anderson [this message]
2022-01-19 18:23     ` Sean Anderson
2022-01-20  5:23   ` Kathiravan T
2022-01-20 10:29     ` Baruch Siach
2022-01-20 10:29       ` Baruch Siach
2022-01-24 15:11       ` Kathiravan Thirumoorthy
2022-01-24 15:11         ` Kathiravan Thirumoorthy
2022-01-24 23:01         ` Thinh Nguyen
2022-01-24 23:01           ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a1932eba-564c-fe32-f220-53aa75250105@seco.com \
    --to=sean.anderson@seco.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=agross@kernel.org \
    --cc=balbi@kernel.org \
    --cc=baruch@tkos.co.il \
    --cc=bjagadee@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=robert.hancock@calian.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.