From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Jones <drjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<linux-arm-kernel@lists.infradead.org>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<xen-devel@lists.xensource.com>,
David Vrabel <david.vrabel@citrix.com>,
<boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Mon, 15 Feb 2016 16:51:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602151643150.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <1455278707-2008263-1-git-send-email-arnd@arndb.de>
CC'ing a few others.
On Fri, 12 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be
> built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result
> in the broken select.
>
> As usual, we would be much better off without the 'select', but removing
> it now would likely break existing user configurations that depend on
> it, so this adds another hack on top to get it working.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..fd3d6fd290a9 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> config XEN_FBDEV_FRONTEND
> tristate "Xen virtual frame buffer support"
> depends on FB && XEN
> + depends on INPUT || !INPUT_MISC
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
> select FB_SYS_IMAGEBLIT
This looks very hackish. Couldn't we just do the following?
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5..3c15f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
- select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
+ select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
select XEN_XENBUS_FRONTEND
default y
help
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Mon, 15 Feb 2016 16:51:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602151643150.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <1455278707-2008263-1-git-send-email-arnd@arndb.de>
CC'ing a few others.
On Fri, 12 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be
> built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result
> in the broken select.
>
> As usual, we would be much better off without the 'select', but removing
> it now would likely break existing user configurations that depend on
> it, so this adds another hack on top to get it working.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..fd3d6fd290a9 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> config XEN_FBDEV_FRONTEND
> tristate "Xen virtual frame buffer support"
> depends on FB && XEN
> + depends on INPUT || !INPUT_MISC
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
> select FB_SYS_IMAGEBLIT
This looks very hackish. Couldn't we just do the following?
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5..3c15f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
- select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
+ select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
select XEN_XENBUS_FRONTEND
default y
help
WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Mon, 15 Feb 2016 16:51:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602151643150.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <1455278707-2008263-1-git-send-email-arnd@arndb.de>
CC'ing a few others.
On Fri, 12 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be
> built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result
> in the broken select.
>
> As usual, we would be much better off without the 'select', but removing
> it now would likely break existing user configurations that depend on
> it, so this adds another hack on top to get it working.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..fd3d6fd290a9 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> config XEN_FBDEV_FRONTEND
> tristate "Xen virtual frame buffer support"
> depends on FB && XEN
> + depends on INPUT || !INPUT_MISC
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
> select FB_SYS_IMAGEBLIT
This looks very hackish. Couldn't we just do the following?
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5..3c15f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
- select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
+ select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
select XEN_XENBUS_FRONTEND
default y
help
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Jones <drjones@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-arm-kernel@lists.infradead.org,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
xen-devel@lists.xensource.com,
David Vrabel <david.vrabel@citrix.com>,
boris.ostrovsky@oracle.com
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Mon, 15 Feb 2016 16:51:08 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602151643150.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <1455278707-2008263-1-git-send-email-arnd@arndb.de>
CC'ing a few others.
On Fri, 12 Feb 2016, Arnd Bergmann wrote:
> The Xen framebuffer driver selects the xen keyboard driver, so the latter
> will be built-in if XEN_FBDEV_FRONTEND=y. However, when CONFIG_INPUT
> is a loadable module, this configuration cannot work. On mainline kernels,
> the symbol will be enabled but not used, while in combination with
> a patch I have to detect such useless configurations, we get the
> expected link failure:
>
> drivers/input/built-in.o: In function `xenkbd_remove':
> xen-kbdfront.c:(.text+0x2f0): undefined reference to `input_unregister_device'
> xen-kbdfront.c:(.text+0x30e): undefined reference to `input_unregister_device'
>
> This changes the dependencies of XEN_FBDEV_FRONTEND so it cannot be
> built-in if CONFIG_INPUT=m && CONFIG_INPUT_MISC=y, as that would result
> in the broken select.
>
> As usual, we would be much better off without the 'select', but removing
> it now would likely break existing user configurations that depend on
> it, so this adds another hack on top to get it working.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 36c1132e34bd ("xen kconfig: fix select INPUT_XEN_KBDDEV_FRONTEND")
> ---
> drivers/video/fbdev/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> index 8ea45a5cd806..fd3d6fd290a9 100644
> --- a/drivers/video/fbdev/Kconfig
> +++ b/drivers/video/fbdev/Kconfig
> @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> config XEN_FBDEV_FRONTEND
> tristate "Xen virtual frame buffer support"
> depends on FB && XEN
> + depends on INPUT || !INPUT_MISC
> select FB_SYS_FILLRECT
> select FB_SYS_COPYAREA
> select FB_SYS_IMAGEBLIT
This looks very hackish. Couldn't we just do the following?
diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
index 8ea45a5..3c15f6d 100644
--- a/drivers/video/fbdev/Kconfig
+++ b/drivers/video/fbdev/Kconfig
@@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
select FB_SYS_IMAGEBLIT
select FB_SYS_FOPS
select FB_DEFERRED_IO
- select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
+ select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
select XEN_XENBUS_FRONTEND
default y
help
next prev parent reply other threads:[~2016-02-15 16:51 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 12:04 [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-15 16:51 ` Stefano Stabellini [this message]
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-16 15:03 ` [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND" Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-02-16 11:35 ` [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602151643150.27008@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=drjones@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.