From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Jones <drjones@redhat.com>,
<xen-devel@lists.xensource.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
<linux-fbdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
"David Vrabel" <david.vrabel@citrix.com>,
<boris.ostrovsky@oracle.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Tue, 16 Feb 2016 12:14:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161156160.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2801550.oZPkqjv8nW@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote:
> > >
> > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > > index 8ea45a5cd806..fd3d6fd290a9 100644
> > > --- a/drivers/video/fbdev/Kconfig
> > > +++ b/drivers/video/fbdev/Kconfig
> > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> > > config XEN_FBDEV_FRONTEND
> > > tristate "Xen virtual frame buffer support"
> > > depends on FB && XEN
> > > + depends on INPUT || !INPUT_MISC
> > > select FB_SYS_FILLRECT
> > > select FB_SYS_COPYAREA
> > > select FB_SYS_IMAGEBLIT
> >
> > This looks very hackish. Couldn't we just do the following?
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5..3c15f6d 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
> > select FB_SYS_IMAGEBLIT
> > select FB_SYS_FOPS
> > select FB_DEFERRED_IO
> > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
> > select XEN_XENBUS_FRONTEND
> > default y
> > help
> >
>
> No, that doesn't solve the problem:
>
> If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still
> get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m.
>
> INPUT_MISC already depends on INPUT, so your change has no effect
> at all.
Please correct me if I am wrong, but the difference is that with this
change if INPUT=m, then the build system would ask the user whether she
wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of
unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y.
However it is true that if the users chooses
INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists.
Maybe we also need:
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 1f2337a..303df24 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C
config INPUT_XEN_KBDDEV_FRONTEND
tristate "Xen virtual keyboard and mouse support"
- depends on XEN
+ depends on XEN && INPUT
default y
select XEN_XENBUS_FRONTEND
help
Do you have a kernel config with INPUT=m that I can use to test with?
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Tue, 16 Feb 2016 12:14:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161156160.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2801550.oZPkqjv8nW@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote:
> > >
> > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > > index 8ea45a5cd806..fd3d6fd290a9 100644
> > > --- a/drivers/video/fbdev/Kconfig
> > > +++ b/drivers/video/fbdev/Kconfig
> > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> > > config XEN_FBDEV_FRONTEND
> > > tristate "Xen virtual frame buffer support"
> > > depends on FB && XEN
> > > + depends on INPUT || !INPUT_MISC
> > > select FB_SYS_FILLRECT
> > > select FB_SYS_COPYAREA
> > > select FB_SYS_IMAGEBLIT
> >
> > This looks very hackish. Couldn't we just do the following?
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5..3c15f6d 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
> > select FB_SYS_IMAGEBLIT
> > select FB_SYS_FOPS
> > select FB_DEFERRED_IO
> > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
> > select XEN_XENBUS_FRONTEND
> > default y
> > help
> >
>
> No, that doesn't solve the problem:
>
> If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still
> get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m.
>
> INPUT_MISC already depends on INPUT, so your change has no effect
> at all.
Please correct me if I am wrong, but the difference is that with this
change if INPUT=m, then the build system would ask the user whether she
wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of
unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y.
However it is true that if the users chooses
INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists.
Maybe we also need:
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 1f2337a..303df24 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C
config INPUT_XEN_KBDDEV_FRONTEND
tristate "Xen virtual keyboard and mouse support"
- depends on XEN
+ depends on XEN && INPUT
default y
select XEN_XENBUS_FRONTEND
help
Do you have a kernel config with INPUT=m that I can use to test with?
WARNING: multiple messages have this Message-ID (diff)
From: stefano.stabellini@eu.citrix.com (Stefano Stabellini)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Tue, 16 Feb 2016 12:14:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161156160.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2801550.oZPkqjv8nW@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote:
> > >
> > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > > index 8ea45a5cd806..fd3d6fd290a9 100644
> > > --- a/drivers/video/fbdev/Kconfig
> > > +++ b/drivers/video/fbdev/Kconfig
> > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> > > config XEN_FBDEV_FRONTEND
> > > tristate "Xen virtual frame buffer support"
> > > depends on FB && XEN
> > > + depends on INPUT || !INPUT_MISC
> > > select FB_SYS_FILLRECT
> > > select FB_SYS_COPYAREA
> > > select FB_SYS_IMAGEBLIT
> >
> > This looks very hackish. Couldn't we just do the following?
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5..3c15f6d 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
> > select FB_SYS_IMAGEBLIT
> > select FB_SYS_FOPS
> > select FB_DEFERRED_IO
> > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
> > select XEN_XENBUS_FRONTEND
> > default y
> > help
> >
>
> No, that doesn't solve the problem:
>
> If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still
> get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m.
>
> INPUT_MISC already depends on INPUT, so your change has no effect
> at all.
Please correct me if I am wrong, but the difference is that with this
change if INPUT=m, then the build system would ask the user whether she
wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of
unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y.
However it is true that if the users chooses
INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists.
Maybe we also need:
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 1f2337a..303df24 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C
config INPUT_XEN_KBDDEV_FRONTEND
tristate "Xen virtual keyboard and mouse support"
- depends on XEN
+ depends on XEN && INPUT
default y
select XEN_XENBUS_FRONTEND
help
Do you have a kernel config with INPUT=m that I can use to test with?
WARNING: multiple messages have this Message-ID (diff)
From: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Andrew Jones <drjones@redhat.com>,
xen-devel@lists.xensource.com,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
David Vrabel <david.vrabel@citrix.com>,
boris.ostrovsky@oracle.com,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>
Subject: Re: [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select
Date: Tue, 16 Feb 2016 12:14:14 +0000 [thread overview]
Message-ID: <alpine.DEB.2.02.1602161156160.27008@kaball.uk.xensource.com> (raw)
In-Reply-To: <2801550.oZPkqjv8nW@wuerfel>
On Tue, 16 Feb 2016, Arnd Bergmann wrote:
> On Monday 15 February 2016 16:51:08 Stefano Stabellini wrote:
> > >
> > > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > > index 8ea45a5cd806..fd3d6fd290a9 100644
> > > --- a/drivers/video/fbdev/Kconfig
> > > +++ b/drivers/video/fbdev/Kconfig
> > > @@ -2241,6 +2241,7 @@ config FB_VIRTUAL
> > > config XEN_FBDEV_FRONTEND
> > > tristate "Xen virtual frame buffer support"
> > > depends on FB && XEN
> > > + depends on INPUT || !INPUT_MISC
> > > select FB_SYS_FILLRECT
> > > select FB_SYS_COPYAREA
> > > select FB_SYS_IMAGEBLIT
> >
> > This looks very hackish. Couldn't we just do the following?
> >
> > diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig
> > index 8ea45a5..3c15f6d 100644
> > --- a/drivers/video/fbdev/Kconfig
> > +++ b/drivers/video/fbdev/Kconfig
> > @@ -2246,7 +2246,7 @@ config XEN_FBDEV_FRONTEND
> > select FB_SYS_IMAGEBLIT
> > select FB_SYS_FOPS
> > select FB_DEFERRED_IO
> > - select INPUT_XEN_KBDDEV_FRONTEND if INPUT_MISC
> > + select INPUT_XEN_KBDDEV_FRONTEND if (INPUT && INPUT_MISC)
> > select XEN_XENBUS_FRONTEND
> > default y
> > help
> >
>
> No, that doesn't solve the problem:
>
> If XEN_FBDEV_FRONTEND=y, INPUT=m and INPUT_MISC=y, we would still
> get INPUT_XEN_KBDDEV_FRONTEND=y, which cannot work because of INPUT=m.
>
> INPUT_MISC already depends on INPUT, so your change has no effect
> at all.
Please correct me if I am wrong, but the difference is that with this
change if INPUT=m, then the build system would ask the user whether she
wants to select INPUT_XEN_KBDDEV_FRONTEND as m or y, instead of
unconditionally set INPUT_XEN_KBDDEV_FRONTEND=y.
However it is true that if the users chooses
INPUT_XEN_KBDDEV_FRONTEND=y, then the problem persists.
Maybe we also need:
diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
index 1f2337a..303df24 100644
--- a/drivers/input/misc/Kconfig
+++ b/drivers/input/misc/Kconfig
@@ -721,7 +721,7 @@ config INPUT_CMA3000_I2C
config INPUT_XEN_KBDDEV_FRONTEND
tristate "Xen virtual keyboard and mouse support"
- depends on XEN
+ depends on XEN && INPUT
default y
select XEN_XENBUS_FRONTEND
help
Do you have a kernel config with INPUT=m that I can use to test with?
next prev parent reply other threads:[~2016-02-16 12:14 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-12 12:04 [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 12:04 ` Arnd Bergmann
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-12 13:56 ` Andrew Jones
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 16:51 ` Stefano Stabellini
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:05 ` David Vrabel
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-15 17:08 ` Stefano Stabellini
2016-02-16 15:03 ` [PATCH v2] xen kconfig: don't "select INPUT_XEN_KBDDEV_FRONTEND" Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 15:03 ` Arnd Bergmann
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-02-16 16:55 ` Stefano Stabellini
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-03-11 11:37 ` Tomi Valkeinen
2016-02-16 11:35 ` [PATCH] xen kconfig: clarify INPUT_XEN_KBDDEV_FRONTEND select Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 11:35 ` Arnd Bergmann
2016-02-16 12:14 ` Stefano Stabellini [this message]
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 12:14 ` Stefano Stabellini
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
2016-02-16 15:05 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.02.1602161156160.27008@kaball.uk.xensource.com \
--to=stefano.stabellini@eu.citrix.com \
--cc=arnd@arndb.de \
--cc=boris.ostrovsky@oracle.com \
--cc=david.vrabel@citrix.com \
--cc=drjones@redhat.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=tomi.valkeinen@ti.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.