All of lore.kernel.org
 help / color / mirror / Atom feed
From: Asutosh Das <quic_asutoshd@quicinc.com>
To: <quic_cang@quicinc.com>, <martin.petersen@oracle.com>,
	<linux-scsi@vger.kernel.org>
Cc: <quic_nguyenb@quicinc.com>, <quic_xiaosenh@quicinc.com>,
	<stanley.chu@mediatek.com>, <eddie.huang@mediatek.com>,
	<daejun7.park@samsung.com>, <bvanassche@acm.org>,
	<avri.altman@wdc.com>, <mani@kernel.org>, <beanhuo@micron.com>,
	Asutosh Das <quic_asutoshd@quicinc.com>,
	<linux-arm-msm@vger.kernel.org>,
	Alim Akhtar <alim.akhtar@samsung.com>,
	"James E.J. Bottomley" <jejb@linux.ibm.com>,
	Jinyoung Choi <j-young.choi@samsung.com>,
	open list <linux-kernel@vger.kernel.org>
Subject: [PATCH v9 01/16] ufs: core: Optimize duplicate code to read extended feature
Date: Wed, 30 Nov 2022 15:50:33 -0800	[thread overview]
Message-ID: <c166e46a1fff4662f7b3677dcbf0b814eaa98ae0.1669850856.git.quic_asutoshd@quicinc.com> (raw)
In-Reply-To: <cover.1669850856.git.quic_asutoshd@quicinc.com>

The code to parse the extended feature is duplicated twice
in the ufs core. Replace the duplicated code with a
function.

Signed-off-by: Asutosh Das <quic_asutoshd@quicinc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
---
 drivers/ufs/core/ufshcd.c | 21 +++++++++++++--------
 1 file changed, 13 insertions(+), 8 deletions(-)

diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
index 2dbe249..6ea22b5 100644
--- a/drivers/ufs/core/ufshcd.c
+++ b/drivers/ufs/core/ufshcd.c
@@ -215,6 +215,17 @@ ufs_get_desired_pm_lvl_for_dev_link_state(enum ufs_dev_pwr_mode dev_state,
 	return UFS_PM_LVL_0;
 }
 
+static unsigned int ufs_get_ext_ufs_feature(struct ufs_hba *hba,
+					    const u8 *desc_buf)
+{
+	if (hba->desc_size[QUERY_DESC_IDN_DEVICE] <
+	    DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
+		return 0;
+
+	return get_unaligned_be32(desc_buf +
+				  DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
+}
+
 static const struct ufs_dev_quirk ufs_fixups[] = {
 	/* UFS cards deviations table */
 	{ .wmanufacturerid = UFS_VENDOR_MICRON,
@@ -7608,13 +7619,7 @@ static void ufshcd_wb_probe(struct ufs_hba *hba, const u8 *desc_buf)
 	     (hba->dev_quirks & UFS_DEVICE_QUIRK_SUPPORT_EXTENDED_FEATURES)))
 		goto wb_disabled;
 
-	if (hba->desc_size[QUERY_DESC_IDN_DEVICE] <
-	    DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP + 4)
-		goto wb_disabled;
-
-	ext_ufs_feature = get_unaligned_be32(desc_buf +
-					DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
-
+	ext_ufs_feature = ufs_get_ext_ufs_feature(hba, desc_buf);
 	if (!(ext_ufs_feature & UFS_DEV_WRITE_BOOSTER_SUP))
 		goto wb_disabled;
 
@@ -7668,7 +7673,7 @@ static void ufshcd_temp_notif_probe(struct ufs_hba *hba, const u8 *desc_buf)
 	if (!(hba->caps & UFSHCD_CAP_TEMP_NOTIF) || dev_info->wspecversion < 0x300)
 		return;
 
-	ext_ufs_feature = get_unaligned_be32(desc_buf + DEVICE_DESC_PARAM_EXT_UFS_FEATURE_SUP);
+	ext_ufs_feature = ufs_get_ext_ufs_feature(hba, desc_buf);
 
 	if (ext_ufs_feature & UFS_DEV_LOW_TEMP_NOTIF)
 		mask |= MASK_EE_TOO_LOW_TEMP;
-- 
2.7.4


  reply	other threads:[~2022-12-01  0:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30 23:50 [PATCH v9 00/16] Add Multi Circular Queue Support Asutosh Das
2022-11-30 23:50 ` Asutosh Das [this message]
2022-12-01  0:45   ` [PATCH v9 01/16] ufs: core: Optimize duplicate code to read extended feature Stanley Chu
2022-11-30 23:50 ` [PATCH v9 02/16] ufs: core: Probe for ext_iid support Asutosh Das
2022-12-01  0:46   ` Stanley Chu
2022-11-30 23:50 ` [PATCH v9 03/16] ufs: core: Introduce Multi-circular queue capability Asutosh Das
2022-12-05  0:58   ` Stanley Chu
2022-11-30 23:50 ` [PATCH v9 04/16] ufs: core: Defer adding host to scsi if mcq is supported Asutosh Das
2022-11-30 23:50 ` [PATCH v9 05/16] ufs: core: mcq: Add support to allocate multiple queues Asutosh Das
2022-11-30 23:50 ` [PATCH v9 06/16] ufs: core: mcq: Configure resource regions Asutosh Das
2022-11-30 23:50 ` [PATCH v9 07/16] ufs: core: mcq: Calculate queue depth Asutosh Das
2022-11-30 23:50 ` [PATCH v9 08/16] ufs: core: mcq: Allocate memory for mcq mode Asutosh Das
2022-11-30 23:50 ` [PATCH v9 09/16] ufs: core: mcq: Configure operation and runtime interface Asutosh Das
2022-11-30 23:50 ` [PATCH v9 10/16] ufs: core: mcq: Use shared tags for MCQ mode Asutosh Das
2022-11-30 23:50 ` [PATCH v9 11/16] ufs: core: Prepare ufshcd_send_command for mcq Asutosh Das
2022-11-30 23:50 ` [PATCH v9 12/16] ufs: core: mcq: Find hardware queue to queue request Asutosh Das
2022-11-30 23:50 ` [PATCH v9 13/16] ufs: core: Prepare for completion in mcq Asutosh Das
2022-11-30 23:50 ` [PATCH v9 14/16] ufs: mcq: Add completion support of a cqe Asutosh Das
2022-12-05 21:24   ` kernel test robot
2022-11-30 23:50 ` [PATCH v9 15/16] ufs: core: mcq: Add completion support in poll Asutosh Das
2022-11-30 23:50 ` [PATCH v9 16/16] ufs: core: mcq: Enable Multi Circular Queue Asutosh Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c166e46a1fff4662f7b3677dcbf0b814eaa98ae0.1669850856.git.quic_asutoshd@quicinc.com \
    --to=quic_asutoshd@quicinc.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bvanassche@acm.org \
    --cc=daejun7.park@samsung.com \
    --cc=eddie.huang@mediatek.com \
    --cc=j-young.choi@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mani@kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=quic_cang@quicinc.com \
    --cc=quic_nguyenb@quicinc.com \
    --cc=quic_xiaosenh@quicinc.com \
    --cc=stanley.chu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.