All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Sanchit Jindal via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Sanchit Jindal <sanchit1053@gmail.com>,
	sanchit1053 <sanchit1053@gmail.com>
Subject: [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
Date: Wed, 20 Mar 2024 19:48:29 +0000	[thread overview]
Message-ID: <pull.1700.git.1710964109659.gitgitgadget@gmail.com> (raw)

From: sanchit1053 <sanchit1053@gmail.com>

Signed-off-by: sanchit1053 <sanchit1053@gmail.com>
---
    t9803-git-p4-shell-metachars.sh: update to use test_path_* functions
    
    I have updated the statements test [!] -[e|f] with the corresponding
    test_path_* functions The statements are at the end of their respective
    texts and can be easily replaced
    
    I am having trouble with the git send-email and my institutes firewall,
    that is why I am trying to use gitgitgadget

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1700%2Fsanchit1053%2Fsj%2Ft8903_use_path_helper_fn-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1700/sanchit1053/sj/t8903_use_path_helper_fn-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1700

 t/t9803-git-p4-shell-metachars.sh | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/t/t9803-git-p4-shell-metachars.sh b/t/t9803-git-p4-shell-metachars.sh
index 2913277013d..4905ed2ae9e 100755
--- a/t/t9803-git-p4-shell-metachars.sh
+++ b/t/t9803-git-p4-shell-metachars.sh
@@ -33,8 +33,8 @@ test_expect_success 'shell metachars in filenames' '
 	(
 		cd "$cli" &&
 		p4 sync ... &&
-		test -e "file with spaces" &&
-		test -e "foo\$bar"
+		test_path_exists "file with spaces" &&
+		test_path_exists "foo\$bar"
 	)
 '
 
@@ -52,8 +52,8 @@ test_expect_success 'deleting with shell metachars' '
 	(
 		cd "$cli" &&
 		p4 sync ... &&
-		test ! -e "file with spaces" &&
-		test ! -e foo\$bar
+		test_path_is_missing "file with spaces" &&
+		test_path_is_missing foo\$bar
 	)
 '
 
@@ -100,8 +100,8 @@ test_expect_success 'branch with shell char' '
 		git p4 clone --dest=. --detect-branches //depot@all &&
 		git log --all --graph --decorate --stat &&
 		git reset --hard p4/depot/branch\$3 &&
-		test -f shell_char_branch_file &&
-		test -f f1
+		test_path_is_file shell_char_branch_file &&
+		test_path_is_file f1
 	)
 '
 

base-commit: 3bd955d26919e149552f34aacf8a4e6368c26cec
-- 
gitgitgadget

             reply	other threads:[~2024-03-20 19:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20 19:48 Sanchit Jindal via GitGitGadget [this message]
2024-03-20 20:35 ` [PATCH] t9803-git-p4-shell-metachars.sh: update to use test_path_* functions Eric Sunshine
2024-03-20 20:46 ` Junio C Hamano
2024-03-20 21:06   ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=pull.1700.git.1710964109659.gitgitgadget@gmail.com \
    --to=gitgitgadget@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=sanchit1053@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.