* MCS rate suggested field - how about aggregation
@ 2009-11-26 21:50 Luis R. Rodriguez
[not found] ` <43e72e890911261350yadfa099n2c9d44d2f30d4845-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Luis R. Rodriguez @ 2009-11-26 21:50 UTC (permalink / raw)
To: Radiotap; +Cc: Matteo Croce
Matteo added an MCS field as a suggested field:
http://www.radiotap.org/suggested-fields/MCS
Curious if anyone has thought about how to process aggregates though.
Luis
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: MCS rate suggested field - how about aggregation
[not found] ` <43e72e890911261350yadfa099n2c9d44d2f30d4845-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2009-11-27 9:22 ` Johannes Berg
[not found] ` <1259313731.5428.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Johannes Berg @ 2009-11-27 9:22 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: Radiotap, Matteo Croce
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Thu, 2009-11-26 at 13:50 -0800, Luis R. Rodriguez wrote:
> Matteo added an MCS field as a suggested field:
>
> http://www.radiotap.org/suggested-fields/MCS
He was going to submit an RFA -- can we not jump that? :)
> Curious if anyone has thought about how to process aggregates though.
FWIW, I think MCS and aggregation is logically different although they
both belong to HT most of the time. Therefore, I think aggregates should
be handled in a different field.
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: MCS rate suggested field - how about aggregation
[not found] ` <1259313731.5428.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
@ 2009-11-27 15:58 ` Matteo Croce
0 siblings, 0 replies; 3+ messages in thread
From: Matteo Croce @ 2009-11-27 15:58 UTC (permalink / raw)
To: Johannes Berg; +Cc: Luis R. Rodriguez, Radiotap
On Fri, Nov 27, 2009 at 10:22 AM, Johannes Berg
<johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org> wrote:
> On Thu, 2009-11-26 at 13:50 -0800, Luis R. Rodriguez wrote:
>> Matteo added an MCS field as a suggested field:
>>
>> http://www.radiotap.org/suggested-fields/MCS
>
> He was going to submit an RFA -- can we not jump that? :)
>
>> Curious if anyone has thought about how to process aggregates though.
>
> FWIW, I think MCS and aggregation is logically different although they
> both belong to HT most of the time. Therefore, I think aggregates should
> be handled in a different field.
>
> johannes
>
I wrote some implementations for the MCS field for mac80211, tcpdump
and wireshark.
They can be found here: http://teknoraver.net/software/radiotap_mcs/
I attach the radiotap one below:
diff --git a/radiotap.c b/radiotap.c
index 0745ba8..a5c64a8 100644
--- a/radiotap.c
+++ b/radiotap.c
@@ -60,6 +60,7 @@ static const struct radiotap_align_size
rtap_namespace_sizes[] = {
[IEEE80211_RADIOTAP_TX_FLAGS] = { .align = 2, .size = 2, },
[IEEE80211_RADIOTAP_RTS_RETRIES] = { .align = 1, .size = 1, },
[IEEE80211_RADIOTAP_DATA_RETRIES] = { .align = 1, .size = 1, },
+ [IEEE80211_RADIOTAP_RATE_MCS] = { .align = 1, .size = 2, },
/*
* add more here as they are defined in
* include/net/ieee80211_radiotap.h
diff --git a/radiotap.h b/radiotap.h
index 87455eb..3c3f591 100644
--- a/radiotap.h
+++ b/radiotap.h
@@ -178,6 +178,11 @@ struct ieee80211_radiotap_header {
*
* Number of unicast retries a transmitted frame used.
*
+ * IEEE80211_RADIOTAP_RATE_MCS 2 x u8 data, bitmap
+ *
+ * First byte is the MCS index of the rate,
+ * second one has flags about channel width and guard interval
+ *
*/
enum ieee80211_radiotap_type {
IEEE80211_RADIOTAP_TSFT = 0,
@@ -198,6 +203,7 @@ enum ieee80211_radiotap_type {
IEEE80211_RADIOTAP_TX_FLAGS = 15,
IEEE80211_RADIOTAP_RTS_RETRIES = 16,
IEEE80211_RADIOTAP_DATA_RETRIES = 17,
+ IEEE80211_RADIOTAP_RATE_MCS = 19,
/* valid in every it_present bitmap, even vendor namespaces */
IEEE80211_RADIOTAP_RADIOTAP_NAMESPACE = 29,
@@ -243,4 +249,8 @@ enum ieee80211_radiotap_type {
#define IEEE80211_RADIOTAP_F_TX_CTS 0x0002 /* used cts 'protection' */
#define IEEE80211_RADIOTAP_F_TX_RTS 0x0004 /* used rts/cts handshake */
+/* For IEEE80211_RADIOTAP_RATE_MCS */
+#define IEEE80211_RADIOTAP_RATE_MCS_40MHZ 0x01 /* 40 MHz channel width */
+#define IEEE80211_RADIOTAP_RATE_MCS_SHORT_GI 0x02 /* short guard interval */
+
#endif /* IEEE80211_RADIOTAP_H */
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-11-27 15:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-11-26 21:50 MCS rate suggested field - how about aggregation Luis R. Rodriguez
[not found] ` <43e72e890911261350yadfa099n2c9d44d2f30d4845-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-11-27 9:22 ` Johannes Berg
[not found] ` <1259313731.5428.6.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-11-27 15:58 ` Matteo Croce
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).