* [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks
@ 2019-03-29 9:55 Neeraj Upadhyay
2019-03-29 10:12 ` Mukesh Ojha
0 siblings, 1 reply; 3+ messages in thread
From: Neeraj Upadhyay @ 2019-03-29 9:55 UTC (permalink / raw)
To: paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai, joel
Cc: rcu, linux-kernel, Neeraj Upadhyay
dump_blkd_tasks() uses 10 as the max number of blocked
tasks, which are printed. However, it has an argument
which provides that number. So, use the argument value
instead. As all callers currently pass 10 as the number,
there isn't any impact.
Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
---
kernel/rcu/tree_plugin.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index 3960294..08bcd87 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -740,7 +740,7 @@ void exit_rcu(void)
i = 0;
list_for_each(lhp, &rnp->blkd_tasks) {
pr_cont(" %p", lhp);
- if (++i >= 10)
+ if (++i >= ncheck)
break;
}
pr_cont("\n");
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a
member of the Code Aurora Forum, hosted by The Linux Foundation
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks
2019-03-29 9:55 [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks Neeraj Upadhyay
@ 2019-03-29 10:12 ` Mukesh Ojha
2019-03-29 21:27 ` Paul E. McKenney
0 siblings, 1 reply; 3+ messages in thread
From: Mukesh Ojha @ 2019-03-29 10:12 UTC (permalink / raw)
To: Neeraj Upadhyay, paulmck, josh, rostedt, mathieu.desnoyers,
jiangshanlai, joel
Cc: rcu, linux-kernel
On 3/29/2019 3:25 PM, Neeraj Upadhyay wrote:
> dump_blkd_tasks() uses 10 as the max number of blocked
> tasks, which are printed. However, it has an argument
> which provides that number. So, use the argument value
> instead. As all callers currently pass 10 as the number,
> there isn't any impact.
>
> Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
Looks good to me.
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers,
-Mukesh
> ---
> kernel/rcu/tree_plugin.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> index 3960294..08bcd87 100644
> --- a/kernel/rcu/tree_plugin.h
> +++ b/kernel/rcu/tree_plugin.h
> @@ -740,7 +740,7 @@ void exit_rcu(void)
> i = 0;
> list_for_each(lhp, &rnp->blkd_tasks) {
> pr_cont(" %p", lhp);
> - if (++i >= 10)
> + if (++i >= ncheck)
> break;
> }
> pr_cont("\n");
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks
2019-03-29 10:12 ` Mukesh Ojha
@ 2019-03-29 21:27 ` Paul E. McKenney
0 siblings, 0 replies; 3+ messages in thread
From: Paul E. McKenney @ 2019-03-29 21:27 UTC (permalink / raw)
To: Mukesh Ojha
Cc: Neeraj Upadhyay, josh, rostedt, mathieu.desnoyers, jiangshanlai,
joel, rcu, linux-kernel
On Fri, Mar 29, 2019 at 03:42:44PM +0530, Mukesh Ojha wrote:
>
> On 3/29/2019 3:25 PM, Neeraj Upadhyay wrote:
> >dump_blkd_tasks() uses 10 as the max number of blocked
> >tasks, which are printed. However, it has an argument
> >which provides that number. So, use the argument value
> >instead. As all callers currently pass 10 as the number,
> >there isn't any impact.
> >
> >Signed-off-by: Neeraj Upadhyay <neeraju@codeaurora.org>
>
> Looks good to me.
>
> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Applied, thank you both!
Thanx, Paul
> Cheers,
> -Mukesh
>
> >---
> > kernel/rcu/tree_plugin.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
> >index 3960294..08bcd87 100644
> >--- a/kernel/rcu/tree_plugin.h
> >+++ b/kernel/rcu/tree_plugin.h
> >@@ -740,7 +740,7 @@ void exit_rcu(void)
> > i = 0;
> > list_for_each(lhp, &rnp->blkd_tasks) {
> > pr_cont(" %p", lhp);
> >- if (++i >= 10)
> >+ if (++i >= ncheck)
> > break;
> > }
> > pr_cont("\n");
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-29 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-29 9:55 [PATCH] rcu: tree_plugin: Dump specified number of blocked tasks Neeraj Upadhyay
2019-03-29 10:12 ` Mukesh Ojha
2019-03-29 21:27 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).