* [PATCH] net: wan: lapbether.c: Use built-in RCU list checking
@ 2020-01-15 11:41 madhuparnabhowmik04
2020-01-16 13:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: madhuparnabhowmik04 @ 2020-01-15 11:41 UTC (permalink / raw)
To: davem, gregkh
Cc: paulmck, joel, netdev, linux-kernel, rcu, frextrite, Madhuparna Bhowmik
From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
The only callers of the function lapbeth_get_x25_dev()
are lapbeth_rcv() and lapbeth_device_event().
lapbeth_rcv() uses rcu_read_lock() whereas lapbeth_device_event()
is called with RTNL held (As mentioned in the comments).
Therefore, pass lockdep_rtnl_is_held() as cond argument in
list_for_each_entry_rcu();
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
---
drivers/net/wan/lapbether.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wan/lapbether.c b/drivers/net/wan/lapbether.c
index 0f1217b506ad..e30d91a38cfb 100644
--- a/drivers/net/wan/lapbether.c
+++ b/drivers/net/wan/lapbether.c
@@ -64,7 +64,7 @@ static struct lapbethdev *lapbeth_get_x25_dev(struct net_device *dev)
{
struct lapbethdev *lapbeth;
- list_for_each_entry_rcu(lapbeth, &lapbeth_devices, node) {
+ list_for_each_entry_rcu(lapbeth, &lapbeth_devices, node, lockdep_rtnl_is_held()) {
if (lapbeth->ethdev == dev)
return lapbeth;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net: wan: lapbether.c: Use built-in RCU list checking
2020-01-15 11:41 [PATCH] net: wan: lapbether.c: Use built-in RCU list checking madhuparnabhowmik04
@ 2020-01-16 13:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2020-01-16 13:31 UTC (permalink / raw)
To: madhuparnabhowmik04
Cc: gregkh, paulmck, joel, netdev, linux-kernel, rcu, frextrite
From: madhuparnabhowmik04@gmail.com
Date: Wed, 15 Jan 2020 17:11:01 +0530
> From: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
>
> The only callers of the function lapbeth_get_x25_dev()
> are lapbeth_rcv() and lapbeth_device_event().
>
> lapbeth_rcv() uses rcu_read_lock() whereas lapbeth_device_event()
> is called with RTNL held (As mentioned in the comments).
>
> Therefore, pass lockdep_rtnl_is_held() as cond argument in
> list_for_each_entry_rcu();
>
> Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-16 13:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-15 11:41 [PATCH] net: wan: lapbether.c: Use built-in RCU list checking madhuparnabhowmik04
2020-01-16 13:31 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).