* [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency_stop static
@ 2020-04-09 11:42 Jason Yan
2020-04-09 20:59 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Jason Yan @ 2020-04-09 11:42 UTC (permalink / raw)
To: dave, paulmck, josh, rostedt, mathieu.desnoyers, jiangshanlai,
joel, linux-kernel, rcu
Cc: Jason Yan
Fix the following sparse warning:
kernel/rcu/rcutorture.c:1695:16: warning: symbol 'rcu_fwds' was not
declared. Should it be static?
kernel/rcu/rcutorture.c:1696:6: warning: symbol 'rcu_fwd_emergency_stop'
was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Jason Yan <yanaijie@huawei.com>
---
kernel/rcu/rcutorture.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
index 5453bd557f43..d621a31de8a4 100644
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1692,8 +1692,8 @@ struct rcu_fwd {
unsigned long rcu_launder_gp_seq_start;
};
-struct rcu_fwd *rcu_fwds;
-bool rcu_fwd_emergency_stop;
+static struct rcu_fwd *rcu_fwds;
+static bool rcu_fwd_emergency_stop;
static void rcu_torture_fwd_cb_hist(struct rcu_fwd *rfp)
{
--
2.17.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency_stop static
2020-04-09 11:42 [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency_stop static Jason Yan
@ 2020-04-09 20:59 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2020-04-09 20:59 UTC (permalink / raw)
To: Jason Yan
Cc: dave, josh, rostedt, mathieu.desnoyers, jiangshanlai, joel,
linux-kernel, rcu
On Thu, Apr 09, 2020 at 07:42:38PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
>
> kernel/rcu/rcutorture.c:1695:16: warning: symbol 'rcu_fwds' was not
> declared. Should it be static?
> kernel/rcu/rcutorture.c:1696:6: warning: symbol 'rcu_fwd_emergency_stop'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Jason Yan <yanaijie@huawei.com>
Good catch, queued, thank you!
Thanx, Paul
> ---
> kernel/rcu/rcutorture.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 5453bd557f43..d621a31de8a4 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1692,8 +1692,8 @@ struct rcu_fwd {
> unsigned long rcu_launder_gp_seq_start;
> };
>
> -struct rcu_fwd *rcu_fwds;
> -bool rcu_fwd_emergency_stop;
> +static struct rcu_fwd *rcu_fwds;
> +static bool rcu_fwd_emergency_stop;
>
> static void rcu_torture_fwd_cb_hist(struct rcu_fwd *rfp)
> {
> --
> 2.17.2
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-09 20:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-09 11:42 [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency_stop static Jason Yan
2020-04-09 20:59 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).