From: "Paul E. McKenney" <paulmck@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Uladzislau Rezki <urezki@gmail.com>,
LKML <linux-kernel@vger.kernel.org>, RCU <rcu@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
"Theodore Y . Ts'o" <tytso@mit.edu>,
Matthew Wilcox <willy@infradead.org>,
Joel Fernandes <joel@joelfernandes.org>,
Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Subject: Re: [PATCH 1/1] rcu/tree: Drop the lock before entering to page allocator
Date: Wed, 15 Jul 2020 15:14:49 -0700 [thread overview]
Message-ID: <20200715221449.GJ9247@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <20200715193250.axntj7jdt6bw52dr@linutronix.de>
On Wed, Jul 15, 2020 at 09:32:50PM +0200, Sebastian Andrzej Siewior wrote:
> On 2020-07-15 21:02:43 [+0200], Uladzislau Rezki wrote:
> >
> > <snip>
> > spin_lock();
> > __get_free_page(GFP_NOWAIT | __GFP_NOWARN);
> > spin_unlock();
> > <snip>
> >
> > Also, please note we do it for regular kernel.
>
> ach right okay then.
>
> > >
> > > What happened to the part where I asked for a spinlock_t?
> > >
> > What do you mean?
>
> Please drop that raw_spinlock_t for the kfree_rcu() based locking and
> use just a plain spinlock_t for the locking. Then you can keep the same
> code flow for RT and !RT without any special cases and everything.
My concern is that some critical bug will show up at some point
that requires double-argument kfree_rcu() be invoked while holding
a raw spinlock. (Single-argument kfree_rcu() must sometimes invoke
synchronize_rcu(), so it can never be invoked in any state forbidding
invoking schedule().)
Yes, dropping to a plain spinlock would be simple in the here and now,
but experience indicates that it is only a matter of time, and that when
that time comes it will come as an emergency.
One approach would be to replace the "IS_ENABLED(CONFIG_PREEMPT_RT)"
with some sort of check for being in a context where spinlock acquisition
is not legal. What could be done along those lines?
Thanx, Paul
next prev parent reply other threads:[~2020-07-15 22:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 18:35 [PATCH 1/1] rcu/tree: Drop the lock before entering to page allocator Uladzislau Rezki (Sony)
2020-07-15 18:56 ` Sebastian Andrzej Siewior
2020-07-15 19:02 ` Uladzislau Rezki
2020-07-15 19:32 ` Sebastian Andrzej Siewior
2020-07-15 19:36 ` Uladzislau Rezki
2020-07-15 22:14 ` Paul E. McKenney [this message]
2020-07-16 14:14 ` Sebastian Andrzej Siewior
2020-07-16 15:20 ` Paul E. McKenney
2020-07-16 15:36 ` Sebastian Andrzej Siewior
2020-07-16 16:36 ` Paul E. McKenney
2020-07-15 23:13 ` Joel Fernandes
2020-07-16 9:19 ` Uladzislau Rezki
2020-07-16 13:36 ` Joel Fernandes
2020-07-16 14:37 ` Uladzislau Rezki
2020-07-16 18:27 ` Joel Fernandes
2020-07-16 19:03 ` Uladzislau Rezki
2020-07-16 14:25 ` Sebastian Andrzej Siewior
2020-07-16 14:47 ` Uladzislau Rezki
2020-07-16 15:04 ` Sebastian Andrzej Siewior
2020-07-16 15:34 ` Uladzislau Rezki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715221449.GJ9247@paulmck-ThinkPad-P72 \
--to=paulmck@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=joel@joelfernandes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=oleksiy.avramchenko@sonymobile.com \
--cc=rcu@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=urezki@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).