* [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-09 17:43 ` Sean Christopherson
2023-01-05 0:37 ` [PATCH rcu 02/27] arch/arm64/kvm: " Paul E. McKenney
` (27 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H. Peter Anvin, Sean Christopherson, Paolo Bonzini, x86, kvm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: <x86@kernel.org>
Cc: <kvm@vger.kernel.org>
---
arch/x86/Kconfig | 2 --
arch/x86/kvm/Kconfig | 1 -
2 files changed, 3 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3604074a878b8..4a9175fe7dd18 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -283,7 +283,6 @@ config X86
select RTC_LIB
select RTC_MC146818_LIB
select SPARSE_IRQ
- select SRCU
select SYSCTL_EXCEPTION_TRACE
select THREAD_INFO_IN_TASK
select TRACE_IRQFLAGS_SUPPORT
@@ -1938,7 +1937,6 @@ config X86_SGX
depends on X86_64 && CPU_SUP_INTEL && X86_X2APIC
depends on CRYPTO=y
depends on CRYPTO_SHA256=y
- select SRCU
select MMU_NOTIFIER
select NUMA_KEEP_MEMINFO if NUMA
select XARRAY_MULTI
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index fbeaa9ddef598..9306d99585188 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -46,7 +46,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_VFIO
- select SRCU
select INTERVAL_TREE
select HAVE_KVM_PM_NOTIFIER if PM
help
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 01/27] arch/x86: Remove "select SRCU" Paul E. McKenney
@ 2023-01-09 17:43 ` Sean Christopherson
2023-01-09 19:22 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Sean Christopherson @ 2023-01-09 17:43 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Paolo Bonzini, x86, kvm
On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: <x86@kernel.org>
> Cc: <kvm@vger.kernel.org>
> ---
...
> diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> index fbeaa9ddef598..9306d99585188 100644
> --- a/arch/x86/kvm/Kconfig
> +++ b/arch/x86/kvm/Kconfig
> @@ -46,7 +46,6 @@ config KVM
> select KVM_XFER_TO_GUEST_WORK
> select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> select KVM_VFIO
> - select SRCU
Would it be too much trouble to bundle all of the KVM changes into a single patch?
The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
purely because of KVM's somewhat roundabout Kconfig setup.
> select INTERVAL_TREE
> select HAVE_KVM_PM_NOTIFIER if PM
> help
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-09 17:43 ` Sean Christopherson
@ 2023-01-09 19:22 ` Paul E. McKenney
2023-01-09 20:05 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-09 19:22 UTC (permalink / raw)
To: Sean Christopherson
Cc: rcu, linux-kernel, kernel-team, rostedt, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Paolo Bonzini, x86, kvm
On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: Sean Christopherson <seanjc@google.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: <x86@kernel.org>
> > Cc: <kvm@vger.kernel.org>
> > ---
>
> ...
>
> > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > index fbeaa9ddef598..9306d99585188 100644
> > --- a/arch/x86/kvm/Kconfig
> > +++ b/arch/x86/kvm/Kconfig
> > @@ -46,7 +46,6 @@ config KVM
> > select KVM_XFER_TO_GUEST_WORK
> > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > select KVM_VFIO
> > - select SRCU
>
> Would it be too much trouble to bundle all of the KVM changes into a single patch?
> The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> purely because of KVM's somewhat roundabout Kconfig setup.
No problem, and will do on my next rebase. I might end up with a long
list of Cc's, but so it goes. I will of course send the result as a
reply to this message.
Thanx, Paul
> > select INTERVAL_TREE
> > select HAVE_KVM_PM_NOTIFIER if PM
> > help
> > --
> > 2.31.1.189.g2e36527f23
> >
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-09 19:22 ` Paul E. McKenney
@ 2023-01-09 20:05 ` Paul E. McKenney
2023-01-10 19:55 ` Sean Christopherson
0 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-09 20:05 UTC (permalink / raw)
To: Sean Christopherson
Cc: rcu, linux-kernel, kernel-team, rostedt, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Paolo Bonzini, x86, kvm
On Mon, Jan 09, 2023 at 11:22:28AM -0800, Paul E. McKenney wrote:
> On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> > On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > > Kconfig statements.
> > >
> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > Cc: Ingo Molnar <mingo@redhat.com>
> > > Cc: Borislav Petkov <bp@alien8.de>
> > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > Cc: Sean Christopherson <seanjc@google.com>
> > > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > > Cc: <x86@kernel.org>
> > > Cc: <kvm@vger.kernel.org>
> > > ---
> >
> > ...
> >
> > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > > index fbeaa9ddef598..9306d99585188 100644
> > > --- a/arch/x86/kvm/Kconfig
> > > +++ b/arch/x86/kvm/Kconfig
> > > @@ -46,7 +46,6 @@ config KVM
> > > select KVM_XFER_TO_GUEST_WORK
> > > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > > select KVM_VFIO
> > > - select SRCU
> >
> > Would it be too much trouble to bundle all of the KVM changes into a single patch?
> > The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> > purely because of KVM's somewhat roundabout Kconfig setup.
>
> No problem, and will do on my next rebase. I might end up with a long
> list of Cc's, but so it goes. I will of course send the result as a
> reply to this message.
Like this? (Given the acks, the Cc list wasn't as long as I feared that
it would be.)
Thanx, Paul
------------------------------------------------------------------------
commit 8bde7256e3bdcf4519ee783b0bd919685b960402
Author: Paul E. McKenney <paulmck@kernel.org>
Date: Tue Nov 22 15:45:39 2022 -0800
kvm: Remove "select SRCU"
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements from the various KVM Kconfig files.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <kvm@vger.kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org>
Acked-by: Anup Patel <anup@brainfault.org>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index 05da3c8f7e88f..312f0e9869111 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -28,7 +28,6 @@ menuconfig KVM
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_XFER_TO_GUEST_WORK
- select SRCU
select KVM_VFIO
select HAVE_KVM_EVENTFD
select HAVE_KVM_IRQFD
diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig
index 91d197bee9c0a..591f46a5d7be1 100644
--- a/arch/mips/kvm/Kconfig
+++ b/arch/mips/kvm/Kconfig
@@ -26,7 +26,6 @@ config KVM
select HAVE_KVM_VCPU_ASYNC_IOCTL
select KVM_MMIO
select MMU_NOTIFIER
- select SRCU
select INTERVAL_TREE
help
Support for hosting Guest kernels.
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index a9f57dad6d916..902611954200d 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
select PREEMPT_NOTIFIERS
select HAVE_KVM_EVENTFD
select HAVE_KVM_VCPU_ASYNC_IOCTL
- select SRCU
select KVM_VFIO
select IRQ_BYPASS_MANAGER
select HAVE_KVM_IRQ_BYPASS
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index f36a737d5f96d..6bc9b290c1283 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -27,7 +27,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select HAVE_KVM_VCPU_ASYNC_IOCTL
select HAVE_KVM_EVENTFD
- select SRCU
help
Support hosting virtualized guest machines.
diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig
index 33f4ff909476c..45fdf2a9b2e32 100644
--- a/arch/s390/kvm/Kconfig
+++ b/arch/s390/kvm/Kconfig
@@ -31,7 +31,6 @@ config KVM
select HAVE_KVM_IRQ_ROUTING
select HAVE_KVM_INVALID_WAKEUPS
select HAVE_KVM_NO_POLL
- select SRCU
select KVM_VFIO
select INTERVAL_TREE
select MMU_NOTIFIER
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index fbeaa9ddef598..9306d99585188 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -46,7 +46,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_VFIO
- select SRCU
select INTERVAL_TREE
select HAVE_KVM_PM_NOTIFIER if PM
help
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-09 20:05 ` Paul E. McKenney
@ 2023-01-10 19:55 ` Sean Christopherson
2023-01-12 0:05 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Sean Christopherson @ 2023-01-10 19:55 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Paolo Bonzini, x86, kvm
On Mon, Jan 09, 2023, Paul E. McKenney wrote:
> On Mon, Jan 09, 2023 at 11:22:28AM -0800, Paul E. McKenney wrote:
> > On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> > > On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > > > Kconfig statements.
> > > >
> > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > Cc: Ingo Molnar <mingo@redhat.com>
> > > > Cc: Borislav Petkov <bp@alien8.de>
> > > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > > Cc: Sean Christopherson <seanjc@google.com>
> > > > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > > > Cc: <x86@kernel.org>
> > > > Cc: <kvm@vger.kernel.org>
> > > > ---
> > >
> > > ...
> > >
> > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > > > index fbeaa9ddef598..9306d99585188 100644
> > > > --- a/arch/x86/kvm/Kconfig
> > > > +++ b/arch/x86/kvm/Kconfig
> > > > @@ -46,7 +46,6 @@ config KVM
> > > > select KVM_XFER_TO_GUEST_WORK
> > > > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > > > select KVM_VFIO
> > > > - select SRCU
> > >
> > > Would it be too much trouble to bundle all of the KVM changes into a single patch?
> > > The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> > > purely because of KVM's somewhat roundabout Kconfig setup.
> >
> > No problem, and will do on my next rebase. I might end up with a long
> > list of Cc's, but so it goes. I will of course send the result as a
> > reply to this message.
>
> Like this?
Ya, looks good!
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 01/27] arch/x86: Remove "select SRCU"
2023-01-10 19:55 ` Sean Christopherson
@ 2023-01-12 0:05 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-12 0:05 UTC (permalink / raw)
To: Sean Christopherson
Cc: rcu, linux-kernel, kernel-team, rostedt, Thomas Gleixner,
Ingo Molnar, Borislav Petkov, Dave Hansen, H. Peter Anvin,
Paolo Bonzini, x86, kvm
On Tue, Jan 10, 2023 at 07:55:13PM +0000, Sean Christopherson wrote:
> On Mon, Jan 09, 2023, Paul E. McKenney wrote:
> > On Mon, Jan 09, 2023 at 11:22:28AM -0800, Paul E. McKenney wrote:
> > > On Mon, Jan 09, 2023 at 05:43:23PM +0000, Sean Christopherson wrote:
> > > > On Wed, Jan 04, 2023, Paul E. McKenney wrote:
> > > > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > > > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > > > > Kconfig statements.
> > > > >
> > > > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > > > > Cc: Thomas Gleixner <tglx@linutronix.de>
> > > > > Cc: Ingo Molnar <mingo@redhat.com>
> > > > > Cc: Borislav Petkov <bp@alien8.de>
> > > > > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > > > > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > > > > Cc: Sean Christopherson <seanjc@google.com>
> > > > > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > > > > Cc: <x86@kernel.org>
> > > > > Cc: <kvm@vger.kernel.org>
> > > > > ---
> > > >
> > > > ...
> > > >
> > > > > diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
> > > > > index fbeaa9ddef598..9306d99585188 100644
> > > > > --- a/arch/x86/kvm/Kconfig
> > > > > +++ b/arch/x86/kvm/Kconfig
> > > > > @@ -46,7 +46,6 @@ config KVM
> > > > > select KVM_XFER_TO_GUEST_WORK
> > > > > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > > > > select KVM_VFIO
> > > > > - select SRCU
> > > >
> > > > Would it be too much trouble to bundle all of the KVM changes into a single patch?
> > > > The SRCU requirement is a generic KVM requirement that's handled in the arch Kconfigs
> > > > purely because of KVM's somewhat roundabout Kconfig setup.
> > >
> > > No problem, and will do on my next rebase. I might end up with a long
> > > list of Cc's, but so it goes. I will of course send the result as a
> > > reply to this message.
> >
> > Like this?
>
> Ya, looks good!
Glad you like it! May I have your ack? Or would you take this one?
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 02/27] arch/arm64/kvm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 01/27] arch/x86: Remove "select SRCU" Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 9:38 ` Marc Zyngier
2023-01-05 0:37 ` [PATCH rcu 03/27] arch/mips/kvm: " Paul E. McKenney
` (26 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Marc Zyngier, James Morse, Alexandru Elisei, Suzuki K Poulose,
Oliver Upton, Catalin Marinas, Will Deacon, linux-arm-kernel,
kvmarm, kvmarm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Marc Zyngier <maz@kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Alexandru Elisei <alexandru.elisei@arm.com>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
Cc: Oliver Upton <oliver.upton@linux.dev>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>
Cc: <kvmarm@lists.linux.dev>
Cc: <kvmarm@lists.cs.columbia.edu>
---
arch/arm64/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index 05da3c8f7e88f..312f0e9869111 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -28,7 +28,6 @@ menuconfig KVM
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_XFER_TO_GUEST_WORK
- select SRCU
select KVM_VFIO
select HAVE_KVM_EVENTFD
select HAVE_KVM_IRQFD
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 02/27] arch/arm64/kvm: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 02/27] arch/arm64/kvm: " Paul E. McKenney
@ 2023-01-05 9:38 ` Marc Zyngier
2023-01-05 15:42 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Marc Zyngier @ 2023-01-05 9:38 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, James Morse,
Alexandru Elisei, Suzuki K Poulose, Oliver Upton,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm, kvmarm
On Thu, 05 Jan 2023 00:37:48 +0000,
"Paul E. McKenney" <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Marc Zyngier <maz@kernel.org>
> Cc: James Morse <james.morse@arm.com>
> Cc: Alexandru Elisei <alexandru.elisei@arm.com>
> Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> Cc: Oliver Upton <oliver.upton@linux.dev>
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: <linux-arm-kernel@lists.infradead.org>
> Cc: <kvmarm@lists.linux.dev>
> Cc: <kvmarm@lists.cs.columbia.edu>
> ---
> arch/arm64/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
> index 05da3c8f7e88f..312f0e9869111 100644
> --- a/arch/arm64/kvm/Kconfig
> +++ b/arch/arm64/kvm/Kconfig
> @@ -28,7 +28,6 @@ menuconfig KVM
> select KVM_MMIO
> select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> select KVM_XFER_TO_GUEST_WORK
> - select SRCU
> select KVM_VFIO
> select HAVE_KVM_EVENTFD
> select HAVE_KVM_IRQFD
Acked-by: Marc Zyngier <maz@kernel.org>
M.
--
Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 02/27] arch/arm64/kvm: Remove "select SRCU"
2023-01-05 9:38 ` Marc Zyngier
@ 2023-01-05 15:42 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:42 UTC (permalink / raw)
To: Marc Zyngier
Cc: rcu, linux-kernel, kernel-team, rostedt, James Morse,
Alexandru Elisei, Suzuki K Poulose, Oliver Upton,
Catalin Marinas, Will Deacon, linux-arm-kernel, kvmarm, kvmarm
On Thu, Jan 05, 2023 at 09:38:01AM +0000, Marc Zyngier wrote:
> On Thu, 05 Jan 2023 00:37:48 +0000,
> "Paul E. McKenney" <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Marc Zyngier <maz@kernel.org>
> > Cc: James Morse <james.morse@arm.com>
> > Cc: Alexandru Elisei <alexandru.elisei@arm.com>
> > Cc: Suzuki K Poulose <suzuki.poulose@arm.com>
> > Cc: Oliver Upton <oliver.upton@linux.dev>
> > Cc: Catalin Marinas <catalin.marinas@arm.com>
> > Cc: Will Deacon <will@kernel.org>
> > Cc: <linux-arm-kernel@lists.infradead.org>
> > Cc: <kvmarm@lists.linux.dev>
> > Cc: <kvmarm@lists.cs.columbia.edu>
> > ---
> > arch/arm64/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
> > index 05da3c8f7e88f..312f0e9869111 100644
> > --- a/arch/arm64/kvm/Kconfig
> > +++ b/arch/arm64/kvm/Kconfig
> > @@ -28,7 +28,6 @@ menuconfig KVM
> > select KVM_MMIO
> > select KVM_GENERIC_DIRTYLOG_READ_PROTECT
> > select KVM_XFER_TO_GUEST_WORK
> > - select SRCU
> > select KVM_VFIO
> > select HAVE_KVM_EVENTFD
> > select HAVE_KVM_IRQFD
>
> Acked-by: Marc Zyngier <maz@kernel.org>
Thank you, Marc! I will apply this on my next rebase.
Thanx, Paul
> M.
>
> --
> Without deviation from the norm, progress is not possible.
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 03/27] arch/mips/kvm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 01/27] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 02/27] arch/arm64/kvm: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 0:37 ` [PATCH rcu 04/27] arch/powerpc/kvm: " Paul E. McKenney
` (25 subsequent siblings)
28 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Huacai Chen, Aleksandar Markovic, Thomas Bogendoerfer,
linux-mips, kvm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: <linux-mips@vger.kernel.org>
Cc: <kvm@vger.kernel.org>
---
arch/mips/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig
index 91d197bee9c0a..591f46a5d7be1 100644
--- a/arch/mips/kvm/Kconfig
+++ b/arch/mips/kvm/Kconfig
@@ -26,7 +26,6 @@ config KVM
select HAVE_KVM_VCPU_ASYNC_IOCTL
select KVM_MMIO
select MMU_NOTIFIER
- select SRCU
select INTERVAL_TREE
help
Support for hosting Guest kernels.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 04/27] arch/powerpc/kvm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (2 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 03/27] arch/mips/kvm: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-11 23:49 ` Michael Ellerman
2023-01-05 0:37 ` [PATCH rcu 05/27] arch/riscv/kvm: " Paul E. McKenney
` (24 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Michael Ellerman, Nicholas Piggin, Christophe Leroy,
linuxppc-dev
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: <linuxppc-dev@lists.ozlabs.org>
---
arch/powerpc/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index a9f57dad6d916..902611954200d 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
select PREEMPT_NOTIFIERS
select HAVE_KVM_EVENTFD
select HAVE_KVM_VCPU_ASYNC_IOCTL
- select SRCU
select KVM_VFIO
select IRQ_BYPASS_MANAGER
select HAVE_KVM_IRQ_BYPASS
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 04/27] arch/powerpc/kvm: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 04/27] arch/powerpc/kvm: " Paul E. McKenney
@ 2023-01-11 23:49 ` Michael Ellerman
2023-01-12 0:01 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Michael Ellerman @ 2023-01-11 23:49 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Nicholas Piggin, Christophe Leroy, linuxppc-dev
"Paul E. McKenney" <paulmck@kernel.org> writes:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Nicholas Piggin <npiggin@gmail.com>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: <linuxppc-dev@lists.ozlabs.org>
> ---
> arch/powerpc/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
cheers
> diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> index a9f57dad6d916..902611954200d 100644
> --- a/arch/powerpc/kvm/Kconfig
> +++ b/arch/powerpc/kvm/Kconfig
> @@ -22,7 +22,6 @@ config KVM
> select PREEMPT_NOTIFIERS
> select HAVE_KVM_EVENTFD
> select HAVE_KVM_VCPU_ASYNC_IOCTL
> - select SRCU
> select KVM_VFIO
> select IRQ_BYPASS_MANAGER
> select HAVE_KVM_IRQ_BYPASS
> --
> 2.31.1.189.g2e36527f23
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 04/27] arch/powerpc/kvm: Remove "select SRCU"
2023-01-11 23:49 ` Michael Ellerman
@ 2023-01-12 0:01 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-12 0:01 UTC (permalink / raw)
To: Michael Ellerman
Cc: rcu, linux-kernel, kernel-team, rostedt, Nicholas Piggin,
Christophe Leroy, linuxppc-dev
On Thu, Jan 12, 2023 at 10:49:04AM +1100, Michael Ellerman wrote:
> "Paul E. McKenney" <paulmck@kernel.org> writes:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Nicholas Piggin <npiggin@gmail.com>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: <linuxppc-dev@lists.ozlabs.org>
> > ---
> > arch/powerpc/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Thank you! I will apply on the next rebase.
Thanx, Paul
> cheers
>
> > diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
> > index a9f57dad6d916..902611954200d 100644
> > --- a/arch/powerpc/kvm/Kconfig
> > +++ b/arch/powerpc/kvm/Kconfig
> > @@ -22,7 +22,6 @@ config KVM
> > select PREEMPT_NOTIFIERS
> > select HAVE_KVM_EVENTFD
> > select HAVE_KVM_VCPU_ASYNC_IOCTL
> > - select SRCU
> > select KVM_VFIO
> > select IRQ_BYPASS_MANAGER
> > select HAVE_KVM_IRQ_BYPASS
> > --
> > 2.31.1.189.g2e36527f23
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 05/27] arch/riscv/kvm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (3 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 04/27] arch/powerpc/kvm: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-07 9:58 ` Anup Patel
2023-01-05 0:37 ` [PATCH rcu 06/27] arch/s390/kvm: " Paul E. McKenney
` (23 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Anup Patel,
Atish Patra, Paul Walmsley, Palmer Dabbelt, Albert Ou, kvm,
kvm-riscv, linux-riscv
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Anup Patel <anup@brainfault.org>
Cc: Atish Patra <atishp@atishpatra.org>
Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: <kvm@vger.kernel.org>
Cc: <kvm-riscv@lists.infradead.org>
Cc: <linux-riscv@lists.infradead.org>
---
arch/riscv/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index f36a737d5f96d..6bc9b290c1283 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -27,7 +27,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select HAVE_KVM_VCPU_ASYNC_IOCTL
select HAVE_KVM_EVENTFD
- select SRCU
help
Support hosting virtualized guest machines.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 05/27] arch/riscv/kvm: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 05/27] arch/riscv/kvm: " Paul E. McKenney
@ 2023-01-07 9:58 ` Anup Patel
2023-01-07 16:03 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Anup Patel @ 2023-01-07 9:58 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Atish Patra,
Paul Walmsley, Palmer Dabbelt, Albert Ou, kvm, kvm-riscv,
linux-riscv
On Thu, Jan 5, 2023 at 6:08 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Anup Patel <anup@brainfault.org>
> Cc: Atish Patra <atishp@atishpatra.org>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: <kvm@vger.kernel.org>
> Cc: <kvm-riscv@lists.infradead.org>
> Cc: <linux-riscv@lists.infradead.org>
For KVM RISC-V:
Acked-by: Anup Patel <anup@brainfault.org>
Thanks,
Anup
> ---
> arch/riscv/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> index f36a737d5f96d..6bc9b290c1283 100644
> --- a/arch/riscv/kvm/Kconfig
> +++ b/arch/riscv/kvm/Kconfig
> @@ -27,7 +27,6 @@ config KVM
> select KVM_XFER_TO_GUEST_WORK
> select HAVE_KVM_VCPU_ASYNC_IOCTL
> select HAVE_KVM_EVENTFD
> - select SRCU
> help
> Support hosting virtualized guest machines.
>
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 05/27] arch/riscv/kvm: Remove "select SRCU"
2023-01-07 9:58 ` Anup Patel
@ 2023-01-07 16:03 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-07 16:03 UTC (permalink / raw)
To: Anup Patel
Cc: rcu, linux-kernel, kernel-team, rostedt, Atish Patra,
Paul Walmsley, Palmer Dabbelt, Albert Ou, kvm, kvm-riscv,
linux-riscv
On Sat, Jan 07, 2023 at 03:28:06PM +0530, Anup Patel wrote:
> On Thu, Jan 5, 2023 at 6:08 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Anup Patel <anup@brainfault.org>
> > Cc: Atish Patra <atishp@atishpatra.org>
> > Cc: Paul Walmsley <paul.walmsley@sifive.com>
> > Cc: Palmer Dabbelt <palmer@dabbelt.com>
> > Cc: Albert Ou <aou@eecs.berkeley.edu>
> > Cc: <kvm@vger.kernel.org>
> > Cc: <kvm-riscv@lists.infradead.org>
> > Cc: <linux-riscv@lists.infradead.org>
>
> For KVM RISC-V:
> Acked-by: Anup Patel <anup@brainfault.org>
Thank you, Anup! I will apply this on my next rebase.
Thanx, Paul
> Thanks,
> Anup
>
> > ---
> > arch/riscv/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
> > index f36a737d5f96d..6bc9b290c1283 100644
> > --- a/arch/riscv/kvm/Kconfig
> > +++ b/arch/riscv/kvm/Kconfig
> > @@ -27,7 +27,6 @@ config KVM
> > select KVM_XFER_TO_GUEST_WORK
> > select HAVE_KVM_VCPU_ASYNC_IOCTL
> > select HAVE_KVM_EVENTFD
> > - select SRCU
> > help
> > Support hosting virtualized guest machines.
> >
> > --
> > 2.31.1.189.g2e36527f23
> >
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 06/27] arch/s390/kvm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (4 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 05/27] arch/riscv/kvm: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 8:06 ` Heiko Carstens
2023-01-05 0:37 ` [PATCH rcu 07/27] block: " Paul E. McKenney
` (22 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Christian Borntraeger, Janosch Frank, Claudio Imbrenda,
David Hildenbrand, Heiko Carstens, Vasily Gorbik,
Alexander Gordeev, Sven Schnelle, kvm, linux-s390
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
Cc: Janosch Frank <frankja@linux.ibm.com>
Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
Cc: David Hildenbrand <david@redhat.com>
Cc: Heiko Carstens <hca@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>
Cc: Sven Schnelle <svens@linux.ibm.com>
Cc: <kvm@vger.kernel.org>
Cc: <linux-s390@vger.kernel.org>
---
arch/s390/kvm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig
index 33f4ff909476c..45fdf2a9b2e32 100644
--- a/arch/s390/kvm/Kconfig
+++ b/arch/s390/kvm/Kconfig
@@ -31,7 +31,6 @@ config KVM
select HAVE_KVM_IRQ_ROUTING
select HAVE_KVM_INVALID_WAKEUPS
select HAVE_KVM_NO_POLL
- select SRCU
select KVM_VFIO
select INTERVAL_TREE
select MMU_NOTIFIER
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 06/27] arch/s390/kvm: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 06/27] arch/s390/kvm: " Paul E. McKenney
@ 2023-01-05 8:06 ` Heiko Carstens
2023-01-05 15:30 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Heiko Carstens @ 2023-01-05 8:06 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Christian Borntraeger,
Janosch Frank, Claudio Imbrenda, David Hildenbrand,
Vasily Gorbik, Alexander Gordeev, Sven Schnelle, kvm, linux-s390
On Wed, Jan 04, 2023 at 04:37:52PM -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Janosch Frank <frankja@linux.ibm.com>
> Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
> Cc: David Hildenbrand <david@redhat.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: <kvm@vger.kernel.org>
> Cc: <linux-s390@vger.kernel.org>
> ---
> arch/s390/kvm/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Acked-by: Heiko Carstens <hca@linux.ibm.com>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 06/27] arch/s390/kvm: Remove "select SRCU"
2023-01-05 8:06 ` Heiko Carstens
@ 2023-01-05 15:30 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:30 UTC (permalink / raw)
To: Heiko Carstens
Cc: rcu, linux-kernel, kernel-team, rostedt, Christian Borntraeger,
Janosch Frank, Claudio Imbrenda, David Hildenbrand,
Vasily Gorbik, Alexander Gordeev, Sven Schnelle, kvm, linux-s390
On Thu, Jan 05, 2023 at 09:06:26AM +0100, Heiko Carstens wrote:
> On Wed, Jan 04, 2023 at 04:37:52PM -0800, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> > Cc: Janosch Frank <frankja@linux.ibm.com>
> > Cc: Claudio Imbrenda <imbrenda@linux.ibm.com>
> > Cc: David Hildenbrand <david@redhat.com>
> > Cc: Heiko Carstens <hca@linux.ibm.com>
> > Cc: Vasily Gorbik <gor@linux.ibm.com>
> > Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> > Cc: Sven Schnelle <svens@linux.ibm.com>
> > Cc: <kvm@vger.kernel.org>
> > Cc: <linux-s390@vger.kernel.org>
> > ---
> > arch/s390/kvm/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
>
> Acked-by: Heiko Carstens <hca@linux.ibm.com>
Thank you, Heiko! I will apply on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (5 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 06/27] arch/s390/kvm: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 0:43 ` Jens Axboe
2023-01-05 0:37 ` [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
` (21 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jens Axboe,
linux-block
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: linux-block@vger.kernel.org
---
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/Kconfig b/block/Kconfig
index 444c5ab3b67e2..5d9d9c84d5165 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -6,7 +6,6 @@ menuconfig BLOCK
bool "Enable the block layer" if EXPERT
default y
select SBITMAP
- select SRCU
help
Provide block layer support for the kernel.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 07/27] block: " Paul E. McKenney
@ 2023-01-05 0:43 ` Jens Axboe
2023-01-05 8:05 ` Heiko Carstens
0 siblings, 1 reply; 126+ messages in thread
From: Jens Axboe @ 2023-01-05 0:43 UTC (permalink / raw)
To: Paul E. McKenney, rcu; +Cc: linux-kernel, kernel-team, rostedt, linux-block
On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
I'm assuming something earlier made this true (only CC'ed on this patch,
not the cover letter or interesting btis...), then:
Reviewed-by: Jens Axboe <axboe@kernel.dk>
--
Jens Axboe
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 0:43 ` Jens Axboe
@ 2023-01-05 8:05 ` Heiko Carstens
2023-01-05 15:33 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Heiko Carstens @ 2023-01-05 8:05 UTC (permalink / raw)
To: Jens Axboe
Cc: Paul E. McKenney, rcu, linux-kernel, kernel-team, rostedt, linux-block
On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> I'm assuming something earlier made this true (only CC'ed on this patch,
> not the cover letter or interesting btis...), then:
I was wondering the same. But it is already unconditionally enabled
since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 8:05 ` Heiko Carstens
@ 2023-01-05 15:33 ` Paul E. McKenney
2023-01-05 15:36 ` Jens Axboe
0 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:33 UTC (permalink / raw)
To: Heiko Carstens
Cc: Jens Axboe, rcu, linux-kernel, kernel-team, rostedt, linux-block
On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> > On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> > > Now that the SRCU Kconfig option is unconditionally selected, there is
> > > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > > Kconfig statements.
> >
> > I'm assuming something earlier made this true (only CC'ed on this patch,
> > not the cover letter or interesting btis...), then:
>
> I was wondering the same. But it is already unconditionally enabled
> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
Ah, apologies for the terseness!
I took the coward's way out by making CONFIG_SRCU unconditional during
the last merge window and removing all references during this merge
window. ;-)
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 15:33 ` Paul E. McKenney
@ 2023-01-05 15:36 ` Jens Axboe
2023-01-05 15:48 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Jens Axboe @ 2023-01-05 15:36 UTC (permalink / raw)
To: paulmck, Heiko Carstens
Cc: rcu, linux-kernel, kernel-team, rostedt, linux-block
On 1/5/23 8:33 AM, Paul E. McKenney wrote:
> On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
>> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
>>> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
>>>> Now that the SRCU Kconfig option is unconditionally selected, there is
>>>> no longer any point in selecting it. Therefore, remove the "select SRCU"
>>>> Kconfig statements.
>>>
>>> I'm assuming something earlier made this true (only CC'ed on this patch,
>>> not the cover letter or interesting btis...), then:
>>
>> I was wondering the same. But it is already unconditionally enabled
>> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
>
> Ah, apologies for the terseness!
>
> I took the coward's way out by making CONFIG_SRCU unconditional during
> the last merge window and removing all references during this merge
> window. ;-)
Are you intending for maintainers to pick up these patches, or are you
collecting acks for sending the series separately? That part is also
not clear :-)
--
Jens Axboe
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 07/27] block: Remove "select SRCU"
2023-01-05 15:36 ` Jens Axboe
@ 2023-01-05 15:48 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:48 UTC (permalink / raw)
To: Jens Axboe
Cc: Heiko Carstens, rcu, linux-kernel, kernel-team, rostedt, linux-block
On Thu, Jan 05, 2023 at 08:36:43AM -0700, Jens Axboe wrote:
> On 1/5/23 8:33 AM, Paul E. McKenney wrote:
> > On Thu, Jan 05, 2023 at 09:05:47AM +0100, Heiko Carstens wrote:
> >> On Wed, Jan 04, 2023 at 05:43:07PM -0700, Jens Axboe wrote:
> >>> On 1/4/23 5:37 PM, Paul E. McKenney wrote:
> >>>> Now that the SRCU Kconfig option is unconditionally selected, there is
> >>>> no longer any point in selecting it. Therefore, remove the "select SRCU"
> >>>> Kconfig statements.
> >>>
> >>> I'm assuming something earlier made this true (only CC'ed on this patch,
> >>> not the cover letter or interesting btis...), then:
> >>
> >> I was wondering the same. But it is already unconditionally enabled
> >> since commit 0cd7e350abc4 ("rcu: Make SRCU mandatory").
> >
> > Ah, apologies for the terseness!
> >
> > I took the coward's way out by making CONFIG_SRCU unconditional during
> > the last merge window and removing all references during this merge
> > window. ;-)
>
> Are you intending for maintainers to pick up these patches, or are you
> collecting acks for sending the series separately? That part is also
> not clear :-)
Fair point!
Maintainer's choice. By default, I collect acks and send it. But if
(for example) this change is in a high-traffic area, the maintainer
might want to take it, in which case I drop it from my tree.
Either way works for me, as long as you let me know. ;-)
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (6 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 07/27] block: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 11:23 ` Greg Kroah-Hartman
2023-01-05 0:37 ` [PATCH rcu 09/27] drivers/clk: Remove "select SRCU" Paul E. McKenney
` (20 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Greg Kroah-Hartman, Rafael J. Wysocki
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef and throw away the #else clause.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
---
drivers/base/core.c | 42 ------------------------------------------
1 file changed, 42 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index a3e14143ec0cf..bb36aca8d1b7a 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -181,7 +181,6 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
}
EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers);
-#ifdef CONFIG_SRCU
static DEFINE_MUTEX(device_links_lock);
DEFINE_STATIC_SRCU(device_links_srcu);
@@ -220,47 +219,6 @@ static void device_link_remove_from_lists(struct device_link *link)
list_del_rcu(&link->s_node);
list_del_rcu(&link->c_node);
}
-#else /* !CONFIG_SRCU */
-static DECLARE_RWSEM(device_links_lock);
-
-static inline void device_links_write_lock(void)
-{
- down_write(&device_links_lock);
-}
-
-static inline void device_links_write_unlock(void)
-{
- up_write(&device_links_lock);
-}
-
-int device_links_read_lock(void)
-{
- down_read(&device_links_lock);
- return 0;
-}
-
-void device_links_read_unlock(int not_used)
-{
- up_read(&device_links_lock);
-}
-
-#ifdef CONFIG_DEBUG_LOCK_ALLOC
-int device_links_read_lock_held(void)
-{
- return lockdep_is_held(&device_links_lock);
-}
-#endif
-
-static inline void device_link_synchronize_removal(void)
-{
-}
-
-static void device_link_remove_from_lists(struct device_link *link)
-{
- list_del(&link->s_node);
- list_del(&link->c_node);
-}
-#endif /* !CONFIG_SRCU */
static bool device_is_ancestor(struct device *dev, struct device *target)
{
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU
2023-01-05 0:37 ` [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-05 11:23 ` Greg Kroah-Hartman
0 siblings, 0 replies; 126+ messages in thread
From: Greg Kroah-Hartman @ 2023-01-05 11:23 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki
On Wed, Jan 04, 2023 at 04:37:54PM -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef and throw away the #else clause.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> ---
> drivers/base/core.c | 42 ------------------------------------------
> 1 file changed, 42 deletions(-)
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 09/27] drivers/clk: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (7 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 08/27] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
[not found] ` <c59b64de02161ceeed11b43230cd46d0.sboyd@kernel.org>
2023-01-05 0:37 ` [PATCH rcu 10/27] drivers/cpufreq: " Paul E. McKenney
` (19 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Michael Turquette, Stephen Boyd, linux-clk
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: <linux-clk@vger.kernel.org>
---
drivers/clk/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/clk/Kconfig b/drivers/clk/Kconfig
index d79905f3e1744..b6c5bf69a2b2c 100644
--- a/drivers/clk/Kconfig
+++ b/drivers/clk/Kconfig
@@ -23,7 +23,6 @@ menuconfig COMMON_CLK
depends on !HAVE_LEGACY_CLK
select HAVE_CLK_PREPARE
select HAVE_CLK
- select SRCU
select RATIONAL
help
The common clock framework is a single definition of struct
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 10/27] drivers/cpufreq: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (8 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 09/27] drivers/clk: Remove "select SRCU" Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 4:04 ` Viresh Kumar
2023-01-05 15:09 ` Rafael J. Wysocki
2023-01-05 0:37 ` [PATCH rcu 11/27] drivers/dax: " Paul E. McKenney
` (18 subsequent siblings)
28 siblings, 2 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Viresh Kumar, linux-pm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <linux-pm@vger.kernel.org>
---
drivers/cpufreq/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 2a84fc63371e2..785541df59379 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
config CPU_FREQ
bool "CPU Frequency scaling"
- select SRCU
help
CPU Frequency scaling allows you to change the clock speed of
CPUs on the fly. This is a nice method to save power, because
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 10/27] drivers/cpufreq: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 10/27] drivers/cpufreq: " Paul E. McKenney
@ 2023-01-05 4:04 ` Viresh Kumar
2023-01-05 15:09 ` Rafael J. Wysocki
1 sibling, 0 replies; 126+ messages in thread
From: Viresh Kumar @ 2023-01-05 4:04 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki, linux-pm
On 04-01-23, 16:37, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: <linux-pm@vger.kernel.org>
> ---
> drivers/cpufreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2a84fc63371e2..785541df59379 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
>
> config CPU_FREQ
> bool "CPU Frequency scaling"
> - select SRCU
> help
> CPU Frequency scaling allows you to change the clock speed of
> CPUs on the fly. This is a nice method to save power, because
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 10/27] drivers/cpufreq: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 10/27] drivers/cpufreq: " Paul E. McKenney
2023-01-05 4:04 ` Viresh Kumar
@ 2023-01-05 15:09 ` Rafael J. Wysocki
2023-01-05 15:51 ` Paul E. McKenney
1 sibling, 1 reply; 126+ messages in thread
From: Rafael J. Wysocki @ 2023-01-05 15:09 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki,
Viresh Kumar, linux-pm
On Thu, Jan 5, 2023 at 1:38 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: <linux-pm@vger.kernel.org>
Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> ---
> drivers/cpufreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2a84fc63371e2..785541df59379 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
>
> config CPU_FREQ
> bool "CPU Frequency scaling"
> - select SRCU
> help
> CPU Frequency scaling allows you to change the clock speed of
> CPUs on the fly. This is a nice method to save power, because
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 10/27] drivers/cpufreq: Remove "select SRCU"
2023-01-05 15:09 ` Rafael J. Wysocki
@ 2023-01-05 15:51 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:51 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar, linux-pm
On Thu, Jan 05, 2023 at 04:09:38PM +0100, Rafael J. Wysocki wrote:
> On Thu, Jan 5, 2023 at 1:38 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: <linux-pm@vger.kernel.org>
>
> Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
Thank you, Rafael! I will apply both on my next rebase.
Thanx, Paul
> > ---
> > drivers/cpufreq/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> > index 2a84fc63371e2..785541df59379 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
> >
> > config CPU_FREQ
> > bool "CPU Frequency scaling"
> > - select SRCU
> > help
> > CPU Frequency scaling allows you to change the clock speed of
> > CPUs on the fly. This is a nice method to save power, because
> > --
> > 2.31.1.189.g2e36527f23
> >
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 11/27] drivers/dax: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (9 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 10/27] drivers/cpufreq: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-05 16:48 ` Dan Williams
2023-01-05 0:37 ` [PATCH rcu 12/27] drivers/devfreq: " Paul E. McKenney
` (17 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Dan Williams, Vishal Verma, Dave Jiang, nvdimm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: <nvdimm@lists.linux.dev>
---
drivers/dax/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
index 5fdf269a822e5..2bf5123e48279 100644
--- a/drivers/dax/Kconfig
+++ b/drivers/dax/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
menuconfig DAX
tristate "DAX: direct access to differentiated memory"
- select SRCU
default m if NVDIMM_DAX
if DAX
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* RE: [PATCH rcu 11/27] drivers/dax: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 11/27] drivers/dax: " Paul E. McKenney
@ 2023-01-05 16:48 ` Dan Williams
2023-01-05 17:35 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Dan Williams @ 2023-01-05 16:48 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Dan Williams, Vishal Verma, Dave Jiang, nvdimm
Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vishal Verma <vishal.l.verma@intel.com>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: <nvdimm@lists.linux.dev>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Let me know if I should pick this up directly, otherwise I assume this
will go in along with the rest of the set.
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 11/27] drivers/dax: Remove "select SRCU"
2023-01-05 16:48 ` Dan Williams
@ 2023-01-05 17:35 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 17:35 UTC (permalink / raw)
To: Dan Williams
Cc: rcu, linux-kernel, kernel-team, rostedt, Vishal Verma,
Dave Jiang, nvdimm
On Thu, Jan 05, 2023 at 08:48:28AM -0800, Dan Williams wrote:
> Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Vishal Verma <vishal.l.verma@intel.com>
> > Cc: Dave Jiang <dave.jiang@intel.com>
> > Cc: <nvdimm@lists.linux.dev>
>
> Acked-by: Dan Williams <dan.j.williams@intel.com>
>
> Let me know if I should pick this up directly, otherwise I assume this
> will go in along with the rest of the set.
Thank you, Dan! I will apply your ack on my next rebase. I do plan to
send this along with the rest of the set, but if you do decide to take
it, please just let me know.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 12/27] drivers/devfreq: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (10 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 11/27] drivers/dax: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-10 13:07 ` Chanwoo Choi
2023-01-05 0:37 ` [PATCH rcu 13/27] drivers/hwtracing/stm: " Paul E. McKenney
` (16 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
MyungJoo Ham, Kyungmin Park, Chanwoo Choi, linux-pm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Chanwoo Choi <cw00.choi@samsung.com>
Cc: <linux-pm@vger.kernel.org>
---
drivers/devfreq/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index 9754d8b316211..3c4862a752b5a 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
menuconfig PM_DEVFREQ
bool "Generic Dynamic Voltage and Frequency Scaling (DVFS) support"
- select SRCU
select PM_OPP
help
A device may have a list of frequencies and voltages available.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 12/27] drivers/devfreq: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 12/27] drivers/devfreq: " Paul E. McKenney
@ 2023-01-10 13:07 ` Chanwoo Choi
2023-01-10 15:01 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Chanwoo Choi @ 2023-01-10 13:07 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, MyungJoo Ham, Kyungmin Park,
Chanwoo Choi, linux-pm
On 23. 1. 5. 09:37, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: <linux-pm@vger.kernel.org>
> ---
> drivers/devfreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 9754d8b316211..3c4862a752b5a 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -1,7 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> menuconfig PM_DEVFREQ
> bool "Generic Dynamic Voltage and Frequency Scaling (DVFS) support"
> - select SRCU
> select PM_OPP
> help
> A device may have a list of frequencies and voltages available.
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 12/27] drivers/devfreq: Remove "select SRCU"
2023-01-10 13:07 ` Chanwoo Choi
@ 2023-01-10 15:01 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-10 15:01 UTC (permalink / raw)
To: Chanwoo Choi
Cc: rcu, linux-kernel, kernel-team, rostedt, MyungJoo Ham,
Kyungmin Park, Chanwoo Choi, linux-pm, sfr
On Tue, Jan 10, 2023 at 10:07:54PM +0900, Chanwoo Choi wrote:
> On 23. 1. 5. 09:37, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Cc: Kyungmin Park <kyungmin.park@samsung.com>
> > Cc: Chanwoo Choi <cw00.choi@samsung.com>
> > Cc: <linux-pm@vger.kernel.org>
> > ---
> > drivers/devfreq/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> > index 9754d8b316211..3c4862a752b5a 100644
> > --- a/drivers/devfreq/Kconfig
> > +++ b/drivers/devfreq/Kconfig
> > @@ -1,7 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > menuconfig PM_DEVFREQ
> > bool "Generic Dynamic Voltage and Frequency Scaling (DVFS) support"
> > - select SRCU
> > select PM_OPP
> > help
> > A device may have a list of frequencies and voltages available.
>
> Applied it. Thanks.
Thank you! I will drop mine on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 13/27] drivers/hwtracing/stm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (11 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 12/27] drivers/devfreq: " Paul E. McKenney
@ 2023-01-05 0:37 ` Paul E. McKenney
2023-01-13 13:19 ` Alexander Shishkin
2023-01-05 0:38 ` [PATCH rcu 14/27] drivers/md: " Paul E. McKenney
` (15 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:37 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Alexander Shishkin, Maxime Coquelin, Alexandre Torgue,
linux-stm32, linux-arm-kernel
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: <linux-stm32@st-md-mailman.stormreply.com>
Cc: <linux-arm-kernel@lists.infradead.org>
---
drivers/hwtracing/stm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index aad594fe79cc5..eda6b11d40a1f 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -2,7 +2,6 @@
config STM
tristate "System Trace Module devices"
select CONFIGFS_FS
- select SRCU
help
A System Trace Module (STM) is a device exporting data in System
Trace Protocol (STP) format as defined by MIPI STP standards.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 13/27] drivers/hwtracing/stm: Remove "select SRCU"
2023-01-05 0:37 ` [PATCH rcu 13/27] drivers/hwtracing/stm: " Paul E. McKenney
@ 2023-01-13 13:19 ` Alexander Shishkin
0 siblings, 0 replies; 126+ messages in thread
From: Alexander Shishkin @ 2023-01-13 13:19 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel,
alexander.shishkin
"Paul E. McKenney" <paulmck@kernel.org> writes:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Thanks,
--
Alex
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 14/27] drivers/md: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (12 preceding siblings ...)
2023-01-05 0:37 ` [PATCH rcu 13/27] drivers/hwtracing/stm: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 0:44 ` Song Liu
2023-01-05 0:38 ` [PATCH rcu 15/27] drivers/net: " Paul E. McKenney
` (14 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Song Liu,
Alasdair Kergon, Mike Snitzer, dm-devel, linux-raid
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: <dm-devel@redhat.com>
Cc: <linux-raid@vger.kernel.org>
---
drivers/md/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index 998a5cfdbc4e9..5f1e2593fad7e 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -6,7 +6,6 @@
menuconfig MD
bool "Multiple devices driver support (RAID and LVM)"
depends on BLOCK
- select SRCU
help
Support multiple physical spindles through a single logical device.
Required for RAID and logical volume management.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 14/27] drivers/md: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 14/27] drivers/md: " Paul E. McKenney
@ 2023-01-05 0:44 ` Song Liu
0 siblings, 0 replies; 126+ messages in thread
From: Song Liu @ 2023-01-05 0:44 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Alasdair Kergon,
Mike Snitzer, dm-devel, linux-raid
On Wed, Jan 4, 2023 at 4:38 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Song Liu <song@kernel.org>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: <dm-devel@redhat.com>
> Cc: <linux-raid@vger.kernel.org>
Acked-by: Song Liu <song@kernel.org>
> ---
> drivers/md/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
> index 998a5cfdbc4e9..5f1e2593fad7e 100644
> --- a/drivers/md/Kconfig
> +++ b/drivers/md/Kconfig
> @@ -6,7 +6,6 @@
> menuconfig MD
> bool "Multiple devices driver support (RAID and LVM)"
> depends on BLOCK
> - select SRCU
> help
> Support multiple physical spindles through a single logical device.
> Required for RAID and logical volume management.
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 15/27] drivers/net: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (13 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 14/27] drivers/md: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 1:28 ` Jakub Kicinski
2023-01-05 0:38 ` [PATCH rcu 16/27] drivers/opp: " Paul E. McKenney
` (13 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>
---
drivers/net/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9e63b8c43f3e2..12910338ea1a0 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -334,7 +334,6 @@ config NETCONSOLE_DYNAMIC
config NETPOLL
def_bool NETCONSOLE
- select SRCU
config NET_POLL_CONTROLLER
def_bool NETPOLL
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 15/27] drivers/net: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 15/27] drivers/net: " Paul E. McKenney
@ 2023-01-05 1:28 ` Jakub Kicinski
0 siblings, 0 replies; 126+ messages in thread
From: Jakub Kicinski @ 2023-01-05 1:28 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, David S. Miller,
Eric Dumazet, Paolo Abeni, netdev
On Wed, 4 Jan 2023 16:38:01 -0800 Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Eric Dumazet <edumazet@google.com>
> Cc: Jakub Kicinski <kuba@kernel.org>
> Cc: Paolo Abeni <pabeni@redhat.com>
> Cc: <netdev@vger.kernel.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 16/27] drivers/opp: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (14 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 15/27] drivers/net: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 4:06 ` Viresh Kumar
2023-01-05 6:17 ` Viresh Kumar
2023-01-05 0:38 ` [PATCH rcu 17/27] drivers/pci/controller: " Paul E. McKenney
` (12 subsequent siblings)
28 siblings, 2 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Viresh Kumar, Nishanth Menon, Stephen Boyd, linux-pm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Viresh Kumar <vireshk@kernel.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: <linux-pm@vger.kernel.org>
---
drivers/opp/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/opp/Kconfig b/drivers/opp/Kconfig
index e8ce47b327359..d7c649a1a981c 100644
--- a/drivers/opp/Kconfig
+++ b/drivers/opp/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config PM_OPP
bool
- select SRCU
help
SOCs have a standard set of tuples consisting of frequency and
voltage pairs that the device will support per voltage domain. This
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 16/27] drivers/opp: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 16/27] drivers/opp: " Paul E. McKenney
@ 2023-01-05 4:06 ` Viresh Kumar
2023-01-05 4:50 ` Paul E. McKenney
2023-01-05 6:17 ` Viresh Kumar
1 sibling, 1 reply; 126+ messages in thread
From: Viresh Kumar @ 2023-01-05 4:06 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar,
Nishanth Menon, Stephen Boyd, linux-pm
On 04-01-23, 16:38, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: <linux-pm@vger.kernel.org>
> ---
> drivers/opp/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/opp/Kconfig b/drivers/opp/Kconfig
> index e8ce47b327359..d7c649a1a981c 100644
> --- a/drivers/opp/Kconfig
> +++ b/drivers/opp/Kconfig
> @@ -1,7 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config PM_OPP
> bool
> - select SRCU
> help
> SOCs have a standard set of tuples consisting of frequency and
> voltage pairs that the device will support per voltage domain. This
Paul,
Should I apply this in my tree ? Or you plan to merge all the patches
yourself ?
--
viresh
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 16/27] drivers/opp: Remove "select SRCU"
2023-01-05 4:06 ` Viresh Kumar
@ 2023-01-05 4:50 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 4:50 UTC (permalink / raw)
To: Viresh Kumar
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar,
Nishanth Menon, Stephen Boyd, linux-pm
On Thu, Jan 05, 2023 at 09:36:16AM +0530, Viresh Kumar wrote:
> On 04-01-23, 16:38, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Viresh Kumar <vireshk@kernel.org>
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: <linux-pm@vger.kernel.org>
> > ---
> > drivers/opp/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/opp/Kconfig b/drivers/opp/Kconfig
> > index e8ce47b327359..d7c649a1a981c 100644
> > --- a/drivers/opp/Kconfig
> > +++ b/drivers/opp/Kconfig
> > @@ -1,7 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config PM_OPP
> > bool
> > - select SRCU
> > help
> > SOCs have a standard set of tuples consisting of frequency and
> > voltage pairs that the device will support per voltage domain. This
>
> Paul,
>
> Should I apply this in my tree ? Or you plan to merge all the patches
> yourself ?
Your choice, either way works for me, just let me know!
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 16/27] drivers/opp: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 16/27] drivers/opp: " Paul E. McKenney
2023-01-05 4:06 ` Viresh Kumar
@ 2023-01-05 6:17 ` Viresh Kumar
2023-01-05 15:28 ` Paul E. McKenney
1 sibling, 1 reply; 126+ messages in thread
From: Viresh Kumar @ 2023-01-05 6:17 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar,
Nishanth Menon, Stephen Boyd, linux-pm
On 04-01-23, 16:38, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Viresh Kumar <vireshk@kernel.org>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Stephen Boyd <sboyd@kernel.org>
> Cc: <linux-pm@vger.kernel.org>
> ---
> drivers/opp/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/opp/Kconfig b/drivers/opp/Kconfig
> index e8ce47b327359..d7c649a1a981c 100644
> --- a/drivers/opp/Kconfig
> +++ b/drivers/opp/Kconfig
> @@ -1,7 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config PM_OPP
> bool
> - select SRCU
> help
> SOCs have a standard set of tuples consisting of frequency and
> voltage pairs that the device will support per voltage domain. This
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 16/27] drivers/opp: Remove "select SRCU"
2023-01-05 6:17 ` Viresh Kumar
@ 2023-01-05 15:28 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:28 UTC (permalink / raw)
To: Viresh Kumar
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar,
Nishanth Menon, Stephen Boyd, linux-pm
On Thu, Jan 05, 2023 at 11:47:30AM +0530, Viresh Kumar wrote:
> On 04-01-23, 16:38, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Viresh Kumar <vireshk@kernel.org>
> > Cc: Nishanth Menon <nm@ti.com>
> > Cc: Stephen Boyd <sboyd@kernel.org>
> > Cc: <linux-pm@vger.kernel.org>
> > ---
> > drivers/opp/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/opp/Kconfig b/drivers/opp/Kconfig
> > index e8ce47b327359..d7c649a1a981c 100644
> > --- a/drivers/opp/Kconfig
> > +++ b/drivers/opp/Kconfig
> > @@ -1,7 +1,6 @@
> > # SPDX-License-Identifier: GPL-2.0-only
> > config PM_OPP
> > bool
> > - select SRCU
> > help
> > SOCs have a standard set of tuples consisting of frequency and
> > voltage pairs that the device will support per voltage domain. This
>
> Applied. Thanks.
Thank you, Viresh! I will drop my patch on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 17/27] drivers/pci/controller: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (15 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 16/27] drivers/opp: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-12 14:37 ` Lorenzo Pieralisi
2023-01-05 0:38 ` [PATCH rcu 18/27] fs/btrfs: " Paul E. McKenney
` (11 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, linux-pci
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>
---
drivers/pci/controller/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 1569d9a3ada0b..b09cdc59bfd02 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -258,7 +258,7 @@ config PCIE_MEDIATEK_GEN3
MediaTek SoCs.
config VMD
- depends on PCI_MSI && X86_64 && SRCU && !UML
+ depends on PCI_MSI && X86_64 && !UML
tristate "Intel Volume Management Device Driver"
help
Adds support for the Intel Volume Management Device (VMD). VMD is a
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 17/27] drivers/pci/controller: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 17/27] drivers/pci/controller: " Paul E. McKenney
@ 2023-01-12 14:37 ` Lorenzo Pieralisi
2023-01-12 15:27 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Lorenzo Pieralisi @ 2023-01-12 14:37 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci
On Wed, Jan 04, 2023 at 04:38:03PM -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> Cc: Rob Herring <robh@kernel.org>
> Cc: "Krzysztof Wilczyński" <kw@linux.com>
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: <linux-pci@vger.kernel.org>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
I assume I don't have to pick this up and it will go via
a separate route upstream, if I am wrong please let me know.
Thanks,
Lorenzo
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 1569d9a3ada0b..b09cdc59bfd02 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -258,7 +258,7 @@ config PCIE_MEDIATEK_GEN3
> MediaTek SoCs.
>
> config VMD
> - depends on PCI_MSI && X86_64 && SRCU && !UML
> + depends on PCI_MSI && X86_64 && !UML
> tristate "Intel Volume Management Device Driver"
> help
> Adds support for the Intel Volume Management Device (VMD). VMD is a
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 17/27] drivers/pci/controller: Remove "select SRCU"
2023-01-12 14:37 ` Lorenzo Pieralisi
@ 2023-01-12 15:27 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-12 15:27 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: rcu, linux-kernel, kernel-team, rostedt, Rob Herring,
Krzysztof Wilczyński, Bjorn Helgaas, linux-pci
On Thu, Jan 12, 2023 at 03:37:16PM +0100, Lorenzo Pieralisi wrote:
> On Wed, Jan 04, 2023 at 04:38:03PM -0800, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: "Krzysztof Wilczyński" <kw@linux.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: <linux-pci@vger.kernel.org>
> > ---
> > drivers/pci/controller/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
>
> I assume I don't have to pick this up and it will go via
> a separate route upstream, if I am wrong please let me know.
Thank you!
I will apply your ack on my next rebase and send it along into the
upcoming merge window. If you later decide that you would like to take
it, just let me know, either way works for me.
Thanx, Paul
> Thanks,
> Lorenzo
>
> > diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> > index 1569d9a3ada0b..b09cdc59bfd02 100644
> > --- a/drivers/pci/controller/Kconfig
> > +++ b/drivers/pci/controller/Kconfig
> > @@ -258,7 +258,7 @@ config PCIE_MEDIATEK_GEN3
> > MediaTek SoCs.
> >
> > config VMD
> > - depends on PCI_MSI && X86_64 && SRCU && !UML
> > + depends on PCI_MSI && X86_64 && !UML
> > tristate "Intel Volume Management Device Driver"
> > help
> > Adds support for the Intel Volume Management Device (VMD). VMD is a
> > --
> > 2.31.1.189.g2e36527f23
> >
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (16 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 17/27] drivers/pci/controller: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 9:06 ` Qu Wenruo
2023-01-05 15:45 ` David Sterba
2023-01-05 0:38 ` [PATCH rcu 19/27] fs/dlm: " Paul E. McKenney
` (10 subsequent siblings)
28 siblings, 2 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Chris Mason, Josef Bacik, David Sterba, linux-btrfs
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: David Sterba <dsterba@suse.com>
Cc: <linux-btrfs@vger.kernel.org>
---
fs/btrfs/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 183e5c4aed348..37b6bab90c835 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -17,7 +17,6 @@ config BTRFS_FS
select FS_IOMAP
select RAID6_PQ
select XOR_BLOCKS
- select SRCU
depends on PAGE_SIZE_LESS_THAN_256KB
help
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 18/27] fs/btrfs: " Paul E. McKenney
@ 2023-01-05 9:06 ` Qu Wenruo
2023-01-05 15:41 ` Paul E. McKenney
2023-01-05 15:45 ` David Sterba
1 sibling, 1 reply; 126+ messages in thread
From: Qu Wenruo @ 2023-01-05 9:06 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Chris Mason, Josef Bacik,
David Sterba, linux-btrfs
On 2023/1/5 08:38, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Cc: <linux-btrfs@vger.kernel.org>
In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we
can completely remove any SRCU related configs and even includes.
Reviewed-by: Qu Wenruo <wqu@suse.com>
Thanks,
Qu
> ---
> fs/btrfs/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> index 183e5c4aed348..37b6bab90c835 100644
> --- a/fs/btrfs/Kconfig
> +++ b/fs/btrfs/Kconfig
> @@ -17,7 +17,6 @@ config BTRFS_FS
> select FS_IOMAP
> select RAID6_PQ
> select XOR_BLOCKS
> - select SRCU
> depends on PAGE_SIZE_LESS_THAN_256KB
>
> help
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
2023-01-05 9:06 ` Qu Wenruo
@ 2023-01-05 15:41 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:41 UTC (permalink / raw)
To: Qu Wenruo
Cc: rcu, linux-kernel, kernel-team, rostedt, Chris Mason,
Josef Bacik, David Sterba, linux-btrfs
On Thu, Jan 05, 2023 at 05:06:09PM +0800, Qu Wenruo wrote:
>
>
> On 2023/1/5 08:38, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Chris Mason <clm@fb.com>
> > Cc: Josef Bacik <josef@toxicpanda.com>
> > Cc: David Sterba <dsterba@suse.com>
> > Cc: <linux-btrfs@vger.kernel.org>
>
> In fact, since commit c75e839414d3 ("btrfs: kill the subvol_srcu"), we can
> completely remove any SRCU related configs and even includes.
$ git grep srcu fs/btrfs/
fs/btrfs/disk-io.h: * fs_info->subvol_srcu
I know that situation. ;-)
> Reviewed-by: Qu Wenruo <wqu@suse.com>
Thank you! I will update on my next rebase.
Thanx, Paul
> Thanks,
> Qu
>
> > ---
> > fs/btrfs/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
> > index 183e5c4aed348..37b6bab90c835 100644
> > --- a/fs/btrfs/Kconfig
> > +++ b/fs/btrfs/Kconfig
> > @@ -17,7 +17,6 @@ config BTRFS_FS
> > select FS_IOMAP
> > select RAID6_PQ
> > select XOR_BLOCKS
> > - select SRCU
> > depends on PAGE_SIZE_LESS_THAN_256KB
> > help
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 18/27] fs/btrfs: " Paul E. McKenney
2023-01-05 9:06 ` Qu Wenruo
@ 2023-01-05 15:45 ` David Sterba
2023-01-05 16:05 ` Paul E. McKenney
1 sibling, 1 reply; 126+ messages in thread
From: David Sterba @ 2023-01-05 15:45 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Chris Mason,
Josef Bacik, David Sterba, linux-btrfs
On Wed, Jan 04, 2023 at 04:38:04PM -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Chris Mason <clm@fb.com>
> Cc: Josef Bacik <josef@toxicpanda.com>
> Cc: David Sterba <dsterba@suse.com>
> Cc: <linux-btrfs@vger.kernel.org>
Acked-by: David Sterba <dsterba@suse.com>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 18/27] fs/btrfs: Remove "select SRCU"
2023-01-05 15:45 ` David Sterba
@ 2023-01-05 16:05 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 16:05 UTC (permalink / raw)
To: David Sterba
Cc: rcu, linux-kernel, kernel-team, rostedt, Chris Mason,
Josef Bacik, David Sterba, linux-btrfs
On Thu, Jan 05, 2023 at 04:45:18PM +0100, David Sterba wrote:
> On Wed, Jan 04, 2023 at 04:38:04PM -0800, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Chris Mason <clm@fb.com>
> > Cc: Josef Bacik <josef@toxicpanda.com>
> > Cc: David Sterba <dsterba@suse.com>
> > Cc: <linux-btrfs@vger.kernel.org>
>
> Acked-by: David Sterba <dsterba@suse.com>
Thank you, David! I will apply this on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 19/27] fs/dlm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (17 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 18/27] fs/btrfs: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 20/27] fs/notify: " Paul E. McKenney
` (9 subsequent siblings)
28 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Christine Caulfield, David Teigland, cluster-devel
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Cc: <cluster-devel@redhat.com>
---
fs/dlm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
index 1105ce3c80cbd..b3b86dbdc1878 100644
--- a/fs/dlm/Kconfig
+++ b/fs/dlm/Kconfig
@@ -4,7 +4,6 @@ menuconfig DLM
depends on INET
depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
select IP_SCTP
- select SRCU
help
A general purpose distributed lock manager for kernel or userspace
applications.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 20/27] fs/notify: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (18 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 19/27] fs/dlm: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 11:30 ` Jan Kara
2023-01-05 0:38 ` [PATCH rcu 21/27] fs/quota: " Paul E. McKenney
` (8 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jan Kara,
Amir Goldstein, linux-fsdevel
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: <linux-fsdevel@vger.kernel.org>
---
fs/notify/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/notify/Kconfig b/fs/notify/Kconfig
index c020d26ba223e..c6c72c90fd253 100644
--- a/fs/notify/Kconfig
+++ b/fs/notify/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config FSNOTIFY
def_bool n
- select SRCU
source "fs/notify/dnotify/Kconfig"
source "fs/notify/inotify/Kconfig"
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 20/27] fs/notify: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 20/27] fs/notify: " Paul E. McKenney
@ 2023-01-05 11:30 ` Jan Kara
0 siblings, 0 replies; 126+ messages in thread
From: Jan Kara @ 2023-01-05 11:30 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Jan Kara,
Amir Goldstein, linux-fsdevel
On Wed 04-01-23 16:38:06, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Jan Kara <jack@suse.cz>
> Cc: Amir Goldstein <amir73il@gmail.com>
> Cc: <linux-fsdevel@vger.kernel.org>
Sure. You can add:
Acked-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/notify/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/notify/Kconfig b/fs/notify/Kconfig
> index c020d26ba223e..c6c72c90fd253 100644
> --- a/fs/notify/Kconfig
> +++ b/fs/notify/Kconfig
> @@ -1,7 +1,6 @@
> # SPDX-License-Identifier: GPL-2.0-only
> config FSNOTIFY
> def_bool n
> - select SRCU
>
> source "fs/notify/dnotify/Kconfig"
> source "fs/notify/inotify/Kconfig"
> --
> 2.31.1.189.g2e36527f23
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (19 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 20/27] fs/notify: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 11:30 ` Jan Kara
2023-01-05 0:38 ` [PATCH rcu 22/27] init: " Paul E. McKenney
` (7 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu; +Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jan Kara
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jan Kara <jack@suse.com>
---
fs/quota/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
index b59cd172b5f97..d5a85a8062d05 100644
--- a/fs/quota/Kconfig
+++ b/fs/quota/Kconfig
@@ -6,7 +6,6 @@
config QUOTA
bool "Quota support"
select QUOTACTL
- select SRCU
help
If you say Y here, you will be able to set per user limits for disk
usage (also called disk quotas). Currently, it works for the
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 21/27] fs/quota: " Paul E. McKenney
@ 2023-01-05 11:30 ` Jan Kara
2023-01-05 15:45 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Jan Kara @ 2023-01-05 11:30 UTC (permalink / raw)
To: Paul E. McKenney; +Cc: rcu, linux-kernel, kernel-team, rostedt, Jan Kara
On Wed 04-01-23 16:38:07, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Jan Kara <jack@suse.com>
> ---
> fs/quota/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
Sure. You can add:
Acked-by: Jan Kara <jack@suse.cz>
Honza
>
> diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> index b59cd172b5f97..d5a85a8062d05 100644
> --- a/fs/quota/Kconfig
> +++ b/fs/quota/Kconfig
> @@ -6,7 +6,6 @@
> config QUOTA
> bool "Quota support"
> select QUOTACTL
> - select SRCU
> help
> If you say Y here, you will be able to set per user limits for disk
> usage (also called disk quotas). Currently, it works for the
> --
> 2.31.1.189.g2e36527f23
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 21/27] fs/quota: Remove "select SRCU"
2023-01-05 11:30 ` Jan Kara
@ 2023-01-05 15:45 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:45 UTC (permalink / raw)
To: Jan Kara; +Cc: rcu, linux-kernel, kernel-team, rostedt, Jan Kara
On Thu, Jan 05, 2023 at 12:30:15PM +0100, Jan Kara wrote:
> On Wed 04-01-23 16:38:07, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Jan Kara <jack@suse.com>
> > ---
> > fs/quota/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
>
> Sure. You can add:
>
> Acked-by: Jan Kara <jack@suse.cz>
Thank you, Jan! I will apply both on my next rebase.
> Honza
>
> >
> > diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
> > index b59cd172b5f97..d5a85a8062d05 100644
> > --- a/fs/quota/Kconfig
> > +++ b/fs/quota/Kconfig
> > @@ -6,7 +6,6 @@
> > config QUOTA
> > bool "Quota support"
> > select QUOTACTL
> > - select SRCU
> > help
> > If you say Y here, you will be able to set per user limits for disk
> > usage (also called disk quotas). Currently, it works for the
> > --
> > 2.31.1.189.g2e36527f23
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 22/27] init: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (20 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 21/27] fs/quota: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-10 0:02 ` Nick Desaulniers
2023-01-05 0:38 ` [PATCH rcu 23/27] kernel/power: " Paul E. McKenney
` (6 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Andrew Morton, Nick Desaulniers, Masahiro Yamada,
Johannes Weiner, Vlastimil Babka, Nathan Chancellor,
Arnd Bergmann, Miguel Ojeda, Masami Hiramatsu, Dmitry Torokhov,
Aaron Tomlin, Tejun Heo, Christophe Leroy
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Aaron Tomlin <atomlin@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
---
init/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index 7e5c3ddc341de..af511c726d695 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1865,7 +1865,6 @@ config PERF_EVENTS
default y if PROFILING
depends on HAVE_PERF_EVENTS
select IRQ_WORK
- select SRCU
help
Enable kernel support for various performance events provided
by software and hardware.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 22/27] init: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 22/27] init: " Paul E. McKenney
@ 2023-01-10 0:02 ` Nick Desaulniers
2023-01-10 0:05 ` Nick Desaulniers
2023-01-10 0:36 ` Paul E. McKenney
0 siblings, 2 replies; 126+ messages in thread
From: Nick Desaulniers @ 2023-01-10 0:02 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Andrew Morton,
Masahiro Yamada, Johannes Weiner, Vlastimil Babka,
Nathan Chancellor, Arnd Bergmann, Miguel Ojeda, Masami Hiramatsu,
Dmitry Torokhov, Aaron Tomlin, Tejun Heo, Christophe Leroy
On Wed, Jan 4, 2023 at 4:38 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
Looks like that's the case as of
commit 0cd7e350abc4 ("rcu: Make SRCU mandatory")
in v6.2-rc1.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Nick Desaulniers <ndesaulniers@google.com>
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Cc: Johannes Weiner <hannes@cmpxchg.org>
> Cc: Vlastimil Babka <vbabka@suse.cz>
> Cc: Nathan Chancellor <nathan@kernel.org>
> Cc: Arnd Bergmann <arnd@arndb.de>
> Cc: Miguel Ojeda <ojeda@kernel.org>
> Cc: Masami Hiramatsu <mhiramat@kernel.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Aaron Tomlin <atomlin@redhat.com>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Patch LGTM
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Note that there's quite a few more of these though. Perhaps best to
remove them all together? Or perhaps you already have individual
patches out already for all of these?
$ grep -rn 'select SRCU'
mm/Kconfig:670: select SRCU
kernel/power/Kconfig:121: select SRCU
arch/mips/kvm/Kconfig:29: select SRCU
arch/riscv/kvm/Kconfig:30: select SRCU
arch/s390/kvm/Kconfig:34: select SRCU
arch/powerpc/kvm/Kconfig:25: select SRCU
arch/x86/kvm/Kconfig:49: select SRCU
arch/x86/Kconfig:286: select SRCU
arch/x86/Kconfig:1941: select SRCU
arch/arm64/kvm/Kconfig:31: select SRCU
init/Kconfig:1868: select SRCU
security/tomoyo/Kconfig:9: select SRCU
fs/btrfs/Kconfig:20: select SRCU
fs/dlm/Kconfig:7: select SRCU
fs/quota/Kconfig:9: select SRCU
fs/notify/Kconfig:4: select SRCU
drivers/md/Kconfig:9: select SRCU
drivers/clk/Kconfig:26: select SRCU
drivers/dax/Kconfig:4: select SRCU
drivers/devfreq/Kconfig:4: select SRCU
drivers/net/Kconfig:337: select SRCU
drivers/hwtracing/stm/Kconfig:5: select SRCU
drivers/cpufreq/Kconfig:6: select SRCU
drivers/opp/Kconfig:4: select SRCU
> ---
> init/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/init/Kconfig b/init/Kconfig
> index 7e5c3ddc341de..af511c726d695 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -1865,7 +1865,6 @@ config PERF_EVENTS
> default y if PROFILING
> depends on HAVE_PERF_EVENTS
> select IRQ_WORK
> - select SRCU
> help
> Enable kernel support for various performance events provided
> by software and hardware.
> --
> 2.31.1.189.g2e36527f23
>
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 22/27] init: Remove "select SRCU"
2023-01-10 0:02 ` Nick Desaulniers
@ 2023-01-10 0:05 ` Nick Desaulniers
2023-01-10 0:36 ` Paul E. McKenney
1 sibling, 0 replies; 126+ messages in thread
From: Nick Desaulniers @ 2023-01-10 0:05 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Andrew Morton,
Masahiro Yamada, Johannes Weiner, Vlastimil Babka,
Nathan Chancellor, Arnd Bergmann, Miguel Ojeda, Masami Hiramatsu,
Dmitry Torokhov, Aaron Tomlin, Tejun Heo, Christophe Leroy
On Mon, Jan 9, 2023 at 4:02 PM Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> On Wed, Jan 4, 2023 at 4:38 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> Looks like that's the case as of
> commit 0cd7e350abc4 ("rcu: Make SRCU mandatory")
> in v6.2-rc1.
>
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Miguel Ojeda <ojeda@kernel.org>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Aaron Tomlin <atomlin@redhat.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Patch LGTM
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
>
> Note that there's quite a few more of these though. Perhaps best to
> remove them all together? Or perhaps you already have individual
> patches out already for all of these?
Ah indeed, I missed that this was part of such a series:
https://lore.kernel.org/lkml/20230105003759.GA1769545@paulmck-ThinkPad-P17-Gen-1/
>
> $ grep -rn 'select SRCU'
> mm/Kconfig:670: select SRCU
> kernel/power/Kconfig:121: select SRCU
> arch/mips/kvm/Kconfig:29: select SRCU
> arch/riscv/kvm/Kconfig:30: select SRCU
> arch/s390/kvm/Kconfig:34: select SRCU
> arch/powerpc/kvm/Kconfig:25: select SRCU
> arch/x86/kvm/Kconfig:49: select SRCU
> arch/x86/Kconfig:286: select SRCU
> arch/x86/Kconfig:1941: select SRCU
> arch/arm64/kvm/Kconfig:31: select SRCU
> init/Kconfig:1868: select SRCU
> security/tomoyo/Kconfig:9: select SRCU
> fs/btrfs/Kconfig:20: select SRCU
> fs/dlm/Kconfig:7: select SRCU
> fs/quota/Kconfig:9: select SRCU
> fs/notify/Kconfig:4: select SRCU
> drivers/md/Kconfig:9: select SRCU
> drivers/clk/Kconfig:26: select SRCU
> drivers/dax/Kconfig:4: select SRCU
> drivers/devfreq/Kconfig:4: select SRCU
> drivers/net/Kconfig:337: select SRCU
> drivers/hwtracing/stm/Kconfig:5: select SRCU
> drivers/cpufreq/Kconfig:6: select SRCU
> drivers/opp/Kconfig:4: select SRCU
>
> > ---
> > init/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 7e5c3ddc341de..af511c726d695 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1865,7 +1865,6 @@ config PERF_EVENTS
> > default y if PROFILING
> > depends on HAVE_PERF_EVENTS
> > select IRQ_WORK
> > - select SRCU
> > help
> > Enable kernel support for various performance events provided
> > by software and hardware.
> > --
> > 2.31.1.189.g2e36527f23
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
--
Thanks,
~Nick Desaulniers
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 22/27] init: Remove "select SRCU"
2023-01-10 0:02 ` Nick Desaulniers
2023-01-10 0:05 ` Nick Desaulniers
@ 2023-01-10 0:36 ` Paul E. McKenney
1 sibling, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-10 0:36 UTC (permalink / raw)
To: Nick Desaulniers
Cc: rcu, linux-kernel, kernel-team, rostedt, Andrew Morton,
Masahiro Yamada, Johannes Weiner, Vlastimil Babka,
Nathan Chancellor, Arnd Bergmann, Miguel Ojeda, Masami Hiramatsu,
Dmitry Torokhov, Aaron Tomlin, Tejun Heo, Christophe Leroy
On Mon, Jan 09, 2023 at 04:02:48PM -0800, Nick Desaulniers wrote:
> On Wed, Jan 4, 2023 at 4:38 PM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> Looks like that's the case as of
> commit 0cd7e350abc4 ("rcu: Make SRCU mandatory")
> in v6.2-rc1.
I freely confess that I took the cowardly way out by making it
unconditional in the last merge window and getting rid of references in
the next merge window. ;-)
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Nick Desaulniers <ndesaulniers@google.com>
> > Cc: Masahiro Yamada <masahiroy@kernel.org>
> > Cc: Johannes Weiner <hannes@cmpxchg.org>
> > Cc: Vlastimil Babka <vbabka@suse.cz>
> > Cc: Nathan Chancellor <nathan@kernel.org>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Miguel Ojeda <ojeda@kernel.org>
> > Cc: Masami Hiramatsu <mhiramat@kernel.org>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Aaron Tomlin <atomlin@redhat.com>
> > Cc: Tejun Heo <tj@kernel.org>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> Patch LGTM
> Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Thank you! I will apply this on my next rebase.
> Note that there's quite a few more of these though. Perhaps best to
> remove them all together? Or perhaps you already have individual
> patches out already for all of these?
I have these:
e73b36cbeb8eb arch/x86: Remove "select SRCU"
8bde7256e3bdc kvm: Remove "select SRCU"
047bbf23dd4f2 drivers/base: Remove CONFIG_SRCU
1b63789c861c1 drivers/clk: Remove "select SRCU"
3fe724041d29d drivers/cpufreq: Remove "select SRCU"
e8dc9f0f97d6f drivers/dax: Remove "select SRCU"
0be2fa022bcde drivers/devfreq: Remove "select SRCU"
e4ac435cd24da drivers/hwtracing/stm: Remove "select SRCU"
159ce13a6c500 drivers/md: Remove "select SRCU"
dbe417fa57042 drivers/net: Remove "select SRCU"
7cc598f342ae4 drivers/pci/controller: Remove "select SRCU"
fba630f40b15d fs/btrfs: Remove "select SRCU"
a17c8daaee218 fs/dlm: Remove "select SRCU"
fd77fd4fe1852 fs/notify: Remove "select SRCU"
47a84e7a9c1c6 fs/quota: Remove "select SRCU"
e5bc2dc08a416 init: Remove "select SRCU"
b7f8ff0898c04 kernel/power: Remove "select SRCU"
db389dace41db mm: Remove "select SRCU"
e5316ffd44aa1 fs: Remove CONFIG_SRCU
2d07d1c58fad7 kernel/notifier: Remove CONFIG_SRCU
c761c79f1e72f rcu: Remove CONFIG_SRCU
Plus there are three more that people wanted to take via their own
trees. And I am fine either way.
But as long as you generated the list...
> $ grep -rn 'select SRCU'
> mm/Kconfig:670: select SRCU
> kernel/power/Kconfig:121: select SRCU
> arch/mips/kvm/Kconfig:29: select SRCU
> arch/riscv/kvm/Kconfig:30: select SRCU
> arch/s390/kvm/Kconfig:34: select SRCU
> arch/powerpc/kvm/Kconfig:25: select SRCU
> arch/x86/kvm/Kconfig:49: select SRCU
> arch/x86/Kconfig:286: select SRCU
> arch/x86/Kconfig:1941: select SRCU
> arch/arm64/kvm/Kconfig:31: select SRCU
> init/Kconfig:1868: select SRCU
> security/tomoyo/Kconfig:9: select SRCU
> fs/btrfs/Kconfig:20: select SRCU
> fs/dlm/Kconfig:7: select SRCU
> fs/quota/Kconfig:9: select SRCU
> fs/notify/Kconfig:4: select SRCU
> drivers/md/Kconfig:9: select SRCU
> drivers/clk/Kconfig:26: select SRCU
> drivers/dax/Kconfig:4: select SRCU
> drivers/devfreq/Kconfig:4: select SRCU
> drivers/net/Kconfig:337: select SRCU
> drivers/hwtracing/stm/Kconfig:5: select SRCU
> drivers/cpufreq/Kconfig:6: select SRCU
> drivers/opp/Kconfig:4: select SRCU
And it does look like I missed security/tomoyo/Kconfig, so thank you
for checking! I have queued the patch.
The other one missing from -next is drivers/opp/Kconfig, which Viresh
said that he was taking.
There is no trace of CONFIG_SRCU in -next, which is the more worrying
one.
Thanx, Paul
> > ---
> > init/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index 7e5c3ddc341de..af511c726d695 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1865,7 +1865,6 @@ config PERF_EVENTS
> > default y if PROFILING
> > depends on HAVE_PERF_EVENTS
> > select IRQ_WORK
> > - select SRCU
> > help
> > Enable kernel support for various performance events provided
> > by software and hardware.
> > --
> > 2.31.1.189.g2e36527f23
> >
>
>
> --
> Thanks,
> ~Nick Desaulniers
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 23/27] kernel/power: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (21 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 22/27] init: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 15:08 ` Rafael J. Wysocki
2023-01-05 0:38 ` [PATCH rcu 24/27] mm: " Paul E. McKenney
` (5 subsequent siblings)
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Len Brown, Pavel Machek, linux-pm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: <linux-pm@vger.kernel.org>
---
kernel/power/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 60a1d3051cc79..4b31629c5be4b 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -118,7 +118,6 @@ config PM_SLEEP
def_bool y
depends on SUSPEND || HIBERNATE_CALLBACKS
select PM
- select SRCU
config PM_SLEEP_SMP
def_bool y
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 23/27] kernel/power: Remove "select SRCU"
2023-01-05 0:38 ` [PATCH rcu 23/27] kernel/power: " Paul E. McKenney
@ 2023-01-05 15:08 ` Rafael J. Wysocki
0 siblings, 0 replies; 126+ messages in thread
From: Rafael J. Wysocki @ 2023-01-05 15:08 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki,
Len Brown, Pavel Machek, linux-pm
On Thu, Jan 5, 2023 at 1:38 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: <linux-pm@vger.kernel.org>
Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> ---
> kernel/power/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index 60a1d3051cc79..4b31629c5be4b 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -118,7 +118,6 @@ config PM_SLEEP
> def_bool y
> depends on SUSPEND || HIBERNATE_CALLBACKS
> select PM
> - select SRCU
>
> config PM_SLEEP_SMP
> def_bool y
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu 24/27] mm: Remove "select SRCU"
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (22 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 23/27] kernel/power: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 25/27] fs: Remove CONFIG_SRCU Paul E. McKenney
` (4 subsequent siblings)
28 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu; +Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, linux-mm
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton
Cc: <linux-mm@kvack.org>
---
mm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index ff7b209dec055..dc660775b7d3f 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -667,7 +667,6 @@ config BOUNCE
config MMU_NOTIFIER
bool
- select SRCU
select INTERVAL_TREE
config KSM
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 25/27] fs: Remove CONFIG_SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (23 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 24/27] mm: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 26/27] kernel/notifier: " Paul E. McKenney
` (3 subsequent siblings)
28 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Jeff Layton, Chuck Lever, Alexander Viro, linux-fsdevel
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef and throw away the #else clause.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>
---
fs/locks.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 8f01bee177159..1909a9de242c8 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1889,7 +1889,6 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp,
}
EXPORT_SYMBOL(generic_setlease);
-#if IS_ENABLED(CONFIG_SRCU)
/*
* Kernel subsystems can register to be notified on any attempt to set
* a new lease with the lease_notifier_chain. This is used by (e.g.) nfsd
@@ -1923,30 +1922,6 @@ void lease_unregister_notifier(struct notifier_block *nb)
}
EXPORT_SYMBOL_GPL(lease_unregister_notifier);
-#else /* !IS_ENABLED(CONFIG_SRCU) */
-static inline void
-lease_notifier_chain_init(void)
-{
-}
-
-static inline void
-setlease_notifier(long arg, struct file_lock *lease)
-{
-}
-
-int lease_register_notifier(struct notifier_block *nb)
-{
- return 0;
-}
-EXPORT_SYMBOL_GPL(lease_register_notifier);
-
-void lease_unregister_notifier(struct notifier_block *nb)
-{
-}
-EXPORT_SYMBOL_GPL(lease_unregister_notifier);
-
-#endif /* IS_ENABLED(CONFIG_SRCU) */
-
/**
* vfs_setlease - sets a lease on an open file
* @filp: file pointer
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 26/27] kernel/notifier: Remove CONFIG_SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (24 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 25/27] fs: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 0:38 ` [PATCH rcu 27/27] rcu: " Paul E. McKenney
` (2 subsequent siblings)
28 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Michał Mirosław, Borislav Petkov,
Alan Stern
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Borislav Petkov <bp@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
---
kernel/notifier.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index ab75637fd904f..d353e4b5402d7 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
}
EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
-#ifdef CONFIG_SRCU
/*
* SRCU notifier chain routines. Registration and unregistration
* use a mutex, and call_chain is synchronized by SRCU (no locks).
@@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
}
EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
-#endif /* CONFIG_SRCU */
-
static ATOMIC_NOTIFIER_HEAD(die_chain);
int notrace notify_die(enum die_val val, const char *str,
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (25 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 26/27] kernel/notifier: " Paul E. McKenney
@ 2023-01-05 0:38 ` Paul E. McKenney
2023-01-05 8:04 ` John Ogness
2023-01-05 15:50 ` (subset) [PATCH rcu 0/27] Unconditionally enable SRCU Jens Axboe
2023-01-13 0:11 ` Paul E. McKenney
28 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 0:38 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
John Ogness, Petr Mladek
Now that all references to CONFIG_SRCU have been removed, it is time to
remove CONFIG_SRCU itself.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>
---
kernel/rcu/Kconfig | 3 ---
tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 ----
2 files changed, 7 deletions(-)
diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
index ab62074174c32..9071182b1284b 100644
--- a/kernel/rcu/Kconfig
+++ b/kernel/rcu/Kconfig
@@ -53,9 +53,6 @@ config RCU_EXPERT
Say N if you are unsure.
-config SRCU
- def_bool y
-
config TINY_SRCU
bool
default y if TINY_RCU
diff --git a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
index 42acb1a64ce10..3f5fb66f16df7 100644
--- a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
+++ b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
@@ -71,9 +71,5 @@ CONFIG_TASKS_RCU
These are controlled by CONFIG_PREEMPT and/or CONFIG_SMP.
-CONFIG_SRCU
-
- Selected by CONFIG_RCU_TORTURE_TEST, so cannot disable.
-
boot parameters ignored: TBD
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU
2023-01-05 0:38 ` [PATCH rcu 27/27] rcu: " Paul E. McKenney
@ 2023-01-05 8:04 ` John Ogness
2023-01-05 15:23 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: John Ogness @ 2023-01-05 8:04 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Petr Mladek
On 2023-01-04, "Paul E. McKenney" <paulmck@kernel.org> wrote:
> Now that all references to CONFIG_SRCU have been removed, it is time to
> remove CONFIG_SRCU itself.
I think "all references" is a bit misleading since there still are
several places in the kernel code that use it:
$ git grep CONFIG_SRCU
drivers/base/core.c:#ifdef CONFIG_SRCU
drivers/base/core.c:#else /* !CONFIG_SRCU */
drivers/base/core.c:#endif /* !CONFIG_SRCU */
fs/locks.c:#if IS_ENABLED(CONFIG_SRCU)
fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */
fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */
kernel/notifier.c:#ifdef CONFIG_SRCU
kernel/notifier.c:#endif /* CONFIG_SRCU */
Should those be removed before this patch?
John Ogness
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU
2023-01-05 8:04 ` John Ogness
@ 2023-01-05 15:23 ` Paul E. McKenney
2023-01-05 15:52 ` John Ogness
0 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 15:23 UTC (permalink / raw)
To: John Ogness; +Cc: rcu, linux-kernel, kernel-team, rostedt, Petr Mladek
On Thu, Jan 05, 2023 at 09:10:16AM +0106, John Ogness wrote:
> On 2023-01-04, "Paul E. McKenney" <paulmck@kernel.org> wrote:
> > Now that all references to CONFIG_SRCU have been removed, it is time to
> > remove CONFIG_SRCU itself.
>
> I think "all references" is a bit misleading since there still are
> several places in the kernel code that use it:
>
> $ git grep CONFIG_SRCU
> drivers/base/core.c:#ifdef CONFIG_SRCU
> drivers/base/core.c:#else /* !CONFIG_SRCU */
> drivers/base/core.c:#endif /* !CONFIG_SRCU */
> fs/locks.c:#if IS_ENABLED(CONFIG_SRCU)
> fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */
> fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */
> kernel/notifier.c:#ifdef CONFIG_SRCU
> kernel/notifier.c:#endif /* CONFIG_SRCU */
In the -rcu tree, these are removed by these commits:
1798c5b6b0ea ("drivers/base: Remove CONFIG_SRCU")
19aa50512372 ("fs: Remove CONFIG_SRCU")
fe0c9bd625ad ("kernel/notifier: Remove CONFIG_SRCU")
> Should those be removed before this patch?
When I merge the -rcu tree's "dev" branch with current mainline, "git
grep CONFIG_SRCU" gives me no output. Am I fat-fingering something here?
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU
2023-01-05 15:23 ` Paul E. McKenney
@ 2023-01-05 15:52 ` John Ogness
2023-01-05 16:04 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: John Ogness @ 2023-01-05 15:52 UTC (permalink / raw)
To: paulmck; +Cc: rcu, linux-kernel, kernel-team, rostedt, Petr Mladek
On 2023-01-05, "Paul E. McKenney" <paulmck@kernel.org> wrote:
>> $ git grep CONFIG_SRCU
>> drivers/base/core.c:#ifdef CONFIG_SRCU
>> drivers/base/core.c:#else /* !CONFIG_SRCU */
>> drivers/base/core.c:#endif /* !CONFIG_SRCU */
>> fs/locks.c:#if IS_ENABLED(CONFIG_SRCU)
>> fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */
>> fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */
>> kernel/notifier.c:#ifdef CONFIG_SRCU
>> kernel/notifier.c:#endif /* CONFIG_SRCU */
>
> In the -rcu tree, these are removed by these commits:
>
> 1798c5b6b0ea ("drivers/base: Remove CONFIG_SRCU")
> 19aa50512372 ("fs: Remove CONFIG_SRCU")
> fe0c9bd625ad ("kernel/notifier: Remove CONFIG_SRCU")
>
>> Should those be removed before this patch?
>
> When I merge the -rcu tree's "dev" branch with current mainline, "git
> grep CONFIG_SRCU" gives me no output. Am I fat-fingering something
> here?
Sorry, I checked against the wrong branch. You are good.
Reviewed-by: John Ogness <john.ogness@linutronix.de>
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu 27/27] rcu: Remove CONFIG_SRCU
2023-01-05 15:52 ` John Ogness
@ 2023-01-05 16:04 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 16:04 UTC (permalink / raw)
To: John Ogness; +Cc: rcu, linux-kernel, kernel-team, rostedt, Petr Mladek
On Thu, Jan 05, 2023 at 04:58:40PM +0106, John Ogness wrote:
> On 2023-01-05, "Paul E. McKenney" <paulmck@kernel.org> wrote:
> >> $ git grep CONFIG_SRCU
> >> drivers/base/core.c:#ifdef CONFIG_SRCU
> >> drivers/base/core.c:#else /* !CONFIG_SRCU */
> >> drivers/base/core.c:#endif /* !CONFIG_SRCU */
> >> fs/locks.c:#if IS_ENABLED(CONFIG_SRCU)
> >> fs/locks.c:#else /* !IS_ENABLED(CONFIG_SRCU) */
> >> fs/locks.c:#endif /* IS_ENABLED(CONFIG_SRCU) */
> >> kernel/notifier.c:#ifdef CONFIG_SRCU
> >> kernel/notifier.c:#endif /* CONFIG_SRCU */
> >
> > In the -rcu tree, these are removed by these commits:
> >
> > 1798c5b6b0ea ("drivers/base: Remove CONFIG_SRCU")
> > 19aa50512372 ("fs: Remove CONFIG_SRCU")
> > fe0c9bd625ad ("kernel/notifier: Remove CONFIG_SRCU")
> >
> >> Should those be removed before this patch?
> >
> > When I merge the -rcu tree's "dev" branch with current mainline, "git
> > grep CONFIG_SRCU" gives me no output. Am I fat-fingering something
> > here?
>
> Sorry, I checked against the wrong branch. You are good.
>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
Thank you, and I will apply this on the next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: (subset) [PATCH rcu 0/27] Unconditionally enable SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (26 preceding siblings ...)
2023-01-05 0:38 ` [PATCH rcu 27/27] rcu: " Paul E. McKenney
@ 2023-01-05 15:50 ` Jens Axboe
2023-01-05 16:01 ` Paul E. McKenney
2023-01-13 0:11 ` Paul E. McKenney
28 siblings, 1 reply; 126+ messages in thread
From: Jens Axboe @ 2023-01-05 15:50 UTC (permalink / raw)
To: rcu, Paul E. McKenney; +Cc: linux-kernel, kernel-team, rostedt
On Wed, 04 Jan 2023 16:37:59 -0800, Paul E. McKenney wrote:
> This series removes Kconfig "select" clauses and #ifdef directives that
> are no longer necessary give that SRCU is now unconditionally enabled,
> courtesy of new-age printk() requirements. Finally, the SRCU Kconfig
> option is removed entirely.
>
> 1. arch/x86: Remove "select SRCU".
>
> [...]
Applied, thanks!
[07/27] block: Remove "select SRCU"
commit: b2b50d572135c5c6e10c2ff79cd828d5a8141ef6
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: (subset) [PATCH rcu 0/27] Unconditionally enable SRCU
2023-01-05 15:50 ` (subset) [PATCH rcu 0/27] Unconditionally enable SRCU Jens Axboe
@ 2023-01-05 16:01 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-05 16:01 UTC (permalink / raw)
To: Jens Axboe; +Cc: rcu, linux-kernel, kernel-team, rostedt
On Thu, Jan 05, 2023 at 08:50:37AM -0700, Jens Axboe wrote:
>
> On Wed, 04 Jan 2023 16:37:59 -0800, Paul E. McKenney wrote:
> > This series removes Kconfig "select" clauses and #ifdef directives that
> > are no longer necessary give that SRCU is now unconditionally enabled,
> > courtesy of new-age printk() requirements. Finally, the SRCU Kconfig
> > option is removed entirely.
> >
> > 1. arch/x86: Remove "select SRCU".
> >
> > [...]
>
> Applied, thanks!
>
> [07/27] block: Remove "select SRCU"
> commit: b2b50d572135c5c6e10c2ff79cd828d5a8141ef6
Thank you, Jens! I will drop this one on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu 0/27] Unconditionally enable SRCU
2023-01-05 0:37 [PATCH rcu 0/27] Unconditionally enable SRCU Paul E. McKenney
` (27 preceding siblings ...)
2023-01-05 15:50 ` (subset) [PATCH rcu 0/27] Unconditionally enable SRCU Jens Axboe
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 01/20] arch/x86: Remove "select SRCU" Paul E. McKenney
` (20 more replies)
28 siblings, 21 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu; +Cc: linux-kernel, kernel-team, rostedt
Hello!
This v2 series removes Kconfig "select" clauses and #ifdef directives that
are no longer necessary give that SRCU is now unconditionally enabled,
courtesy of new-age printk() requirements. Finally, the SRCU Kconfig
option is removed entirely.
1. arch/x86: Remove "select SRCU".
2. drivers/base: Remove CONFIG_SRCU.
3. drivers/cpufreq: Remove "select SRCU".
4. drivers/dax: Remove "select SRCU".
5. drivers/hwtracing/stm: Remove "select SRCU".
6. drivers/md: Remove "select SRCU".
7. drivers/net: Remove "select SRCU".
8. drivers/pci/controller: Remove "select SRCU".
9. fs: Remove CONFIG_SRCU.
10. fs/btrfs: Remove "select SRCU".
11. fs/dlm: Remove "select SRCU".
12. fs/notify: Remove "select SRCU".
13. fs/quota: Remove "select SRCU".
14. init: Remove "select SRCU".
15. kernel/notifier: Remove CONFIG_SRCU.
16. kernel/power: Remove "select SRCU".
17. kvm: Remove "select SRCU".
18. mm: Remove "select SRCU".
19. tomoyo: Remove "select SRCU".
20. Remove CONFIG_SRCU.
Changes since v1:
o Added ack and review tags.
o Dropped patches taken by their maintainers.
o Combined the KVM-related commits into a single commit, as requested
by Sean Christopherson. Acks received thus far are qualified by
the corresponding architecture.
o Added the tomoyo patch based on feedback from Nick Desaulniers.
Thanx, Paul
------------------------------------------------------------------------
arch/arm64/kvm/Kconfig | 1
arch/mips/kvm/Kconfig | 1
arch/powerpc/kvm/Kconfig | 1
arch/riscv/kvm/Kconfig | 1
arch/s390/kvm/Kconfig | 1
arch/x86/Kconfig | 2
arch/x86/kvm/Kconfig | 1
drivers/base/core.c | 42 ------------
drivers/cpufreq/Kconfig | 1
drivers/dax/Kconfig | 1
drivers/hwtracing/stm/Kconfig | 1
drivers/md/Kconfig | 1
drivers/net/Kconfig | 1
drivers/pci/controller/Kconfig | 2
fs/btrfs/Kconfig | 1
fs/dlm/Kconfig | 1
fs/locks.c | 25 -------
fs/notify/Kconfig | 1
fs/quota/Kconfig | 1
init/Kconfig | 1
kernel/notifier.c | 3
kernel/power/Kconfig | 1
kernel/rcu/Kconfig | 3
mm/Kconfig | 1
security/tomoyo/Kconfig | 1
tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 -
26 files changed, 1 insertion(+), 99 deletions(-)
^ permalink raw reply [flat|nested] 126+ messages in thread* [PATCH rcu v2 01/20] arch/x86: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
` (19 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H. Peter Anvin, x86, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <x86@kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
arch/x86/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 3604074a878b8..4a9175fe7dd18 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -283,7 +283,6 @@ config X86
select RTC_LIB
select RTC_MC146818_LIB
select SPARSE_IRQ
- select SRCU
select SYSCTL_EXCEPTION_TRACE
select THREAD_INFO_IN_TASK
select TRACE_IRQFLAGS_SUPPORT
@@ -1938,7 +1937,6 @@ config X86_SGX
depends on X86_64 && CPU_SUP_INTEL && X86_X2APIC
depends on CRYPTO=y
depends on CRYPTO_SHA256=y
- select SRCU
select MMU_NOTIFIER
select NUMA_KEEP_MEMINFO if NUMA
select XARRAY_MULTI
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU
2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 01/20] arch/x86: Remove "select SRCU" Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 9:46 ` Rafael J. Wysocki
2023-01-13 0:11 ` [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU" Paul E. McKenney
` (18 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Greg Kroah-Hartman, Rafael J. Wysocki, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef and throw away the #else clause.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/base/core.c | 42 ------------------------------------------
1 file changed, 42 deletions(-)
diff --git a/drivers/base/core.c b/drivers/base/core.c
index a3e14143ec0cf..bb36aca8d1b7a 100644
--- a/drivers/base/core.c
+++ b/drivers/base/core.c
@@ -181,7 +181,6 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
}
EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers);
-#ifdef CONFIG_SRCU
static DEFINE_MUTEX(device_links_lock);
DEFINE_STATIC_SRCU(device_links_srcu);
@@ -220,47 +219,6 @@ static void device_link_remove_from_lists(struct device_link *link)
list_del_rcu(&link->s_node);
list_del_rcu(&link->c_node);
}
-#else /* !CONFIG_SRCU */
-static DECLARE_RWSEM(device_links_lock);
-
-static inline void device_links_write_lock(void)
-{
- down_write(&device_links_lock);
-}
-
-static inline void device_links_write_unlock(void)
-{
- up_write(&device_links_lock);
-}
-
-int device_links_read_lock(void)
-{
- down_read(&device_links_lock);
- return 0;
-}
-
-void device_links_read_unlock(int not_used)
-{
- up_read(&device_links_lock);
-}
-
-#ifdef CONFIG_DEBUG_LOCK_ALLOC
-int device_links_read_lock_held(void)
-{
- return lockdep_is_held(&device_links_lock);
-}
-#endif
-
-static inline void device_link_synchronize_removal(void)
-{
-}
-
-static void device_link_remove_from_lists(struct device_link *link)
-{
- list_del(&link->s_node);
- list_del(&link->c_node);
-}
-#endif /* !CONFIG_SRCU */
static bool device_is_ancestor(struct device *dev, struct device *target)
{
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU
2023-01-13 0:11 ` [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 9:46 ` Rafael J. Wysocki
0 siblings, 0 replies; 126+ messages in thread
From: Rafael J. Wysocki @ 2023-01-13 9:46 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Greg Kroah-Hartman,
Rafael J. Wysocki, John Ogness
On Fri, Jan 13, 2023 at 1:11 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef and throw away the #else clause.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
> ---
> drivers/base/core.c | 42 ------------------------------------------
> 1 file changed, 42 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index a3e14143ec0cf..bb36aca8d1b7a 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -181,7 +181,6 @@ void fw_devlink_purge_absent_suppliers(struct fwnode_handle *fwnode)
> }
> EXPORT_SYMBOL_GPL(fw_devlink_purge_absent_suppliers);
>
> -#ifdef CONFIG_SRCU
> static DEFINE_MUTEX(device_links_lock);
> DEFINE_STATIC_SRCU(device_links_srcu);
>
> @@ -220,47 +219,6 @@ static void device_link_remove_from_lists(struct device_link *link)
> list_del_rcu(&link->s_node);
> list_del_rcu(&link->c_node);
> }
> -#else /* !CONFIG_SRCU */
> -static DECLARE_RWSEM(device_links_lock);
> -
> -static inline void device_links_write_lock(void)
> -{
> - down_write(&device_links_lock);
> -}
> -
> -static inline void device_links_write_unlock(void)
> -{
> - up_write(&device_links_lock);
> -}
> -
> -int device_links_read_lock(void)
> -{
> - down_read(&device_links_lock);
> - return 0;
> -}
> -
> -void device_links_read_unlock(int not_used)
> -{
> - up_read(&device_links_lock);
> -}
> -
> -#ifdef CONFIG_DEBUG_LOCK_ALLOC
> -int device_links_read_lock_held(void)
> -{
> - return lockdep_is_held(&device_links_lock);
> -}
> -#endif
> -
> -static inline void device_link_synchronize_removal(void)
> -{
> -}
> -
> -static void device_link_remove_from_lists(struct device_link *link)
> -{
> - list_del(&link->s_node);
> - list_del(&link->c_node);
> -}
> -#endif /* !CONFIG_SRCU */
>
> static bool device_is_ancestor(struct device *dev, struct device *target)
> {
> --
> 2.31.1.189.g2e36527f23
>
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 01/20] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 02/20] drivers/base: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-20 16:54 ` Rafael J. Wysocki
2023-01-13 0:11 ` [PATCH rcu v2 04/20] drivers/dax: " Paul E. McKenney
` (17 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Viresh Kumar, linux-pm, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <linux-pm@vger.kernel.org>
Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/cpufreq/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
index 2a84fc63371e2..785541df59379 100644
--- a/drivers/cpufreq/Kconfig
+++ b/drivers/cpufreq/Kconfig
@@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
config CPU_FREQ
bool "CPU Frequency scaling"
- select SRCU
help
CPU Frequency scaling allows you to change the clock speed of
CPUs on the fly. This is a nice method to save power, because
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU"
2023-01-13 0:11 ` [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU" Paul E. McKenney
@ 2023-01-20 16:54 ` Rafael J. Wysocki
2023-01-20 18:03 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Rafael J. Wysocki @ 2023-01-20 16:54 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki,
Viresh Kumar, linux-pm, John Ogness
On Fri, Jan 13, 2023 at 1:11 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: <linux-pm@vger.kernel.org>
> Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> ---
> drivers/cpufreq/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> index 2a84fc63371e2..785541df59379 100644
> --- a/drivers/cpufreq/Kconfig
> +++ b/drivers/cpufreq/Kconfig
> @@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
>
> config CPU_FREQ
> bool "CPU Frequency scaling"
> - select SRCU
> help
> CPU Frequency scaling allows you to change the clock speed of
> CPUs on the fly. This is a nice method to save power, because
> --
Applied as 6.3 material, thanks!
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU"
2023-01-20 16:54 ` Rafael J. Wysocki
@ 2023-01-20 18:03 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-20 18:03 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: rcu, linux-kernel, kernel-team, rostedt, Viresh Kumar, linux-pm,
John Ogness, sfr
On Fri, Jan 20, 2023 at 05:54:17PM +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 13, 2023 at 1:11 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: <linux-pm@vger.kernel.org>
> > Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> > Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> > ---
> > drivers/cpufreq/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/Kconfig b/drivers/cpufreq/Kconfig
> > index 2a84fc63371e2..785541df59379 100644
> > --- a/drivers/cpufreq/Kconfig
> > +++ b/drivers/cpufreq/Kconfig
> > @@ -3,7 +3,6 @@ menu "CPU Frequency scaling"
> >
> > config CPU_FREQ
> > bool "CPU Frequency scaling"
> > - select SRCU
> > help
> > CPU Frequency scaling allows you to change the clock speed of
> > CPUs on the fly. This is a nice method to save power, because
> > --
>
> Applied as 6.3 material, thanks!
Thank you, I will drop it from my tree on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 04/20] drivers/dax: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (2 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 03/20] drivers/cpufreq: Remove "select SRCU" Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 05/20] drivers/hwtracing/stm: " Paul E. McKenney
` (16 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Dan Williams, Vishal Verma, Dave Jiang, nvdimm, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: <nvdimm@lists.linux.dev>
Acked-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/dax/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/dax/Kconfig b/drivers/dax/Kconfig
index 5fdf269a822e5..2bf5123e48279 100644
--- a/drivers/dax/Kconfig
+++ b/drivers/dax/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
menuconfig DAX
tristate "DAX: direct access to differentiated memory"
- select SRCU
default m if NVDIMM_DAX
if DAX
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 05/20] drivers/hwtracing/stm: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (3 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 04/20] drivers/dax: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 15:52 ` Alexander Shishkin
2023-01-13 0:11 ` [PATCH rcu v2 06/20] drivers/md: " Paul E. McKenney
` (15 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Alexander Shishkin, Maxime Coquelin, Alexandre Torgue,
linux-stm32, linux-arm-kernel, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
Cc: Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc: <linux-stm32@st-md-mailman.stormreply.com>
Cc: <linux-arm-kernel@lists.infradead.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/hwtracing/stm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwtracing/stm/Kconfig b/drivers/hwtracing/stm/Kconfig
index aad594fe79cc5..eda6b11d40a1f 100644
--- a/drivers/hwtracing/stm/Kconfig
+++ b/drivers/hwtracing/stm/Kconfig
@@ -2,7 +2,6 @@
config STM
tristate "System Trace Module devices"
select CONFIGFS_FS
- select SRCU
help
A System Trace Module (STM) is a device exporting data in System
Trace Protocol (STP) format as defined by MIPI STP standards.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 05/20] drivers/hwtracing/stm: Remove "select SRCU"
2023-01-13 0:11 ` [PATCH rcu v2 05/20] drivers/hwtracing/stm: " Paul E. McKenney
@ 2023-01-13 15:52 ` Alexander Shishkin
2023-01-13 19:47 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Alexander Shishkin @ 2023-01-13 15:52 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Maxime Coquelin, Alexandre Torgue, linux-stm32, linux-arm-kernel,
John Ogness, alexander.shishkin
"Paul E. McKenney" <paulmck@kernel.org> writes:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
Accidentally acked the previous version. This appears to be the same.
Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Regards,
--
Alex
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v2 05/20] drivers/hwtracing/stm: Remove "select SRCU"
2023-01-13 15:52 ` Alexander Shishkin
@ 2023-01-13 19:47 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 19:47 UTC (permalink / raw)
To: Alexander Shishkin
Cc: rcu, linux-kernel, kernel-team, rostedt, Maxime Coquelin,
Alexandre Torgue, linux-stm32, linux-arm-kernel, John Ogness
On Fri, Jan 13, 2023 at 05:52:37PM +0200, Alexander Shishkin wrote:
> "Paul E. McKenney" <paulmck@kernel.org> writes:
>
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
>
> Accidentally acked the previous version. This appears to be the same.
I somehow missed that ack, probably fat-fingered it. :-/
> Acked-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Thank you! I will apply this on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 06/20] drivers/md: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (4 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 05/20] drivers/hwtracing/stm: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-17 23:08 ` Mike Snitzer
2023-01-13 0:11 ` [PATCH rcu v2 07/20] drivers/net: " Paul E. McKenney
` (14 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Song Liu,
Alasdair Kergon, Mike Snitzer, dm-devel, linux-raid, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Song Liu <song@kernel.org>
Cc: Alasdair Kergon <agk@redhat.com>
Cc: Mike Snitzer <snitzer@kernel.org>
Cc: <dm-devel@redhat.com>
Cc: <linux-raid@vger.kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/md/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig
index 998a5cfdbc4e9..5f1e2593fad7e 100644
--- a/drivers/md/Kconfig
+++ b/drivers/md/Kconfig
@@ -6,7 +6,6 @@
menuconfig MD
bool "Multiple devices driver support (RAID and LVM)"
depends on BLOCK
- select SRCU
help
Support multiple physical spindles through a single logical device.
Required for RAID and logical volume management.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 06/20] drivers/md: Remove "select SRCU"
2023-01-13 0:11 ` [PATCH rcu v2 06/20] drivers/md: " Paul E. McKenney
@ 2023-01-17 23:08 ` Mike Snitzer
2023-01-18 3:55 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Mike Snitzer @ 2023-01-17 23:08 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Song Liu,
Alasdair Kergon, Mike Snitzer, dm-devel, linux-raid, John Ogness
On Thu, Jan 12 2023 at 7:11P -0500,
Paul E. McKenney <paulmck@kernel.org> wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Song Liu <song@kernel.org>
> Cc: Alasdair Kergon <agk@redhat.com>
> Cc: Mike Snitzer <snitzer@kernel.org>
> Cc: <dm-devel@redhat.com>
> Cc: <linux-raid@vger.kernel.org>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Mike Snitzer <snitzer@kernel.org>
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v2 06/20] drivers/md: Remove "select SRCU"
2023-01-17 23:08 ` Mike Snitzer
@ 2023-01-18 3:55 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-18 3:55 UTC (permalink / raw)
To: Mike Snitzer
Cc: rcu, linux-kernel, kernel-team, rostedt, Song Liu,
Alasdair Kergon, Mike Snitzer, dm-devel, linux-raid, John Ogness
On Tue, Jan 17, 2023 at 06:08:46PM -0500, Mike Snitzer wrote:
> On Thu, Jan 12 2023 at 7:11P -0500,
> Paul E. McKenney <paulmck@kernel.org> wrote:
>
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Song Liu <song@kernel.org>
> > Cc: Alasdair Kergon <agk@redhat.com>
> > Cc: Mike Snitzer <snitzer@kernel.org>
> > Cc: <dm-devel@redhat.com>
> > Cc: <linux-raid@vger.kernel.org>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
>
> Acked-by: Mike Snitzer <snitzer@kernel.org>
Will apply on my next rebase, thank you!
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 07/20] drivers/net: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (5 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 06/20] drivers/md: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 08/20] drivers/pci/controller: " Paul E. McKenney
` (13 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
netdev, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Eric Dumazet <edumazet@google.com>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Paolo Abeni <pabeni@redhat.com>
Cc: <netdev@vger.kernel.org>
Acked-by: Jakub Kicinski <kuba@kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/net/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 9e63b8c43f3e2..12910338ea1a0 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -334,7 +334,6 @@ config NETCONSOLE_DYNAMIC
config NETPOLL
def_bool NETCONSOLE
- select SRCU
config NET_POLL_CONTROLLER
def_bool NETPOLL
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 08/20] drivers/pci/controller: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (6 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 07/20] drivers/net: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU Paul E. McKenney
` (12 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Lorenzo Pieralisi, Rob Herring, Krzysztof Wilczyński,
Bjorn Helgaas, linux-pci, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Lorenzo Pieralisi <lpieralisi@kernel.org>
Cc: Rob Herring <robh@kernel.org>
Cc: "Krzysztof Wilczyński" <kw@linux.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: <linux-pci@vger.kernel.org>
Acked-by: Lorenzo Pieralisi <lpieralisi@kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
drivers/pci/controller/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 1569d9a3ada0b..b09cdc59bfd02 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -258,7 +258,7 @@ config PCIE_MEDIATEK_GEN3
MediaTek SoCs.
config VMD
- depends on PCI_MSI && X86_64 && SRCU && !UML
+ depends on PCI_MSI && X86_64 && !UML
tristate "Intel Volume Management Device Driver"
help
Adds support for the Intel Volume Management Device (VMD). VMD is a
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU
2023-01-13 0:11 ` Paul E. McKenney
` (7 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 08/20] drivers/pci/controller: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 1:03 ` Jeff Layton
2023-01-13 0:11 ` [PATCH rcu v2 10/20] fs/btrfs: Remove "select SRCU" Paul E. McKenney
` (11 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Jeff Layton, Chuck Lever, Alexander Viro, linux-fsdevel,
John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef and throw away the #else clause.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
fs/locks.c | 25 -------------------------
1 file changed, 25 deletions(-)
diff --git a/fs/locks.c b/fs/locks.c
index 8f01bee177159..1909a9de242c8 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -1889,7 +1889,6 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp,
}
EXPORT_SYMBOL(generic_setlease);
-#if IS_ENABLED(CONFIG_SRCU)
/*
* Kernel subsystems can register to be notified on any attempt to set
* a new lease with the lease_notifier_chain. This is used by (e.g.) nfsd
@@ -1923,30 +1922,6 @@ void lease_unregister_notifier(struct notifier_block *nb)
}
EXPORT_SYMBOL_GPL(lease_unregister_notifier);
-#else /* !IS_ENABLED(CONFIG_SRCU) */
-static inline void
-lease_notifier_chain_init(void)
-{
-}
-
-static inline void
-setlease_notifier(long arg, struct file_lock *lease)
-{
-}
-
-int lease_register_notifier(struct notifier_block *nb)
-{
- return 0;
-}
-EXPORT_SYMBOL_GPL(lease_register_notifier);
-
-void lease_unregister_notifier(struct notifier_block *nb)
-{
-}
-EXPORT_SYMBOL_GPL(lease_unregister_notifier);
-
-#endif /* IS_ENABLED(CONFIG_SRCU) */
-
/**
* vfs_setlease - sets a lease on an open file
* @filp: file pointer
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU
2023-01-13 0:11 ` [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 1:03 ` Jeff Layton
2023-01-13 1:10 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Jeff Layton @ 2023-01-13 1:03 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Chuck Lever, Alexander Viro,
linux-fsdevel, John Ogness
On Thu, 2023-01-12 at 16:11 -0800, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef and throw away the #else clause.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Jeff Layton <jlayton@kernel.org>
> Cc: Chuck Lever <chuck.lever@oracle.com>
> Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> Cc: <linux-fsdevel@vger.kernel.org>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> ---
> fs/locks.c | 25 -------------------------
> 1 file changed, 25 deletions(-)
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 8f01bee177159..1909a9de242c8 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -1889,7 +1889,6 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp,
> }
> EXPORT_SYMBOL(generic_setlease);
>
> -#if IS_ENABLED(CONFIG_SRCU)
> /*
> * Kernel subsystems can register to be notified on any attempt to set
> * a new lease with the lease_notifier_chain. This is used by (e.g.) nfsd
> @@ -1923,30 +1922,6 @@ void lease_unregister_notifier(struct notifier_block *nb)
> }
> EXPORT_SYMBOL_GPL(lease_unregister_notifier);
>
> -#else /* !IS_ENABLED(CONFIG_SRCU) */
> -static inline void
> -lease_notifier_chain_init(void)
> -{
> -}
> -
> -static inline void
> -setlease_notifier(long arg, struct file_lock *lease)
> -{
> -}
> -
> -int lease_register_notifier(struct notifier_block *nb)
> -{
> - return 0;
> -}
> -EXPORT_SYMBOL_GPL(lease_register_notifier);
> -
> -void lease_unregister_notifier(struct notifier_block *nb)
> -{
> -}
> -EXPORT_SYMBOL_GPL(lease_unregister_notifier);
> -
> -#endif /* IS_ENABLED(CONFIG_SRCU) */
> -
> /**
> * vfs_setlease - sets a lease on an open file
> * @filp: file pointer
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU
2023-01-13 1:03 ` Jeff Layton
@ 2023-01-13 1:10 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 1:10 UTC (permalink / raw)
To: Jeff Layton
Cc: rcu, linux-kernel, kernel-team, rostedt, Chuck Lever,
Alexander Viro, linux-fsdevel, John Ogness
On Thu, Jan 12, 2023 at 08:03:48PM -0500, Jeff Layton wrote:
> On Thu, 2023-01-12 at 16:11 -0800, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in conditional compilation based on CONFIG_SRCU.
> > Therefore, remove the #ifdef and throw away the #else clause.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Jeff Layton <jlayton@kernel.org>
> > Cc: Chuck Lever <chuck.lever@oracle.com>
> > Cc: Alexander Viro <viro@zeniv.linux.org.uk>
> > Cc: <linux-fsdevel@vger.kernel.org>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> > ---
> > fs/locks.c | 25 -------------------------
> > 1 file changed, 25 deletions(-)
> >
> > diff --git a/fs/locks.c b/fs/locks.c
> > index 8f01bee177159..1909a9de242c8 100644
> > --- a/fs/locks.c
> > +++ b/fs/locks.c
> > @@ -1889,7 +1889,6 @@ int generic_setlease(struct file *filp, long arg, struct file_lock **flp,
> > }
> > EXPORT_SYMBOL(generic_setlease);
> >
> > -#if IS_ENABLED(CONFIG_SRCU)
> > /*
> > * Kernel subsystems can register to be notified on any attempt to set
> > * a new lease with the lease_notifier_chain. This is used by (e.g.) nfsd
> > @@ -1923,30 +1922,6 @@ void lease_unregister_notifier(struct notifier_block *nb)
> > }
> > EXPORT_SYMBOL_GPL(lease_unregister_notifier);
> >
> > -#else /* !IS_ENABLED(CONFIG_SRCU) */
> > -static inline void
> > -lease_notifier_chain_init(void)
> > -{
> > -}
> > -
> > -static inline void
> > -setlease_notifier(long arg, struct file_lock *lease)
> > -{
> > -}
> > -
> > -int lease_register_notifier(struct notifier_block *nb)
> > -{
> > - return 0;
> > -}
> > -EXPORT_SYMBOL_GPL(lease_register_notifier);
> > -
> > -void lease_unregister_notifier(struct notifier_block *nb)
> > -{
> > -}
> > -EXPORT_SYMBOL_GPL(lease_unregister_notifier);
> > -
> > -#endif /* IS_ENABLED(CONFIG_SRCU) */
> > -
> > /**
> > * vfs_setlease - sets a lease on an open file
> > * @filp: file pointer
>
> Reviewed-by: Jeff Layton <jlayton@kernel.org>
Thank you! I will apply this on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 10/20] fs/btrfs: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (8 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 09/20] fs: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 11/20] fs/dlm: " Paul E. McKenney
` (10 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Chris Mason, Josef Bacik, David Sterba, linux-btrfs, Qu Wenruo,
John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Chris Mason <clm@fb.com>
Cc: Josef Bacik <josef@toxicpanda.com>
Cc: David Sterba <dsterba@suse.com>
Cc: <linux-btrfs@vger.kernel.org>
Acked-by: David Sterba <dsterba@suse.com>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
fs/btrfs/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/btrfs/Kconfig b/fs/btrfs/Kconfig
index 183e5c4aed348..37b6bab90c835 100644
--- a/fs/btrfs/Kconfig
+++ b/fs/btrfs/Kconfig
@@ -17,7 +17,6 @@ config BTRFS_FS
select FS_IOMAP
select RAID6_PQ
select XOR_BLOCKS
- select SRCU
depends on PAGE_SIZE_LESS_THAN_256KB
help
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 11/20] fs/dlm: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (9 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 10/20] fs/btrfs: Remove "select SRCU" Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 12/20] fs/notify: " Paul E. McKenney
` (9 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Christine Caulfield, David Teigland, cluster-devel, Anup Patel,
John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Christine Caulfield <ccaulfie@redhat.com>
Cc: David Teigland <teigland@redhat.com>
Cc: <cluster-devel@redhat.com>
Acked-by: Anup Patel <anup@brainfault.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
fs/dlm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/dlm/Kconfig b/fs/dlm/Kconfig
index 1105ce3c80cbd..b3b86dbdc1878 100644
--- a/fs/dlm/Kconfig
+++ b/fs/dlm/Kconfig
@@ -4,7 +4,6 @@ menuconfig DLM
depends on INET
depends on SYSFS && CONFIGFS_FS && (IPV6 || IPV6=n)
select IP_SCTP
- select SRCU
help
A general purpose distributed lock manager for kernel or userspace
applications.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 12/20] fs/notify: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (10 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 11/20] fs/dlm: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 13/20] fs/quota: " Paul E. McKenney
` (8 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jan Kara,
Amir Goldstein, linux-fsdevel, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>
Cc: <linux-fsdevel@vger.kernel.org>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
fs/notify/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/notify/Kconfig b/fs/notify/Kconfig
index c020d26ba223e..c6c72c90fd253 100644
--- a/fs/notify/Kconfig
+++ b/fs/notify/Kconfig
@@ -1,7 +1,6 @@
# SPDX-License-Identifier: GPL-2.0-only
config FSNOTIFY
def_bool n
- select SRCU
source "fs/notify/dnotify/Kconfig"
source "fs/notify/inotify/Kconfig"
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 13/20] fs/quota: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (11 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 12/20] fs/notify: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 14/20] init: " Paul E. McKenney
` (7 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, Jan Kara,
Jan Kara, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Jan Kara <jack@suse.com>
Acked-by: Jan Kara <jack@suse.cz>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
fs/quota/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/quota/Kconfig b/fs/quota/Kconfig
index b59cd172b5f97..d5a85a8062d05 100644
--- a/fs/quota/Kconfig
+++ b/fs/quota/Kconfig
@@ -6,7 +6,6 @@
config QUOTA
bool "Quota support"
select QUOTACTL
- select SRCU
help
If you say Y here, you will be able to set per user limits for disk
usage (also called disk quotas). Currently, it works for the
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 14/20] init: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (12 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 13/20] fs/quota: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU Paul E. McKenney
` (6 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Andrew Morton, Nick Desaulniers, Masahiro Yamada,
Johannes Weiner, Vlastimil Babka, Nathan Chancellor,
Arnd Bergmann, Miguel Ojeda, Masami Hiramatsu, Dmitry Torokhov,
Aaron Tomlin, Tejun Heo, Christophe Leroy, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Nick Desaulniers <ndesaulniers@google.com>
Cc: Masahiro Yamada <masahiroy@kernel.org>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Nathan Chancellor <nathan@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Miguel Ojeda <ojeda@kernel.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Aaron Tomlin <atomlin@redhat.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
init/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/init/Kconfig b/init/Kconfig
index 7e5c3ddc341de..af511c726d695 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -1865,7 +1865,6 @@ config PERF_EVENTS
default y if PROFILING
depends on HAVE_PERF_EVENTS
select IRQ_WORK
- select SRCU
help
Enable kernel support for various performance events provided
by software and hardware.
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU
2023-01-13 0:11 ` Paul E. McKenney
` (13 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 14/20] init: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 11:25 ` Wysocki, Rafael J
2023-01-13 0:11 ` [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU" Paul E. McKenney
` (5 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Michał Mirosław, Borislav Petkov,
Alan Stern, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in conditional compilation based on CONFIG_SRCU.
Therefore, remove the #ifdef.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: Borislav Petkov <bp@suse.de>
Cc: Alan Stern <stern@rowland.harvard.edu>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
kernel/notifier.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/kernel/notifier.c b/kernel/notifier.c
index ab75637fd904f..d353e4b5402d7 100644
--- a/kernel/notifier.c
+++ b/kernel/notifier.c
@@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
}
EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
-#ifdef CONFIG_SRCU
/*
* SRCU notifier chain routines. Registration and unregistration
* use a mutex, and call_chain is synchronized by SRCU (no locks).
@@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
}
EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
-#endif /* CONFIG_SRCU */
-
static ATOMIC_NOTIFIER_HEAD(die_chain);
int notrace notify_die(enum die_val val, const char *str,
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU
2023-01-13 0:11 ` [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 11:25 ` Wysocki, Rafael J
2023-01-13 19:42 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Wysocki, Rafael J @ 2023-01-13 11:25 UTC (permalink / raw)
To: Paul E. McKenney, rcu
Cc: linux-kernel, kernel-team, rostedt, Michał Mirosław,
Borislav Petkov, Alan Stern, John Ogness
On 1/13/2023 1:11 AM, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in conditional compilation based on CONFIG_SRCU.
> Therefore, remove the #ifdef.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
> Cc: Borislav Petkov <bp@suse.de>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> kernel/notifier.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/notifier.c b/kernel/notifier.c
> index ab75637fd904f..d353e4b5402d7 100644
> --- a/kernel/notifier.c
> +++ b/kernel/notifier.c
> @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
> }
> EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
>
> -#ifdef CONFIG_SRCU
> /*
> * SRCU notifier chain routines. Registration and unregistration
> * use a mutex, and call_chain is synchronized by SRCU (no locks).
> @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
> }
> EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
>
> -#endif /* CONFIG_SRCU */
> -
> static ATOMIC_NOTIFIER_HEAD(die_chain);
>
> int notrace notify_die(enum die_val val, const char *str,
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU
2023-01-13 11:25 ` Wysocki, Rafael J
@ 2023-01-13 19:42 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 19:42 UTC (permalink / raw)
To: Wysocki, Rafael J
Cc: rcu, linux-kernel, kernel-team, rostedt,
Michał Mirosław, Borislav Petkov, Alan Stern,
John Ogness
On Fri, Jan 13, 2023 at 12:25:48PM +0100, Wysocki, Rafael J wrote:
>
> On 1/13/2023 1:11 AM, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in conditional compilation based on CONFIG_SRCU.
> > Therefore, remove the #ifdef.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
> > Cc: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
> > Cc: Borislav Petkov <bp@suse.de>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Thank you! I will apply both of your acks on my next rebase.
Thanx, Paul
> > ---
> > kernel/notifier.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/kernel/notifier.c b/kernel/notifier.c
> > index ab75637fd904f..d353e4b5402d7 100644
> > --- a/kernel/notifier.c
> > +++ b/kernel/notifier.c
> > @@ -456,7 +456,6 @@ int raw_notifier_call_chain(struct raw_notifier_head *nh,
> > }
> > EXPORT_SYMBOL_GPL(raw_notifier_call_chain);
> > -#ifdef CONFIG_SRCU
> > /*
> > * SRCU notifier chain routines. Registration and unregistration
> > * use a mutex, and call_chain is synchronized by SRCU (no locks).
> > @@ -573,8 +572,6 @@ void srcu_init_notifier_head(struct srcu_notifier_head *nh)
> > }
> > EXPORT_SYMBOL_GPL(srcu_init_notifier_head);
> > -#endif /* CONFIG_SRCU */
> > -
> > static ATOMIC_NOTIFIER_HEAD(die_chain);
> > int notrace notify_die(enum die_val val, const char *str,
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (14 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 15/20] kernel/notifier: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-20 16:55 ` Rafael J. Wysocki
2023-01-13 0:11 ` [PATCH rcu v2 17/20] kvm: " Paul E. McKenney
` (4 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Rafael J. Wysocki, Len Brown, Pavel Machek, linux-pm,
John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <len.brown@intel.com>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: <linux-pm@vger.kernel.org>
Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
kernel/power/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
index 60a1d3051cc79..4b31629c5be4b 100644
--- a/kernel/power/Kconfig
+++ b/kernel/power/Kconfig
@@ -118,7 +118,6 @@ config PM_SLEEP
def_bool y
depends on SUSPEND || HIBERNATE_CALLBACKS
select PM
- select SRCU
config PM_SLEEP_SMP
def_bool y
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU"
2023-01-13 0:11 ` [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU" Paul E. McKenney
@ 2023-01-20 16:55 ` Rafael J. Wysocki
2023-01-20 18:04 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Rafael J. Wysocki @ 2023-01-20 16:55 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Rafael J. Wysocki,
Len Brown, Pavel Machek, linux-pm, John Ogness
On Fri, Jan 13, 2023 at 1:11 AM Paul E. McKenney <paulmck@kernel.org> wrote:
>
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: <linux-pm@vger.kernel.org>
> Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> ---
> kernel/power/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index 60a1d3051cc79..4b31629c5be4b 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -118,7 +118,6 @@ config PM_SLEEP
> def_bool y
> depends on SUSPEND || HIBERNATE_CALLBACKS
> select PM
> - select SRCU
>
> config PM_SLEEP_SMP
> def_bool y
> --
Applied as 6.3 material, thanks!
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU"
2023-01-20 16:55 ` Rafael J. Wysocki
@ 2023-01-20 18:04 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-20 18:04 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: rcu, linux-kernel, kernel-team, rostedt, Len Brown, Pavel Machek,
linux-pm, John Ogness, sfr
On Fri, Jan 20, 2023 at 05:55:04PM +0100, Rafael J. Wysocki wrote:
> On Fri, Jan 13, 2023 at 1:11 AM Paul E. McKenney <paulmck@kernel.org> wrote:
> >
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: Len Brown <len.brown@intel.com>
> > Cc: Pavel Machek <pavel@ucw.cz>
> > Cc: <linux-pm@vger.kernel.org>
> > Acked-by: "Rafael J. Wysocki" <rafael@kernel.org>
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> > ---
> > kernel/power/Kconfig | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> > index 60a1d3051cc79..4b31629c5be4b 100644
> > --- a/kernel/power/Kconfig
> > +++ b/kernel/power/Kconfig
> > @@ -118,7 +118,6 @@ config PM_SLEEP
> > def_bool y
> > depends on SUSPEND || HIBERNATE_CALLBACKS
> > select PM
> > - select SRCU
> >
> > config PM_SLEEP_SMP
> > def_bool y
> > --
>
> Applied as 6.3 material, thanks!
Thank you, and I will drop this from my tree on my next rebase.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 17/20] kvm: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (15 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 16/20] kernel/power: Remove "select SRCU" Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-18 1:27 ` Sean Christopherson
2023-01-13 0:11 ` [PATCH rcu v2 18/20] mm: " Paul E. McKenney
` (3 subsequent siblings)
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Huacai Chen, Aleksandar Markovic, Thomas Bogendoerfer,
Michael Ellerman, Christophe Leroy, Sean Christopherson,
Paolo Bonzini, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, H. Peter Anvin, kvm, Marc Zyngier, Anup Patel,
Heiko Carstens, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements from the various KVM Kconfig files.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <kvm@vger.kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Acked-by: Anup Patel <anup@brainfault.org> (riscv)
Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
arch/arm64/kvm/Kconfig | 1 -
arch/mips/kvm/Kconfig | 1 -
arch/powerpc/kvm/Kconfig | 1 -
arch/riscv/kvm/Kconfig | 1 -
arch/s390/kvm/Kconfig | 1 -
arch/x86/kvm/Kconfig | 1 -
6 files changed, 6 deletions(-)
diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index 05da3c8f7e88f..312f0e9869111 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -28,7 +28,6 @@ menuconfig KVM
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_XFER_TO_GUEST_WORK
- select SRCU
select KVM_VFIO
select HAVE_KVM_EVENTFD
select HAVE_KVM_IRQFD
diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig
index 91d197bee9c0a..591f46a5d7be1 100644
--- a/arch/mips/kvm/Kconfig
+++ b/arch/mips/kvm/Kconfig
@@ -26,7 +26,6 @@ config KVM
select HAVE_KVM_VCPU_ASYNC_IOCTL
select KVM_MMIO
select MMU_NOTIFIER
- select SRCU
select INTERVAL_TREE
help
Support for hosting Guest kernels.
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index a9f57dad6d916..902611954200d 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
select PREEMPT_NOTIFIERS
select HAVE_KVM_EVENTFD
select HAVE_KVM_VCPU_ASYNC_IOCTL
- select SRCU
select KVM_VFIO
select IRQ_BYPASS_MANAGER
select HAVE_KVM_IRQ_BYPASS
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index f36a737d5f96d..6bc9b290c1283 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -27,7 +27,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select HAVE_KVM_VCPU_ASYNC_IOCTL
select HAVE_KVM_EVENTFD
- select SRCU
help
Support hosting virtualized guest machines.
diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig
index 33f4ff909476c..45fdf2a9b2e32 100644
--- a/arch/s390/kvm/Kconfig
+++ b/arch/s390/kvm/Kconfig
@@ -31,7 +31,6 @@ config KVM
select HAVE_KVM_IRQ_ROUTING
select HAVE_KVM_INVALID_WAKEUPS
select HAVE_KVM_NO_POLL
- select SRCU
select KVM_VFIO
select INTERVAL_TREE
select MMU_NOTIFIER
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index fbeaa9ddef598..9306d99585188 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -46,7 +46,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_VFIO
- select SRCU
select INTERVAL_TREE
select HAVE_KVM_PM_NOTIFIER if PM
help
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 17/20] kvm: Remove "select SRCU"
2023-01-13 0:11 ` [PATCH rcu v2 17/20] kvm: " Paul E. McKenney
@ 2023-01-18 1:27 ` Sean Christopherson
2023-01-18 3:56 ` Paul E. McKenney
0 siblings, 1 reply; 126+ messages in thread
From: Sean Christopherson @ 2023-01-18 1:27 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Huacai Chen,
Aleksandar Markovic, Thomas Bogendoerfer, Michael Ellerman,
Christophe Leroy, Paolo Bonzini, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, H. Peter Anvin, kvm, Marc Zyngier,
Anup Patel, Heiko Carstens, John Ogness
On Thu, Jan 12, 2023, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements from the various KVM Kconfig files.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: <kvm@vger.kernel.org>
> Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Acked-by: Anup Patel <anup@brainfault.org> (riscv)
> Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> ---
Reviewed-by: Sean Christopherson <seanjc@google.com>
Ugh, my apologies Paul. I didn't realize 0cd7e350abc4 ("rcu: Make SRCU mandatory")
is already in Linus' tree, i.e. bundling this in a single patch was unnecessary work
for you.
Anyways, since there isn't an external dependency, this can go through the KVM
tree. Unless you prefer to take it directly, I'll make sure Paolo sends it along
at some point before v6.2 final.
^ permalink raw reply [flat|nested] 126+ messages in thread* Re: [PATCH rcu v2 17/20] kvm: Remove "select SRCU"
2023-01-18 1:27 ` Sean Christopherson
@ 2023-01-18 3:56 ` Paul E. McKenney
0 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-18 3:56 UTC (permalink / raw)
To: Sean Christopherson
Cc: rcu, linux-kernel, kernel-team, rostedt, Huacai Chen,
Aleksandar Markovic, Thomas Bogendoerfer, Michael Ellerman,
Christophe Leroy, Paolo Bonzini, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, H. Peter Anvin, kvm, Marc Zyngier,
Anup Patel, Heiko Carstens, John Ogness
On Wed, Jan 18, 2023 at 01:27:36AM +0000, Sean Christopherson wrote:
> On Thu, Jan 12, 2023, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements from the various KVM Kconfig files.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Huacai Chen <chenhuacai@kernel.org>
> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: Sean Christopherson <seanjc@google.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: <kvm@vger.kernel.org>
> > Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
> > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> > Acked-by: Anup Patel <anup@brainfault.org> (riscv)
> > Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> > ---
>
> Reviewed-by: Sean Christopherson <seanjc@google.com>
>
>
> Ugh, my apologies Paul. I didn't realize 0cd7e350abc4 ("rcu: Make SRCU mandatory")
> is already in Linus' tree, i.e. bundling this in a single patch was unnecessary work
> for you.
>
> Anyways, since there isn't an external dependency, this can go through the KVM
> tree. Unless you prefer to take it directly, I'll make sure Paolo sends it along
> at some point before v6.2 final.
I am very happy to have you guys take it. Just let me know when you
have it in place, and I will drop my copy on my next rebase after that.
Thanx, Paul
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v2 18/20] mm: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (16 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 17/20] kvm: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 0:11 ` [PATCH rcu v2 19/20] tomoyo: " Paul E. McKenney
` (2 subsequent siblings)
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney, linux-mm,
John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton
Cc: <linux-mm@kvack.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
mm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index ff7b209dec055..dc660775b7d3f 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -667,7 +667,6 @@ config BOUNCE
config MMU_NOTIFIER
bool
- select SRCU
select INTERVAL_TREE
config KSM
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 19/20] tomoyo: Remove "select SRCU"
2023-01-13 0:11 ` Paul E. McKenney
` (17 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 18/20] mm: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-01-13 14:22 ` Tetsuo Handa
2023-01-13 0:11 ` [PATCH rcu v2 20/20] rcu: Remove CONFIG_SRCU Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
20 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Kentaro Takeda, Tetsuo Handa, Paul Moore, James Morris,
Serge E. Hallyn, linux-security-module
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Kentaro Takeda <takedakn@nttdata.co.jp>
Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: Paul Moore <paul@paul-moore.com>
Cc: James Morris <jmorris@namei.org>
Cc: "Serge E. Hallyn" <serge@hallyn.com>
Cc: <linux-security-module@vger.kernel.org>
Cc: <linux-kernel@vger.kernel.org>
---
security/tomoyo/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/security/tomoyo/Kconfig b/security/tomoyo/Kconfig
index b9f867100a9ff..a9796b4003124 100644
--- a/security/tomoyo/Kconfig
+++ b/security/tomoyo/Kconfig
@@ -6,7 +6,6 @@ config SECURITY_TOMOYO
select SECURITYFS
select SECURITY_PATH
select SECURITY_NETWORK
- select SRCU
select BUILD_BIN2C
default n
help
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v2 20/20] rcu: Remove CONFIG_SRCU
2023-01-13 0:11 ` Paul E. McKenney
` (18 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 19/20] tomoyo: " Paul E. McKenney
@ 2023-01-13 0:11 ` Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
20 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-01-13 0:11 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
John Ogness, Petr Mladek
Now that all references to CONFIG_SRCU have been removed, it is time to
remove CONFIG_SRCU itself.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
kernel/rcu/Kconfig | 3 ---
tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 ----
2 files changed, 7 deletions(-)
diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
index ab62074174c32..9071182b1284b 100644
--- a/kernel/rcu/Kconfig
+++ b/kernel/rcu/Kconfig
@@ -53,9 +53,6 @@ config RCU_EXPERT
Say N if you are unsure.
-config SRCU
- def_bool y
-
config TINY_SRCU
bool
default y if TINY_RCU
diff --git a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
index 42acb1a64ce10..3f5fb66f16df7 100644
--- a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
+++ b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
@@ -71,9 +71,5 @@ CONFIG_TASKS_RCU
These are controlled by CONFIG_PREEMPT and/or CONFIG_SMP.
-CONFIG_SRCU
-
- Selected by CONFIG_RCU_TORTURE_TEST, so cannot disable.
-
boot parameters ignored: TBD
--
2.31.1.189.g2e36527f23
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v3 0/27] Unconditionally enable SRCU
2023-01-13 0:11 ` Paul E. McKenney
` (19 preceding siblings ...)
2023-01-13 0:11 ` [PATCH rcu v2 20/20] rcu: Remove CONFIG_SRCU Paul E. McKenney
@ 2023-03-24 20:52 ` Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 1/4] arch/x86: Remove "select SRCU" Paul E. McKenney
` (3 more replies)
20 siblings, 4 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-03-24 20:52 UTC (permalink / raw)
To: rcu; +Cc: linux-kernel, kernel-team, rostedt
Hello!
This v3 series removes the remaining Kconfig "select" clauses that are
no longer necessary given that SRCU is now unconditionally enabled,
courtesy of new-age printk() requirements. Finally, the SRCU Kconfig
option is removed entirely.
1. arch/x86: Remove "select SRCU".
2. kvm: Remove "select SRCU".
3. mm: Remove "select SRCU".
4. Remove CONFIG_SRCU.
Thanx, Paul
------------------------------------------------------------------------
arch/arm64/kvm/Kconfig | 1 -
arch/mips/kvm/Kconfig | 1 -
arch/powerpc/kvm/Kconfig | 1 -
arch/riscv/kvm/Kconfig | 1 -
arch/s390/kvm/Kconfig | 1 -
arch/x86/Kconfig | 2 --
arch/x86/kvm/Kconfig | 1 -
kernel/rcu/Kconfig | 3 ---
mm/Kconfig | 1 -
tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 ----
10 files changed, 16 deletions(-)
^ permalink raw reply [flat|nested] 126+ messages in thread* [PATCH rcu v3 1/4] arch/x86: Remove "select SRCU"
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
@ 2023-03-24 20:52 ` Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 2/4] kvm: " Paul E. McKenney
` (2 subsequent siblings)
3 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-03-24 20:52 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Thomas Gleixner, Ingo Molnar, Borislav Petkov, Dave Hansen,
H. Peter Anvin, x86, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <x86@kernel.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
arch/x86/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index a825bf031f49..947e24714c28 100644
--- a/arch/x86/Kconfig
+++ b/arch/x86/Kconfig
@@ -283,7 +283,6 @@ config X86
select RTC_LIB
select RTC_MC146818_LIB
select SPARSE_IRQ
- select SRCU
select SYSCTL_EXCEPTION_TRACE
select THREAD_INFO_IN_TASK
select TRACE_IRQFLAGS_SUPPORT
@@ -1938,7 +1937,6 @@ config X86_SGX
depends on X86_64 && CPU_SUP_INTEL && X86_X2APIC
depends on CRYPTO=y
depends on CRYPTO_SHA256=y
- select SRCU
select MMU_NOTIFIER
select NUMA_KEEP_MEMINFO if NUMA
select XARRAY_MULTI
--
2.40.0.rc2
^ permalink raw reply related [flat|nested] 126+ messages in thread* [PATCH rcu v3 2/4] kvm: Remove "select SRCU"
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 1/4] arch/x86: Remove "select SRCU" Paul E. McKenney
@ 2023-03-24 20:52 ` Paul E. McKenney
2023-03-28 4:56 ` Sean Christopherson
2023-03-24 20:52 ` [PATCH rcu v3 3/4] mm: " Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 4/4] rcu: Remove CONFIG_SRCU Paul E. McKenney
3 siblings, 1 reply; 126+ messages in thread
From: Paul E. McKenney @ 2023-03-24 20:52 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Huacai Chen, Aleksandar Markovic, Thomas Bogendoerfer,
Michael Ellerman, Christophe Leroy, Sean Christopherson,
Paolo Bonzini, Thomas Gleixner, Ingo Molnar, Borislav Petkov,
Dave Hansen, H. Peter Anvin, kvm, Marc Zyngier, Anup Patel,
Heiko Carstens, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements from the various KVM Kconfig files.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Huacai Chen <chenhuacai@kernel.org>
Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Sean Christopherson <seanjc@google.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: <kvm@vger.kernel.org>
Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
Acked-by: Anup Patel <anup@brainfault.org> (riscv)
Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
arch/arm64/kvm/Kconfig | 1 -
arch/mips/kvm/Kconfig | 1 -
arch/powerpc/kvm/Kconfig | 1 -
arch/riscv/kvm/Kconfig | 1 -
arch/s390/kvm/Kconfig | 1 -
arch/x86/kvm/Kconfig | 1 -
6 files changed, 6 deletions(-)
diff --git a/arch/arm64/kvm/Kconfig b/arch/arm64/kvm/Kconfig
index ca6eadeb7d1a..f531da6b362e 100644
--- a/arch/arm64/kvm/Kconfig
+++ b/arch/arm64/kvm/Kconfig
@@ -29,7 +29,6 @@ menuconfig KVM
select KVM_MMIO
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_XFER_TO_GUEST_WORK
- select SRCU
select KVM_VFIO
select HAVE_KVM_EVENTFD
select HAVE_KVM_IRQFD
diff --git a/arch/mips/kvm/Kconfig b/arch/mips/kvm/Kconfig
index 29e51649203b..a8cdba75f98d 100644
--- a/arch/mips/kvm/Kconfig
+++ b/arch/mips/kvm/Kconfig
@@ -26,7 +26,6 @@ config KVM
select HAVE_KVM_VCPU_ASYNC_IOCTL
select KVM_MMIO
select MMU_NOTIFIER
- select SRCU
select INTERVAL_TREE
select KVM_GENERIC_HARDWARE_ENABLING
help
diff --git a/arch/powerpc/kvm/Kconfig b/arch/powerpc/kvm/Kconfig
index a9f57dad6d91..902611954200 100644
--- a/arch/powerpc/kvm/Kconfig
+++ b/arch/powerpc/kvm/Kconfig
@@ -22,7 +22,6 @@ config KVM
select PREEMPT_NOTIFIERS
select HAVE_KVM_EVENTFD
select HAVE_KVM_VCPU_ASYNC_IOCTL
- select SRCU
select KVM_VFIO
select IRQ_BYPASS_MANAGER
select HAVE_KVM_IRQ_BYPASS
diff --git a/arch/riscv/kvm/Kconfig b/arch/riscv/kvm/Kconfig
index d5a658a047a7..5682d8c017b3 100644
--- a/arch/riscv/kvm/Kconfig
+++ b/arch/riscv/kvm/Kconfig
@@ -28,7 +28,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select HAVE_KVM_VCPU_ASYNC_IOCTL
select HAVE_KVM_EVENTFD
- select SRCU
help
Support hosting virtualized guest machines.
diff --git a/arch/s390/kvm/Kconfig b/arch/s390/kvm/Kconfig
index 33f4ff909476..45fdf2a9b2e3 100644
--- a/arch/s390/kvm/Kconfig
+++ b/arch/s390/kvm/Kconfig
@@ -31,7 +31,6 @@ config KVM
select HAVE_KVM_IRQ_ROUTING
select HAVE_KVM_INVALID_WAKEUPS
select HAVE_KVM_NO_POLL
- select SRCU
select KVM_VFIO
select INTERVAL_TREE
select MMU_NOTIFIER
diff --git a/arch/x86/kvm/Kconfig b/arch/x86/kvm/Kconfig
index 8e578311ca9d..89ca7f4c1464 100644
--- a/arch/x86/kvm/Kconfig
+++ b/arch/x86/kvm/Kconfig
@@ -46,7 +46,6 @@ config KVM
select KVM_XFER_TO_GUEST_WORK
select KVM_GENERIC_DIRTYLOG_READ_PROTECT
select KVM_VFIO
- select SRCU
select INTERVAL_TREE
select HAVE_KVM_PM_NOTIFIER if PM
select KVM_GENERIC_HARDWARE_ENABLING
--
2.40.0.rc2
^ permalink raw reply related [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v3 2/4] kvm: Remove "select SRCU"
2023-03-24 20:52 ` [PATCH rcu v3 2/4] kvm: " Paul E. McKenney
@ 2023-03-28 4:56 ` Sean Christopherson
2023-03-30 15:34 ` Joel Fernandes
0 siblings, 1 reply; 126+ messages in thread
From: Sean Christopherson @ 2023-03-28 4:56 UTC (permalink / raw)
To: Paul E. McKenney
Cc: rcu, linux-kernel, kernel-team, rostedt, Huacai Chen,
Aleksandar Markovic, Thomas Bogendoerfer, Michael Ellerman,
Christophe Leroy, Paolo Bonzini, Thomas Gleixner, Ingo Molnar,
Borislav Petkov, Dave Hansen, H. Peter Anvin, kvm, Marc Zyngier,
Anup Patel, Heiko Carstens, John Ogness
On Fri, Mar 24, 2023, Paul E. McKenney wrote:
> Now that the SRCU Kconfig option is unconditionally selected, there is
> no longer any point in selecting it. Therefore, remove the "select SRCU"
> Kconfig statements from the various KVM Kconfig files.
>
> Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> Cc: Huacai Chen <chenhuacai@kernel.org>
> Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> Cc: Michael Ellerman <mpe@ellerman.id.au>
> Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> Cc: Sean Christopherson <seanjc@google.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Ingo Molnar <mingo@redhat.com>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Dave Hansen <dave.hansen@linux.intel.com>
> Cc: "H. Peter Anvin" <hpa@zytor.com>
> Cc: <kvm@vger.kernel.org>
> Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> Acked-by: Anup Patel <anup@brainfault.org> (riscv)
> Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
> Reviewed-by: John Ogness <john.ogness@linutronix.de>
> ---
As amusing at it would be to see KVM as the lone holdout,
Acked-by: Sean Christopherson <seanjc@google.com> (x86)
Paul, feel free to take this through your tree if you think that would be the
fastest way to purge the config. Holler if you want to route it through KVM, I'll
either throw it kvm-x86/generic, or rewatch Beetlejuice and try to summon Paolo
that way. ;-)
^ permalink raw reply [flat|nested] 126+ messages in thread
* Re: [PATCH rcu v3 2/4] kvm: Remove "select SRCU"
2023-03-28 4:56 ` Sean Christopherson
@ 2023-03-30 15:34 ` Joel Fernandes
0 siblings, 0 replies; 126+ messages in thread
From: Joel Fernandes @ 2023-03-30 15:34 UTC (permalink / raw)
To: Sean Christopherson; +Cc: Paul E. McKenney, rcu
On Mon, Mar 27, 2023 at 09:56:02PM -0700, Sean Christopherson wrote:
> On Fri, Mar 24, 2023, Paul E. McKenney wrote:
> > Now that the SRCU Kconfig option is unconditionally selected, there is
> > no longer any point in selecting it. Therefore, remove the "select SRCU"
> > Kconfig statements from the various KVM Kconfig files.
> >
> > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> > Cc: Huacai Chen <chenhuacai@kernel.org>
> > Cc: Aleksandar Markovic <aleksandar.qemu.devel@gmail.com>
> > Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
> > Cc: Sean Christopherson <seanjc@google.com>
> > Cc: Paolo Bonzini <pbonzini@redhat.com>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Ingo Molnar <mingo@redhat.com>
> > Cc: Borislav Petkov <bp@alien8.de>
> > Cc: Dave Hansen <dave.hansen@linux.intel.com>
> > Cc: "H. Peter Anvin" <hpa@zytor.com>
> > Cc: <kvm@vger.kernel.org>
> > Acked-by: Marc Zyngier <maz@kernel.org> (arm64)
> > Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc)
> > Acked-by: Anup Patel <anup@brainfault.org> (riscv)
> > Acked-by: Heiko Carstens <hca@linux.ibm.com> (s390)
> > Reviewed-by: John Ogness <john.ogness@linutronix.de>
> > ---
>
> As amusing at it would be to see KVM as the lone holdout,
>
> Acked-by: Sean Christopherson <seanjc@google.com> (x86)
Applied the Ack, thank you!
thanks,
- Joel
^ permalink raw reply [flat|nested] 126+ messages in thread
* [PATCH rcu v3 3/4] mm: Remove "select SRCU"
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 1/4] arch/x86: Remove "select SRCU" Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 2/4] kvm: " Paul E. McKenney
@ 2023-03-24 20:52 ` Paul E. McKenney
2023-03-24 20:52 ` [PATCH rcu v3 4/4] rcu: Remove CONFIG_SRCU Paul E. McKenney
3 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-03-24 20:52 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
Andrew Morton, linux-mm, John Ogness
Now that the SRCU Kconfig option is unconditionally selected, there is
no longer any point in selecting it. Therefore, remove the "select SRCU"
Kconfig statements.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
mm/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/Kconfig b/mm/Kconfig
index 4751031f3f05..ebfe5796adf8 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -686,7 +686,6 @@ config BOUNCE
config MMU_NOTIFIER
bool
- select SRCU
select INTERVAL_TREE
config KSM
--
2.40.0.rc2
^ permalink raw reply related [flat|nested] 126+ messages in thread
* [PATCH rcu v3 4/4] rcu: Remove CONFIG_SRCU
2023-03-24 20:52 ` [PATCH rcu v3 0/27] Unconditionally enable SRCU Paul E. McKenney
` (2 preceding siblings ...)
2023-03-24 20:52 ` [PATCH rcu v3 3/4] mm: " Paul E. McKenney
@ 2023-03-24 20:52 ` Paul E. McKenney
3 siblings, 0 replies; 126+ messages in thread
From: Paul E. McKenney @ 2023-03-24 20:52 UTC (permalink / raw)
To: rcu
Cc: linux-kernel, kernel-team, rostedt, Paul E. McKenney,
John Ogness, Petr Mladek
Now that all references to CONFIG_SRCU have been removed, it is time to
remove CONFIG_SRCU itself.
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Cc: John Ogness <john.ogness@linutronix.de>
Cc: Petr Mladek <pmladek@suse.com>
Reviewed-by: John Ogness <john.ogness@linutronix.de>
---
kernel/rcu/Kconfig | 3 ---
tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt | 4 ----
2 files changed, 7 deletions(-)
diff --git a/kernel/rcu/Kconfig b/kernel/rcu/Kconfig
index ab62074174c3..9071182b1284 100644
--- a/kernel/rcu/Kconfig
+++ b/kernel/rcu/Kconfig
@@ -53,9 +53,6 @@ config RCU_EXPERT
Say N if you are unsure.
-config SRCU
- def_bool y
-
config TINY_SRCU
bool
default y if TINY_RCU
diff --git a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
index 42acb1a64ce1..3f5fb66f16df 100644
--- a/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
+++ b/tools/testing/selftests/rcutorture/doc/TREE_RCU-kconfig.txt
@@ -71,9 +71,5 @@ CONFIG_TASKS_RCU
These are controlled by CONFIG_PREEMPT and/or CONFIG_SMP.
-CONFIG_SRCU
-
- Selected by CONFIG_RCU_TORTURE_TEST, so cannot disable.
-
boot parameters ignored: TBD
--
2.40.0.rc2
^ permalink raw reply related [flat|nested] 126+ messages in thread