From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: Carl Huang <cjhuang@codeaurora.org>,
Loic Poulain <loic.poulain@linaro.org>,
ath11k@lists.infradead.org,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-wireless@vger.kernel.org, regressions@lists.linux.dev,
mhi <mhi@lists.linux.dev>
Subject: Re: [regression] mhi: ath11k resume fails on some devices
Date: Thu, 21 Oct 2021 15:31:11 +0530 [thread overview]
Message-ID: <20211021100111.GC7580@workstation> (raw)
In-Reply-To: <874k9t9n13.fsf@codeaurora.org>
On Thu, Oct 07, 2021 at 12:55:52PM +0300, Kalle Valo wrote:
> (adding also mhi list)
>
> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
>
> > On Fri, Sep 24, 2021 at 12:07:41PM +0300, Kalle Valo wrote:
> >> Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> writes:
> >>
> >> > For aid debugging, please see the state the device is in during mhi_pm_resume().
> >> > You can use below diff:
> >> >
> >> > diff --git a/drivers/bus/mhi/core/pm.c b/drivers/bus/mhi/core/pm.c
> >> > index fb99e3727155..482d55dd209e 100644
> >> > --- a/drivers/bus/mhi/core/pm.c
> >> > +++ b/drivers/bus/mhi/core/pm.c
> >> > @@ -898,6 +898,9 @@ int mhi_pm_resume(struct mhi_controller *mhi_cntrl)
> >> > if (MHI_PM_IN_ERROR_STATE(mhi_cntrl->pm_state))
> >> > return -EIO;
> >> >
> >> > + dev_info(dev, "Device state: %s\n",
> >> > + TO_MHI_STATE_STR(mhi_get_mhi_state(mhi_cntrl)));
> >> > +
> >> > if (mhi_get_mhi_state(mhi_cntrl) != MHI_STATE_M3)
> >> > return -EINVAL;
> >>
> >> This is what I get with my NUC testbox:
> >>
> >> [ 970.488202] ACPI: EC: event unblocked
> >> [ 970.492484] hpet: Lost 1587 RTC interrupts
> >> [ 970.492749] mhi mhi0: Device state: RESET
> >
> > Looks like the MHI device went into RESET state! It also looks to be a
> > firmware thing. But let's nail this down before adding any workaround in
> > the MHI stack.
> >
> > Can you also rebuild the kernel with MHI debug enabled and capture the
> > logs in faliure case?
>
> So what I should exactly do to enable debug messages?
>
> I have this in my Kconfig:
>
> CONFIG_MHI_BUS=m
> # CONFIG_MHI_BUS_DEBUG is not set
> # CONFIG_MHI_BUS_PCI_GENERIC is not set
>
> And AFAICS CONFIG_MHI_BUS_DEBUG only enables the debugfs interface, I
> doubt you meant that.
>
No. You should enable the dev_dbg messages in MHI core by adding the -DDEBUG
flag to the Makefile or by CONFIG_DYNAMIC_DEBUG.
Thanks,
Mani
> --
> https://patchwork.kernel.org/project/linux-wireless/list/
>
> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-10-21 10:01 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 8:00 [regression] mhi: ath11k resume fails on some devices Kalle Valo
2021-09-16 10:18 ` Loic Poulain
2021-09-16 11:12 ` Manivannan Sadhasivam
[not found] ` <CAMZdPi94607mZorp+Zmkw3seWXak6p9Jr05CQ5hhfgKQoG8n7Q@mail.gmail.com>
2021-09-16 16:35 ` Manivannan Sadhasivam
2021-09-16 16:42 ` Kalle Valo
2021-09-16 17:19 ` Manivannan Sadhasivam
2021-09-23 8:34 ` Carl Huang
2021-09-23 8:59 ` Manivannan Sadhasivam
2021-09-23 9:26 ` Carl Huang
2021-09-23 10:50 ` Loic Poulain
2021-09-24 9:07 ` Kalle Valo
2021-09-24 9:57 ` Manivannan Sadhasivam
2021-10-07 9:55 ` Kalle Valo
2021-10-21 10:01 ` Manivannan Sadhasivam [this message]
2021-09-24 8:36 ` Kalle Valo
2021-09-24 9:43 ` Loic Poulain
2021-09-24 10:00 ` Manivannan Sadhasivam
2021-10-07 9:48 ` Kalle Valo
2021-10-19 12:12 ` Kalle Valo
2021-10-21 10:03 ` Manivannan Sadhasivam
2021-11-12 11:36 ` Thorsten Leemhuis
2021-11-18 17:41 ` Manivannan Sadhasivam
2021-12-01 7:34 ` Thorsten Leemhuis
2021-09-25 17:40 ` Thorsten Leemhuis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021100111.GC7580@workstation \
--to=manivannan.sadhasivam@linaro.org \
--cc=ath11k@lists.infradead.org \
--cc=cjhuang@codeaurora.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=mhi@lists.linux.dev \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).