From: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
To: "NeilBrown" <neilb@suse.de>
Cc: Jes Sorensen <jes@trained-monkey.org>,
"Song Liu" <song@kernel.org>,
"Linux regressions mailing list" <regressions@lists.linux.dev>,
"linux-raid" <linux-raid@vger.kernel.org>,
"LKML" <linux-kernel@vger.kernel.org>,
"Nikolay Kichukov" <hijacker@oldum.net>
Subject: Re: [PATCH - mdadm] mdopen: always try create_named_array()
Date: Tue, 14 Mar 2023 10:11:13 +0100 [thread overview]
Message-ID: <20230314101113.000001fa@linux.intel.com> (raw)
In-Reply-To: <167875238571.8008.9808655454439667586@noble.neil.brown.name>
On Tue, 14 Mar 2023 11:06:25 +1100
"NeilBrown" <neilb@suse.de> wrote:
> mdopen() will use create_named_array() to ask the kernel to create the
> given md array, but only if it is given a number or name.
> If it is NOT given a name and is required to choose one itself using
> find_free_devnm() it does NOT use create_named_array().
>
> On kernels with CONFIG_BLOCK_LEGACY_AUTOLOAD not set, this can result in
> failure to assemble an array. This can particularly seen when the
> "name" of the array begins with a host name different to the name of the
> host running the command.
>
> So add the missing call to create_named_array().
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217074
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
> mdopen.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mdopen.c b/mdopen.c
> index d18c931996d2..810f79a3d19a 100644
> --- a/mdopen.c
> +++ b/mdopen.c
> @@ -370,6 +370,7 @@ int create_mddev(char *dev, char *name, int autof, int
> trustworthy, }
> if (block_udev)
> udev_block(devnm);
> + create_named_array(devnm);
> }
>
> sprintf(devname, "/dev/%s", devnm);
Hi Neil,
Thanks for handling that. I didn't have time to get into this topic yet.
I trust you and I believe that it is a good fix but I cannot verify it by
standard code review- the code is to complex. Could you please add test for it
to prove it works this way at least for following cases?
- mdadm -CR /dev/md/name
- mdadm -CR name
- mdadm -CR /dev/md_name
- mdadm -CR /dev/mdX, where X is a number.
You can disable creation via open temporarily by changing value in
/sys/module/md_mod/parameters/new_array that should be enough for verification.
For code:
Acked-by: Mariusz Tkaczyk <mariusz.tkaczyk@linux.intel.com>
Thanks,
Mariusz
next prev parent reply other threads:[~2023-03-14 9:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-14 0:06 [PATCH - mdadm] mdopen: always try create_named_array() NeilBrown
2023-03-14 9:11 ` Mariusz Tkaczyk [this message]
2023-03-19 16:36 ` Jes Sorensen
2023-03-19 22:09 ` NeilBrown
2023-03-20 17:15 ` Jes Sorensen
2023-03-21 8:49 ` Mariusz Tkaczyk
2023-03-22 3:00 ` Xiao Ni
2023-03-22 3:24 ` NeilBrown
2023-03-22 6:51 ` Mariusz Tkaczyk
2023-03-23 2:09 ` Xiao Ni
2023-03-29 21:51 ` NeilBrown
2023-03-30 0:10 ` Xiao Ni
2023-03-30 3:15 ` NeilBrown
2023-03-30 4:55 ` Xiao Ni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230314101113.000001fa@linux.intel.com \
--to=mariusz.tkaczyk@linux.intel.com \
--cc=hijacker@oldum.net \
--cc=jes@trained-monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=regressions@lists.linux.dev \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).