Re: [PATCH v1 net 1/2] tcp: Fix bind() conflict check for dual-stack wildcard address.

Re: [PATCH v1 net 1/2] tcp: Fix bind() conflict check for dual-stack wildcard address.

[Jakub Kicinski]

On Sun, 12 Mar 2023 12:42:48 +0100 Linux regression tracking (Thorsten
Leemhuis) wrote:
> Link:
> https://lore.kernel.org/netdev/CAG_fn=Ud3zSW7AZWXc+asfMhZVL5ETnvuY44Pmyv4NPv-ijN-A@mail.gmail.com/
> [1]
> Fixes: 5456262d2baa ("net: Fix incorrect address comparison when
> searching for a bind2 bucket")
> Reported-by: Paul Holzinger <pholzing@redhat.com>
> Link:
> https://lore.kernel.org/netdev/e21bf153-80b0-9ec0-15ba-e04a4ad42c34@redhat.com/
> [0]

I tried to fix this manually when applying but:
 - your email client wraps your replies
 - please don't reply to patches with tags which will look to scripts
   and patchwork like tags it should pull into the submission
   (Reported-by in particular, here)

Re: [PATCH v1 net 1/2] tcp: Fix bind() conflict check for dual-stack wildcard address.

[Thorsten Leemhuis]

On 15.03.23 08:26, Jakub Kicinski wrote:
> On Sun, 12 Mar 2023 12:42:48 +0100 Linux regression tracking (Thorsten
> Leemhuis) wrote:
>> Link:
>> https://lore.kernel.org/netdev/CAG_fn=Ud3zSW7AZWXc+asfMhZVL5ETnvuY44Pmyv4NPv-ijN-A@mail.gmail.com/
>> [1]
>> Fixes: 5456262d2baa ("net: Fix incorrect address comparison when
>> searching for a bind2 bucket")
>> Reported-by: Paul Holzinger <pholzing@redhat.com>
>> Link:
>> https://lore.kernel.org/netdev/e21bf153-80b0-9ec0-15ba-e04a4ad42c34@redhat.com/
>> [0]
> 
> I tried to fix this manually when applying but:
>  - your email client wraps your replies
>  - please don't reply to patches with tags which will look to scripts
>    and patchwork like tags it should pull into the submission
>    (Reported-by in particular, here)

Sorry for the mixup and thx for letting me know, will simply quote my
suggestion next time, that should avoid both problems.

Ciao, Thorsten

Re: [PATCH v1 net 1/2] tcp: Fix bind() conflict check for dual-stack wildcard address.

[Jakub Kicinski]

On Wed, 15 Mar 2023 09:05:29 +0100 Thorsten Leemhuis wrote:
> On 15.03.23 08:26, Jakub Kicinski wrote:
> > On Sun, 12 Mar 2023 12:42:48 +0100 Linux regression tracking (Thorsten
> > Leemhuis) wrote:  
> >> Link:
> >> https://lore.kernel.org/netdev/CAG_fn=Ud3zSW7AZWXc+asfMhZVL5ETnvuY44Pmyv4NPv-ijN-A@mail.gmail.com/
> >> [1]
> >> Fixes: 5456262d2baa ("net: Fix incorrect address comparison when
> >> searching for a bind2 bucket")
> >> Reported-by: Paul Holzinger <pholzing@redhat.com>
> >> Link:
> >> https://lore.kernel.org/netdev/e21bf153-80b0-9ec0-15ba-e04a4ad42c34@redhat.com/
> >> [0]  
> > 
> > I tried to fix this manually when applying but:
> >  - your email client wraps your replies
> >  - please don't reply to patches with tags which will look to scripts
> >    and patchwork like tags it should pull into the submission
> >    (Reported-by in particular, here)  
> 
> Sorry for the mixup and thx for letting me know, will simply quote my
> suggestion next time, that should avoid both problems.

FWIW indenting with spaces would work too, for our scripts at least.
We match on tags only at start of the line.