* Re: [PATCH] alpha: Use generic <asm-generic/io.h>
[not found] ` <2e110666-7519-4693-8a89-240cbb118c7e@app.fastmail.com>
@ 2022-10-12 14:05 ` Guenter Roeck
2022-10-12 15:32 ` Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Guenter Roeck @ 2022-10-12 14:05 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Linus Walleij, Richard Henderson, Ivan Kokshaysky, Matt Turner,
linux-alpha, kernel test robot, Mark Brown, Linux-Arch,
regressions
On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote:
> On Tue, Oct 4, 2022, at 9:42 PM, Guenter Roeck wrote:
> > On 10/3/22 06:03, Arnd Bergmann wrote:
> >> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote:
> >
> > Looks like something was missed. When building alpha:allnoconfig
> > in next-20221004:
> >
> > Building alpha:allnoconfig ... failed
> > --------------
> > Error log:
> > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
> > arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for
> > 'marvel_ioread8'; have 'unsigned int(const void *)'
> > 807 | marvel_ioread8(const void __iomem *xaddr)
> > | ^~~~~~~~~~~~~~
> > In file included from arch/alpha/kernel/core_marvel.c:10:
> > arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration
> > of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned
> > char(const void *)'}
> > 335 | extern u8 marvel_ioread8(const void __iomem *);
> > | ^~~~~~~~~~~~~~
>
> Right, I already noticed this and uploaded a fixed branch earlier today.
> Should be ok tomorrow.
>
Unfortunately that did not completely fix the problem, or maybe the fix got
lost. In mainline, when building alpha:allnoconfig:
arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'marvel_ioread8'
807 | marvel_ioread8(const void __iomem *xaddr)
The code is:
unsigned u8
marvel_ioread8(const void __iomem *xaddr)
The compiler doesn't like "unsigned u8".
#regzbot ^introduced: e19d4ebc536d
#regzbot title: alpha:allnoconfig fails to build
#regzbot monitor: https://lore.kernel.org/linux-arch/202210062117.wJypzBWL-lkp@intel.com/
Guenter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] alpha: Use generic <asm-generic/io.h>
2022-10-12 14:05 ` [PATCH] alpha: Use generic <asm-generic/io.h> Guenter Roeck
@ 2022-10-12 15:32 ` Arnd Bergmann
2022-10-13 12:36 ` [PATCH] alpha: Use generic <asm-generic/io.h> #forregzbot Thorsten Leemhuis
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2022-10-12 15:32 UTC (permalink / raw)
To: Guenter Roeck
Cc: Linus Walleij, Richard Henderson, Ivan Kokshaysky, Matt Turner,
linux-alpha, kernel test robot, Mark Brown, Linux-Arch,
regressions
On Wed, Oct 12, 2022, at 4:05 PM, Guenter Roeck wrote:
> On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote:
>> On Tue, Oct 4, 2022, at 9:42 PM, Guenter Roeck wrote:
>> > On 10/3/22 06:03, Arnd Bergmann wrote:
>> >> On Mon, Oct 3, 2022, at 12:45 AM, Guenter Roeck wrote:
>> >
>> > Looks like something was missed. When building alpha:allnoconfig
>> > in next-20221004:
>> >
>> > Building alpha:allnoconfig ... failed
>> > --------------
>> > Error log:
>> > <stdin>:1517:2: warning: #warning syscall clone3 not implemented [-Wcpp]
>> > arch/alpha/kernel/core_marvel.c:807:1: error: conflicting types for
>> > 'marvel_ioread8'; have 'unsigned int(const void *)'
>> > 807 | marvel_ioread8(const void __iomem *xaddr)
>> > | ^~~~~~~~~~~~~~
>> > In file included from arch/alpha/kernel/core_marvel.c:10:
>> > arch/alpha/include/asm/core_marvel.h:335:11: note: previous declaration
>> > of 'marvel_ioread8' with type 'u8(const void *)' {aka 'unsigned
>> > char(const void *)'}
>> > 335 | extern u8 marvel_ioread8(const void __iomem *);
>> > | ^~~~~~~~~~~~~~
>>
>> Right, I already noticed this and uploaded a fixed branch earlier today.
>> Should be ok tomorrow.
>>
>
> Unfortunately that did not completely fix the problem, or maybe the fix got
> lost. In mainline, when building alpha:allnoconfig:
>
> arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';',
> 'asm' or '__attribute__' before 'marvel_ioread8'
> 807 | marvel_ioread8(const void __iomem *xaddr)
>
> The code is:
>
> unsigned u8
> marvel_ioread8(const void __iomem *xaddr)
>
> The compiler doesn't like "unsigned u8".
Right, I fixed up a different bug and introduced this wrong type.
I didn't catch my mistake until after the pull request was
merged, but fixed it in
https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=2e21c1575208
which should be in linux-next. I was giving it a little more
time to be see if there are any other regressions I caused.
Arnd
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] alpha: Use generic <asm-generic/io.h> #forregzbot
2022-10-12 15:32 ` Arnd Bergmann
@ 2022-10-13 12:36 ` Thorsten Leemhuis
0 siblings, 0 replies; 3+ messages in thread
From: Thorsten Leemhuis @ 2022-10-13 12:36 UTC (permalink / raw)
To: regressions, Guenter Roeck; +Cc: linux-alpha, kernel test robot, Linux-Arch
[Note: this mail is primarily send for documentation purposes and/or for
regzbot, my Linux kernel regression tracking bot. That's why I removed
most or all folks from the list of recipients, but left any that looked
like a mailing lists. These mails usually contain '#forregzbot' in the
subject, to make them easy to spot and filter out.]
On 12.10.22 17:32, Arnd Bergmann wrote:
> On Wed, Oct 12, 2022, at 4:05 PM, Guenter Roeck wrote:
>> On Tue, Oct 04, 2022 at 10:28:24PM +0200, Arnd Bergmann wrote:
>> Unfortunately that did not completely fix the problem, or maybe the fix got
>> lost. In mainline, when building alpha:allnoconfig:
>>
>> arch/alpha/kernel/core_marvel.c:807:1: error: expected '=', ',', ';',
>> 'asm' or '__attribute__' before 'marvel_ioread8'
>> 807 | marvel_ioread8(const void __iomem *xaddr)
>>
>> The code is:
>>
>> unsigned u8
>> marvel_ioread8(const void __iomem *xaddr)
>>
>> The compiler doesn't like "unsigned u8".
>
> Right, I fixed up a different bug and introduced this wrong type.
> I didn't catch my mistake until after the pull request was
> merged, but fixed it in
>
> https://git.kernel.org/pub/scm/linux/kernel/git/arnd/asm-generic.git/commit/?id=2e21c1575208
>
> which should be in linux-next. I was giving it a little more
> time to be see if there are any other regressions I caused.
In that case:
#regzbot fixed-by: 2e21c157520
Ciao, Thorsten
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-13 12:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220818092059.103884-1-linus.walleij@linaro.org>
[not found] ` <20221002224521.GA968453@roeck-us.net>
[not found] ` <fd905ca5-fe0d-4cfb-a0d0-aea8af539cc7@app.fastmail.com>
[not found] ` <57200020-c460-74ec-c786-9a2c16f4870e@roeck-us.net>
[not found] ` <2e110666-7519-4693-8a89-240cbb118c7e@app.fastmail.com>
2022-10-12 14:05 ` [PATCH] alpha: Use generic <asm-generic/io.h> Guenter Roeck
2022-10-12 15:32 ` Arnd Bergmann
2022-10-13 12:36 ` [PATCH] alpha: Use generic <asm-generic/io.h> #forregzbot Thorsten Leemhuis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).