* New warning: ACPI: CEDT not present
@ 2022-02-15 7:51 Paul Menzel
2022-02-15 16:22 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2022-02-15 7:51 UTC (permalink / raw)
To: Dan Williams; +Cc: Rafael J. Wysocki, linux-acpi, LKML, regressions
#regzbot introduced: 2d03e46a4bad20191d07b83ec1242d5f002577be
Dear Dan,
On the Dell Latitude E7250, Linux 5.17-rc3 logs the warning below
(`dmesg --level=warn`):
ACPI: CEDT not present
I think commit 2d03e46a4bad (ACPI: Add a context argument for table
parsing handlers), part of Linux since 5.17-rc1, is the reason.
If I understand it correctly, CEDT is not to be expected on older
devices, so the warning is not justified. Can something be done about it?
Kind regards,
Paul
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New warning: ACPI: CEDT not present
2022-02-15 7:51 New warning: ACPI: CEDT not present Paul Menzel
@ 2022-02-15 16:22 ` Dan Williams
2022-02-15 17:11 ` Rafael J. Wysocki
0 siblings, 1 reply; 4+ messages in thread
From: Dan Williams @ 2022-02-15 16:22 UTC (permalink / raw)
To: Paul Menzel; +Cc: Rafael J. Wysocki, Linux ACPI, LKML, regressions
On Mon, Feb 14, 2022 at 11:52 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
>
> #regzbot introduced: 2d03e46a4bad20191d07b83ec1242d5f002577be
>
> Dear Dan,
>
>
> On the Dell Latitude E7250, Linux 5.17-rc3 logs the warning below
> (`dmesg --level=warn`):
>
> ACPI: CEDT not present
>
> I think commit 2d03e46a4bad (ACPI: Add a context argument for table
> parsing handlers), part of Linux since 5.17-rc1, is the reason.
>
> If I understand it correctly, CEDT is not to be expected on older
> devices, so the warning is not justified. Can something be done about it?
Rafael,
I'm inclined to just delete the warning altogether, but special casing
is also an option. Any preference?
diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 0741a4933f62..fb2e4a216154 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -399,7 +399,7 @@ int __init_or_acpilib acpi_table_parse_entries_array(
instance = acpi_apic_instance;
acpi_get_table(id, instance, &table_header);
- if (!table_header) {
+ if (!table_header && strcmp(id, ACPI_SIG_CEDT) != 0) {
pr_warn("%4.4s not present\n", id);
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: New warning: ACPI: CEDT not present
2022-02-15 16:22 ` Dan Williams
@ 2022-02-15 17:11 ` Rafael J. Wysocki
2022-02-15 17:28 ` Dan Williams
0 siblings, 1 reply; 4+ messages in thread
From: Rafael J. Wysocki @ 2022-02-15 17:11 UTC (permalink / raw)
To: Dan Williams
Cc: Paul Menzel, Rafael J. Wysocki, Linux ACPI, LKML, regressions
On Tue, Feb 15, 2022 at 5:22 PM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Mon, Feb 14, 2022 at 11:52 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> >
> > #regzbot introduced: 2d03e46a4bad20191d07b83ec1242d5f002577be
> >
> > Dear Dan,
> >
> >
> > On the Dell Latitude E7250, Linux 5.17-rc3 logs the warning below
> > (`dmesg --level=warn`):
> >
> > ACPI: CEDT not present
> >
> > I think commit 2d03e46a4bad (ACPI: Add a context argument for table
> > parsing handlers), part of Linux since 5.17-rc1, is the reason.
> >
> > If I understand it correctly, CEDT is not to be expected on older
> > devices, so the warning is not justified. Can something be done about it?
>
> Rafael,
>
> I'm inclined to just delete the warning altogether, but special casing
> is also an option. Any preference?
Change it into pr_debug()?
> diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
> index 0741a4933f62..fb2e4a216154 100644
> --- a/drivers/acpi/tables.c
> +++ b/drivers/acpi/tables.c
> @@ -399,7 +399,7 @@ int __init_or_acpilib acpi_table_parse_entries_array(
> instance = acpi_apic_instance;
>
> acpi_get_table(id, instance, &table_header);
> - if (!table_header) {
> + if (!table_header && strcmp(id, ACPI_SIG_CEDT) != 0) {
> pr_warn("%4.4s not present\n", id);
> return -ENODEV;
> }
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: New warning: ACPI: CEDT not present
2022-02-15 17:11 ` Rafael J. Wysocki
@ 2022-02-15 17:28 ` Dan Williams
0 siblings, 0 replies; 4+ messages in thread
From: Dan Williams @ 2022-02-15 17:28 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Paul Menzel, Rafael J. Wysocki, Linux ACPI, LKML, regressions
On Tue, Feb 15, 2022 at 9:14 AM Rafael J. Wysocki <rafael@kernel.org> wrote:
>
> On Tue, Feb 15, 2022 at 5:22 PM Dan Williams <dan.j.williams@intel.com> wrote:
> >
> > On Mon, Feb 14, 2022 at 11:52 PM Paul Menzel <pmenzel@molgen.mpg.de> wrote:
> > >
> > > #regzbot introduced: 2d03e46a4bad20191d07b83ec1242d5f002577be
> > >
> > > Dear Dan,
> > >
> > >
> > > On the Dell Latitude E7250, Linux 5.17-rc3 logs the warning below
> > > (`dmesg --level=warn`):
> > >
> > > ACPI: CEDT not present
> > >
> > > I think commit 2d03e46a4bad (ACPI: Add a context argument for table
> > > parsing handlers), part of Linux since 5.17-rc1, is the reason.
> > >
> > > If I understand it correctly, CEDT is not to be expected on older
> > > devices, so the warning is not justified. Can something be done about it?
> >
> > Rafael,
> >
> > I'm inclined to just delete the warning altogether, but special casing
> > is also an option. Any preference?
>
> Change it into pr_debug()?
Sounds good, patch inbound.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-15 17:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-15 7:51 New warning: ACPI: CEDT not present Paul Menzel
2022-02-15 16:22 ` Dan Williams
2022-02-15 17:11 ` Rafael J. Wysocki
2022-02-15 17:28 ` Dan Williams
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).