Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

[Thorsten Leemhuis]

Hi, this is your Linux kernel regression tracker.

On 14.12.22 14:32, Mark Brown wrote:
> On Fri, 09 Dec 2022 13:45:27 +0200, Kai Vehmanen wrote:
>> This patchset is an alternative solution to problems
>> reported by Ricardo Ribalda <ribalda@chromium.org> and
>> Zhen Ni <nizhen@uniontech.com>, as discussed in
>>
>> - "[PATCH] ALSA: core: Fix deadlock when shutdown a frozen userspace"
>>  https://mailman.alsa-project.org/pipermail/alsa-devel/2022-November/209248.html
>>
>> [...]
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
> 
> Thanks!
> 
> [1/2] ASoC: SOF: Intel: pci-tgl: unblock S5 entry if DMA stop has failed"
>       commit: 2aa2a5ead0ee0a358bf80a2984a641d1bf2adc2a
> [2/2] ASoC: SOF: Revert: "core: unregister clients and machine drivers in .shutdown"
>       commit: 44fda61d2bcfb74a942df93959e083a4e8eff75f
> 
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.
> [...]

I noticed a regression report in bugzilla:
https://bugzilla.kernel.org/show_bug.cgi?id=216820

```
> My laptop started to hang on hibernation (sleep and shutdown are
> fine). I bisected it to commit 83bfc7e793b555291785136c3ae86abcdc046887,
> which appears to be related to ALSA.
```

That's a commit the second patch from this series reverts. To my
untrained eyes it thus looks a lot like these change will resolve the
reported issue, which made me wonder:

* these patches afaics are not yet in mainline, is the plan to still
send it this cycle?

* there are no "CC: <stable..." tags in these patches. Is the plan to
manually ask for a backport? Or how can we get the regression fixed in
older releases?

Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)

P.S.: As the Linux kernel's regression tracker I deal with a lot of
reports and sometimes miss something important when writing mails like
this. If that's the case here, don't hesitate to tell me in a public
reply, it's in everyone's interest to set the public record straight.

Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 313 bytes --]

On Mon, Dec 19, 2022 at 10:41:41AM +0100, Thorsten Leemhuis wrote:

> * there are no "CC: <stable..." tags in these patches. Is the plan to
> manually ask for a backport? Or how can we get the regression fixed in
> older releases?

Speak to the stable maintainers I guess, or hope their bot picks the
commits up.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

[Kai Vehmanen]

Hi,

On Mon, 19 Dec 2022, Mark Brown wrote:

> On Mon, Dec 19, 2022 at 10:41:41AM +0100, Thorsten Leemhuis wrote:
> 
> > * there are no "CC: <stable..." tags in these patches. Is the plan to
> > manually ask for a backport? Or how can we get the regression fixed in
> > older releases?
> 
> Speak to the stable maintainers I guess, or hope their bot picks the
> commits up.

thanks Thorsten for the notice. These patches do lack the "Fixes:" tag, so 
it's possible the bots will not pick these up. I can follow up and send 
these to stable if this does not happen.

Br, Kai

Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

[Greg KH]

On Tue, Dec 20, 2022 at 01:41:01PM +0200, Kai Vehmanen wrote:
> Hi,
> 
> On Mon, 19 Dec 2022, Mark Brown wrote:
> 
> > On Mon, Dec 19, 2022 at 10:41:41AM +0100, Thorsten Leemhuis wrote:
> > 
> > > * there are no "CC: <stable..." tags in these patches. Is the plan to
> > > manually ask for a backport? Or how can we get the regression fixed in
> > > older releases?
> > 
> > Speak to the stable maintainers I guess, or hope their bot picks the
> > commits up.
> 
> thanks Thorsten for the notice. These patches do lack the "Fixes:" tag, so 
> it's possible the bots will not pick these up. I can follow up and send 
> these to stable if this does not happen.

"Fixes:" guarantees nothing, please NEVER rely on that.  As per the
kernel documentation for the last 18+ years, you have to tag a commit
with the "Cc: stable@..." tag to ensure that it gets picked up properly.

thanks,

greg k-h

Re: [PATCH 0/2] ASoC: SOF: remove unregister calls from shutdown

[Thorsten Leemhuis]

On 20.12.22 12:41, Kai Vehmanen wrote:
> 
> On Mon, 19 Dec 2022, Mark Brown wrote:
> 
>> On Mon, Dec 19, 2022 at 10:41:41AM +0100, Thorsten Leemhuis wrote:
>>
>>> * there are no "CC: <stable..." tags in these patches. Is the plan to
>>> manually ask for a backport? Or how can we get the regression fixed in
>>> older releases?
>>
>> Speak to the stable maintainers I guess, or hope their bot picks the
>> commits up.
> 
> thanks Thorsten for the notice. These patches do lack the "Fixes:" tag, so 
> it's possible the bots will not pick these up. I can follow up and send 
> these to stable if this does not happen.

Thanks, that would be great, I try to stay out of that business, as
actual developers of the code in question are in the best position to
judge and handle things like this.

Ciao, Thorsten