From: "Linux regression tracking (Thorsten Leemhuis)" <regressions@leemhuis.info>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Alexander Stein <alexander.stein@ew.tq-group.com>,
Arnd Bergmann <arnd@arndb.de>,
Dave Stevenson <dave.stevenson@raspberrypi.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Arnd Bergmann <arnd@kernel.org>
Subject: Re: [PATCH] media: i2c: imx290: fix conditional function defintions
Date: Mon, 20 Mar 2023 10:42:17 +0100 [thread overview]
Message-ID: <84540c66-166e-067a-e1d9-961234640d2e@leemhuis.info> (raw)
In-Reply-To: <ZBgoHvg3kxsVoSzg@kekkonen.localdomain>
On 20.03.23 10:32, Sakari Ailus wrote:
> On Mon, Mar 20, 2023 at 10:18:23AM +0100, Linux regression tracking (Thorsten Leemhuis) wrote:
>> On 07.02.23 17:40, Laurent Pinchart wrote:
>>> On Tue, Feb 07, 2023 at 05:13:12PM +0100, Arnd Bergmann wrote:
>>>> From: Arnd Bergmann <arnd@arndb.de>
>>>>
>>>> The runtime suspend/resume functions are only referenced from the
>>>> dev_pm_ops, but they use the old SET_RUNTIME_PM_OPS() helper
>>>> that requires a __maybe_unused annotation to avoid a warning:
>>>>
>>>> drivers/media/i2c/imx290.c:1082:12: error: unused function 'imx290_runtime_resume' [-Werror,-Wunused-function]
>>>> static int imx290_runtime_resume(struct device *dev)
>>>> ^
>>>> drivers/media/i2c/imx290.c:1090:12: error: unused function 'imx290_runtime_suspend' [-Werror,-Wunused-function]
>>>> static int imx290_runtime_suspend(struct device *dev)
>>>> ^
>>>>
>>
>> I might be missing something (if so, please tell me), but to me it looks
>> this fix for a build issue in 6.3-rc (which shows up in Guenters weekly
>> reports to Linus) didn't make any progress in the past few weeks. Is
>> there a reason why? Who actually needs to pick it up and send it towards
>> mainline? Manivannan Sadhasivam? Sakari Ailus?
>
> Mauro has recently pulled my PR including this and I understand it's in
> Mauro's tree now.
Ahh, great, many thx.
I checked Linux-next before writing my mail, but didn't sport it there. :-/
Ciao, Thorsten
next prev parent reply other threads:[~2023-03-20 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230207161316.293923-1-arnd@kernel.org>
[not found] ` <Y+J+7lsf083k4x80@pendragon.ideasonboard.com>
2023-03-20 9:18 ` [PATCH] media: i2c: imx290: fix conditional function defintions Linux regression tracking (Thorsten Leemhuis)
2023-03-20 9:32 ` Sakari Ailus
2023-03-20 9:42 ` Linux regression tracking (Thorsten Leemhuis) [this message]
2023-03-20 9:46 ` Thorsten Leemhuis
2023-03-20 9:51 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84540c66-166e-067a-e1d9-961234640d2e@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=alexander.stein@ew.tq-group.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dave.stevenson@raspberrypi.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mchehab@kernel.org \
--cc=regressions@lists.linux.dev \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).