* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
[not found] ` <87y20aod5d.fsf@kernel.org>
@ 2022-04-12 9:55 ` Thorsten Leemhuis
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
[not found] ` <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com>
1 sibling, 2 replies; 7+ messages in thread
From: Thorsten Leemhuis @ 2022-04-12 9:55 UTC (permalink / raw)
To: Kalle Valo, Philippe Schenker
Cc: linux-wireless, Felix Fietkau, David S. Miller, Deren Wu,
Jakub Kicinski, Lorenzo Bianconi, Matthias Brugger, Paolo Abeni,
Ryder Lee, Sean Wang, Shayne Chen, YN Chen, linux-arm-kernel,
linux-kernel, linux-mediatek, netdev, regressions
On 12.04.22 11:37, Kalle Valo wrote:
> Philippe Schenker <dev@pschenker.ch> writes:
>
>> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>>
>> This commit introduces a regression on some systems where the kernel is
>> crashing in different locations after a reboot was issued.
>>
>> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
>>
>> Link: https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
>> Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>
> Can I take this to wireless tree? Felix, ack?
>
> I'll also add:
>
> Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
Sorry, stupid questions from the regression tracker: wouldn't this cause
a regression for users of kernel versions post-bf3747ae2e25, as the
power consumption is likely to increase for them? Without having dug
into the backstory much: would disabling ASPM for this particular
machine using a quirk be the better approach? Or are we assuming a lot
of machines are affected?
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
P.S.: As the Linux kernel's regression tracker I'm getting a lot of
reports on my table. I can only look briefly into most of them and lack
knowledge about most of the areas they concern. I thus unfortunately
will sometimes get things wrong or miss something important. I hope
that's not the case here; if you think it is, don't hesitate to tell me
in a public reply, it's in everyone's interest to set the public record
straight.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
2022-04-12 9:55 ` [PATCH] Revert "mt76: mt7921: enable aspm by default" Thorsten Leemhuis
@ 2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
1 sibling, 0 replies; 7+ messages in thread
From: Kalle Valo @ 2022-04-12 10:33 UTC (permalink / raw)
To: Thorsten Leemhuis
Cc: Philippe Schenker, linux-wireless, Felix Fietkau,
David S. Miller, Deren Wu, Jakub Kicinski, Lorenzo Bianconi,
Matthias Brugger, Paolo Abeni, Ryder Lee, Sean Wang, Shayne Chen,
YN Chen, linux-arm-kernel, linux-kernel, linux-mediatek, netdev,
regressions
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> On 12.04.22 11:37, Kalle Valo wrote:
>> Philippe Schenker <dev@pschenker.ch> writes:
>>
>>> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>>>
>>> This commit introduces a regression on some systems where the kernel is
>>> crashing in different locations after a reboot was issued.
>>>
>>> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
>>>
>>> Link:
>>> https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
>>> Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>>
>> Can I take this to wireless tree? Felix, ack?
>>
>> I'll also add:
>>
>> Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
>
> Sorry, stupid questions from the regression tracker: wouldn't this cause
> a regression for users of kernel versions post-bf3747ae2e25, as the
> power consumption is likely to increase for them? Without having dug
> into the backstory much: would disabling ASPM for this particular
> machine using a quirk be the better approach? Or are we assuming a lot
> of machines are affected?
Kernel crashing is far more serious than increased power consumption. If
there's a better fix available in the next day or two of course that can
be considered. But if there's no such fix available, we have to revert
the commit.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
2022-04-12 9:55 ` [PATCH] Revert "mt76: mt7921: enable aspm by default" Thorsten Leemhuis
2022-04-12 10:33 ` Kalle Valo
@ 2022-04-12 10:36 ` Kalle Valo
2022-04-27 7:32 ` Thorsten Leemhuis
1 sibling, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2022-04-12 10:36 UTC (permalink / raw)
To: Thorsten Leemhuis
Cc: Philippe Schenker, linux-wireless, Felix Fietkau,
David S. Miller, Deren Wu, Jakub Kicinski, Lorenzo Bianconi,
Matthias Brugger, Paolo Abeni, Ryder Lee, Sean Wang, Shayne Chen,
YN Chen, linux-arm-kernel, linux-kernel, linux-mediatek, netdev,
regressions
Thorsten Leemhuis <regressions@leemhuis.info> writes:
> On 12.04.22 11:37, Kalle Valo wrote:
>> Philippe Schenker <dev@pschenker.ch> writes:
>>
>>> This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>>>
>>> This commit introduces a regression on some systems where the kernel is
>>> crashing in different locations after a reboot was issued.
>>>
>>> This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest firmware.
>>>
>>> Link:
>>> https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/
>>> Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>>
>> Can I take this to wireless tree? Felix, ack?
>>
>> I'll also add:
>>
>> Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
>
> Sorry, stupid questions from the regression tracker: wouldn't this cause
> a regression for users of kernel versions post-bf3747ae2e25, as the
> power consumption is likely to increase for them? Without having dug
> into the backstory much: would disabling ASPM for this particular
> machine using a quirk be the better approach? Or are we assuming a lot
> of machines are affected?
>
> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>
> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
> reports on my table. I can only look briefly into most of them and lack
> knowledge about most of the areas they concern. I thus unfortunately
> will sometimes get things wrong or miss something important. I hope
> that's not the case here; if you think it is, don't hesitate to tell me
> in a public reply, it's in everyone's interest to set the public record
> straight.
BTW, maybe you could add that boilerplace text after P.S. into the
signature (ie. under "-- " line)? That way your mails would more
readable and make it more clear that you didn't write the boilerplate
text specifically for this mail.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
2022-04-12 10:36 ` Kalle Valo
@ 2022-04-27 7:32 ` Thorsten Leemhuis
0 siblings, 0 replies; 7+ messages in thread
From: Thorsten Leemhuis @ 2022-04-27 7:32 UTC (permalink / raw)
To: Kalle Valo
Cc: Philippe Schenker, linux-wireless, Felix Fietkau,
David S. Miller, Deren Wu, Jakub Kicinski, Lorenzo Bianconi,
Matthias Brugger, Paolo Abeni, Ryder Lee, Sean Wang, Shayne Chen,
YN Chen, linux-arm-kernel, linux-kernel, linux-mediatek, netdev,
regressions
On 12.04.22 12:36, Kalle Valo wrote:
>> Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
>> [...]
>> P.S.: As the Linux kernel's regression tracker I'm getting a lot of
>> reports on my table. I can only look briefly into most of them and lack
>> knowledge about most of the areas they concern. I thus unfortunately
>> will sometimes get things wrong or miss something important. I hope
>> that's not the case here; if you think it is, don't hesitate to tell me
>> in a public reply, it's in everyone's interest to set the public record
>> straight.
> BTW, maybe you could add that boilerplace text after P.S. into the
> signature (ie. under "-- " line)? That way your mails would more
> readable and make it more clear that you didn't write the boilerplate
> text specifically for this mail.
Late reply:
FYI, I thought back and forth about the boilerplace text and how to
handle that when I started using it. I deliberately decided against
putting it under a "-- " line, as that wouldn't work well for some of
the mails I write -- for example those where I deliberately use
top-posting (which I hate and kinda feels wrong, but nevertheless right
at the same time) to make this as easy to grasp as possible.
After your comment I have thought about it again for a while but in the
end for now decided to mostly stick to the approach I used, but your
comment made me shorten the text a bit.
Ciao, Thorsten
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
[not found] ` <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch>
@ 2022-06-01 8:58 ` Kalle Valo
2022-06-01 16:55 ` Deren Wu
0 siblings, 1 reply; 7+ messages in thread
From: Kalle Valo @ 2022-06-01 8:58 UTC (permalink / raw)
To: Philippe Schenker
Cc: Deren Wu, linux-wireless, Felix Fietkau, linux, David S. Miller,
Jakub Kicinski, Lorenzo Bianconi, Matthias Brugger, Paolo Abeni,
Ryder Lee, Sean Wang, Shayne Chen, YN Chen, linux-arm-kernel,
linux-kernel, linux-mediatek, netdev, regressions
Philippe Schenker <dev@pschenker.ch> writes:
> On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
>> On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
>> > Philippe Schenker <dev@pschenker.ch> writes:
>> >
>> > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
>> > >
>> > > This commit introduces a regression on some systems where the
>> > > kernel is
>> > > crashing in different locations after a reboot was issued.
>> > >
>> > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with latest
>> > > firmware.
>> > >
>> > > Link:
>> > > https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
>> > >
>> > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
>> >
>> > Can I take this to wireless tree? Felix, ack?
>> >
>> > I'll also add:
>> >
>> > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
>> >
>>
>> Hi Kalle,
>>
>> We have a patch for a similar problem. Can you wait for the
>> verification by Philippe?
>> Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
>> after
>> reboot")
>> Link:
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380
>>
>> I can reproduce the problem in my v5.16-rc5 desktop. And the issue can
>> be fixed when the patch applied.
>>
>>
>> Hi Philippe,
>>
>> Can you please help to check the patch in your platform?
>
> Hi Kalle and Deren,
>
> I just noticed on my system and mainline v5.18 reboots do now work
> however Bluetooth is no longer accessible after a reboot.
>
> Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of
> v5.18 solves this problem for me.
>
> @Deren are you aware of this bug?
> @Kalle Is there a bugtracker somewhere I can submit this?
For regressions the best is to submit it to the regressions list, CCed
it now.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
2022-06-01 8:58 ` Kalle Valo
@ 2022-06-01 16:55 ` Deren Wu
2022-06-02 10:00 ` Philippe Schenker
0 siblings, 1 reply; 7+ messages in thread
From: Deren Wu @ 2022-06-01 16:55 UTC (permalink / raw)
To: Kalle Valo, Philippe Schenker
Cc: linux-wireless, Felix Fietkau, linux, David S. Miller,
Jakub Kicinski, Lorenzo Bianconi, Matthias Brugger, Paolo Abeni,
Ryder Lee, Sean Wang, Shayne Chen, YN Chen, linux-arm-kernel,
linux-kernel, linux-mediatek, netdev, regressions
On Wed, 2022-06-01 at 11:58 +0300, Kalle Valo wrote:
> Philippe Schenker <dev@pschenker.ch> writes:
>
> > On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> > > On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > > > Philippe Schenker <dev@pschenker.ch> writes:
> > > >
> > > > > This reverts commit bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > > > >
> > > > > This commit introduces a regression on some systems where the
> > > > > kernel is
> > > > > crashing in different locations after a reboot was issued.
> > > > >
> > > > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with
> > > > > latest
> > > > > firmware.
> > > > >
> > > > > Link:
> > > > >
https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
> > > > >
> > > > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
> > > >
> > > > Can I take this to wireless tree? Felix, ack?
> > > >
> > > > I'll also add:
> > > >
> > > > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> > > >
> > >
> > > Hi Kalle,
> > >
> > > We have a patch for a similar problem. Can you wait for the
> > > verification by Philippe?
> > > Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe failure
> > > after
> > > reboot")
> > > Link:
> > >
https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380__;!!CTRNKA9wMg0ARbw!zCYyDcufJ-OLqQV6leCegA5SkNOOVjAIo-jzTHTk6HUWT9Gjt-bvSz8lr81Zv95u$
> > >
> > >
> > > I can reproduce the problem in my v5.16-rc5 desktop. And the
> > > issue can
> > > be fixed when the patch applied.
> > >
> > >
> > > Hi Philippe,
> > >
> > > Can you please help to check the patch in your platform?
> >
> > Hi Kalle and Deren,
> >
> > I just noticed on my system and mainline v5.18 reboots do now work
> > however Bluetooth is no longer accessible after a reboot.
> >
> > Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top of
> > v5.18 solves this problem for me.
> >
> > @Deren are you aware of this bug?
> > @Kalle Is there a bugtracker somewhere I can submit this?
>
> For regressions the best is to submit it to the regressions list,
> CCed
> it now.
>
Hi Philippe,
Tried your test with v5.18.0 on my desktop and both wifi/bt are still
avaible after reboot. The only problem is I need to insert btusb module
by command "modprobe btusb" to make BT workable.
I will check the issue on different platforms. If there are any
finding, I will let you know.
Regards,
Deren
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Revert "mt76: mt7921: enable aspm by default"
2022-06-01 16:55 ` Deren Wu
@ 2022-06-02 10:00 ` Philippe Schenker
0 siblings, 0 replies; 7+ messages in thread
From: Philippe Schenker @ 2022-06-02 10:00 UTC (permalink / raw)
To: Deren Wu, Kalle Valo
Cc: linux-wireless, Felix Fietkau, linux, David S. Miller,
Jakub Kicinski, Lorenzo Bianconi, Matthias Brugger, Paolo Abeni,
Ryder Lee, Sean Wang, Shayne Chen, YN Chen, linux-arm-kernel,
linux-kernel, linux-mediatek, netdev, regressions
On Thu, 2022-06-02 at 00:55 +0800, Deren Wu wrote:
> On Wed, 2022-06-01 at 11:58 +0300, Kalle Valo wrote:
> > Philippe Schenker <dev@pschenker.ch> writes:
> >
> > > On Tue, 2022-04-12 at 19:06 +0800, Deren Wu wrote:
> > > > On Tue, 2022-04-12 at 12:37 +0300, Kalle Valo wrote:
> > > > > Philippe Schenker <dev@pschenker.ch> writes:
> > > > >
> > > > > > This reverts commit
> > > > > > bf3747ae2e25dda6a9e6c464a717c66118c588c8.
> > > > > >
> > > > > > This commit introduces a regression on some systems where
> > > > > > the
> > > > > > kernel is
> > > > > > crashing in different locations after a reboot was issued.
> > > > > >
> > > > > > This issue was bisected on a Thinkpad P14s Gen2 (AMD) with
> > > > > > latest
> > > > > > firmware.
> > > > > >
> > > > > > Link:
> > > > > >
> https://urldefense.com/v3/__https://lore.kernel.org/linux-wireless/5077a953487275837e81bdf1808ded00b9676f9f.camel@pschenker.ch/__;!!CTRNKA9wMg0ARbw!09tjyaQlMci3fVI3yiNiDJKUW_qwNA_CbVhoAraeIX96B99Q14J4iDycWA9cq36Y$
> > > > > >
> > > > > > Signed-off-by: Philippe Schenker <dev@pschenker.ch>
> > > > >
> > > > > Can I take this to wireless tree? Felix, ack?
> > > > >
> > > > > I'll also add:
> > > > >
> > > > > Fixes: bf3747ae2e25 ("mt76: mt7921: enable aspm by default")
> > > > >
> > > >
> > > > Hi Kalle,
> > > >
> > > > We have a patch for a similar problem. Can you wait for the
> > > > verification by Philippe?
> > > > Commit 602cc0c9618a81 ("mt76: mt7921e: fix possible probe
> > > > failure
> > > > after
> > > > reboot")
> > > > Link:
> > > >
> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/net/wireless/mediatek/mt76?id=602cc0c9618a819ab00ea3c9400742a0ca318380__;!!CTRNKA9wMg0ARbw!zCYyDcufJ-OLqQV6leCegA5SkNOOVjAIo-jzTHTk6HUWT9Gjt-bvSz8lr81Zv95u$
> > > >
> > > >
> > > > I can reproduce the problem in my v5.16-rc5 desktop. And the
> > > > issue can
> > > > be fixed when the patch applied.
> > > >
> > > >
> > > > Hi Philippe,
> > > >
> > > > Can you please help to check the patch in your platform?
> > >
> > > Hi Kalle and Deren,
> > >
> > > I just noticed on my system and mainline v5.18 reboots do now work
> > > however Bluetooth is no longer accessible after a reboot.
> > >
> > > Reverting commit bf3747ae2e25dda6a9e6c464a717c66118c588c8 on top
> > > of
> > > v5.18 solves this problem for me.
> > >
> > > @Deren are you aware of this bug?
> > > @Kalle Is there a bugtracker somewhere I can submit this?
> >
> > For regressions the best is to submit it to the regressions list,
> > CCed
> > it now.
> >
> Hi Philippe,
>
> Tried your test with v5.18.0 on my desktop and both wifi/bt are still
> avaible after reboot. The only problem is I need to insert btusb
> module
> by command "modprobe btusb" to make BT workable.
>
> I will check the issue on different platforms. If there are any
> finding, I will let you know.
Thanks for your tests, I did test again on my platform. This time with a
hand-built v5.18 straight from torvalds/linux. And I can confirm my
findings I even loaded btusb (removed and reloaded) nothing helped. I
always get the message
No default controller available
In this case I guess it could be rather a BIOS issue. In this testing
round also some USB ports did not work.
If it helps any my system is a Lenovo P14s Gen2. I believe then the
driver is good.
Regards,
Philippe
>
> Regards,
> Deren
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-06-02 11:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220412090415.17541-1-dev@pschenker.ch>
[not found] ` <87y20aod5d.fsf@kernel.org>
2022-04-12 9:55 ` [PATCH] Revert "mt76: mt7921: enable aspm by default" Thorsten Leemhuis
2022-04-12 10:33 ` Kalle Valo
2022-04-12 10:36 ` Kalle Valo
2022-04-27 7:32 ` Thorsten Leemhuis
[not found] ` <668f1310cc78b17c24ce7be10f5f907d5578e280.camel@mediatek.com>
[not found] ` <e93aef5c9f8a97efe23cfb5892f78f919ce328e7.camel@pschenker.ch>
2022-06-01 8:58 ` Kalle Valo
2022-06-01 16:55 ` Deren Wu
2022-06-02 10:00 ` Philippe Schenker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).