* Re: [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" [not found] ` <YgEeQNdgBuHRyEWl@dumbo> @ 2022-02-08 6:46 ` Thorsten Leemhuis 2022-02-10 9:50 ` [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" #forregzbot Thorsten Leemhuis [not found] ` <YgGTSR628xhRvCjB@bombadil.infradead.org> 1 sibling, 1 reply; 7+ messages in thread From: Thorsten Leemhuis @ 2022-02-08 6:46 UTC (permalink / raw) To: Domenico Andreoli, airlied, akpm, amir73il, andriy.shevchenko, arnd, bcrl, benh, clemens, crope, dgilbert, ebiederm, gregkh, jack, jani.nikula, jani.nikula, jejb, jlbec, john.ogness, joonas.lahtinen, joseph.qi, julia.lawall, keescook, kernel, linux-mm, mark, martin.petersen, mcgrof, mm-commits, nixiaoming, penguin-kernel, peterz, phil, pjt, pmladek, rafael, rodrigo.vivi, rostedt, senozhatsky, sre, steve, surenb, torvalds, tytso, viro, wangqing, yzaikin Cc: linux-kernel, regressions [TLDR: I'm adding the regression report below to regzbot, the Linux kernel regression tracking bot; all text you find below is compiled from a few templates paragraphs you might have encountered already already from similar mails.] Hi, this is your Linux kernel regression tracker speaking. CCing the regression mailing list, as it should be in the loop for all regressions, as explained here: https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html On 07.02.22 14:27, Domenico Andreoli wrote: > Commit 3ba442d5331f did not go unnoticed, binfmt-support stopped to > work on my Debian system since v5.17-rc2 (did not check with -rc1). > > The existance of /proc/sys/fs/binfmt_misc is a precondition for > attempting to mount the binfmt_misc fs, which in turn triggers the > autoload of the binfmt_misc module. Without it, no module is loaded > and no binfmt is available at boot. > > Building as built-in or manually loading the module and mounting the fs > works fine, it's therefore only a matter of interaction with user-space. > > I could try to improve the Debian systemd configuration but I can't > say anything about the other distributions. > > In the meanwhile this patch restores a working system right after boot. > [...] To be sure this issue doesn't fall through the cracks unnoticed, I'm adding it to regzbot, my Linux kernel regression tracking bot: #regzbot ^introduced 3ba442d5331f #regzbot title binfmt-support stopped to work #regzbot ignore-activity Reminder for developers: when fixing the issue, please add a 'Link:' tags pointing to the report (the mail quoted above) using lore.kernel.org/r/, as explained in 'Documentation/process/submitting-patches.rst' and 'Documentation/process/5.Posting.rst'. This allows the bot to connect the report with any patches posted or committed to fix the issue; this again allows the bot to show the current status of regressions and automatically resolve the issue when the fix hits the right tree. I'm sending this to everyone that got the initial report, to make them aware of the tracking. I also hope that messages like this motivate people to directly get at least the regression mailing list and ideally even regzbot involved when dealing with regressions, as messages like this wouldn't be needed then. Don't worry, I'll send further messages wrt to this regression just to the lists (with a tag in the subject so people can filter them away), if they are relevant just for regzbot. With a bit of luck no such messages will be needed anyway. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them and lack knowledge about most of the areas they concern. I thus unfortunately will sometimes get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. -- Additional information about regzbot: If you want to know more about regzbot, check out its web-interface, the getting start guide, and the references documentation: https://linux-regtracking.leemhuis.info/regzbot/ https://gitlab.com/knurd42/regzbot/-/blob/main/docs/getting_started.md https://gitlab.com/knurd42/regzbot/-/blob/main/docs/reference.md The last two documents will explain how you can interact with regzbot yourself if your want to. Hint for reporters: when reporting a regression it's in your interest to CC the regression list and tell regzbot about the issue, as that ensures the regression makes it onto the radar of the Linux kernel's regression tracker -- that's in your interest, as it ensures your report won't fall through the cracks unnoticed. Hint for developers: you normally don't need to care about regzbot once it's involved. Fix the issue as you normally would, just remember to include 'Link:' tag in the patch descriptions pointing to all reports about the issue. This has been expected from developers even before regzbot showed up for reasons explained in 'Documentation/process/submitting-patches.rst' and 'Documentation/process/5.Posting.rst'. ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" #forregzbot 2022-02-08 6:46 ` [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Thorsten Leemhuis @ 2022-02-10 9:50 ` Thorsten Leemhuis 0 siblings, 0 replies; 7+ messages in thread From: Thorsten Leemhuis @ 2022-02-10 9:50 UTC (permalink / raw) To: regressions, Domenico Andreoli For the record: Sadly the fix for below regression didn't link to the report, as explained by 'Documentation/process/submitting-patches.rst' and 'Documentation/process/5.Posting.rst'. So I have to tell regzbot about the fix manually: #regzbot fixed-by: b42bc9a3c5115c https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?h=master&id=b42bc9a3c5115c3102a4923776bbeed3b191f2db Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) P.S.: As the Linux kernel's regression tracker I'm getting a lot of reports on my table. I can only look briefly into most of them and lack knowledge about most of the areas they concern. I thus unfortunately will sometimes get things wrong or miss something important. I hope that's not the case here; if you think it is, don't hesitate to tell me in a public reply, it's in everyone's interest to set the public record straight. TWIMC: this mail is primarily send for documentation purposes and for regzbot, my Linux kernel regression tracking bot. These mails usually contain '#forregzbot' in the subject, to make them easy to spot and filter. On 08.02.22 07:46, Thorsten Leemhuis wrote: > > [TLDR: I'm adding the regression report below to regzbot, the Linux > kernel regression tracking bot; all text you find below is compiled from > a few templates paragraphs you might have encountered already already > from similar mails.] > > Hi, this is your Linux kernel regression tracker speaking. > > CCing the regression mailing list, as it should be in the loop for all > regressions, as explained here: > https://www.kernel.org/doc/html/latest/admin-guide/reporting-issues.html > > On 07.02.22 14:27, Domenico Andreoli wrote: >> Commit 3ba442d5331f did not go unnoticed, binfmt-support stopped to >> work on my Debian system since v5.17-rc2 (did not check with -rc1). >> >> The existance of /proc/sys/fs/binfmt_misc is a precondition for >> attempting to mount the binfmt_misc fs, which in turn triggers the >> autoload of the binfmt_misc module. Without it, no module is loaded >> and no binfmt is available at boot. >> >> Building as built-in or manually loading the module and mounting the fs >> works fine, it's therefore only a matter of interaction with user-space. >> >> I could try to improve the Debian systemd configuration but I can't >> say anything about the other distributions. >> >> In the meanwhile this patch restores a working system right after boot. >> [...] > > To be sure this issue doesn't fall through the cracks unnoticed, I'm > adding it to regzbot, my Linux kernel regression tracking bot: > > #regzbot ^introduced 3ba442d5331f > #regzbot title binfmt-support stopped to work > #regzbot ignore-activity > > Reminder for developers: when fixing the issue, please add a 'Link:' > tags pointing to the report (the mail quoted above) using > lore.kernel.org/r/, as explained in > 'Documentation/process/submitting-patches.rst' and > 'Documentation/process/5.Posting.rst'. This allows the bot to connect > the report with any patches posted or committed to fix the issue; this > again allows the bot to show the current status of regressions and > automatically resolve the issue when the fix hits the right tree. > > I'm sending this to everyone that got the initial report, to make them > aware of the tracking. I also hope that messages like this motivate > people to directly get at least the regression mailing list and ideally > even regzbot involved when dealing with regressions, as messages like > this wouldn't be needed then. > > Don't worry, I'll send further messages wrt to this regression just to > the lists (with a tag in the subject so people can filter them away), if > they are relevant just for regzbot. With a bit of luck no such messages > will be needed anyway. > > Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) > > P.S.: As the Linux kernel's regression tracker I'm getting a lot of > reports on my table. I can only look briefly into most of them and lack > knowledge about most of the areas they concern. I thus unfortunately > will sometimes get things wrong or miss something important. I hope > that's not the case here; if you think it is, don't hesitate to tell me > in a public reply, it's in everyone's interest to set the public record > straight. > ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <YgGTSR628xhRvCjB@bombadil.infradead.org>]
[parent not found: <CAA5qM4BGmrkwatyO_h3F=ErDZ9t5swuttbt6NkQU-1KDGDiD4g@mail.gmail.com>]
[parent not found: <YgKmaggsipzzCGCg@bombadil.infradead.org>]
* [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" [not found] ` <YgKmaggsipzzCGCg@bombadil.infradead.org> @ 2022-02-09 7:49 ` Domenico Andreoli 2022-02-09 7:55 ` Tong Zhang 2022-02-13 15:34 ` Ido Schimmel 0 siblings, 2 replies; 7+ messages in thread From: Domenico Andreoli @ 2022-02-09 7:49 UTC (permalink / raw) To: Luis Chamberlain Cc: Tong Zhang, Eric W. Biederman, David Airlie, Andrew Morton, amir73il, Andy Shevchenko, Arnd Bergmann, bcrl, benh, clemens, crope, dgilbert, Greg KH, jack, jani.nikula, jani.nikula, James E.J. Bottomley, jlbec, john.ogness, joonas.lahtinen, Joseph Qi, julia.lawall, Kees Cook, kernel, Linux Memory Management List, mark, Martin K. Petersen, mm-commits, nixiaoming, penguin-kernel, peterz, phil, pjt, pmladek, rafael, rodrigo.vivi, rostedt, senozhatsky, sre, steve, surenb, torvalds, tytso, Al Viro, wangqing, Iurii Zaikin, open list, regressions Commit 3ba442d5331f did not go unnoticed, binfmt-support stopped to work on my Debian system since v5.17-rc2 (did not check with -rc1). The existance of the /proc/sys/fs/binfmt_misc is a precondition for attempting to mount the binfmt_misc fs, which in turn triggers the autoload of the binfmt_misc module. Without it, no module is loaded and no binfmt is available at boot. Building as built-in or manually loading the module and mounting the fs works fine, it's therefore only a matter of interaction with user-space. I could try to improve the Debian systemd configuration but I can't say anything about the other distributions. This patch restores a working system right after boot. v2: - move creation of fs/binfmt_misc to fs/file_table.c - use IS_ENABLED() to conditionally create it Fixes: 3ba442d5331f ("fs: move binfmt_misc sysctl to its own file") Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Amir Goldstein <amir73il@gmail.com> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: Antti Palosaari <crope@iki.fi> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Benjamin LaHaise <bcrl@kvack.org> Cc: Clemens Ladisch <clemens@ladisch.de> Cc: David Airlie <airlied@linux.ie> Cc: Douglas Gilbert <dgilbert@interlog.com> Cc: Eric Biederman <ebiederm@xmission.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Iurii Zaikin <yzaikin@google.com> Cc: James E.J. Bottomley <jejb@linux.ibm.com> Cc: Jan Kara <jack@suse.cz> Cc: Jani Nikula <jani.nikula@intel.com> Cc: Jani Nikula <jani.nikula@linux.intel.com> Cc: Joel Becker <jlbec@evilplan.org> Cc: John Ogness <john.ogness@linutronix.de> Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> Cc: Joseph Qi <joseph.qi@linux.alibaba.com> Cc: Julia Lawall <julia.lawall@inria.fr> Cc: Kees Cook <keescook@chromium.org> Cc: Lukas Middendorf <kernel@tuxforce.de> Cc: Mark Fasheh <mark@fasheh.com> Cc: Martin K. Petersen <martin.petersen@oracle.com> Cc: Paul Turner <pjt@google.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Petr Mladek <pmladek@suse.com> Cc: Phillip Potter <phil@philpotter.co.uk> Cc: Qing Wang <wangqing@vivo.com> Cc: "Rafael J. Wysocki" <rafael@kernel.org> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> Cc: Sebastian Reichel <sre@kernel.org> Cc: Sergey Senozhatsky <senozhatsky@chromium.org> Cc: Stephen Kitt <steve@sk2.org> Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> Cc: Suren Baghdasaryan <surenb@google.com> Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Xiaoming Ni <nixiaoming@huawei.com> --- fs/binfmt_misc.c | 6 +----- fs/file_table.c | 2 ++ 2 files changed, 3 insertions(+), 5 deletions(-) Index: b/fs/binfmt_misc.c =================================================================== --- a/fs/binfmt_misc.c +++ b/fs/binfmt_misc.c @@ -817,20 +817,16 @@ static struct file_system_type bm_fs_typ }; MODULE_ALIAS_FS("binfmt_misc"); -static struct ctl_table_header *binfmt_misc_header; - static int __init init_misc_binfmt(void) { int err = register_filesystem(&bm_fs_type); if (!err) insert_binfmt(&misc_format); - binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc"); - return 0; + return err; } static void __exit exit_misc_binfmt(void) { - unregister_sysctl_table(binfmt_misc_header); unregister_binfmt(&misc_format); unregister_filesystem(&bm_fs_type); } Index: b/fs/file_table.c =================================================================== --- a/fs/file_table.c +++ b/fs/file_table.c @@ -119,6 +119,8 @@ static struct ctl_table fs_stat_sysctls[ static int __init init_fs_stat_sysctls(void) { register_sysctl_init("fs", fs_stat_sysctls); + if (IS_ENABLED(CONFIG_BINFMT_MISC)) + register_sysctl_mount_point("fs/binfmt_misc"); return 0; } fs_initcall(init_fs_stat_sysctls); ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" 2022-02-09 7:49 ` [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Domenico Andreoli @ 2022-02-09 7:55 ` Tong Zhang 2022-02-13 15:34 ` Ido Schimmel 1 sibling, 0 replies; 7+ messages in thread From: Tong Zhang @ 2022-02-09 7:55 UTC (permalink / raw) To: Domenico Andreoli Cc: Luis Chamberlain, Eric W. Biederman, David Airlie, Andrew Morton, amir73il, Andy Shevchenko, Arnd Bergmann, bcrl, benh, clemens, crope, dgilbert, Greg KH, jack, jani.nikula, jani.nikula, James E.J. Bottomley, jlbec, john.ogness, joonas.lahtinen, Joseph Qi, julia.lawall, Kees Cook, kernel, Linux Memory Management List, Mark Fasheh, Martin K. Petersen, mm-commits, nixiaoming, penguin-kernel, peterz, Phillip Potter, Paul Turner, pmladek, rafael, rodrigo.vivi, rostedt, senozhatsky, sre, steve, Suren Baghdasaryan, torvalds, tytso, Al Viro, wangqing, Iurii Zaikin, open list, regressions On Tue, Feb 8, 2022 at 11:49 PM Domenico Andreoli <domenico.andreoli@linux.com> wrote: > > Commit 3ba442d5331f did not go unnoticed, binfmt-support stopped to > work on my Debian system since v5.17-rc2 (did not check with -rc1). > > The existance of the /proc/sys/fs/binfmt_misc is a precondition for > attempting to mount the binfmt_misc fs, which in turn triggers the > autoload of the binfmt_misc module. Without it, no module is loaded > and no binfmt is available at boot. > > Building as built-in or manually loading the module and mounting the fs > works fine, it's therefore only a matter of interaction with user-space. > I could try to improve the Debian systemd configuration but I can't > say anything about the other distributions. > > This patch restores a working system right after boot. > > v2: > - move creation of fs/binfmt_misc to fs/file_table.c > - use IS_ENABLED() to conditionally create it > > Fixes: 3ba442d5331f ("fs: move binfmt_misc sysctl to its own file") > Signed-off-by: Domenico Andreoli <domenico.andreoli@linux.com> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Amir Goldstein <amir73il@gmail.com> > Cc: Andrew Morton <akpm@linux-foundation.org> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Antti Palosaari <crope@iki.fi> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: Benjamin LaHaise <bcrl@kvack.org> > Cc: Clemens Ladisch <clemens@ladisch.de> > Cc: David Airlie <airlied@linux.ie> > Cc: Douglas Gilbert <dgilbert@interlog.com> > Cc: Eric Biederman <ebiederm@xmission.com> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > Cc: Iurii Zaikin <yzaikin@google.com> > Cc: James E.J. Bottomley <jejb@linux.ibm.com> > Cc: Jan Kara <jack@suse.cz> > Cc: Jani Nikula <jani.nikula@intel.com> > Cc: Jani Nikula <jani.nikula@linux.intel.com> > Cc: Joel Becker <jlbec@evilplan.org> > Cc: John Ogness <john.ogness@linutronix.de> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com> > Cc: Joseph Qi <joseph.qi@linux.alibaba.com> > Cc: Julia Lawall <julia.lawall@inria.fr> > Cc: Kees Cook <keescook@chromium.org> > Cc: Lukas Middendorf <kernel@tuxforce.de> > Cc: Mark Fasheh <mark@fasheh.com> > Cc: Martin K. Petersen <martin.petersen@oracle.com> > Cc: Paul Turner <pjt@google.com> > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Petr Mladek <pmladek@suse.com> > Cc: Phillip Potter <phil@philpotter.co.uk> > Cc: Qing Wang <wangqing@vivo.com> > Cc: "Rafael J. Wysocki" <rafael@kernel.org> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com> > Cc: Sebastian Reichel <sre@kernel.org> > Cc: Sergey Senozhatsky <senozhatsky@chromium.org> > Cc: Stephen Kitt <steve@sk2.org> > Cc: Steven Rostedt (VMware) <rostedt@goodmis.org> > Cc: Suren Baghdasaryan <surenb@google.com> > Cc: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp> > Cc: "Theodore Ts'o" <tytso@mit.edu> > Cc: Xiaoming Ni <nixiaoming@huawei.com> > > --- > fs/binfmt_misc.c | 6 +----- > fs/file_table.c | 2 ++ > 2 files changed, 3 insertions(+), 5 deletions(-) > > Index: b/fs/binfmt_misc.c > =================================================================== > --- a/fs/binfmt_misc.c > +++ b/fs/binfmt_misc.c > @@ -817,20 +817,16 @@ static struct file_system_type bm_fs_typ > }; > MODULE_ALIAS_FS("binfmt_misc"); > > -static struct ctl_table_header *binfmt_misc_header; > - > static int __init init_misc_binfmt(void) > { > int err = register_filesystem(&bm_fs_type); > if (!err) > insert_binfmt(&misc_format); > - binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc"); > - return 0; > + return err; > } > > static void __exit exit_misc_binfmt(void) > { > - unregister_sysctl_table(binfmt_misc_header); > unregister_binfmt(&misc_format); > unregister_filesystem(&bm_fs_type); > } > Index: b/fs/file_table.c > =================================================================== > --- a/fs/file_table.c > +++ b/fs/file_table.c > @@ -119,6 +119,8 @@ static struct ctl_table fs_stat_sysctls[ > static int __init init_fs_stat_sysctls(void) > { > register_sysctl_init("fs", fs_stat_sysctls); > + if (IS_ENABLED(CONFIG_BINFMT_MISC)) > + register_sysctl_mount_point("fs/binfmt_misc"); > return 0; > } > fs_initcall(init_fs_stat_sysctls); Looks good Thanks! Reviewed-by: Tong Zhang <ztong0001@gmail.com> ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" 2022-02-09 7:49 ` [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Domenico Andreoli 2022-02-09 7:55 ` Tong Zhang @ 2022-02-13 15:34 ` Ido Schimmel 2022-02-13 21:10 ` Tong Zhang 1 sibling, 1 reply; 7+ messages in thread From: Ido Schimmel @ 2022-02-13 15:34 UTC (permalink / raw) To: Domenico Andreoli Cc: Luis Chamberlain, Tong Zhang, Eric W. Biederman, David Airlie, Andrew Morton, amir73il, Andy Shevchenko, Arnd Bergmann, bcrl, benh, clemens, crope, dgilbert, Greg KH, jack, jani.nikula, jani.nikula, James E.J. Bottomley, jlbec, john.ogness, joonas.lahtinen, Joseph Qi, julia.lawall, Kees Cook, kernel, Linux Memory Management List, mark, Martin K. Petersen, mm-commits, nixiaoming, penguin-kernel, peterz, phil, pjt, pmladek, rafael, rodrigo.vivi, rostedt, senozhatsky, sre, steve, surenb, torvalds, tytso, Al Viro, wangqing, Iurii Zaikin, open list, regressions On Wed, Feb 09, 2022 at 08:49:20AM +0100, Domenico Andreoli wrote: > fs/binfmt_misc.c | 6 +----- > fs/file_table.c | 2 ++ > 2 files changed, 3 insertions(+), 5 deletions(-) > > Index: b/fs/binfmt_misc.c > =================================================================== > --- a/fs/binfmt_misc.c > +++ b/fs/binfmt_misc.c > @@ -817,20 +817,16 @@ static struct file_system_type bm_fs_typ > }; > MODULE_ALIAS_FS("binfmt_misc"); > > -static struct ctl_table_header *binfmt_misc_header; > - > static int __init init_misc_binfmt(void) > { > int err = register_filesystem(&bm_fs_type); > if (!err) > insert_binfmt(&misc_format); > - binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc"); > - return 0; > + return err; > } > > static void __exit exit_misc_binfmt(void) > { > - unregister_sysctl_table(binfmt_misc_header); > unregister_binfmt(&misc_format); > unregister_filesystem(&bm_fs_type); > } > Index: b/fs/file_table.c > =================================================================== > --- a/fs/file_table.c > +++ b/fs/file_table.c > @@ -119,6 +119,8 @@ static struct ctl_table fs_stat_sysctls[ > static int __init init_fs_stat_sysctls(void) > { > register_sysctl_init("fs", fs_stat_sysctls); > + if (IS_ENABLED(CONFIG_BINFMT_MISC)) > + register_sysctl_mount_point("fs/binfmt_misc"); Hi, kmemleak complains about this: # cat /sys/kernel/debug/kmemleak unreferenced object 0xffff8881045fea88 (size 96): comm "swapper/0", pid 1, jiffies 4294669355 (age 167.804s) hex dump (first 32 bytes): e0 c8 07 88 ff ff ff ff 00 00 00 00 01 00 00 00 ................ 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ backtrace: [<ffffffff81d11637>] __register_sysctl_table+0x117/0x1150 [<ffffffff86c3600f>] init_fs_stat_sysctls+0x30/0x33 [<ffffffff81002558>] do_one_initcall+0x108/0x690 [<ffffffff86bca8bd>] kernel_init_freeable+0x45a/0x4de [<ffffffff83e0757f>] kernel_init+0x1f/0x220 [<ffffffff810048cf>] ret_from_fork+0x1f/0x30 > return 0; > } > fs_initcall(init_fs_stat_sysctls); > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" 2022-02-13 15:34 ` Ido Schimmel @ 2022-02-13 21:10 ` Tong Zhang 2022-02-14 7:47 ` Ido Schimmel 0 siblings, 1 reply; 7+ messages in thread From: Tong Zhang @ 2022-02-13 21:10 UTC (permalink / raw) To: Ido Schimmel Cc: Domenico Andreoli, Luis Chamberlain, Eric W. Biederman, David Airlie, Andrew Morton, amir73il, Andy Shevchenko, Arnd Bergmann, bcrl, benh, clemens, crope, dgilbert, Greg KH, jack, jani.nikula, Jani Nikula, James E.J. Bottomley, jlbec, john.ogness, Joonas Lahtinen, Joseph Qi, julia.lawall, Kees Cook, kernel, Linux Memory Management List, Mark Fasheh, Martin K. Petersen, mm-commits, nixiaoming, penguin-kernel, peterz, Phillip Potter, Paul Turner, pmladek, rafael, Rodrigo Vivi, rostedt, senozhatsky, sre, steve, Suren Baghdasaryan, Linus Torvalds, tytso, Al Viro, wangqing, Iurii Zaikin, open list, regressions On Sun, Feb 13, 2022 at 7:34 AM Ido Schimmel <idosch@idosch.org> wrote: > > On Wed, Feb 09, 2022 at 08:49:20AM +0100, Domenico Andreoli wrote: > > fs/binfmt_misc.c | 6 +----- > > fs/file_table.c | 2 ++ > > 2 files changed, 3 insertions(+), 5 deletions(-) > > > > Index: b/fs/binfmt_misc.c > > =================================================================== > > --- a/fs/binfmt_misc.c > > +++ b/fs/binfmt_misc.c > > @@ -817,20 +817,16 @@ static struct file_system_type bm_fs_typ > > }; > > MODULE_ALIAS_FS("binfmt_misc"); > > > > -static struct ctl_table_header *binfmt_misc_header; > > - > > static int __init init_misc_binfmt(void) > > { > > int err = register_filesystem(&bm_fs_type); > > if (!err) > > insert_binfmt(&misc_format); > > - binfmt_misc_header = register_sysctl_mount_point("fs/binfmt_misc"); > > - return 0; > > + return err; > > } > > > > static void __exit exit_misc_binfmt(void) > > { > > - unregister_sysctl_table(binfmt_misc_header); > > unregister_binfmt(&misc_format); > > unregister_filesystem(&bm_fs_type); > > } > > Index: b/fs/file_table.c > > =================================================================== > > --- a/fs/file_table.c > > +++ b/fs/file_table.c > > @@ -119,6 +119,8 @@ static struct ctl_table fs_stat_sysctls[ > > static int __init init_fs_stat_sysctls(void) > > { > > register_sysctl_init("fs", fs_stat_sysctls); > > + if (IS_ENABLED(CONFIG_BINFMT_MISC)) > > + register_sysctl_mount_point("fs/binfmt_misc"); > > Hi, > > kmemleak complains about this: > > # cat /sys/kernel/debug/kmemleak > unreferenced object 0xffff8881045fea88 (size 96): > comm "swapper/0", pid 1, jiffies 4294669355 (age 167.804s) > hex dump (first 32 bytes): > e0 c8 07 88 ff ff ff ff 00 00 00 00 01 00 00 00 ................ > 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................ > backtrace: > [<ffffffff81d11637>] __register_sysctl_table+0x117/0x1150 > [<ffffffff86c3600f>] init_fs_stat_sysctls+0x30/0x33 > [<ffffffff81002558>] do_one_initcall+0x108/0x690 > [<ffffffff86bca8bd>] kernel_init_freeable+0x45a/0x4de > [<ffffffff83e0757f>] kernel_init+0x1f/0x220 > [<ffffffff810048cf>] ret_from_fork+0x1f/0x30 > > > return 0; > > } > > fs_initcall(init_fs_stat_sysctls); > > Hi Ido, Thanks for the report. This is a known issue. The fix is proposed here. https://lore.kernel.org/all/YgRbEG21AUrLSFKX@bombadil.infradead.org/ Thanks, - Tong ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" 2022-02-13 21:10 ` Tong Zhang @ 2022-02-14 7:47 ` Ido Schimmel 0 siblings, 0 replies; 7+ messages in thread From: Ido Schimmel @ 2022-02-14 7:47 UTC (permalink / raw) To: Tong Zhang Cc: Domenico Andreoli, Luis Chamberlain, Eric W. Biederman, David Airlie, Andrew Morton, amir73il, Andy Shevchenko, Arnd Bergmann, bcrl, benh, clemens, crope, dgilbert, Greg KH, jack, jani.nikula, Jani Nikula, James E.J. Bottomley, jlbec, john.ogness, Joonas Lahtinen, Joseph Qi, julia.lawall, Kees Cook, kernel, Linux Memory Management List, Mark Fasheh, Martin K. Petersen, mm-commits, nixiaoming, penguin-kernel, peterz, Phillip Potter, Paul Turner, pmladek, rafael, Rodrigo Vivi, rostedt, senozhatsky, sre, steve, Suren Baghdasaryan, Linus Torvalds, tytso, Al Viro, wangqing, Iurii Zaikin, open list, regressions On Sun, Feb 13, 2022 at 01:10:42PM -0800, Tong Zhang wrote: > Hi Ido, > Thanks for the report. This is a known issue. The fix is proposed here. > https://lore.kernel.org/all/YgRbEG21AUrLSFKX@bombadil.infradead.org/ Great, thanks for letting me know ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-14 7:47 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220121221021.60533b009c357d660791476e@linux-foundation.org>
[not found] ` <20220122061228.nmuo75sDn%akpm@linux-foundation.org>
[not found] ` <YgEeQNdgBuHRyEWl@dumbo>
2022-02-08 6:46 ` [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Thorsten Leemhuis
2022-02-10 9:50 ` [PATCH] Fix regression due to "fs: move binfmt_misc sysctl to its own file" #forregzbot Thorsten Leemhuis
[not found] ` <YgGTSR628xhRvCjB@bombadil.infradead.org>
[not found] ` <CAA5qM4BGmrkwatyO_h3F=ErDZ9t5swuttbt6NkQU-1KDGDiD4g@mail.gmail.com>
[not found] ` <YgKmaggsipzzCGCg@bombadil.infradead.org>
2022-02-09 7:49 ` [PATCH v2] Fix regression due to "fs: move binfmt_misc sysctl to its own file" Domenico Andreoli
2022-02-09 7:55 ` Tong Zhang
2022-02-13 15:34 ` Ido Schimmel
2022-02-13 21:10 ` Tong Zhang
2022-02-14 7:47 ` Ido Schimmel
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).