* Re: [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div
[not found] ` <20220510132756.qmyjca53xu44iwn7@houat>
@ 2022-05-14 8:17 ` Stefan Wahren
0 siblings, 0 replies; only message in thread
From: Stefan Wahren @ 2022-05-14 8:17 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Linus Torvalds
Cc: Florian Fainelli, Ray Jui, Scott Branden,
bcm-kernel-feedback-list, linux-clk, linux-rpi-kernel,
linux-arm-kernel, linux-kernel, Maxime Ripard, regressions
Hi,
Am 10.05.22 um 15:27 schrieb Maxime Ripard:
> On Sat, May 07, 2022 at 11:26:28AM +0200, Stefan Wahren wrote:
>> Am 03.05.22 um 16:58 schrieb Maxime Ripard:
>>> Hi,
>>>
>>> On Thu, Apr 28, 2022 at 08:30:10PM +0200, Stefan Wahren wrote:
>>>> The commit 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
>>>> accidentially breaks the behavior of bcm2835_clock_choose_div() and
>>>> booting of Raspberry Pi. The removed do_div macro call had side effects,
>>>> so we need to restore it.
>>>>
>>>> Fixes: 09e3b18ca5de ("clk: bcm2835: Remove unused variable")
>>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> I only found this patch after debugging why the HDMI driver was
>>> returning -EINVAL at probe on -rc5.
>>>
>>> Acked-by: Maxime Ripard <maxime@cerno.tech>
>>> Tested-by: Maxime Ripard <maxime@cerno.tech>
>> Thanks,
>>
>> does this go via clk-fixes?
> Yep, it should.
>
> Stephen, could we merge this?
Is there any chance to get this regression fix into mainline before 5.18
is released?
>
> Maxime
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-14 8:17 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220428183010.1635248-1-stefan.wahren@i2se.com>
[not found] ` <20220503145804.b2xz4etzc6kpr3fk@houat>
[not found] ` <ee39ddd1-bfce-012d-5e04-448d779ed995@i2se.com>
[not found] ` <20220510132756.qmyjca53xu44iwn7@houat>
2022-05-14 8:17 ` [PATCH] clk: bcm2835: fix bcm2835_clock_choose_div Stefan Wahren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).