archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <>
Cc: stable <>,
	Greg Kroah-Hartman <>,
	Frank Wunderlich <>,
	Peter Hess <>,
	Mark Brown <>
Subject: regression [fixed]: SPI interface on systems with Mediatek CPU broken
Date: Fri, 6 Aug 2021 15:33:47 -0700	[thread overview]
Message-ID: <> (raw)

[ submitted for reference. The problem has now been fixed in the upstream kernel ]

Affected upstream kernel releases: v5.14-rc3, v5.14-rc4
Various stable releases with the problematic commit are also affected.

The SPI interface on systems with various Mediatek CPUs is not operational.
The problem affects all Chromebooks with Mediatek CPU since those Chromebooks
use the SPI interface to connect to the Embedded Controller.

Bisect suggests that commit 3a70dd2d050 ("spi: mediatek: fix fifo rx mode")
introduced the problem. The problem was fixed with upstream commit 0d5c3954b35e
("spi: mediatek: Fix fifo transfer").

Detailed problem description from commit 0d5c3954b35e:

     Commit 3a70dd2d0503 ("spi: mediatek: fix fifo rx mode") claims that
     fifo RX mode was never handled, and adds the presumably missing code
     to the FIFO transfer function. However, the claim that receive data
     was not handled is incorrect. It was handled as part of interrupt
     handling after the transfer was complete. The code added with the above
     mentioned commit reads data from the receive FIFO before the transfer
     is started, which is wrong. This results in an actual transfer error
     on a Hayato Chromebook.

     Remove the code trying to handle receive data before the transfer is
     started to fix the problem.


             reply	other threads:[~2021-08-06 22:33 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-06 22:33 Guenter Roeck [this message]
2021-08-08 22:13 ` regression [fixed]: SPI interface on systems with Mediatek CPU broken Peter Hess

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).