From: Adam Bratschi-Kaye <ark.email@gmail.com>
To: Fabio Aiuto <fabioaiuto83@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
rust-for-linux <rust-for-linux@vger.kernel.org>
Subject: Re: module parameters permission
Date: Thu, 29 Apr 2021 13:26:29 +0200 [thread overview]
Message-ID: <CAHaybgktoXXCYX1P0n5VRtCzGWC=4oW34nAg2McUH0aaRXOYzg@mail.gmail.com> (raw)
In-Reply-To: <20210429102543.GG1409@agape.jhs>
> Anyway I'd like to know what was the matter with those bindings...
There's nothing wrong with the bindings, the problem is that the
`module!` procedural macro will only parse a literal for the
permissions field. Given Greg's comment I don't think it's much of an
issue, but there's the same problem for other fields which it would be
nice to fix (e.g. your example works with the default parameter value
`42`, but will hit the same parse error if you instead had `40 + 2`).
We discussed it a bit here:
https://github.com/Rust-for-Linux/linux/issues/11#issuecomment-778569067
.
next prev parent reply other threads:[~2021-04-29 11:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-29 9:58 module parameters permission Fabio Aiuto
2021-04-29 10:05 ` Greg KH
2021-04-29 10:25 ` Fabio Aiuto
2021-04-29 11:26 ` Adam Bratschi-Kaye [this message]
2021-04-29 11:26 ` Finn Behrens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHaybgktoXXCYX1P0n5VRtCzGWC=4oW34nAg2McUH0aaRXOYzg@mail.gmail.com' \
--to=ark.email@gmail.com \
--cc=fabioaiuto83@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=rust-for-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).