All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Kristin Paget <kristin@tombom.co.uk>
Cc: Takashi Iwai <tiwai@suse.com>,
	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop
Date: Sun, 15 Aug 2021 09:30:49 +0200	[thread overview]
Message-ID: <s5h1r6vi2qe.wl-tiwai@suse.de> (raw)
In-Reply-To: <e1fc95c5-c10a-1f98-a5c2-dd6e336157e1@tombom.co.uk>

On Sun, 15 Aug 2021 00:46:05 +0200,
Kristin Paget wrote:
> 
> The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio
> setup as the Precision models, so requires the same quirk to enable woofer
> output. Tested on my own 9510.
> 
> Signed-off-by: Kristin Paget <kristin@tombom.co.uk>

It seems that your MUA broken the patch (tabs converted to spaces).
Since it's a trivial oneliner, I applied manually.  But for the next
time, please try to fix your MUA setup.

Thanks!

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Kristin Paget <kristin@tombom.co.uk>
Cc: linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
	Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop
Date: Sun, 15 Aug 2021 09:30:49 +0200	[thread overview]
Message-ID: <s5h1r6vi2qe.wl-tiwai@suse.de> (raw)
In-Reply-To: <e1fc95c5-c10a-1f98-a5c2-dd6e336157e1@tombom.co.uk>

On Sun, 15 Aug 2021 00:46:05 +0200,
Kristin Paget wrote:
> 
> The 2021-model XPS 15 appears to use the same 4-speakers-on-ALC289 audio
> setup as the Precision models, so requires the same quirk to enable woofer
> output. Tested on my own 9510.
> 
> Signed-off-by: Kristin Paget <kristin@tombom.co.uk>

It seems that your MUA broken the patch (tabs converted to spaces).
Since it's a trivial oneliner, I applied manually.  But for the next
time, please try to fix your MUA setup.

Thanks!

Takashi

  reply	other threads:[~2021-08-15  7:30 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-14 22:46 [PATCH] ALSA: hda/realtek: Enable 4-speaker output for Dell XPS 15 9510 laptop Kristin Paget
2021-08-14 22:46 ` Kristin Paget
2021-08-15  7:30 ` Takashi Iwai [this message]
2021-08-15  7:30   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h1r6vi2qe.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=kristin@tombom.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.