From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: clemens@ladisch.de, alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: fireface: fix reference to wrong register for clock configuration
Date: Sun, 09 Dec 2018 09:38:11 +0100 [thread overview]
Message-ID: <s5h36r7f630.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181209080419.9554-1-o-takashi@sakamocchi.jp>
On Sun, 09 Dec 2018 09:04:19 +0100,
Takashi Sakamoto wrote:
>
> In an initial commit, 'SYNC_STATUS' register is referred to get
> clock configuration, however this is wrong, according to my local
> note at hand for reverse-engineering about packet dump. It should
> be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config()
> is correctly programmed.
>
> This commit fixes the bug.
>
> Cc: <stable@vger.kernel.org> # v4.12+
> Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400')
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied, thanks.
Takashi
WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: fireface: fix reference to wrong register for clock configuration
Date: Sun, 09 Dec 2018 09:38:11 +0100 [thread overview]
Message-ID: <s5h36r7f630.wl-tiwai@suse.de> (raw)
In-Reply-To: <20181209080419.9554-1-o-takashi@sakamocchi.jp>
On Sun, 09 Dec 2018 09:04:19 +0100,
Takashi Sakamoto wrote:
>
> In an initial commit, 'SYNC_STATUS' register is referred to get
> clock configuration, however this is wrong, according to my local
> note at hand for reverse-engineering about packet dump. It should
> be 'CLOCK_CONFIG' register. Actually, ff400_dump_clock_config()
> is correctly programmed.
>
> This commit fixes the bug.
>
> Cc: <stable@vger.kernel.org> # v4.12+
> Fixes: 76fdb3a9e13a ('ALSA: fireface: add support for Fireface 400')
> Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Applied, thanks.
Takashi
next prev parent reply other threads:[~2018-12-09 8:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 8:04 [PATCH] ALSA: fireface: fix reference to wrong register for clock configuration Takashi Sakamoto
2018-12-09 8:38 ` Takashi Iwai [this message]
2018-12-09 8:38 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h36r7f630.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=o-takashi@sakamocchi.jp \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.