From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de,
ffado-devel@lists.sf.net
Subject: Re: [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and data block processing layer
Date: Tue, 29 Sep 2015 14:57:15 +0200 [thread overview]
Message-ID: <s5h37xxidsk.wl-tiwai@suse.de> (raw)
In-Reply-To: <560A87CC.20203@sakamocchi.jp>
On Tue, 29 Sep 2015 14:45:00 +0200,
Takashi Sakamoto wrote:
>
> On Sep 29 2015 19:55, Takashi Iwai wrote:
> > On Sat, 19 Sep 2015 18:46:53 +0200,
> > Takashi Iwai wrote:
> >>
> >> On Sat, 19 Sep 2015 04:21:47 +0200,
> >> Takashi Sakamoto wrote:
> >>>
> >>> This patchset updates a part of my previous post (patch 01 and 02):
> >>>
> >>> [alsa-devel] [PATCH 00/25 v2] ALSA: support AMDTP variants
> >>> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-August/096739.html
> >>>
> >>> The aim of this patchset is to allow current amdtp implementation
> >>> to handle several data block processing backends. For this aim, this
> >>> patchset separates the implementation to packet streaming layer and AM824
> >>> data block processing layer.
> >>>
> >>> The communication between these two layers is done by callback function.
> >>> This patchset adds an overhead to call the functions as the same
> >>> frequently as 8,000 times per second.
> >>
> >> Since I'm traveling now, I can't review in details and will take a
> >> closer look in the next week. Hopefully other people will give review
> >> comments before that.
> >
> > There were a few obvious typos (using bit OR instead of logical OR),
> > but otherwise they look good through a quick review, so I merged them
> > with some manual fixes now. The patches are found in
> > topic/firewire-update branch and merged into for-next branch, too.
>
> Oops. Patch 15 includes such typos... Thanks for your reviewing and
> fixing ;-)
>
> I have more patches and I'll post them as a small parts in this
> developing period. I'd be glad if the patches are also reviewd.
Sure, feel free to submit patches at any time.
But I'll be traveling again in the next week for LCE and audio mini
summit, so the review might be taken after that.
thanks,
Takashi
prev parent reply other threads:[~2015-09-29 12:57 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 2:21 [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and data block processing layer Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 01/15] ALSA: firewire-lib: arrange structure for AMDTP stream Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 02/15] ALSA: firewire-lib: return error code when amdtp_stream_set_parameters() detects error Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 03/15] ALSA: firewire-lib: add an argument for Dice's dual wire mode Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 04/15] ALSA: firewire-lib: add a member of frame_multiplier instead of double_pcm_frames Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 05/15] ALSA: firewire-lib: add helper functions as interfaces between packet streaming layer and data block processing layer Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 06/15] ALSA: firewire-lib: add support arbitrary value for fmt/fdf fields in CIP header Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 07/15] ALSA: firewire-lib: rename 'amdtp' to 'amdtp-stream' to prepare for functional separation Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 08/15] ALSA: firewire-lib: add data block processing layer for AM824 format Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 09/15] ALSA: firewire-lib: rename parameter setting function for AM824 with FDF field Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 10/15] ALSA: firewire-lib: move PCM substream constraint to AM824 layer Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 11/15] ALSA: firewire-lib: add helper functions to set positions of data channels Takashi Sakamoto
2015-09-19 2:21 ` [PATCH 12/15] ALSA: firewire-lib: move MIDI trigger helper function to AM824 layer Takashi Sakamoto
2015-09-19 2:22 ` [PATCH 13/15] ALSA: firewire-lib: rename PCM format helper function Takashi Sakamoto
2015-09-19 2:22 ` [PATCH 14/15] ALSA: firewire-lib: rename macros with AM824 prefix Takashi Sakamoto
2015-09-19 2:22 ` [PATCH 15/15] ALSA: firewire-lib: complete AM824 data block processing layer Takashi Sakamoto
2015-09-19 16:46 ` [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and " Takashi Iwai
2015-09-29 10:55 ` Takashi Iwai
2015-09-29 12:45 ` Takashi Sakamoto
2015-09-29 12:57 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=s5h37xxidsk.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=ffado-devel@lists.sf.net \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.