Re: [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and data block processing layer

From: Takashi Iwai <tiwai@suse.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de,
	ffado-devel@lists.sf.net
Subject: Re: [PATCH 00/15 v3] ALSA: firewire-lib: separate to packet streaming layer and data block processing layer
Date: Sat, 19 Sep 2015 18:46:53 +0200	[thread overview]
Message-ID: <s5htwqqxsoy.wl-tiwai@suse.de> (raw)
In-Reply-To: <1442629322-15457-1-git-send-email-o-takashi@sakamocchi.jp>

On Sat, 19 Sep 2015 04:21:47 +0200,
Takashi Sakamoto wrote:
> 
> This patchset updates a part of my previous post (patch 01 and 02):
> 
> [alsa-devel] [PATCH 00/25 v2] ALSA: support AMDTP variants
> http://mailman.alsa-project.org/pipermail/alsa-devel/2015-August/096739.html
> 
> The aim of this patchset is to allow current amdtp implementation
> to handle several data block processing backends. For this aim, this
> patchset separates the implementation to packet streaming layer and AM824
> data block processing layer.
> 
> The communication between these two layers is done by callback function.
> This patchset adds an overhead to call the functions as the same
> frequently as 8,000 times per second.

Since I'm traveling now, I can't review in details and will take a
closer look in the next week.  Hopefully other people will give review
comments before that.

thanks,

Takashi

> 
> Takashi Sakamoto (15):
>   ALSA: firewire-lib: arrange structure for AMDTP stream
>   ALSA: firewire-lib: return error code when
>     amdtp_stream_set_parameters() detects error
>   ALSA: firewire-lib: add an argument for Dice's dual wire mode
>   ALSA: firewire-lib: add a member of frame_multiplier instead of
>     double_pcm_frames
>   ALSA: firewire-lib: add helper functions as interfaces between packet
>     streaming layer and data block processing layer
>   ALSA: firewire-lib: add support arbitrary value for fmt/fdf fields in
>     CIP header
>   ALSA: firewire-lib: rename 'amdtp' to 'amdtp-stream' to prepare for
>     functional separation
>   ALSA: firewire-lib: add data block processing layer for AM824 format
>   ALSA: firewire-lib: rename parameter setting function for AM824 with
>     FDF field
>   ALSA: firewire-lib: move PCM substream constraint to AM824 layer
>   ALSA: firewire-lib: add helper functions to set positions of data
>     channels
>   ALSA: firewire-lib: move MIDI trigger helper function to AM824 layer
>   ALSA: firewire-lib: rename PCM format helper function
>   ALSA: firewire-lib: rename macros with AM824 prefix
>   ALSA: firewire-lib: complete AM824 data block processing layer
> 
>  sound/firewire/Makefile                     |   2 +-
>  sound/firewire/amdtp-am824.c                | 465 ++++++++++++++++++++++++++++
>  sound/firewire/amdtp-am824.h                |  52 ++++
>  sound/firewire/{amdtp.c => amdtp-stream.c}  | 377 ++++------------------
>  sound/firewire/{amdtp.h => amdtp-stream.h}  | 116 +++----
>  sound/firewire/bebob/bebob.h                |   2 +-
>  sound/firewire/bebob/bebob_midi.c           |  16 +-
>  sound/firewire/bebob/bebob_pcm.c            |  14 +-
>  sound/firewire/bebob/bebob_stream.c         |  34 +-
>  sound/firewire/dice/dice-midi.c             |  12 +-
>  sound/firewire/dice/dice-pcm.c              |  12 +-
>  sound/firewire/dice/dice-stream.c           |  22 +-
>  sound/firewire/dice/dice.h                  |   2 +-
>  sound/firewire/fcp.c                        |   2 +-
>  sound/firewire/fireworks/fireworks.c        |  12 +-
>  sound/firewire/fireworks/fireworks.h        |   2 +-
>  sound/firewire/fireworks/fireworks_midi.c   |  12 +-
>  sound/firewire/fireworks/fireworks_pcm.c    |  12 +-
>  sound/firewire/fireworks/fireworks_stream.c |   8 +-
>  sound/firewire/oxfw/oxfw-midi.c             |  16 +-
>  sound/firewire/oxfw/oxfw-pcm.c              |  10 +-
>  sound/firewire/oxfw/oxfw-stream.c           |  11 +-
>  sound/firewire/oxfw/oxfw.h                  |   2 +-
>  23 files changed, 730 insertions(+), 483 deletions(-)
>  create mode 100644 sound/firewire/amdtp-am824.c
>  create mode 100644 sound/firewire/amdtp-am824.h
>  rename sound/firewire/{amdtp.c => amdtp-stream.c} (70%)
>  rename sound/firewire/{amdtp.h => amdtp-stream.h} (78%)
> 
> -- 
> 2.1.4
> 